171363 2017-04-26 20:04:10 -0700 Web Inspector: ASSERT(!m_startedComposite) fails when recording on non-Cocoa Timeline 2017-05-01 16:54:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 ross.kirsling webkit-unassigned bburg commit-queue fujii inspector-bugzilla-changes mattbaker oldest_to_newest 1301909 0 ross.kirsling 2017-04-26 20:04:10 -0700 It appears that when compositing events were implemented, this wasn't done in an entirely safe fashion for non-Cocoa platforms: https://bugs.webkit.org/show_bug.cgi?id=146168 Specifically, the asserts for InspectorTimelineAgent::willComposite and InspectorTimelineAgent::didComposite ensure that one is not used without the other, yet didComposite is called within a PLATFORM(COCOA) block while willComposite is called on all platforms. Asserts: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp#L358 didComposite callsite: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp#L196 willComposite callsite: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/page/FrameView.cpp#L1234 As such, on any non-Cocoa platform, the second compositing event in a timeline recording causes an assertion failure. 1301910 1 ross.kirsling 2017-04-26 20:04:24 -0700 Compositing events are Cocoa-specific until we have platform abstraction for RunLoopObserver: https://bugs.webkit.org/show_bug.cgi?id=142748 Therefore we should simply guard the willComposite callsite for now. 1301921 2 308327 ross.kirsling 2017-04-26 20:18:37 -0700 Created attachment 308327 Patch 1302389 3 bburg 2017-04-27 16:39:57 -0700 I'd like Matt to review this when he's back in office next week. 1303483 4 308327 mattbaker 2017-05-01 16:25:21 -0700 Comment on attachment 308327 Patch r=me. I don't have an easy way to test this, but it seems clear that the second time willComposite is called (and every time after) it will assert, since didComposite is never called. Ross's patch matches the guards around the creation of the run loop observation points and looks correct. 1303496 5 308327 commit-queue 2017-05-01 16:54:34 -0700 Comment on attachment 308327 Patch Clearing flags on attachment: 308327 Committed r216043: <http://trac.webkit.org/changeset/216043> 1303497 6 commit-queue 2017-05-01 16:54:35 -0700 All reviewed patches have been landed. Closing bug. 308327 2017-04-26 20:18:37 -0700 2017-05-01 16:54:34 -0700 Patch bug-171363-20170426201836.patch text/plain 1397 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTdjOTEwYjJhYjQ1YWMx YTZlNDEzYzM2Y2VhOWU5YTEwNjhjYmFjMS4uZjllZjFiMjQ5ODQyZWE3NTMwN2YxMjJjNjI3MWU4 MTQwYmNlMzYwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA0LTI2ICBSb3Nz IEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBBU1NFUlQoIW1fc3RhcnRlZENvbXBvc2l0ZSkgZmFpbHMgd2hlbiByZWNvcmRpbmcgb24g bm9uLUNvY29hIFRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzEzNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l Vmlldzo6Zmx1c2hDb21wb3NpdGluZ1N0YXRlSW5jbHVkaW5nU3ViZnJhbWVzKTogQWRkIFBMQVRG T1JNKENPQ09BKSBndWFyZC4KKwogMjAxNy0wNC0yNSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFw cGxlLmNvbT4KIAogICAgICAgICBKU0FycmF5Ojppc0FycmF5UHJvdG90eXBlSXRlcmF0b3JQcm90 b2NvbEZhc3RBbmROb25PYnNlcnZhYmxlIGlzIHdyb25nIGJlY2F1c2UgaXQgZG9lcyBub3QgZG8g dGhlIG5lY2Vzc2FyeSBjaGVja3Mgb24gdGhlIGJhc2Ugb2JqZWN0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKaW5kZXggMzY4YzZjZDBjODQzY2IyOTBlOGIwYWYwYTRlYjI1Mzc3ODExZmQ2MC4u ZTQ4NDZlYjMwOGRmODdiMDk5YzkyYzg4Y2U3YTAzNmEzOGRkZDdlNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcApAQCAtMTIzMSw3ICsxMjMxLDkgQEAgYm9vbCBGcmFtZVZpZXc6OmlzRW5j bG9zZWRJbkNvbXBvc2l0aW5nTGF5ZXIoKSBjb25zdAogCiBib29sIEZyYW1lVmlldzo6Zmx1c2hD b21wb3NpdGluZ1N0YXRlSW5jbHVkaW5nU3ViZnJhbWVzKCkKIHsKKyNpZiBQTEFURk9STShDT0NP QSkKICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OndpbGxDb21wb3NpdGUoZnJhbWUoKSk7 CisjZW5kaWYKIAogICAgIGJvb2wgYWxsRnJhbWVzRmx1c2hlZCA9IGZsdXNoQ29tcG9zaXRpbmdT dGF0ZUZvclRoaXNGcmFtZShmcmFtZSgpKTsKIAo=