<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171346</bug_id>
          
          <creation_ts>2017-04-26 15:33:24 -0700</creation_ts>
          <short_desc>REGRESSION r215821: LayoutTest inspector/dom/getAccessibilityPropertiesForNode.html is failing</short_desc>
          <delta_ts>2017-04-26 16:33:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Lewis">jlewis3</reporter>
          <assigned_to name="Matt Lewis">jlewis3</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>jlewis3</cc>
    
    <cc>ryanhaddad</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1301793</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Lewis">jlewis3</who>
    <bug_when>2017-04-26 15:33:24 -0700</bug_when>
    <thetext>REGRESSION r215821: LayoutTest inspector/dom/getAccessibilityPropertiesForNode.html is failing

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/808

diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-actual.txt
@@ -296,6 +296,7 @@
     focused: false
     ownedNodeIds.length: 1
     required: false
+    isPopUpButton: true
 
 &lt;select&gt;
     &lt;option&gt;FOO&lt;/option&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1301794</commentid>
    <comment_count>1</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-04-26 15:33:57 -0700</bug_when>
    <thetext>It seems that this started after the change for https://bugs.webkit.org/show_bug.cgi?id=171164

I think we just need to rebaseline this test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1301800</commentid>
    <comment_count>2</comment_count>
      <attachid>308295</attachid>
    <who name="Matt Lewis">jlewis3</who>
    <bug_when>2017-04-26 15:50:39 -0700</bug_when>
    <thetext>Created attachment 308295
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1301831</commentid>
    <comment_count>3</comment_count>
      <attachid>308295</attachid>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-04-26 16:33:09 -0700</bug_when>
    <thetext>Comment on attachment 308295
Patch

Clearing flags on attachment: 308295

Committed r215839: &lt;http://trac.webkit.org/changeset/215839&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1301832</commentid>
    <comment_count>4</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-04-26 16:33:10 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>308295</attachid>
            <date>2017-04-26 15:50:39 -0700</date>
            <delta_ts>2017-04-26 16:32:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171346-20170426155039.patch</filename>
            <type>text/plain</type>
            <size>1302</size>
            <attacher name="Matt Lewis">jlewis3</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1ODM0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTU1NWRkZWRlNWNkNDRhMWZmZjU0
MDk0YzQ4ZmM2MjE3MjQwNzFjNy4uNDUwMDJhY2YzZmZjZDQ4MjQ4YTg2NWQzOTU2YzQ3Mjk3OGZm
YWUyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA0LTI2ICBNYXR0IExld2lzICA8amxl
d2lzM0BhcHBsZS5jb20+CisKKyAgICAgICAgUmUtYmFzZWxpbmUgaW5zcGVjdG9yL2RvbS9nZXRB
Y2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUuaHRtbCBhZnRlciByMjE1ODIxCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzEzNDYKKworICAgICAg
ICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgICogaW5zcGVjdG9yL2RvbS9n
ZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUtZXhwZWN0ZWQudHh0OgorCiAyMDE3LTA0
LTI2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBMYXlvdXRU
ZXN0IHdlYnJ0Yy9kYXRhY2hhbm5lbC9idWZmZXJlZEFtb3VudExvd1RocmVzaG9sZC5odG1sIGlz
IGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RvbS9n
ZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz
dHMvaW5zcGVjdG9yL2RvbS9nZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUtZXhwZWN0
ZWQudHh0CmluZGV4IDQwYWZmYjExZTNkMDBiY2UwNzI1ZmM3MjYyNWZhYWRhOTUzMDE3MjguLjE1
MzM2ZGU5MTRmZDI0OTUzMjFmMjRmNDNmYjc1ZTc4MGU3ZjVmNGEgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL2luc3BlY3Rvci9kb20vZ2V0QWNjZXNzaWJpbGl0eVByb3BlcnRpZXNGb3JOb2RlLWV4
cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZG9tL2dldEFjY2Vzc2liaWxp
dHlQcm9wZXJ0aWVzRm9yTm9kZS1leHBlY3RlZC50eHQKQEAgLTI5Niw2ICsyOTYsNyBAQCBUb3Rh
bCBlbGVtZW50cyB0byBiZSB0ZXN0ZWQ6IDEyMi4KICAgICBmb2N1c2VkOiBmYWxzZQogICAgIG93
bmVkTm9kZUlkcy5sZW5ndGg6IDEKICAgICByZXF1aXJlZDogZmFsc2UKKyAgICBpc1BvcFVwQnV0
dG9uOiB0cnVlCiAKIDxzZWxlY3Q+CiAgICAgPG9wdGlvbj5GT088L29wdGlvbj4K
</data>

          </attachment>
      

    </bug>

</bugzilla>