171338 2017-04-26 13:19:53 -0700 RTL: recent searches popover is displayed in incorrect location 2017-04-26 14:56:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue dino simon.fraser zalan oldest_to_newest 1301742 0 zalan 2017-04-26 13:19:53 -0700 rdar://problem/31377807 1301748 1 308279 zalan 2017-04-26 13:27:04 -0700 Created attachment 308279 Patch 1301761 2 308279 commit-queue 2017-04-26 13:52:18 -0700 Comment on attachment 308279 Patch Clearing flags on attachment: 308279 Committed r215830: <http://trac.webkit.org/changeset/215830> 1301762 3 commit-queue 2017-04-26 13:52:20 -0700 All reviewed patches have been landed. Closing bug. 1301779 4 308279 simon.fraser 2017-04-26 14:56:48 -0700 Comment on attachment 308279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308279&action=review > Source/WebCore/rendering/RenderSearchField.cpp:138 > + FloatPoint absTopLeft = localToAbsolute(FloatPoint(), UseTransforms); > + IntRect absBounds = absoluteBoundingBoxRectIgnoringTransforms(); This is pretty confusing. Why ignore transforms for one but not the other? Did you test iframes? 308279 2017-04-26 13:27:04 -0700 2017-04-26 13:52:18 -0700 Patch bug-171338-20170426132703.patch text/plain 6911 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWRkNDc2YTdjODJmZmU5 ZTc3MmQ0ODRjZmUwOTkzZTQ5NmE3Zjk5Ni4uY2VhZDNkYTFlOTAwYzgyNzdjZjBhMGRkODg4ZDgz MzA3MDYxNjJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA0LTI2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUlRMOiByZWNlbnQgc2VhcmNo ZXMgcG9wb3ZlciBpcyBkaXNwbGF5ZWQgaW4gaW5jb3JyZWN0IGxvY2F0aW9uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzEzMzgKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzMxMzc3ODA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvbXB1dGUgdGhlIGFic29sdXRlIGNvb3JkaW5hdGVzIGZvciB0aGUg cG9wdXAgdGhlIHNhbWUgd2F5IHdlIGRvIGZvciB0aGUgc2VsZWN0IGRyb3Bkb3duLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclNlYXJjaEZpZWxkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclNlYXJjaEZpZWxkOjpzaG93UG9wdXApOgorCiAyMDE3LTA0LTI0ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTd2l0Y2gg dG8gdXNlIEVOQUJMRV9SRU1PVEVfSU5TUEVDVE9SIGluc3RlYWQgb2YgRU5BQkxFX0lOU1BFQ1RP Ul9TRVJWRVIgZm9yIHRoZSByZW1vdGUgaW5zcGVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggYjI1 Mjc5YTVlZjc3NGY1ZjUzMTk3MzA5NGVhNTcyNjgxYzg2MWQxZi4uMWE2ZjBiYjVlZGRhMzE5NDlm NjA4ZTQzMjY1MzliMDk3ZDI3NzZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDE3LTA0LTI2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAg UlRMOiByZWNlbnQgc2VhcmNoZXMgcG9wb3ZlciBpcyBkaXNwbGF5ZWQgaW4gaW5jb3JyZWN0IGxv Y2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzEzMzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxMzc3ODA3PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBSVEwgc3VwcG9ydCBmb3IgdGhl IHBvcC11bmRlciBicmFuY2guCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Qb3B1cE1lbnVN YWMubW06CisgICAgICAgIChQb3B1cE1lbnVNYWM6OnNob3cpOgorCiAyMDE3LTA0LTIxICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgd3Jp dGluZyBsaW5rIHRpdGxlcyB0byB0aGUgcGFzdGVib2FyZCB3aGVuIGJlZ2lubmluZyBkYXRhIGlu dGVyYWN0aW9uIG9uIGEgbGluawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDljNDk4YjQyNmRmOGUzMWJjZGE4NTBl ZDFiYWFmYmFlMmFlZGNjMTIuLjE3ZDI3OWU5MDU3NjUzNTUwMjM4NDY0NjYxMjNhMTU3ZWI2NTcw MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNy0wNC0yNiAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJUTDogcmVjZW50IHNlYXJjaGVzIHBvcG92 ZXIgaXMgZGlzcGxheWVkIGluIGluY29ycmVjdCBsb2NhdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxMzM4CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zMTM3NzgwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgUlRMIHN1cHBvcnQgZm9yIHRoZSBwb3AtdW5kZXIgYnJhbmNoLgorCisgICAg ICAgICogVUlQcm9jZXNzL21hYy9XZWJQb3B1cE1lbnVQcm94eU1hYy5tbToKKyAgICAgICAgKFdl YktpdDo6V2ViUG9wdXBNZW51UHJveHlNYWM6OnNob3dQb3B1cE1lbnUpOgorCiAyMDE3LTA0LTI0 ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1RLXSBTd2l0Y2ggdG8gdXNlIEVOQUJMRV9SRU1PVEVfSU5TUEVDVE9SIGluc3RlYWQgb2YgRU5B QkxFX0lOU1BFQ1RPUl9TRVJWRVIgZm9yIHRoZSByZW1vdGUgaW5zcGVjdG9yCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2VhcmNoRmllbGQuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNlYXJjaEZpZWxkLmNwcAppbmRleCAwNTJiYTdmODZj MzUxZTVhYmMyZGZkODg4NWUxY2MxMmNmY2UyZWEwLi5lMzRjMTgzNjg3YTkyNDNjZDE1ODI1MDVi ZGZlYWM2MDEyOGNlNzFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyU2VhcmNoRmllbGQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJT ZWFyY2hGaWVsZC5jcHAKQEAgLTEzNCw3ICsxMzQsMTAgQEAgdm9pZCBSZW5kZXJTZWFyY2hGaWVs ZDo6c2hvd1BvcHVwKCkKICAgICAgICAgbV9zZWFyY2hQb3B1cC0+c2F2ZVJlY2VudFNlYXJjaGVz KG5hbWUsIG1fcmVjZW50U2VhcmNoZXMpOwogICAgIH0KIAotICAgIG1fc2VhcmNoUG9wdXAtPnBv cHVwTWVudSgpLT5zaG93KHNuYXBwZWRJbnRSZWN0KGFic29sdXRlQm91bmRpbmdCb3hSZWN0KCkp LCAmdmlldygpLmZyYW1lVmlldygpLCAtMSk7CisgICAgRmxvYXRQb2ludCBhYnNUb3BMZWZ0ID0g bG9jYWxUb0Fic29sdXRlKEZsb2F0UG9pbnQoKSwgVXNlVHJhbnNmb3Jtcyk7CisgICAgSW50UmVj dCBhYnNCb3VuZHMgPSBhYnNvbHV0ZUJvdW5kaW5nQm94UmVjdElnbm9yaW5nVHJhbnNmb3Jtcygp OworICAgIGFic0JvdW5kcy5zZXRMb2NhdGlvbihyb3VuZGVkSW50UG9pbnQoYWJzVG9wTGVmdCkp OworICAgIG1fc2VhcmNoUG9wdXAtPnBvcHVwTWVudSgpLT5zaG93KGFic0JvdW5kcywgJnZpZXco KS5mcmFtZVZpZXcoKSwgLTEpOwogfQogCiB2b2lkIFJlbmRlclNlYXJjaEZpZWxkOjpoaWRlUG9w dXAoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvUG9wdXBN ZW51TWFjLm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvUG9wdXBNZW51TWFj Lm1tCmluZGV4IDU2Nzk3YjA2ZGU5ZTkzMTdlYTcyZTQwZmRmYTJlODI2ZDUwMmNmOTMuLjE0YzVm OTBjNjAyZTNjN2Y4N2IwZWNjYjFmMDhhN2E2NTY5Zjk5ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1BvcHVwTWVudU1hYy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L21hYy9XZWJDb3JlU3VwcG9ydC9Qb3B1cE1lbnVNYWMubW0KQEAgLTE3MywxMyArMTczLDIw IEBAIHZvaWQgUG9wdXBNZW51TWFjOjpzaG93KGNvbnN0IEludFJlY3QmIHIsIEZyYW1lVmlldyog diwgaW50IGluZGV4KQogICAgICAgICBpZiAodGV4dERpcmVjdGlvbiA9PSBMVFIpCiAgICAgICAg ICAgICBsb2NhdGlvbiA9IE5TTWFrZVBvaW50KE5TTWluWChyKSArIHBvcE92ZXJIb3Jpem9udGFs QWRqdXN0LCBOU01heFkocikgLSB2ZXJ0T2Zmc2V0KTsKICAgICAgICAgZWxzZQotICAgICAgICAg ICAgbG9jYXRpb24gPSBOU01ha2VQb2ludChOU01pblgocikgLSBwb3BPdmVySG9yaXpvbnRhbEFk anVzdCwgTlNNYXhZKHIpIC0gdmVydE9mZnNldCk7CisgICAgICAgICAgICBsb2NhdGlvbiA9IE5T TWFrZVBvaW50KE5TTWF4WChyKSAtIHBvcE92ZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocikg LSB2ZXJ0T2Zmc2V0KTsKICNlbHNlCiAgICAgICAgIGxvY2F0aW9uID0gTlNNYWtlUG9pbnQoTlNN aW5YKHIpICsgcG9wT3Zlckhvcml6b250YWxBZGp1c3QsIE5TTWF4WShyKSAtIHZlcnRPZmZzZXQp OwogI2VuZGlmCi0gICAgfSBlbHNlCi0gICAgICAgIGxvY2F0aW9uID0gTlNNYWtlUG9pbnQoTlNN aW5YKHIpICsgcG9wVW5kZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocikgKyBwb3BVbmRlclZl cnRpY2FsQWRqdXN0KTsgICAgCi0KKyAgICB9IGVsc2UgeworI2lmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTAxMjAwCisgICAgICAgIGlmICh0ZXh0RGlyZWN0aW9uID09IExU UikKKyAgICAgICAgICAgIGxvY2F0aW9uID0gTlNNYWtlUG9pbnQoTlNNaW5YKHIpICsgcG9wVW5k ZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocikgKyBwb3BVbmRlclZlcnRpY2FsQWRqdXN0KTsK KyAgICAgICAgZWxzZQorICAgICAgICAgICAgbG9jYXRpb24gPSBOU01ha2VQb2ludChOU01heFgo cikgLSBwb3BVbmRlckhvcml6b250YWxBZGp1c3QsIE5TTWF4WShyKSArIHBvcFVuZGVyVmVydGlj YWxBZGp1c3QpOworI2Vsc2UKKyAgICAgICAgbG9jYXRpb24gPSBOU01ha2VQb2ludChOU01pblgo cikgKyBwb3BVbmRlckhvcml6b250YWxBZGp1c3QsIE5TTWF4WShyKSArIHBvcFVuZGVyVmVydGlj YWxBZGp1c3QpOworI2VuZGlmCisgICAgfQogICAgIC8vIFNhdmUgdGhlIGN1cnJlbnQgZXZlbnQg dGhhdCB0cmlnZ2VyZWQgdGhlIHBvcHVwLCBzbyB3ZSBjYW4gY2xlYW4gdXAgb3VyIGV2ZW50CiAg ICAgLy8gc3RhdGUgYWZ0ZXIgdGhlIE5TTWVudSBnb2VzIGF3YXkuCiAgICAgUmVmPEZyYW1lPiBm cmFtZSh2LT5mcmFtZSgpKTsKQEAgLTE4OCw2ICsxOTUsNyBAQCB2b2lkIFBvcHVwTWVudU1hYzo6 c2hvdyhjb25zdCBJbnRSZWN0JiByLCBGcmFtZVZpZXcqIHYsIGludCBpbmRleCkKICAgICBSZWY8 UG9wdXBNZW51TWFjPiBwcm90ZWN0b3IoKnRoaXMpOwogCiAgICAgUmV0YWluUHRyPE5TVmlldz4g ZHVtbXlWaWV3ID0gYWRvcHROUyhbW05TVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpyXSk7Cisg ICAgW2R1bW15Vmlldy5nZXQoKSBzZXRVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uOnRleHRE aXJlY3Rpb24gPT0gTFRSID8gTlNVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uTGVmdFRvUmln aHQgOiBOU1VzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb25SaWdodFRvTGVmdF07CiAgICAgW3Zp ZXcgYWRkU3VidmlldzpkdW1teVZpZXcuZ2V0KCldOwogICAgIGxvY2F0aW9uID0gW2R1bW15Vmll dyBjb252ZXJ0UG9pbnQ6bG9jYXRpb24gZnJvbVZpZXc6dmlld107CiAgICAgCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYlBvcHVwTWVudVByb3h5TWFjLm1tIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQb3B1cE1lbnVQcm94eU1hYy5tbQppbmRl eCBkMzAxOTRkYmYwNjVkYWZlZGM5YTQwZTFhMzE0ODc0YmZkMWIwNTBjLi40ZjcyZGYxOGM0MDgy YmI5YWQ3YWNhMmVmMTlhM2M2NDYzNDY2ODU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvbWFjL1dlYlBvcHVwTWVudVByb3h5TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9tYWMvV2ViUG9wdXBNZW51UHJveHlNYWMubW0KQEAgLTEzOCw5ICsxMzgsMTYg QEAgdm9pZCBXZWJQb3B1cE1lbnVQcm94eU1hYzo6c2hvd1BvcHVwTWVudShjb25zdCBJbnRSZWN0 JiByZWN0LCBUZXh0RGlyZWN0aW9uIHRleHQKICAgICAgICAgbG9jYXRpb24gPSBOU01ha2VQb2lu dChOU01pblgocmVjdCkgKyBwb3BPdmVySG9yaXpvbnRhbEFkanVzdCwgTlNNYXhZKHJlY3QpIC0g dmVydGljYWxPZmZzZXQpOwogI2VuZGlmCiAKLSAgICB9IGVsc2UKLSAgICAgICAgbG9jYXRpb24g PSBOU01ha2VQb2ludChOU01pblgocmVjdCkgKyBwb3BVbmRlckhvcml6b250YWxBZGp1c3QsIE5T TWF4WShyZWN0KSArIHBvcFVuZGVyVmVydGljYWxBZGp1c3QpOyAgCi0KKyAgICB9IGVsc2Ugewor I2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMjAwCisgICAgICAgIGlm ICh0ZXh0RGlyZWN0aW9uID09IExUUikKKyAgICAgICAgICAgIGxvY2F0aW9uID0gTlNNYWtlUG9p bnQoTlNNaW5YKHJlY3QpICsgcG9wVW5kZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocmVjdCkg KyBwb3BVbmRlclZlcnRpY2FsQWRqdXN0KTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbG9j YXRpb24gPSBOU01ha2VQb2ludChOU01heFgocmVjdCkgLSBwb3BVbmRlckhvcml6b250YWxBZGp1 c3QsIE5TTWF4WShyZWN0KSArIHBvcFVuZGVyVmVydGljYWxBZGp1c3QpOworI2Vsc2UKKyAgICAg ICAgbG9jYXRpb24gPSBOU01ha2VQb2ludChOU01pblgocmVjdCkgKyBwb3BVbmRlckhvcml6b250 YWxBZGp1c3QsIE5TTWF4WShyZWN0KSArIHBvcFVuZGVyVmVydGljYWxBZGp1c3QpOworI2VuZGlm CisgICAgfQogICAgIFJldGFpblB0cjxOU1ZpZXc+IGR1bW15VmlldyA9IGFkb3B0TlMoW1tOU1Zp ZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6cmVjdF0pOwogICAgIFtkdW1teVZpZXcuZ2V0KCkgc2V0 VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbjp0ZXh0RGlyZWN0aW9uID09IExUUiA/IE5TVXNl ckludGVyZmFjZUxheW91dERpcmVjdGlvbkxlZnRUb1JpZ2h0IDogTlNVc2VySW50ZXJmYWNlTGF5 b3V0RGlyZWN0aW9uUmlnaHRUb0xlZnRdOwogICAgIFttX3dlYlZpZXcgYWRkU3VidmlldzpkdW1t eVZpZXcuZ2V0KCldOwo=