171312 2017-04-25 20:44:48 -0700 Web Inspector: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception) 2017-04-25 23:35:09 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1301446 0 joepeck 2017-04-25 20:44:48 -0700 Summary: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception) Steps to Reproduce: 1. Inspect this page 2. Show Network Tab 3. Reload 4. Show Priority Column if it is not visible 5. Sort by Priority Column => all rows disappear Exception: TypeError:​ Cannot convert a symbol to a number (at TimelineDataGrid.js:​411:​17)​ _sortComparator @ TimelineDataGrid.js:​411:​17 _sortComparator @ [native code]​ merge @ [native code]​ mergeSort @ [native code]​ comparatorSort @ [native code]​ sort @ [native code]​ _sort @ TimelineDataGrid.js:​336:​36 dispatch @ Object.js:​170:​30 1301447 1 joepeck 2017-04-25 20:45:00 -0700 <rdar://problem/31828554> 1301450 2 308202 joepeck 2017-04-25 20:46:13 -0700 Created attachment 308202 [PATCH] Proposed Fix 1301499 3 308202 bburg 2017-04-25 23:06:48 -0700 Comment on attachment 308202 [PATCH] Proposed Fix r=me 1301507 4 308202 commit-queue 2017-04-25 23:35:08 -0700 Comment on attachment 308202 [PATCH] Proposed Fix Clearing flags on attachment: 308202 Committed r215793: <http://trac.webkit.org/changeset/215793> 1301508 5 commit-queue 2017-04-25 23:35:09 -0700 All reviewed patches have been landed. Closing bug. 308202 2017-04-25 20:46:13 -0700 2017-04-25 23:35:08 -0700 [PATCH] Proposed Fix fix-sort-1.patch text/plain 5121 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRlY2FmMWE3N2E3Li44NDg0MjExM2E2OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTctMDQtMjUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBOZXR3b3JrIFRhYiAtIFNvcnRpbmcgYnkgUHJpb3JpdHkgQ29sdW1uIGhpZGVzIGFsbCByb3dz IGluIHRoZSBkYXRhZ3JpZCAodW5jYXVnaHQgZXhjZXB0aW9uKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxMzEyCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zMTgyODU1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlJlc291cmNlLmNvbXBhcmVQcmlvcml0eSk6CisgICAgICAgIFByb3ZpZGUgYSBo ZWxwZXIgZm9yIGNvbXBhcml0aW5nIE5ldHdvcmtQcmlvcml0eSBlbnVtIHZhbHVlcy4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3KToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3LnByb3RvdHlwZS5kYXRhR3JpZFNvcnRD b21wYXJhdG9yKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGlu ZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lVmlldy5wcm90 b3R5cGUuZGF0YUdyaWRTb3J0Q29tcGFyYXRvcik6CisgICAgICAgIEN1c3RvbSBzb3J0IGhhbmRs ZXIgZm9yIHByaW9yaXR5LgorCiAyMDE3LTA0LTI1ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5 ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE9wZW4gdGhlIG5ldyBidWcg cGFnZSBpbiB0aGUgbmV3IHRhYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzCmluZGV4IDVlZmY3Y2FlYjU1Li4yMmFhODhi ZmQ1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL1Jlc291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9SZXNvdXJjZS5qcwpAQCAtMTY5LDYgKzE2OSwyMyBAQCBXZWJJbnNwZWN0b3IuUmVz b3VyY2UgPSBjbGFzcyBSZXNvdXJjZSBleHRlbmRzIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlCiAg ICAgICAgIH0KICAgICB9CiAKKyAgICBzdGF0aWMgY29tcGFyZVByaW9yaXR5KGEsIGIpCisgICAg eworICAgICAgICBjb25zb2xlLmFzc2VydCh0eXBlb2YgYSA9PT0gInN5bWJvbCIpOworICAgICAg ICBjb25zb2xlLmFzc2VydCh0eXBlb2YgYiA9PT0gInN5bWJvbCIpOworCisgICAgICAgIGNvbnN0 IG1hcCA9IHsKKyAgICAgICAgICAgIFtXZWJJbnNwZWN0b3IuUmVzb3VyY2UuTmV0d29ya1ByaW9y aXR5LlVua25vd25dOiAwLAorICAgICAgICAgICAgW1dlYkluc3BlY3Rvci5SZXNvdXJjZS5OZXR3 b3JrUHJpb3JpdHkuTG93XTogMSwKKyAgICAgICAgICAgIFtXZWJJbnNwZWN0b3IuUmVzb3VyY2Uu TmV0d29ya1ByaW9yaXR5Lk1lZGl1bV06IDIsCisgICAgICAgICAgICBbV2ViSW5zcGVjdG9yLlJl c291cmNlLk5ldHdvcmtQcmlvcml0eS5IaWdoXTogMywKKyAgICAgICAgfTsKKworICAgICAgICBs ZXQgYU51bSA9IG1hcFthXSB8fCAwOworICAgICAgICBsZXQgYk51bSA9IG1hcFtiXSB8fCAwOwor ICAgICAgICByZXR1cm4gYU51bSAtIGJOdW07CisgICAgfQorCiAgICAgc3RhdGljIGRpc3BsYXlO YW1lRm9yUHJpb3JpdHkocHJpb3JpdHkpCiAgICAgewogICAgICAgICBzd2l0Y2ggKHByaW9yaXR5 KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9OZXR3b3JrR3JpZENvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5qcwppbmRleCBkNTliNGYyNjUw Mi4uZWFiNTI5YjJhOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL05ldHdvcmtHcmlkQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5qcwpA QCAtMTE3LDYgKzExNyw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3ID0g Y2xhc3MgTmV0d29ya0dyaWRDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAKICAgICAgICAgdGhp cy5fZGF0YUdyaWQgPSBuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWQoY29sdW1ucywg dGhpcy5fY29udGVudFRyZWVPdXRsaW5lKTsKICAgICAgICAgdGhpcy5fZGF0YUdyaWQuYWRkRXZl bnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRGF0YUdyaWQuRXZlbnQuU2VsZWN0ZWROb2RlQ2hhbmdl ZCwgdGhpcy5fZGF0YUdyaWROb2RlU2VsZWN0ZWQsIHRoaXMpOworICAgICAgICB0aGlzLl9kYXRh R3JpZC5zb3J0RGVsZWdhdGUgPSB0aGlzOwogICAgICAgICB0aGlzLl9kYXRhR3JpZC5zb3J0Q29s dW1uSWRlbnRpZmllciA9ICJyZXF1ZXN0U2VudCI7CiAgICAgICAgIHRoaXMuX2RhdGFHcmlkLnNv cnRPcmRlciA9IFdlYkluc3BlY3Rvci5EYXRhR3JpZC5Tb3J0T3JkZXIuQXNjZW5kaW5nOwogICAg ICAgICB0aGlzLl9kYXRhR3JpZC5jcmVhdGVTZXR0aW5ncygibmV0d29yay1ncmlkLWNvbnRlbnQt dmlldyIpOwpAQCAtMjY3LDYgKzI2OCwxNiBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0dyaWRDb250 ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtHcmlkQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbgogICAg ICAgICB0aGlzLnJlc2V0KCk7CiAgICAgfQogCisgICAgLy8gVGltZWxpbmVEYXRhR3JpZCBzb3J0 IGRlbGVnYXRlCisKKyAgICBkYXRhR3JpZFNvcnRDb21wYXJhdG9yKHNvcnRDb2x1bW5JZGVudGlm aWVyLCBzb3J0RGlyZWN0aW9uLCBub2RlMSwgbm9kZTIpCisgICAgeworICAgICAgICBpZiAoc29y dENvbHVtbklkZW50aWZpZXIgPT09ICJwcmlvcml0eSIpCisgICAgICAgICAgICByZXR1cm4gV2Vi SW5zcGVjdG9yLlJlc291cmNlLmNvbXBhcmVQcmlvcml0eShub2RlMS5kYXRhLnByaW9yaXR5LCBu b2RlMi5kYXRhLnByaW9yaXR5KSAqIHNvcnREaXJlY3Rpb247CisKKyAgICAgICAgcmV0dXJuIG51 bGw7CisgICAgfQorCiAgICAgLy8gUHJpdmF0ZQogCiAgICAgX3Jlc291cmNlQ2FjaGluZ0Rpc2Fi bGVkU2V0dGluZ0NoYW5nZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5lVmlldy5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZVZpZXcuanMKaW5kZXgg NzAxNWJmMDI4ODAuLjU2ZDQyZTE2MzE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGltZWxpbmVWaWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZVZpZXcu anMKQEAgLTE5MCwxNSArMTkwLDIwIEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrVGltZWxpbmVWaWV3 ID0gY2xhc3MgTmV0d29ya1RpbWVsaW5lVmlldyBleHRlbmRzIFdlYkluc3BlY3RvCiAKICAgICBk YXRhR3JpZFNvcnRDb21wYXJhdG9yKHNvcnRDb2x1bW5JZGVudGlmaWVyLCBzb3J0RGlyZWN0aW9u LCBub2RlMSwgbm9kZTIpCiAgICAgewotICAgICAgICBpZiAoc29ydENvbHVtbklkZW50aWZpZXIg IT09ICJuYW1lIikKLSAgICAgICAgICAgIHJldHVybiBudWxsOworICAgICAgICBpZiAoc29ydENv bHVtbklkZW50aWZpZXIgPT09ICJwcmlvcml0eSIpCisgICAgICAgICAgICByZXR1cm4gV2ViSW5z cGVjdG9yLlJlc291cmNlLmNvbXBhcmVQcmlvcml0eShub2RlMS5kYXRhLnByaW9yaXR5LCBub2Rl Mi5kYXRhLnByaW9yaXR5KSAqIHNvcnREaXJlY3Rpb247CisgICAgICAgIAorICAgICAgICBpZiAo c29ydENvbHVtbklkZW50aWZpZXIgPT0gIm5hbWUiKSB7CisgICAgICAgICAgICBsZXQgZGlzcGxh eU5hbWUxID0gbm9kZTEuZGlzcGxheU5hbWUoKTsKKyAgICAgICAgICAgIGxldCBkaXNwbGF5TmFt ZTIgPSBub2RlMi5kaXNwbGF5TmFtZSgpOwogCi0gICAgICAgIGxldCBkaXNwbGF5TmFtZTEgPSBu b2RlMS5kaXNwbGF5TmFtZSgpOwotICAgICAgICBsZXQgZGlzcGxheU5hbWUyID0gbm9kZTIuZGlz cGxheU5hbWUoKTsKLSAgICAgICAgaWYgKGRpc3BsYXlOYW1lMSAhPT0gZGlzcGxheU5hbWUyKQot ICAgICAgICAgICAgcmV0dXJuIGRpc3BsYXlOYW1lMS5sb2NhbGVDb21wYXJlKGRpc3BsYXlOYW1l MikgKiBzb3J0RGlyZWN0aW9uOworICAgICAgICAgICAgaWYgKGRpc3BsYXlOYW1lMSAhPT0gZGlz cGxheU5hbWUyKQorICAgICAgICAgICAgICAgIHJldHVybiBkaXNwbGF5TmFtZTEubG9jYWxlQ29t cGFyZShkaXNwbGF5TmFtZTIpICogc29ydERpcmVjdGlvbjsKIAotICAgICAgICByZXR1cm4gbm9k ZTEucmVzb3VyY2UudXJsLmxvY2FsZUNvbXBhcmUobm9kZTIucmVzb3VyY2UudXJsKSAqIHNvcnRE aXJlY3Rpb247CisgICAgICAgICAgICByZXR1cm4gbm9kZTEucmVzb3VyY2UudXJsLmxvY2FsZUNv bXBhcmUobm9kZTIucmVzb3VyY2UudXJsKSAqIHNvcnREaXJlY3Rpb247CisgICAgICAgIH0KKwor ICAgICAgICByZXR1cm4gbnVsbDsKICAgICB9CiAKICAgICAvLyBQcm90ZWN0ZWQK