171302 2017-04-25 17:25:57 -0700 Skip WebKitAdditions for Safari Technology Preview media controls 2017-04-26 23:21:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 dino dino mitz simon.fraser oldest_to_newest 1301340 0 dino 2017-04-25 17:25:57 -0700 Skip WebKitAdditions for Safari Technology Preview media controls 1301344 1 308173 dino 2017-04-25 17:29:35 -0700 Created attachment 308173 Patch 1301346 2 308174 dino 2017-04-25 17:30:14 -0700 Created attachment 308174 Patch 1301349 3 dino 2017-04-25 17:39:01 -0700 Committed r215774: <http://trac.webkit.org/changeset/215774> 1301483 4 mitz 2017-04-25 21:56:16 -0700 (In reply to Dean Jackson from comment #3) > Committed r215774: <http://trac.webkit.org/changeset/215774> This change isn’t doing what it was intended to do and is inappropriate for WebCore. Can you please revert it? 1301962 5 mitz 2017-04-26 23:21:52 -0700 I reverted r215774 in r215858. 308173 2017-04-25 17:29:35 -0700 2017-04-25 17:30:28 -0700 Patch patch.diff text/plain 2988 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZDcwN2M5MGVlYS4uNjA3ZDVmYzAwNjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wNC0yNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK KyAgICAgICAgU2tpcCBXZWJLaXRBZGRpdGlvbnMgZm9yIFNhZmFyaSBUZWNobm9sb2d5IFByZXZp ZXcgbWVkaWEgY29udHJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MTMwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNhZmFyaSBUZWNobm9sb2d5IFByZXZpZXcgc2hvdWxkIHVzZSB0aGUgc2FtZSBj b250cm9scworICAgICAgICBhcyBPcGVuU291cmNlLgorCisgICAgICAgICogV2ViQ29yZS54Y29k ZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDE3LTA0LTIzICBDb21taXQgUXVldWUgIDxjb21t aXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MjE1NjU3IGFuZCByMjE1Njc2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54 Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGUyN2JjZjM1NTVhLi42MjFkYTFlZTkxMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisr KyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAt MzAzNTksNyArMzAzNTksNyBAQAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHBy b2Nlc3NpbmcgPSAwOwogCQkJc2hlbGxQYXRoID0gL2Jpbi9zaDsKLQkJCXNoZWxsU2NyaXB0ID0g IldLQV9ESVI9XCIkQlVJTFRfUFJPRFVDVFNfRElSL3Vzci9sb2NhbC9pbmNsdWRlL1dlYktpdEFk ZGl0aW9ucy9tb2Rlcm4tbWVkaWEtY29udHJvbHNcIlxuU1JDX0RJUj1cIiRTUkNST09UL01vZHVs ZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzXCJcbkRTVF9ESVI9XCIkQlVJTFRfUFJPRFVDVFNfRElS LyRVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BBVEgvbW9kZXJuLW1lZGlhLWNvbnRyb2xz XCJcblxuaWYgWyAtZCBcIiRXS0FfRElSXCIgXTsgdGhlblxuICAgIE1NQ19ESVI9JFdLQV9ESVI7 XG5lbHNlXG4gICAgTU1DX0RJUj0kU1JDX0RJUlxuZmlcblxubWtkaXIgLXAgXCIkRFNUX0RJUlwi XG5cbmlmIFsgXCIke1BMQVRGT1JNX05BTUV9XCIgPT0gXCJtYWNvc3hcIiBdOyB0aGVuXG4gICAg SU1HX09TX1BSRUZJWD1cIm1hY09TXCJcbmZpXG5cbmlmIFsgXCIke1BMQVRGT1JNX05BTUV9XCIg PT0gXCJpcGhvbmVvc1wiIF0gfHwgWyBcIiR7UExBVEZPUk1fTkFNRX1cIiA9PSBcImlwaG9uZXNp bXVsYXRvclwiIF07IHRoZW5cbiAgICBJTUdfT1NfUFJFRklYPVwiaU9TXCJcbmZpXG5cbmlmIFsg LW4gXCIkSU1HX09TX1BSRUZJWFwiIF07IHRoZW5cbiAgICByc3luYyAtYXEgLS1leGNsdWRlIFwi LnN2blwiIC0tZXhjbHVkZSBcIi5EU19TdG9yZVwiIFwiJE1NQ19ESVIvaW1hZ2VzLyRJTUdfT1Nf UFJFRklYL1wiIFwiJERTVF9ESVIvaW1hZ2VzXCJcbmZpXG5cbmNkIFwiJE1NQ19ESVJcIlxuY2F0 IGNvbnRyb2xzLyouY3NzID4gXCIkRFNUX0RJUi9tb2Rlcm4tbWVkaWEtY29udHJvbHMuY3NzXCJc bmNhdCBgY2F0IGpzLWZpbGVzYCA+IFwiJERTVF9ESVIvbW9kZXJuLW1lZGlhLWNvbnRyb2xzLmpz XCIiOworCQkJc2hlbGxTY3JpcHQgPSAiV0tBX0RJUj1cIiRCVUlMVF9QUk9EVUNUU19ESVIvdXNy L2xvY2FsL2luY2x1ZGUvV2ViS2l0QWRkaXRpb25zL21vZGVybi1tZWRpYS1jb250cm9sc1wiXG5T UkNfRElSPVwiJFNSQ1JPT1QvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHNcIlxuRFNUX0RJ Uj1cIiRCVUlMVF9QUk9EVUNUU19ESVIvJFVOTE9DQUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFU SC9tb2Rlcm4tbWVkaWEtY29udHJvbHNcIlxuXG5pZiBbWyAtZCBcIiRXS0FfRElSXCIgJiYgJFNB RkFSSV9URUNITk9MT0dZX1BSRVZJRVdfVFlQRSAhPSBcIlRFQ0hOT0xPR1lfUFJFVklFV1wiIF1d OyB0aGVuXG4gICAgTU1DX0RJUj0kV0tBX0RJUjtcbmVsc2VcbiAgICBNTUNfRElSPSRTUkNfRElS XG5maVxuXG5ta2RpciAtcCBcIiREU1RfRElSXCJcblxuaWYgWyBcIiR7UExBVEZPUk1fTkFNRX1c IiA9PSBcIm1hY29zeFwiIF07IHRoZW5cbiAgICBJTUdfT1NfUFJFRklYPVwibWFjT1NcIlxuZmlc blxuaWYgWyBcIiR7UExBVEZPUk1fTkFNRX1cIiA9PSBcImlwaG9uZW9zXCIgXSB8fCBbIFwiJHtQ TEFURk9STV9OQU1FfVwiID09IFwiaXBob25lc2ltdWxhdG9yXCIgXTsgdGhlblxuICAgIElNR19P U19QUkVGSVg9XCJpT1NcIlxuZmlcblxuaWYgWyAtbiBcIiRJTUdfT1NfUFJFRklYXCIgXTsgdGhl blxuICAgIHJzeW5jIC1hcSAtLWV4Y2x1ZGUgXCIuc3ZuXCIgLS1leGNsdWRlIFwiLkRTX1N0b3Jl XCIgXCIkTU1DX0RJUi9pbWFnZXMvJElNR19PU19QUkVGSVgvXCIgXCIkRFNUX0RJUi9pbWFnZXNc IlxuZmlcblxuY2QgXCIkTU1DX0RJUlwiXG5jYXQgY29udHJvbHMvKi5jc3MgPiBcIiREU1RfRElS L21vZGVybi1tZWRpYS1jb250cm9scy5jc3NcIlxuY2F0IGBjYXQganMtZmlsZXNgID4gXCIkRFNU X0RJUi9tb2Rlcm4tbWVkaWEtY29udHJvbHMuanNcIlxuZWNobyAkTU1DX0RJUiA+IFwiJERTVF9E SVIvc291cmNlbG9jYXRpb24udHh0XCJcbiI7CiAJCX07CiAJCUE1RTc5Q0VDMUU2N0YyQ0YwMEZC ODE1MyAvKiBNYWtlIEZyYW1ld29ya3MgU3ltYm9saWMgTGluayAqLyA9IHsKIAkJCWlzYSA9IFBC WFNoZWxsU2NyaXB0QnVpbGRQaGFzZTsK 308174 2017-04-25 17:30:14 -0700 2017-04-25 17:33:27 -0700 Patch patch.diff text/plain 2939 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZDcwN2M5MGVlYS4uNjA3ZDVmYzAwNjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wNC0yNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK KyAgICAgICAgU2tpcCBXZWJLaXRBZGRpdGlvbnMgZm9yIFNhZmFyaSBUZWNobm9sb2d5IFByZXZp ZXcgbWVkaWEgY29udHJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MTMwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNhZmFyaSBUZWNobm9sb2d5IFByZXZpZXcgc2hvdWxkIHVzZSB0aGUgc2FtZSBj b250cm9scworICAgICAgICBhcyBPcGVuU291cmNlLgorCisgICAgICAgICogV2ViQ29yZS54Y29k ZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDE3LTA0LTIzICBDb21taXQgUXVldWUgIDxjb21t aXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MjE1NjU3IGFuZCByMjE1Njc2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54 Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGUyN2JjZjM1NTVhLi41YTAxMTAxMmEyYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisr KyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAt MzAzNTksNyArMzAzNTksNyBAQAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHBy b2Nlc3NpbmcgPSAwOwogCQkJc2hlbGxQYXRoID0gL2Jpbi9zaDsKLQkJCXNoZWxsU2NyaXB0ID0g IldLQV9ESVI9XCIkQlVJTFRfUFJPRFVDVFNfRElSL3Vzci9sb2NhbC9pbmNsdWRlL1dlYktpdEFk ZGl0aW9ucy9tb2Rlcm4tbWVkaWEtY29udHJvbHNcIlxuU1JDX0RJUj1cIiRTUkNST09UL01vZHVs ZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzXCJcbkRTVF9ESVI9XCIkQlVJTFRfUFJPRFVDVFNfRElS LyRVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BBVEgvbW9kZXJuLW1lZGlhLWNvbnRyb2xz XCJcblxuaWYgWyAtZCBcIiRXS0FfRElSXCIgXTsgdGhlblxuICAgIE1NQ19ESVI9JFdLQV9ESVI7 XG5lbHNlXG4gICAgTU1DX0RJUj0kU1JDX0RJUlxuZmlcblxubWtkaXIgLXAgXCIkRFNUX0RJUlwi XG5cbmlmIFsgXCIke1BMQVRGT1JNX05BTUV9XCIgPT0gXCJtYWNvc3hcIiBdOyB0aGVuXG4gICAg SU1HX09TX1BSRUZJWD1cIm1hY09TXCJcbmZpXG5cbmlmIFsgXCIke1BMQVRGT1JNX05BTUV9XCIg PT0gXCJpcGhvbmVvc1wiIF0gfHwgWyBcIiR7UExBVEZPUk1fTkFNRX1cIiA9PSBcImlwaG9uZXNp bXVsYXRvclwiIF07IHRoZW5cbiAgICBJTUdfT1NfUFJFRklYPVwiaU9TXCJcbmZpXG5cbmlmIFsg LW4gXCIkSU1HX09TX1BSRUZJWFwiIF07IHRoZW5cbiAgICByc3luYyAtYXEgLS1leGNsdWRlIFwi LnN2blwiIC0tZXhjbHVkZSBcIi5EU19TdG9yZVwiIFwiJE1NQ19ESVIvaW1hZ2VzLyRJTUdfT1Nf UFJFRklYL1wiIFwiJERTVF9ESVIvaW1hZ2VzXCJcbmZpXG5cbmNkIFwiJE1NQ19ESVJcIlxuY2F0 IGNvbnRyb2xzLyouY3NzID4gXCIkRFNUX0RJUi9tb2Rlcm4tbWVkaWEtY29udHJvbHMuY3NzXCJc bmNhdCBgY2F0IGpzLWZpbGVzYCA+IFwiJERTVF9ESVIvbW9kZXJuLW1lZGlhLWNvbnRyb2xzLmpz XCIiOworCQkJc2hlbGxTY3JpcHQgPSAiV0tBX0RJUj1cIiRCVUlMVF9QUk9EVUNUU19ESVIvdXNy L2xvY2FsL2luY2x1ZGUvV2ViS2l0QWRkaXRpb25zL21vZGVybi1tZWRpYS1jb250cm9sc1wiXG5T UkNfRElSPVwiJFNSQ1JPT1QvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHNcIlxuRFNUX0RJ Uj1cIiRCVUlMVF9QUk9EVUNUU19ESVIvJFVOTE9DQUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFU SC9tb2Rlcm4tbWVkaWEtY29udHJvbHNcIlxuXG5pZiBbWyAtZCBcIiRXS0FfRElSXCIgJiYgJFNB RkFSSV9URUNITk9MT0dZX1BSRVZJRVdfVFlQRSAhPSBcIlRFQ0hOT0xPR1lfUFJFVklFV1wiIF1d OyB0aGVuXG4gICAgTU1DX0RJUj0kV0tBX0RJUjtcbmVsc2VcbiAgICBNTUNfRElSPSRTUkNfRElS XG5maVxuXG5ta2RpciAtcCBcIiREU1RfRElSXCJcblxuaWYgWyBcIiR7UExBVEZPUk1fTkFNRX1c IiA9PSBcIm1hY29zeFwiIF07IHRoZW5cbiAgICBJTUdfT1NfUFJFRklYPVwibWFjT1NcIlxuZmlc blxuaWYgWyBcIiR7UExBVEZPUk1fTkFNRX1cIiA9PSBcImlwaG9uZW9zXCIgXSB8fCBbIFwiJHtQ TEFURk9STV9OQU1FfVwiID09IFwiaXBob25lc2ltdWxhdG9yXCIgXTsgdGhlblxuICAgIElNR19P U19QUkVGSVg9XCJpT1NcIlxuZmlcblxuaWYgWyAtbiBcIiRJTUdfT1NfUFJFRklYXCIgXTsgdGhl blxuICAgIHJzeW5jIC1hcSAtLWV4Y2x1ZGUgXCIuc3ZuXCIgLS1leGNsdWRlIFwiLkRTX1N0b3Jl XCIgXCIkTU1DX0RJUi9pbWFnZXMvJElNR19PU19QUkVGSVgvXCIgXCIkRFNUX0RJUi9pbWFnZXNc IlxuZmlcblxuY2QgXCIkTU1DX0RJUlwiXG5jYXQgY29udHJvbHMvKi5jc3MgPiBcIiREU1RfRElS L21vZGVybi1tZWRpYS1jb250cm9scy5jc3NcIlxuY2F0IGBjYXQganMtZmlsZXNgID4gXCIkRFNU X0RJUi9tb2Rlcm4tbWVkaWEtY29udHJvbHMuanNcIlxuIjsKIAkJfTsKIAkJQTVFNzlDRUMxRTY3 RjJDRjAwRkI4MTUzIC8qIE1ha2UgRnJhbWV3b3JrcyBTeW1ib2xpYyBMaW5rICovID0gewogCQkJ aXNhID0gUEJYU2hlbGxTY3JpcHRCdWlsZFBoYXNlOwo=