171296 2017-04-25 16:23:16 -0700 [ARM] Enable GCC visibility 2017-04-26 11:28:06 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead achristensen benjamin buildbot cdumez cmarcelo commit-queue dbates lforschler mcatanzaro oldest_to_newest 1301307 0 don.olmstead 2017-04-25 16:23:16 -0700 The export macros for WebKit have a guard to prevent the GCC visibility attribute on ARM. This was originally done back in 2009 with https://trac.webkit.org/changeset/48251/webkit. It appears that armcc now supports the visibility attribute, http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0472j/chr1359124978628.html, so this can be enabled. 1301330 1 308169 don.olmstead 2017-04-25 17:05:39 -0700 Created attachment 308169 Patch Enables GCC visibility for armcc. GCC needs to be >= 4 to have support. Clang also exposes this macro. 1301331 2 don.olmstead 2017-04-25 17:06:32 -0700 This fixes the feedback from https://bugs.webkit.org/show_bug.cgi?id=171240 that wasn't gotten to before landing. 1301533 3 achristensen 2017-04-26 00:33:57 -0700 I don't think we support gcc older than 4. 1301661 4 mcatanzaro 2017-04-26 10:25:56 -0700 (In reply to Alex Christensen from comment #3) > I don't think we support gcc older than 4. Yeah, GCC 4.0 was released in 2005 and there's no way to compile WebKit with anything less than GCC 4.9. We have checks to prevent this in other places. No need for that version test. 1301666 5 308169 achristensen 2017-04-26 10:40:00 -0700 Comment on attachment 308169 Patch Ok, that's what I thought. Let's just remove the checks. 1301669 6 308265 don.olmstead 2017-04-26 10:43:17 -0700 Created attachment 308265 Patch with GCC 4 check removed 1301698 7 308265 commit-queue 2017-04-26 11:28:04 -0700 Comment on attachment 308265 Patch with GCC 4 check removed Clearing flags on attachment: 308265 Committed r215817: <http://trac.webkit.org/changeset/215817> 1301699 8 commit-queue 2017-04-26 11:28:06 -0700 All reviewed patches have been landed. Closing bug. 308169 2017-04-25 17:05:39 -0700 2017-04-26 10:43:17 -0700 Patch bug171296.diff text/plain 1333 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZGIwM2VhOS4uZThmMzk5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNy0wNC0yNSAg RG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgogCisgICAgICAgIFtBUk1d IEVuYWJsZSBHQ0MgdmlzaWJpbGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTcxMjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKworMjAxNy0wNC0yNSAgRG9uIE9sbXN0 ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgorCiAgICAgICAgIFtXaW5dIFVzZSBDbGFu ZydzIF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZSBmb3IgZXhwb3J0IG1hY3JvcwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxMjQwCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o CmluZGV4IDlmZmY2OTEuLmJhNGVhMTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTQzNiwxMSArNDM2LDEw IEBACiAKIC8qIEV4cG9ydCBtYWNybyBzdXBwb3J0LiBEZXRlY3RzIHRoZSBhdHRyaWJ1dGVzIGF2 YWlsYWJsZSBmb3Igc2hhcmVkIGxpYnJhcnkgc3ltYm9sIGV4cG9ydAogICAgZGVjb3JhdGlvbnMu ICovCi0jaWYgT1MoV0lORE9XUykgXAotICAgIHx8IChDT01QSUxFUl9IQVNfQ0xBTkdfREVDTFNQ RUMoZGxsaW1wb3J0KSAmJiBDT01QSUxFUl9IQVNfQ0xBTkdfREVDTFNQRUMoZGxsZXhwb3J0KSkK KyNpZiBPUyhXSU5ET1dTKSB8fCAoQ09NUElMRVJfSEFTX0NMQU5HX0RFQ0xTUEVDKGRsbGltcG9y dCkgJiYgQ09NUElMRVJfSEFTX0NMQU5HX0RFQ0xTUEVDKGRsbGV4cG9ydCkpCiAjZGVmaW5lIFVT RV9ERUNMU1BFQ19BVFRSSUJVVEUgMQogI2RlZmluZSBVU0VfVklTSUJJTElUWV9BVFRSSUJVVEUg MAotI2VsaWYgZGVmaW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19DQ19BUk0pICYmICFkZWZp bmVkKF9fQVJNQ0NfXykKKyNlbGlmIGRlZmluZWQoX19HTlVDX18pICYmIChfX0dOVUNfXyA+PSA0 KQogI2RlZmluZSBVU0VfREVDTFNQRUNfQVRUUklCVVRFIDAKICNkZWZpbmUgVVNFX1ZJU0lCSUxJ VFlfQVRUUklCVVRFIDEKICNlbHNlCg== 308265 2017-04-26 10:43:17 -0700 2017-04-26 11:28:04 -0700 Patch with GCC 4 check removed bug171296.diff text/plain 1314 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZGIwM2VhOS4uZThmMzk5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNy0wNC0yNSAg RG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgogCisgICAgICAgIFtBUk1d IEVuYWJsZSBHQ0MgdmlzaWJpbGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTcxMjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKworMjAxNy0wNC0yNSAgRG9uIE9sbXN0 ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgorCiAgICAgICAgIFtXaW5dIFVzZSBDbGFu ZydzIF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZSBmb3IgZXhwb3J0IG1hY3JvcwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxMjQwCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o CmluZGV4IDlmZmY2OTEuLmJhNGVhMTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTQzNiwxMSArNDM2LDEw IEBACiAKIC8qIEV4cG9ydCBtYWNybyBzdXBwb3J0LiBEZXRlY3RzIHRoZSBhdHRyaWJ1dGVzIGF2 YWlsYWJsZSBmb3Igc2hhcmVkIGxpYnJhcnkgc3ltYm9sIGV4cG9ydAogICAgZGVjb3JhdGlvbnMu ICovCi0jaWYgT1MoV0lORE9XUykgXAotICAgIHx8IChDT01QSUxFUl9IQVNfQ0xBTkdfREVDTFNQ RUMoZGxsaW1wb3J0KSAmJiBDT01QSUxFUl9IQVNfQ0xBTkdfREVDTFNQRUMoZGxsZXhwb3J0KSkK KyNpZiBPUyhXSU5ET1dTKSB8fCAoQ09NUElMRVJfSEFTX0NMQU5HX0RFQ0xTUEVDKGRsbGltcG9y dCkgJiYgQ09NUElMRVJfSEFTX0NMQU5HX0RFQ0xTUEVDKGRsbGV4cG9ydCkpCiAjZGVmaW5lIFVT RV9ERUNMU1BFQ19BVFRSSUJVVEUgMQogI2RlZmluZSBVU0VfVklTSUJJTElUWV9BVFRSSUJVVEUg MAotI2VsaWYgZGVmaW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19DQ19BUk0pICYmICFkZWZp bmVkKF9fQVJNQ0NfXykKKyNlbGlmIGRlZmluZWQoX19HTlVDX18pCiAjZGVmaW5lIFVTRV9ERUNM U1BFQ19BVFRSSUJVVEUgMAogI2RlZmluZSBVU0VfVklTSUJJTElUWV9BVFRSSUJVVEUgMQogI2Vs c2UK