171281 2017-04-25 11:37:56 -0700 Improve wavy underline rendering 2017-04-26 08:59:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt bfulgham sam simon.fraser zalan oldest_to_newest 1301127 0 hyatt 2017-04-25 11:37:56 -0700 Improve wavy underline rendering 1301128 1 308119 hyatt 2017-04-25 11:40:00 -0700 Created attachment 308119 Patch 1301136 2 308119 sam 2017-04-25 11:53:01 -0700 Comment on attachment 308119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308119&action=review I take it, the only real way to regression test this is pixel tests? > Source/WebCore/style/InlineTextBoxStyle.cpp:93 > // Distance between decoration's axis and Bezier curve's control points. > // The height of the curve is based on this distance. Use a minimum of 6 pixels distance since > // the actual curve passes approximately at half of that distance, that is 3 pixels. > // The minimum height of the curve is also approximately 3 pixels. Increases the curve's height > // as strokeThickness increases to make the curve look better. Is this comment still correct? 1301604 3 hyatt 2017-04-26 08:59:11 -0700 Fixed in r215802. 308119 2017-04-25 11:40:00 -0700 2017-04-25 11:53:01 -0700 Patch patch.txt text/plain 5761 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTc0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA0LTI1ICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgd2F2eSB1bmRlcmxpbmUg cmVuZGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzEyODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDaGFuZ2Ugd2F2eSB1bmRlcmxpbmUgcmVuZGVyaW5nIHRvIHVzZSBmb250IHNpemUgaW5zdGVh ZCBvZiBzdHJva2UKKyAgICAgICAgdGhpY2tuZXNzIGFzIGEgd2F5IHRvIHR1bmUgaXQuIEN1dCB0 aGUgZXh0cmEgb2Zmc2V0IGZyb20gMiB0byAxLgorICAgICAgICBDaGFuZ2UgdGhlIHBhcmFtZXRl cnMgdG8gbWFrZSB0aGUgbGluZSBmbGF0dGVyIGFuZCB0byBtYWtlIHRoZSBwcm9wb3J0aW9uCisg ICAgICAgIG9mIHRoZSB3YXZlIHRoYXQgcmVuZGVycyB1bmRlcm5lYXRoIGEgZ2x5cGggdGhlIHNh bWUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvVGV4dERlY29yYXRpb25QYWludGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OnN0cm9rZVdhdnlUZXh0RGVjb3JhdGlvbik6CisgICAgICAgIChXZWJD b3JlOjpUZXh0RGVjb3JhdGlvblBhaW50ZXI6OnBhaW50VGV4dERlY29yYXRpb24pOgorICAgICAg ICAqIHN0eWxlL0lubGluZVRleHRCb3hTdHlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRX YXZ5U3Ryb2tlUGFyYW1ldGVycyk6CisgICAgICAgIChXZWJDb3JlOjp2aXN1YWxPdmVyZmxvd0Zv ckRlY29yYXRpb25zKToKKyAgICAgICAgKiBzdHlsZS9JbmxpbmVUZXh0Qm94U3R5bGUuaDoKKyAg ICAgICAgKFdlYkNvcmU6OndhdnlPZmZzZXRGcm9tRGVjb3JhdGlvbik6CisKIDIwMTctMDQtMjUg IEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01lZGlh U3RyZWFtIG1hY09TXSBVbmFibGUgdG8gYXBwbHkgZnJhbWVSYXRlIGNvbnN0cmFpbnQKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0RGVjb3JhdGlvblBhaW50ZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0RGVjb3JhdGlvblBhaW50ZXIu Y3BwCShyZXZpc2lvbiAyMTU0MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dERl Y29yYXRpb25QYWludGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODEsNyArODEsNyBAQCBzdGF0 aWMgdm9pZCBhZGp1c3RTdGVwVG9EZWNvcmF0aW9uTGVuZ3RoCiAgKiAgICAgICAgICAgICB8LS0t LS0tLS0tLS18CiAgKiAgICAgICAgICAgICAgICAgc3RlcAogICovCi1zdGF0aWMgdm9pZCBzdHJv a2VXYXZ5VGV4dERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBGbG9h dFBvaW50JiBzdGFydCwgY29uc3QgRmxvYXRQb2ludCYgZW5kLCBmbG9hdCBzdHJva2VUaGlja25l c3MpCitzdGF0aWMgdm9pZCBzdHJva2VXYXZ5VGV4dERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0 JiBjb250ZXh0LCBjb25zdCBGbG9hdFBvaW50JiBzdGFydCwgY29uc3QgRmxvYXRQb2ludCYgZW5k LCBmbG9hdCBzdHJva2VUaGlja25lc3MsIGZsb2F0IGZvbnRTaXplKQogewogICAgIEZsb2F0UG9p bnQgcDEgPSBzdGFydDsKICAgICBGbG9hdFBvaW50IHAyID0gZW5kOwpAQCAtOTIsNyArOTIsNyBA QCBzdGF0aWMgdm9pZCBzdHJva2VXYXZ5VGV4dERlY29yYXRpb24oR3JhCiAKICAgICBmbG9hdCBj b250cm9sUG9pbnREaXN0YW5jZTsKICAgICBmbG9hdCBzdGVwOwotICAgIGdldFdhdnlTdHJva2VQ YXJhbWV0ZXJzKHN0cm9rZVRoaWNrbmVzcywgY29udHJvbFBvaW50RGlzdGFuY2UsIHN0ZXApOwor ICAgIGdldFdhdnlTdHJva2VQYXJhbWV0ZXJzKGZvbnRTaXplLCBjb250cm9sUG9pbnREaXN0YW5j ZSwgc3RlcCk7CiAKICAgICBib29sIGlzVmVydGljYWxMaW5lID0gKHAxLngoKSA9PSBwMi54KCkp OwogCkBAIC0yNjgsNyArMjY4LDcgQEAgdm9pZCBUZXh0RGVjb3JhdGlvblBhaW50ZXI6OnBhaW50 VGV4dERlYwogICAgICAgICBhdXRvIHN0cm9rZVN0eWxlID0gdGV4dERlY29yYXRpb25TdHlsZVRv U3Ryb2tlU3R5bGUoc3R5bGUpOwogCiAgICAgICAgIGlmIChzdHlsZSA9PSBUZXh0RGVjb3JhdGlv blN0eWxlV2F2eSkKLSAgICAgICAgICAgIHN0cm9rZVdhdnlUZXh0RGVjb3JhdGlvbihtX2NvbnRl eHQsIHN0YXJ0LCBlbmQsIHRleHREZWNvcmF0aW9uVGhpY2tuZXNzKTsKKyAgICAgICAgICAgIHN0 cm9rZVdhdnlUZXh0RGVjb3JhdGlvbihtX2NvbnRleHQsIHN0YXJ0LCBlbmQsIHRleHREZWNvcmF0 aW9uVGhpY2tuZXNzLCBtX2xpbmVTdHlsZS5mb250U2l6ZSgpKTsKICAgICAgICAgZWxzZSBpZiAo ZGVjb3JhdGlvbiA9PSBUZXh0RGVjb3JhdGlvblVuZGVybGluZSB8fCBkZWNvcmF0aW9uID09IFRl eHREZWNvcmF0aW9uT3ZlcmxpbmUpIHsKICNpZiBFTkFCTEUoQ1NTM19URVhUX0RFQ09SQVRJT05f U0tJUF9JTkspCiAgICAgICAgICAgICBpZiAoKG1fbGluZVN0eWxlLnRleHREZWNvcmF0aW9uU2tp cCgpID09IFRleHREZWNvcmF0aW9uU2tpcEluayB8fCBtX2xpbmVTdHlsZS50ZXh0RGVjb3JhdGlv blNraXAoKSA9PSBUZXh0RGVjb3JhdGlvblNraXBBdXRvKSAmJiBtX2lzSG9yaXpvbnRhbCkgewpJ bmRleDogU291cmNlL1dlYkNvcmUvc3R5bGUvSW5saW5lVGV4dEJveFN0eWxlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdHlsZS9JbmxpbmVUZXh0Qm94U3R5bGUuY3BwCShyZXZp c2lvbiAyMTU0MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9zdHlsZS9JbmxpbmVUZXh0Qm94U3R5bGUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NCwxOSArODQsMTkgQEAgaW50IGNvbXB1dGVVbmRlcmxp bmVPZmZzZXQoVGV4dFVuZGVybGluZQogICAgIHJldHVybiBmb250TWV0cmljcy5hc2NlbnQoKSAr IGdhcDsKIH0KICAgICAKLXZvaWQgZ2V0V2F2eVN0cm9rZVBhcmFtZXRlcnMoZmxvYXQgc3Ryb2tl VGhpY2tuZXNzLCBmbG9hdCYgY29udHJvbFBvaW50RGlzdGFuY2UsIGZsb2F0JiBzdGVwKQordm9p ZCBnZXRXYXZ5U3Ryb2tlUGFyYW1ldGVycyhmbG9hdCBmb250U2l6ZSwgZmxvYXQmIGNvbnRyb2xQ b2ludERpc3RhbmNlLCBmbG9hdCYgc3RlcCkKIHsKICAgICAvLyBEaXN0YW5jZSBiZXR3ZWVuIGRl Y29yYXRpb24ncyBheGlzIGFuZCBCZXppZXIgY3VydmUncyBjb250cm9sIHBvaW50cy4KICAgICAv LyBUaGUgaGVpZ2h0IG9mIHRoZSBjdXJ2ZSBpcyBiYXNlZCBvbiB0aGlzIGRpc3RhbmNlLiBVc2Ug YSBtaW5pbXVtIG9mIDYgcGl4ZWxzIGRpc3RhbmNlIHNpbmNlCiAgICAgLy8gdGhlIGFjdHVhbCBj dXJ2ZSBwYXNzZXMgYXBwcm94aW1hdGVseSBhdCBoYWxmIG9mIHRoYXQgZGlzdGFuY2UsIHRoYXQg aXMgMyBwaXhlbHMuCiAgICAgLy8gVGhlIG1pbmltdW0gaGVpZ2h0IG9mIHRoZSBjdXJ2ZSBpcyBh bHNvIGFwcHJveGltYXRlbHkgMyBwaXhlbHMuIEluY3JlYXNlcyB0aGUgY3VydmUncyBoZWlnaHQK ICAgICAvLyBhcyBzdHJva2VUaGlja25lc3MgaW5jcmVhc2VzIHRvIG1ha2UgdGhlIGN1cnZlIGxv b2sgYmV0dGVyLgotICAgIGNvbnRyb2xQb2ludERpc3RhbmNlID0gMyAqIHN0ZDo6bWF4PGZsb2F0 PigyLCBzdHJva2VUaGlja25lc3MpOworICAgIGNvbnRyb2xQb2ludERpc3RhbmNlID0gMC4wOTM3 NSAqIGZvbnRTaXplOwogCiAgICAgLy8gSW5jcmVtZW50IHVzZWQgdG8gZm9ybSB0aGUgZGlhbW9u ZCBzaGFwZSBiZXR3ZWVuIHN0YXJ0IHBvaW50IChwMSksIGNvbnRyb2wKICAgICAvLyBwb2ludHMg YW5kIGVuZCBwb2ludCAocDIpIGFsb25nIHRoZSBheGlzIG9mIHRoZSBkZWNvcmF0aW9uLiBNYWtl cyB0aGUKLSAgICAvLyBjdXJ2ZSB3aWRlciBhcyBzdHJva2VUaGlja25lc3MgaW5jcmVhc2VzIHRv IG1ha2UgdGhlIGN1cnZlIGxvb2sgYmV0dGVyLgotICAgIHN0ZXAgPSAyICogc3RkOjptYXg8Zmxv YXQ+KDIsIHN0cm9rZVRoaWNrbmVzcyk7CisgICAgLy8gY3VydmUgd2lkZXIgYXMgZm9udCBzaXpl IGluY3JlYXNlcyB0byBtYWtlIHRoZSBjdXJ2ZSBsb29rIGJldHRlci4KKyAgICBzdGVwID0gZm9u dFNpemUgLyA0LjU7CiB9CiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBleHRlbmRJbnRUb0Zsb2F0KGlu dCYgZXh0ZW5kTWUsIGZsb2F0IGV4dGVuZFRvKQpAQCAtMTIyLDcgKzEyMiw3IEBAIEdseXBoT3Zl cmZsb3cgdmlzdWFsT3ZlcmZsb3dGb3JEZWNvcmF0aW8KICAgICBHbHlwaE92ZXJmbG93IG92ZXJm bG93UmVzdWx0OwogICAgIAogICAgIGlmIChkZWNvcmF0aW9uU3R5bGUgPT0gVGV4dERlY29yYXRp b25TdHlsZVdhdnkpIHsKLSAgICAgICAgZ2V0V2F2eVN0cm9rZVBhcmFtZXRlcnMoc3Ryb2tlVGhp Y2tuZXNzLCBjb250cm9sUG9pbnREaXN0YW5jZSwgc3RlcCk7CisgICAgICAgIGdldFdhdnlTdHJv a2VQYXJhbWV0ZXJzKGxpbmVTdHlsZS5mb250U2l6ZSgpLCBjb250cm9sUG9pbnREaXN0YW5jZSwg c3RlcCk7CiAgICAgICAgIHdhdnlPZmZzZXQgPSB3YXZ5T2Zmc2V0RnJvbURlY29yYXRpb24oKTsK ICAgICAgICAgb3ZlcmZsb3dSZXN1bHQubGVmdCA9IHN0cm9rZVRoaWNrbmVzczsKICAgICAgICAg b3ZlcmZsb3dSZXN1bHQucmlnaHQgPSBzdHJva2VUaGlja25lc3M7CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9zdHlsZS9JbmxpbmVUZXh0Qm94U3R5bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9zdHlsZS9JbmxpbmVUZXh0Qm94U3R5bGUuaAkocmV2aXNpb24gMjE1NDE3KQorKysgU291 cmNlL1dlYkNvcmUvc3R5bGUvSW5saW5lVGV4dEJveFN0eWxlLmgJKHdvcmtpbmcgY29weSkKQEAg LTQxLDExICs0MSwxMSBAQCBpbmxpbmUgZmxvYXQgdGV4dERlY29yYXRpb25TdHJva2VUaGlja25l CiAKIGlubGluZSBmbG9hdCB3YXZ5T2Zmc2V0RnJvbURlY29yYXRpb24oKQogewotICAgIHJldHVy biAyOworICAgIHJldHVybiAxOwogfQogCiBHbHlwaE92ZXJmbG93IHZpc3VhbE92ZXJmbG93Rm9y RGVjb3JhdGlvbnMoY29uc3QgUmVuZGVyU3R5bGUmIGxpbmVTdHlsZSwgY29uc3QgSW5saW5lVGV4 dEJveCopOwotdm9pZCBnZXRXYXZ5U3Ryb2tlUGFyYW1ldGVycyhmbG9hdCBzdHJva2VUaGlja25l c3MsIGZsb2F0JiBjb250cm9sUG9pbnREaXN0YW5jZSwgZmxvYXQmIHN0ZXApOwordm9pZCBnZXRX YXZ5U3Ryb2tlUGFyYW1ldGVycyhmbG9hdCBmb250U2l6ZSwgZmxvYXQmIGNvbnRyb2xQb2ludERp c3RhbmNlLCBmbG9hdCYgc3RlcCk7CiBpbnQgY29tcHV0ZVVuZGVybGluZU9mZnNldChUZXh0VW5k ZXJsaW5lUG9zaXRpb24sIGNvbnN0IEZvbnRNZXRyaWNzJiwgY29uc3QgSW5saW5lVGV4dEJveCos IGludCB0ZXh0RGVjb3JhdGlvblRoaWNrbmVzcyk7CiAgICAgCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCg==