171279 2017-04-25 10:27:48 -0700 [MediaStream macOS] Unable to apply frameRate constraint 2017-04-25 12:51:13 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=171151 InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1301093 0 eric.carlson 2017-04-25 10:27:48 -0700 AVCaptureDevice reports supported frame rates as an object with minimum and maximum values. These values are doubles, so we should cast to integers before comparing to avoid "failure" because of very small deltas. 1301097 1 308113 eric.carlson 2017-04-25 10:33:25 -0700 Created attachment 308113 Proposed patch. 1301098 2 webkit-bug-importer 2017-04-25 10:34:01 -0700 <rdar://problem/31814934> 1301100 3 youennf 2017-04-25 10:35:43 -0700 Let's file a bug about moving mock sources to presets so that layout tests would actually hit that issue. 1301124 4 308113 commit-queue 2017-04-25 11:22:12 -0700 Comment on attachment 308113 Proposed patch. Clearing flags on attachment: 308113 Committed r215746: <http://trac.webkit.org/changeset/215746> 1301125 5 commit-queue 2017-04-25 11:22:14 -0700 All reviewed patches have been landed. Closing bug. 308113 2017-04-25 10:33:25 -0700 2017-04-25 11:22:12 -0700 Proposed patch. frame_rate_range_patch_1.txt text/plain 1636 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTc0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA0LTI1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBt YWNPU10gVW5hYmxlIHRvIGFwcGx5IGZyYW1lUmF0ZSBjb25zdHJhaW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzEyNzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoaXMgZG9l c24ndCBhZmZlY3QgdGhlIG1vY2sgY2FwdHVyZSBkZXZpY2VzLgorCisgICAgICAgICogcGxhdGZv cm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tOgorICAgICAgICAoV2Vi Q29yZTo6QVZWaWRlb0NhcHR1cmVTb3VyY2U6OnN1cHBvcnRzU2l6ZUFuZEZyYW1lUmF0ZSk6IENh c3QgZnJhbWUgcmF0ZQorICAgICAgICByYW5nZXMgdG8gaW50IGJlZm9yZSBjb21wYXJpbmcuCisK IDIwMTctMDQtMjUgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVzb3VyY2UgTG9hZCBTdGF0aXN0aWNzOiBDbGVhciBuZXR3b3JrIHByb2Nlc3MgY2FjaGUg d2hlbiBjbGVhcmluZyBzdG9yZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNvdXJjZS5tbQko cmV2aXNpb24gMjE1NzMyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v bWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MjUsOSArNTI1 LDkgQEAgYm9vbCBBVlZpZGVvQ2FwdHVyZVNvdXJjZTo6c3VwcG9ydHNTaXplQQogICAgIGlmICgh ZnJhbWVSYXRlKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIGRvdWJsZSByYXRlID0gZnJh bWVSYXRlLnZhbHVlKCk7CisgICAgaW50IHJhdGUgPSBzdGF0aWNfY2FzdDxpbnQ+KGZyYW1lUmF0 ZS52YWx1ZSgpKTsKICAgICBmb3IgKEFWRnJhbWVSYXRlUmFuZ2VUeXBlICpyYW5nZSBpbiBbW2Rl dmljZSgpIGFjdGl2ZUZvcm1hdF0gdmlkZW9TdXBwb3J0ZWRGcmFtZVJhdGVSYW5nZXNdKSB7Ci0g ICAgICAgIGlmIChyYXRlID49IHJhbmdlLm1pbkZyYW1lUmF0ZSAmJiByYXRlIDw9IHJhbmdlLm1h eEZyYW1lUmF0ZSkKKyAgICAgICAgaWYgKHJhdGUgPj0gc3RhdGljX2Nhc3Q8aW50PihyYW5nZS5t aW5GcmFtZVJhdGUpICYmIHJhdGUgPD0gc3RhdGljX2Nhc3Q8aW50PihyYW5nZS5tYXhGcmFtZVJh dGUpKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCg==