171268 2017-04-25 03:36:15 -0700 Rename MockFileSystem.maybe_make_directory() 2017-04-25 08:57:30 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=168036 P2 Normal --- 1 clopez webkit-unassigned lforschler mcatanzaro oldest_to_newest 1300958 0 clopez 2017-04-25 03:36:15 -0700 The name maybe_make_directory is pretty confusing as it suggest the function may fail to create the directory. The function is this: def maybe_make_directory(self, *path): norm_path = self.normpath(self.join(*path)) while norm_path and not self.isdir(norm_path): self.dirs.add(norm_path) norm_path = self.dirname(norm_path) https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py?rev=215715#L279 So I understand it behaves exactly like "mkdir -p" 1301000 1 mcatanzaro 2017-04-25 07:29:05 -0700 Hm, this is not what I meant. I assumed it was obvious that maybe_make_directory() functions like "mkdir -p". So I think the current name is fine. But we should have a function that operates like plain "mkdir" so that you can use it in tests in cases where the directory should definitely not already exist, as in bug #168036. This is very unimportant. :) 1301044 2 clopez 2017-04-25 08:57:30 -0700 (In reply to Michael Catanzaro from comment #1) > Hm, this is not what I meant. I assumed it was obvious that > maybe_make_directory() functions like "mkdir -p". So I think the current > name is fine. > But we should have a function that operates like plain "mkdir" > so that you can use it in tests in cases where the directory should > definitely not already exist, as in bug #168036. > I don't think we need such function. If I want to ensure the directory doesn't exits I can test for that with MockFileSystem.isdir() I'll land a follow-up patch for that in bug 168036. > This is very unimportant. :) Ok. Let's close this then.