171259 2017-04-24 20:08:16 -0700 Web Inspector: TypeError:​ sourceCodeLocation.populateLiveDisplayLocationTooltip is not a function 2017-04-25 12:15:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 168709 1 fujii fujii bburg commit-queue hi inspector-bugzilla-changes joepeck oldest_to_newest 1300851 0 fujii 2017-04-24 20:08:16 -0700 I tested with GTK+ port, trunk@215680. Steps: 1) Start MiniBrowser 2) Open Inspector 3) Open Timelines tab 4) Browsing some web pages The following error happens: > TypeError:​ sourceCodeLocation.populateLiveDisplayLocationTooltip is not a function. (In 'sourceCodeLocation.populateLiveDisplayLocationTooltip(linkElement)​', 'sourceCodeLocation.populateLiveDisplayLocationTooltip' is undefined)​ (at Main.js:​2310:​58)​ > createSourceCodeLocationLink @ Main.js:​2310:​58 > createCellContent @ TimelineDataGridNode.js:​161:​79 > createCell @ DataGridNode.js:​353:​45 > createCells @ DataGridNode.js:​111:​54 > element @ DataGridNode.js:​104:​25 > _updateVisibleRows @ DataGrid.js:​1144:​66 > layout @ DataGrid.js:​876:​32 > _layoutSubtree @ View.js:​250:​20 > _layoutSubtree @ View.js:​254:​32 > _visitViewTreeForLayout @ View.js:​327:​36 1300858 1 308057 fujii 2017-04-24 20:13:13 -0700 Created attachment 308057 Patch 1301131 2 308057 joepeck 2017-04-25 11:46:03 -0700 Comment on attachment 308057 Patch Nice! r=me 1301148 3 308057 commit-queue 2017-04-25 12:15:03 -0700 Comment on attachment 308057 Patch Clearing flags on attachment: 308057 Committed r215749: <http://trac.webkit.org/changeset/215749> 1301149 4 commit-queue 2017-04-25 12:15:04 -0700 All reviewed patches have been landed. Closing bug. 308057 2017-04-24 20:13:13 -0700 2017-04-25 12:15:03 -0700 Patch bug-171259-20170425121312.patch text/plain 2068 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm OTBkZjI2NGRmMTQ0ODlhNTEzMTcxOTA0YjMzMDkwNTU4ZTRmZTkwLi4zOGFmMTE5YWZmY2I2MmRh ZmRhZThkYzI1OTk2NTFiM2E3OGFkNWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wNC0yNCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBUeXBlRXJyb3I64oCLIHNvdXJjZUNv ZGVMb2NhdGlvbi5wb3B1bGF0ZUxpdmVEaXNwbGF5TG9jYXRpb25Ub29sdGlwIGlzIG5vdCBhIGZ1 bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzEyNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgZmlyc3QgYXJndW1lbnQgb2YgV2ViSW5zcGVjdG9yLmNyZWF0ZVNvdXJjZUNvZGVMb2NhdGlv bkxpbmsKKyAgICAgICAgc2hvdWxkIGJlIFNvdXJjZUNvZGVMb2NhdGlvbiB0eXBlLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkTm9kZS5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFHcmlkTm9kZS5wcm90b3R5cGUuY3JlYXRlQ2Vs bENvbnRlbnQpOgorICAgICAgICBQYXNzICdjYWxsRnJhbWUuc291cmNlQ29kZUxvY2F0aW9uJyBp bnN0ZWFkIG9mICd2YWx1ZScgdG8gdGhlCisgICAgICAgIGZpcnN0IGFyZ3VtZW50LgorCiAyMDE3 LTA0LTIxICBEZXZpbiBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IEFkZCB0aXRsZXMgdG8gTmV0d29yayBncmlkIGl0ZW1zIGZvciBlYXNp ZXIgcmVhZGluZyB3aGVuIHRleHQgb3ZlcmZsb3dzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkTm9kZS5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWRO b2RlLmpzCmluZGV4IGJiYjZmZjFjZTVjZDc5M2Q1Y2YyYzFiMGJjNmQyODQyNmVkNWEwYTIuLmEz ZjZmNDYxZWY5MjI4MmNmM2VlODhkZGJjYjE3NGNhNDFmN2Y1NTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWROb2Rl LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lRGF0YUdyaWROb2RlLmpzCkBAIC0xNTgsNyArMTU4LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVs aW5lRGF0YUdyaWROb2RlID0gY2xhc3MgVGltZWxpbmVEYXRhR3JpZE5vZGUgZXh0ZW5kcyBXZWJJ bnNwZWMKICAgICAgICAgICAgICAgICAvLyBHaXZlIHRoZSB3aG9sZSBjZWxsIGEgdG9vbHRpcCBh bmQga2VlcCBpdCB1cCB0byBkYXRlLgogICAgICAgICAgICAgICAgIGNhbGxGcmFtZS5zb3VyY2VD b2RlTG9jYXRpb24ucG9wdWxhdGVMaXZlRGlzcGxheUxvY2F0aW9uVG9vbHRpcChjZWxsKTsKIAot ICAgICAgICAgICAgICAgIGZyYWdtZW50LmFwcGVuZENoaWxkKFdlYkluc3BlY3Rvci5jcmVhdGVT b3VyY2VDb2RlTG9jYXRpb25MaW5rKHZhbHVlLCBvcHRpb25zKSk7CisgICAgICAgICAgICAgICAg ZnJhZ21lbnQuYXBwZW5kQ2hpbGQoV2ViSW5zcGVjdG9yLmNyZWF0ZVNvdXJjZUNvZGVMb2NhdGlv bkxpbmsoY2FsbEZyYW1lLnNvdXJjZUNvZGVMb2NhdGlvbiwgb3B0aW9ucykpOwogCiAgICAgICAg ICAgICAgICAgaWYgKGlzQW5vbnltb3VzRnVuY3Rpb24pIHsKICAgICAgICAgICAgICAgICAgICAg Ly8gRm9yIGFub255bW91cyBmdW5jdGlvbnMgd2Ugc2hvdyB0aGUgcmVzb3VyY2Ugb3Igc2NyaXB0 IGljb24gYW5kIG5hbWUuCg==