<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171255</bug_id>
          
          <creation_ts>2017-04-24 18:00:17 -0700</creation_ts>
          <short_desc>[GTK] ImageDiff should be executed with the JHBuild wrapper.</short_desc>
          <delta_ts>2017-04-24 18:41:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>168036</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1300767</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-04-24 18:00:17 -0700</bug_when>
    <thetext>After r215179 &lt;http://trac.webkit.org/changeset/215179&gt; ImageDiff links with icu, and we ship our own version of ICU on the moduleset. 

This causes that on systems with an ICU older than the one we ship (Debian 8) the linker is unable to resolve the dependency unless we run ImageDiff with the jhbuild wrapper:


$ ldd WebKitBuild/Release/bin/ImageDiff |grep icu
	libicudata.so.55 =&gt; not found
	libicui18n.so.55 =&gt; not found
	libicuuc.so.55 =&gt; not found


$ Tools/jhbuild/jhbuild-wrapper --gtk run ldd WebKitBuild/Release/bin/ImageDiff |grep icu
	libicudata.so.55 =&gt; /home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib/libicudata.so.55 (0x00007f9d4afe7000)
	libicui18n.so.55 =&gt; /home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib/libicui18n.so.55 (0x00007f9d4ab6a000)
	libicuuc.so.55 =&gt; /home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib/libicuuc.so.55 (0x00007f9d4a7d1000)


This causes that ImageDiff doesn&apos;t work anymore for me.

I see that on the bots this is not happening, because the ImageDiff binary on the bots has the RPATH set to the JHBuild library dir, meanwhile I&apos;m getting an ImageDiff binary without RPATH set. No idea why, perhaps some difference on the toolchain or the environment

But in any case, we should fix the main problem: ImageDiff should be executed with the JHBuild wrapper if the wrapper was used for building it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300789</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-04-24 18:41:57 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 168036 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>