171254 2017-04-24 16:26:36 -0700 REGRESSION (r214863): Web Inspector: Uncaught Exception when losing focus from a selector field 2017-04-25 21:27:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1300703 0 nvasilyev 2017-04-24 16:26:36 -0700 Uncaught Exceptions: - TypeError: null is not an object (evaluating 'event.relatedTarget.isDescendant') (at CSSStyleDeclarationSection.js:694:32) _handleBlur @ CSSStyleDeclarationSection.js:694:32 _handleBlur @ [native code] * STEPS TO REPRODUCE 1. Open https://webkit.org; 2. Inspect <body>; 3. Focus on "body.home" selector (any selector would do); 4. Focus on an other app (Command-Tab on macOS). Actual: An uncaught exception is thrown. 1301079 1 webkit-bug-importer 2017-04-25 09:56:10 -0700 <rdar://problem/31813959> 1301322 2 nvasilyev 2017-04-25 16:46:51 -0700 This was introduced by https://trac.webkit.org/changeset/214863/webkit. 1301326 3 308167 nvasilyev 2017-04-25 16:53:05 -0700 Created attachment 308167 Patch > The FocusEvent.relatedTarget read-only property represents a secondary target for this event, which will depend on the event itself. > In some cases (like when tabbing in or out of a page), this property may be set to null for security reasons. https://developer.mozilla.org/en-US/docs/Web/API/FocusEvent/relatedTarget 1301411 4 308167 joepeck 2017-04-25 19:05:30 -0700 Comment on attachment 308167 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308167&action=review r=me > Source/WebInspectorUI/ChangeLog:9 > + event.relatedTarget of a blur event contains an element where focus moved to. When tabbing out "When tabbing out" is unclear. This makes me think you just pressed tab and suddenly its null, however the steps to reproduce were Command-Tab. I'd rephrase: The event.relatedTarget of a blur event contains the element where focus moved to. In some cases this can be null, such as if the user leaves the application window. For example Command+Tab to switch to another application. 1301448 5 308201 nvasilyev 2017-04-25 20:45:47 -0700 Created attachment 308201 Patch 1301469 6 308201 commit-queue 2017-04-25 21:27:41 -0700 Comment on attachment 308201 Patch Clearing flags on attachment: 308201 Committed r215789: <http://trac.webkit.org/changeset/215789> 1301470 7 commit-queue 2017-04-25 21:27:42 -0700 All reviewed patches have been landed. Closing bug. 308167 2017-04-25 16:53:05 -0700 2017-04-25 20:45:47 -0700 Patch patch.txt text/plain 1634 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2ODgzYTAuLjA0ZGUxNzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTI1ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMTQ4NjMp OiBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb24gd2hlbiBsb3NpbmcgZm9jdXMgZnJv bSBhIHNlbGVjdG9yIGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzEyNTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxODEzOTU5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGV2ZW50LnJlbGF0 ZWRUYXJnZXQgb2YgYSBibHVyIGV2ZW50IGNvbnRhaW5zIGFuIGVsZW1lbnQgd2hlcmUgZm9jdXMg bW92ZWQgdG8uIFdoZW4gdGFiYmluZyBvdXQKKyAgICAgICAgb2YgYSBwYWdlLCBldmVudC5yZWxh dGVkVGFyZ2V0IGlzIG51bGwuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0 eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxl RGVjbGFyYXRpb25TZWN0aW9uLnByb3RvdHlwZS5faGFuZGxlU2VsZWN0b3JQYXN0ZSk6CisKIDIw MTctMDQtMjQgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IERPTS9YSFIgYnJlYWtwb2ludCBzZWN0aW9ucyBzaG91bGQgYmUgY29sbGFw c2VkIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24u anMKaW5kZXggZmZhMTJlYS4uYzIyZmNjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNs YXJhdGlvblNlY3Rpb24uanMKQEAgLTY5Niw3ICs2OTYsNyBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5 bGVEZWNsYXJhdGlvblNlY3Rpb24gPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiBl eHRlbgogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKGV2ZW50 LnJlbGF0ZWRUYXJnZXQuaXNEZXNjZW5kYW50KHRoaXMuZWxlbWVudCkpIHsKKyAgICAgICAgaWYg KGV2ZW50LnJlbGF0ZWRUYXJnZXQgJiYgZXZlbnQucmVsYXRlZFRhcmdldC5pc0Rlc2NlbmRhbnQo dGhpcy5lbGVtZW50KSkgewogICAgICAgICAgICAgdGhpcy5fZWRpdG9yQWN0aXZlID0gdHJ1ZTsK ICAgICAgICAgICAgIHRoaXMuZm9jdXMoKTsKICAgICAgICAgfQo= 308201 2017-04-25 20:45:47 -0700 2017-04-25 21:27:41 -0700 Patch patch.txt text/plain 1733 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2ODgzYTAuLjVhMzlmNmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA0LTI1ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMTQ4NjMp OiBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb24gd2hlbiBsb3NpbmcgZm9jdXMgZnJv bSBhIHNlbGVjdG9yIGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzEyNTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxODEzOTU5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAgICAgICBUaGUgZXZlbnQu cmVsYXRlZFRhcmdldCBvZiBhIGJsdXIgZXZlbnQgY29udGFpbnMgdGhlIGVsZW1lbnQgd2hlcmUg Zm9jdXMgbW92ZWQgdG8uCisgICAgICAgIEluIHNvbWUgY2FzZXMgdGhpcyBjYW4gYmUgbnVsbCwg c3VjaCBhcyBpZiB0aGUgdXNlciBsZWF2ZXMgdGhlIGFwcGxpY2F0aW9uIHdpbmRvdy4KKyAgICAg ICAgRm9yIGV4YW1wbGUgQ29tbWFuZCtUYWIgdG8gc3dpdGNoIHRvIGFub3RoZXIgYXBwbGljYXRp b24uCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25T ZWN0aW9uLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25TZWN0 aW9uLnByb3RvdHlwZS5faGFuZGxlU2VsZWN0b3JQYXN0ZSk6CisKIDIwMTctMDQtMjQgIE1hdHQg QmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERP TS9YSFIgYnJlYWtwb2ludCBzZWN0aW9ucyBzaG91bGQgYmUgY29sbGFwc2VkIGJ5IGRlZmF1bHQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NT U1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMKaW5kZXggZmZhMTJl YS4uYzIyZmNjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24u anMKQEAgLTY5Niw3ICs2OTYsNyBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblNl Y3Rpb24gPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiBleHRlbgogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKGV2ZW50LnJlbGF0ZWRUYXJnZXQu aXNEZXNjZW5kYW50KHRoaXMuZWxlbWVudCkpIHsKKyAgICAgICAgaWYgKGV2ZW50LnJlbGF0ZWRU YXJnZXQgJiYgZXZlbnQucmVsYXRlZFRhcmdldC5pc0Rlc2NlbmRhbnQodGhpcy5lbGVtZW50KSkg ewogICAgICAgICAgICAgdGhpcy5fZWRpdG9yQWN0aXZlID0gdHJ1ZTsKICAgICAgICAgICAgIHRo aXMuZm9jdXMoKTsKICAgICAgICAgfQo=