171249 2017-04-24 14:00:13 -0700 Allow tabs with capturing audio or video to exceed background CPU limit 2017-04-24 16:56:57 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez barraclough eric.carlson ggaren jonlee webkit-bug-importer youennf oldest_to_newest 1300652 0 cdumez 2017-04-24 14:00:13 -0700 Allow tabs with capturing audio or video to exceed background CPU limit as this is a legit case of potentially high background CPU use. 1300659 1 cdumez 2017-04-24 14:13:09 -0700 <rdar://problem/31796314> 1300660 2 308010 cdumez 2017-04-24 14:14:40 -0700 Created attachment 308010 Patch 1300666 3 308010 ggaren 2017-04-24 14:34:45 -0700 Comment on attachment 308010 Patch Did you mean to put this up for review? If so, r=me 1300686 4 cdumez 2017-04-24 15:43:27 -0700 Committed r215699: <http://trac.webkit.org/changeset/215699> 1300726 5 308010 youennf 2017-04-24 16:56:57 -0700 Comment on attachment 308010 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308010&action=review > Source/WebKit2/UIProcess/WebProcessProxy.cpp:1177 > + if (page->hasActiveAudioStream() || page->hasActiveVideoStream()) { LGTM. Seeing again the names in this context, something like isCapturingAudio/isCapturingVideo might be clearer than hasActiveVideoStream/hasActiveVideoStream. 308010 2017-04-24 14:14:40 -0700 2017-04-24 14:14:40 -0700 Patch bug-171249-20170424141439.patch text/plain 2030 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTczZDJlODlmOGYzMjZl MGE1MzFiYWVkZjQwMjIyZGM1ZDNmYjhkNS4uODBiM2Y1MTUxNWJmNTBjOTllMmZhM2RkZWE1Njgw MTMyYTIwM2YwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWxsb3cgdGFicyB3aXRoIGNh cHR1cmluZyBhdWRpbyBvciB2aWRlbyB0byBleGNlZWQgYmFja2dyb3VuZCBDUFUgbGltaXQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTI0OQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzE3OTYzMTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgdGFicyB3aXRoIGNhcHR1cmluZyBhdWRpbyBv ciB2aWRlbyB0byBleGNlZWQgYmFja2dyb3VuZCBDUFUgbGltaXQgYXMgdGhpcworICAgICAgICBp cyBhIGxlZ2l0IGNhc2Ugb2YgcG90ZW50aWFsbHkgaGlnaCBiYWNrZ3JvdW5kIENQVSB1c2UuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUHJvY2Vzc1Byb3h5OjpkaWRFeGNlZWRCYWNrZ3JvdW5kQ1BVTGltaXQpOgorCiAyMDE3 LTA0LTI0ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8g Zml4IHRoZSAzMi1iaXQgbWFjT1MgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQcm9jZXNzUHJveHkuY3BwCmluZGV4IDI2NmJkNDQ3NTkxZmNiYTI3YzRhZTk1NjM5MzY2MWZm NDMyOTc5ZjAuLjY4ZWE3YWY0Yzk5ZGM4M2RjZDVkZTk5NjEyZDY5ZjU0OTg1ZTgyNDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCkBAIC0xMTczLDYg KzExNzMsMTEgQEAgdm9pZCBXZWJQcm9jZXNzUHJveHk6OmRpZEV4Y2VlZEJhY2tncm91bmRDUFVM aW1pdCgpCiAgICAgICAgICAgICBSRUxFQVNFX0xPRyhQZXJmb3JtYW5jZUxvZ2dpbmcsICIlcCAt IFdlYlByb2Nlc3NQcm94eTo6ZGlkRXhjZWVkQmFja2dyb3VuZENQVUxpbWl0KCkgV2ViUHJvY2Vz cyBoYXMgZXhjZWVkZWQgdGhlIGJhY2tncm91bmQgQ1BVIGxpbWl0IGJ1dCB3ZSBhcmUgbm90IHRl cm1pbmF0aW5nIGl0IGJlY2F1c2UgdGhlcmUgaXMgYXVkaW8gcGxheWluZyIsIHRoaXMpOwogICAg ICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CisKKyAgICAgICAgaWYgKHBhZ2UtPmhhc0FjdGl2 ZUF1ZGlvU3RyZWFtKCkgfHwgcGFnZS0+aGFzQWN0aXZlVmlkZW9TdHJlYW0oKSkgeworICAgICAg ICAgICAgUkVMRUFTRV9MT0coUGVyZm9ybWFuY2VMb2dnaW5nLCAiJXAgLSBXZWJQcm9jZXNzUHJv eHk6OmRpZEV4Y2VlZEJhY2tncm91bmRDUFVMaW1pdCgpIFdlYlByb2Nlc3MgaGFzIGV4Y2VlZGVk IHRoZSBiYWNrZ3JvdW5kIENQVSBsaW1pdCBidXQgd2UgYXJlIG5vdCB0ZXJtaW5hdGluZyBpdCBi ZWNhdXNlIGl0IGlzIGNhcHR1cmluZyBhdWRpbyAvIHZpZGVvIiwgdGhpcyk7CisgICAgICAgICAg ICByZXR1cm47CisgICAgICAgIH0KICAgICB9CiAKICAgICBSRUxFQVNFX0xPRyhQZXJmb3JtYW5j ZUxvZ2dpbmcsICIlcCAtIFdlYlByb2Nlc3NQcm94eTo6ZGlkRXhjZWVkQmFja2dyb3VuZENQVUxp bWl0KCkgVGVybWluYXRpbmcgYmFja2dyb3VuZCBXZWJQcm9jZXNzIHRoYXQgaGFzIGV4Y2VlZGVk IHRoZSBiYWNrZ3JvdW5kIENQVSBsaW1pdCIsIHRoaXMpOwo=