17122 2008-01-31 12:51:45 -0800 [GTK] Bad font default settings 2008-11-29 04:15:13 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED http://www.perdu.com Gtk P2 Normal --- 1 pierre-luc.beaudoin christian alp christian sven oldest_to_newest 68957 0 pierre-luc.beaudoin 2008-01-31 12:51:45 -0800 Displaying the same pages in WebKit/Gtk+ and Firefox 2.0 doesn't result in the same font size. The current default size for WebKit is 10, where Firefox has 16. Setting PROP_DEFAULT_FONT_SIZE to 12 seems to make the fonts look the same size. In WebKit, Monospaced and regular fonts have the same size while they differ in Firefox. The included link has a good simple example of monospace usage. 69118 1 alp 2008-02-01 15:16:40 -0800 Agreed. Our best hope is to do exactly what fx does when it comes to font matching and sizes since users will be used to their existing settings. Although the per-screen DPI-based font size adjustment we have in WebSettings is cool, we may have to disable it by default to match fx. Like you say, the default sizes need looking at. Fonts like "sans" and "monospace" are generally a good choice since FontConfig is meant to do the right thing with them. WebKit/Mac has special cases for certain fonts. If fx special-cases specific fonts, we should borrow their code and/or matching rules. Time to look at http://mxr.mozilla.org herzi, and thoughts on this? Is your patch likely to be ready soon? 99738 2 25368 christian 2008-11-21 18:08:28 -0800 Created attachment 25368 Use default font size 12 instead of 10 This is a tiny modification, defining the default font size as 12 instead of 10, so that in the usual case the font comes very close to the default on other platforms. I ponder hacking up a new setting "force-96-dpi", which would still be disabled by default but instead web browsers and clients displaying web pages would enab le it and also provide an according preference. The reasoning being that this historical quirk is only useful for compatibility and hardly helping usability if the user actually has a considerably high resolved screen. I'd like some kind of feedback from a reviewer beforehand, though. The lack of interest in API additions isn't exactly motivating lately. 99804 3 25368 zecke 2008-11-22 19:08:45 -0800 Comment on attachment 25368 Use default font size 12 instead of 10 > - 5, G_MAXINT, 10, > + 5, G_MAXINT, 12, > flags)); Okay, after the previous discussion it seems that we want that. A 96dpi config option will be much appreciated, we will need it for the regression testing. 100032 4 christian 2008-11-24 13:15:25 -0800 2008-11-24 Christian Dywan <christian@twotoasts.de> Reviewed by Holger Freyther. http://bugs.webkit.org/show_bug.cgi?id=17122 [GTK] Bad font default settings * webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Use default font size 12 instead of 10 100034 5 25444 christian 2008-11-24 13:18:18 -0800 Created attachment 25444 Implement "enforce-96-dpi" setting Here comes "enforce-96-dpi", which overrides the DPI detection. 100279 6 25444 zecke 2008-11-25 13:59:53 -0800 Comment on attachment 25444 Implement "enforce-96-dpi" setting The usage of NULL is a bit sad but we already have that at many places. 100698 7 christian 2008-11-29 04:15:13 -0800 2008-11-29 Christian Dywan <christian@twotoasts.de> Reviewed by Holger Freyther. http://bugs.webkit.org/show_bug.cgi?id=17122 [GTK] Bad font default settings Implement a property "enforce-96-dpi" in WebKitWebSettings that can be enabled to force the view to assume 96 DPI. * webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): * webkit/webkitwebview.cpp: 25368 2008-11-21 18:08:28 -0800 2008-11-24 13:16:31 -0800 Use default font size 12 instead of 10 deffontsize.diff text/plain 719 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcCBiL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAppbmRleCA0OWFiNGM2Li5mZDhj Yjc4IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAK KysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCkBAIC0xNjIsNyAr MTYyLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19jbGFzc19pbml0KFdlYktp dFdlYlNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgImRlZmF1bHQtZm9udC1zaXplIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJEZWZhdWx0IEZvbnQgU2l6ZSIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiVGhlIGRlZmF1bHQgZm9udCBzaXplIHVzZWQgdG8gZGlzcGxheSB0ZXh0LiIsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA1LCBHX01BWElOVCwgMTAsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA1LCBHX01BWElOVCwgMTIsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFncykpOwogCiAgICAgZ19vYmplY3RfY2xh c3NfaW5zdGFsbF9wcm9wZXJ0eShnb2JqZWN0X2NsYXNzLAo= 25444 2008-11-24 13:18:18 -0800 2008-11-25 13:59:53 -0800 Implement "enforce-96-dpi" setting enforce-96-dpi.diff text/plain 4333 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcCBiL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAppbmRleCA0MzkxMDMxLi5kMGNh YmRhIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAK KysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCkBAIC00NSw2ICs0 NSw3IEBAIHN0cnVjdCBfV2ViS2l0V2ViU2V0dGluZ3NQcml2YXRlIHsKICAgICBndWludCBkZWZh dWx0X21vbm9zcGFjZV9mb250X3NpemU7CiAgICAgZ3VpbnQgbWluaW11bV9mb250X3NpemU7CiAg ICAgZ3VpbnQgbWluaW11bV9sb2dpY2FsX2ZvbnRfc2l6ZTsKKyAgICBnYm9vbGVhbiBlbmZvcmNl Xzk2X2RwaTsKICAgICBnYm9vbGVhbiBhdXRvX2xvYWRfaW1hZ2VzOwogICAgIGdib29sZWFuIGF1 dG9fc2hyaW5rX2ltYWdlczsKICAgICBnYm9vbGVhbiBwcmludF9iYWNrZ3JvdW5kczsKQEAgLTcy LDYgKzczLDcgQEAgZW51bSB7CiAgICAgUFJPUF9ERUZBVUxUX01PTk9TUEFDRV9GT05UX1NJWkUs CiAgICAgUFJPUF9NSU5JTVVNX0ZPTlRfU0laRSwKICAgICBQUk9QX01JTklNVU1fTE9HSUNBTF9G T05UX1NJWkUsCisgICAgUFJPUF9FTkZPUkNFXzk2X0RQSSwKICAgICBQUk9QX0FVVE9fTE9BRF9J TUFHRVMsCiAgICAgUFJPUF9BVVRPX1NIUklOS19JTUFHRVMsCiAgICAgUFJPUF9QUklOVF9CQUNL R1JPVU5EUywKQEAgLTE5Nyw2ICsxOTksMjYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0 aW5nc19jbGFzc19pbml0KFdlYktpdFdlYlNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgMSwgR19NQVhJTlQsIDUsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmbGFncykpOwogCisgICAgLyoqCisgICAgKiBXZWJLaXRX ZWJTZXR0aW5nczplbmZvcmNlLTk2LWRwaToKKyAgICAqCisgICAgKiBFbmZvcmNlIGEgcmVzb2x1 dGlvbiBvZiA5NiBEUEkuIFRoaXMgaXMgbWVhbnQgZm9yIGNvbXBhdGliaWxpdHkKKyAgICAqIHdp dGggd2ViIHBhZ2VzIHdoaWNoIGNvcGUgYmFkbHkgd2l0aCBkaWZmZXJlbnQgc2NyZWVuIHJlc29s dXRpb25zCisgICAgKiBhbmQgZm9yIGF1dG9tYXRlZCB0ZXN0aW5nLgorICAgICogV2ViIGJyb3dz ZXJzIGFuZCBhcHBsaWNhdGlvbnMgdGhhdCB0eXBpY2FsbHkgZGlzcGxheSBhcmJpdHJhcnkKKyAg ICAqIGNvbnRlbnQgZnJvbSB0aGUgd2ViIHNob3VsZCBwcm92aWRlIGEgcHJlZmVyZW5jZSBmb3Ig dGhpcy4KKyAgICAqCisgICAgKiBTaW5jZTogMS4wLjMKKyAgICAqLworICAgIGdfb2JqZWN0X2Ns YXNzX2luc3RhbGxfcHJvcGVydHkoZ29iamVjdF9jbGFzcywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFBST1BfRU5GT1JDRV85Nl9EUEksCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJlbmZvcmNlLTk2LWRwaSIsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiRW5mb3JjZSA5NiBEUEkiLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIkVuZm9yY2UgYSByZXNvbHV0aW9uIG9mIDk2IERQSSIsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBGQUxTRSwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGZsYWdzKSk7CisKICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3By b3BlcnR5KGdvYmplY3RfY2xhc3MsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBQUk9QX0FVVE9fTE9BRF9JTUFHRVMsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigKQEAgLTM2NSw2ICszODcsOSBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfd2ViX3NldHRpbmdzX3NldF9wcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50 IHByb3BfaWQsIGNvbgogICAgIGNhc2UgUFJPUF9NSU5JTVVNX0xPR0lDQUxfRk9OVF9TSVpFOgog ICAgICAgICBwcml2LT5taW5pbXVtX2xvZ2ljYWxfZm9udF9zaXplID0gZ192YWx1ZV9nZXRfaW50 KHZhbHVlKTsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9QX0VORk9SQ0VfOTZfRFBJOgor ICAgICAgICBwcml2LT5lbmZvcmNlXzk2X2RwaSA9IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUp OworICAgICAgICBicmVhazsKICAgICBjYXNlIFBST1BfQVVUT19MT0FEX0lNQUdFUzoKICAgICAg ICAgcHJpdi0+YXV0b19sb2FkX2ltYWdlcyA9IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOwog ICAgICAgICBicmVhazsKQEAgLTQzOCw2ICs0NjMsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X3NldHRpbmdzX2dldF9wcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BfaWQsIEdW YQogICAgIGNhc2UgUFJPUF9NSU5JTVVNX0xPR0lDQUxfRk9OVF9TSVpFOgogICAgICAgICBnX3Zh bHVlX3NldF9pbnQodmFsdWUsIHByaXYtPm1pbmltdW1fbG9naWNhbF9mb250X3NpemUpOwogICAg ICAgICBicmVhazsKKyAgICBjYXNlIFBST1BfRU5GT1JDRV85Nl9EUEk6CisgICAgICAgIGdfdmFs dWVfc2V0X2Jvb2xlYW4odmFsdWUsIHByaXYtPmVuZm9yY2VfOTZfZHBpKTsKKyAgICAgICAgYnJl YWs7CiAgICAgY2FzZSBQUk9QX0FVVE9fTE9BRF9JTUFHRVM6CiAgICAgICAgIGdfdmFsdWVfc2V0 X2Jvb2xlYW4odmFsdWUsIHByaXYtPmF1dG9fbG9hZF9pbWFnZXMpOwogICAgICAgICBicmVhazsK ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggZWU0ZDg0MS4uMDNlZmVmMiAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTEzMzUsNiArMTMzNSwxMyBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdl YlZpZXdDbGFzcykKIAogc3RhdGljIGdkb3VibGUgd2ViVmlld0dldERQSShXZWJLaXRXZWJWaWV3 KiB3ZWJWaWV3KQogeworICAgIFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2ID0gd2ViVmlldy0+ cHJpdjsKKyAgICBXZWJLaXRXZWJTZXR0aW5ncyogd2ViU2V0dGluZ3MgPSBwcml2LT53ZWJTZXR0 aW5nczsKKyAgICBnYm9vbGVhbiBlbmZvcmNlOTZEUEk7CisgICAgZ19vYmplY3RfZ2V0KHdlYlNl dHRpbmdzLCAiZW5mb3JjZS05Ni1kcGkiLCAmZW5mb3JjZTk2RFBJLCBOVUxMKTsKKyAgICBpZiAo ZW5mb3JjZTk2RFBJKQorICAgICAgICByZXR1cm4gOTYuMDsKKwogICAgIGdkb3VibGUgRFBJID0g ZGVmYXVsdERQSTsKICNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigyLDEwLDApCiAgICAgR2RrU2NyZWVu KiBzY3JlZW4gPSBndGtfd2lkZ2V0X2hhc19zY3JlZW4oR1RLX1dJREdFVCh3ZWJWaWV3KSkgPyBn dGtfd2lkZ2V0X2dldF9zY3JlZW4oR1RLX1dJREdFVCh3ZWJWaWV3KSkgOiBnZGtfc2NyZWVuX2dl dF9kZWZhdWx0KCk7CkBAIC0xNDYzLDYgKzE0NzAsOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X3ZpZXdfc2V0dGluZ3Nfbm90aWZ5KFdlYktpdFdlYlNldHRpbmdzKiB3ZWJTZXR0aW5ncywgR1Bh cgogICAgICAgICBzZXR0aW5ncy0+c2V0TWluaW11bUZvbnRTaXplKHBpeGVsc0Zyb21TaXplKHdl YlZpZXcsIGdfdmFsdWVfZ2V0X2ludCgmdmFsdWUpKSk7CiAgICAgZWxzZSBpZiAobmFtZSA9PSBn X2ludGVybl9zdHJpbmcoIm1pbmltdW0tbG9naWNhbC1mb250LXNpemUiKSkKICAgICAgICAgc2V0 dGluZ3MtPnNldE1pbmltdW1Mb2dpY2FsRm9udFNpemUocGl4ZWxzRnJvbVNpemUod2ViVmlldywg Z192YWx1ZV9nZXRfaW50KCZ2YWx1ZSkpKTsKKyAgICBlbHNlIGlmIChuYW1lID09IGdfaW50ZXJu X3N0cmluZygiZW5mb3JjZS05Ni1kcGkiKSkKKyAgICAgICAgd2Via2l0X3dlYl92aWV3X3NjcmVl bl9jaGFuZ2VkKHdlYlZpZXcsIE5VTEwsIE5VTEwpOwogICAgIGVsc2UgaWYgKG5hbWUgPT0gZ19p bnRlcm5fc3RyaW5nKCJhdXRvLWxvYWQtaW1hZ2VzIikpCiAgICAgICAgIHNldHRpbmdzLT5zZXRM b2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkoZ192YWx1ZV9nZXRfYm9vbGVhbigmdmFsdWUpKTsKICAg ICBlbHNlIGlmIChuYW1lID09IGdfaW50ZXJuX3N0cmluZygiYXV0by1zaHJpbmstaW1hZ2VzIikp Cg==