171187 2017-04-22 21:01:39 -0700 [ATK] ARIA alertdialogs should be exposed with ROLE_DIALOG 2017-04-27 10:04:28 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All Linux RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro buildbot cfleizach commit-queue dmazzoni jcraig samuel_white webkit-bug-importer oldest_to_newest 1300277 0 jdiggs 2017-04-22 21:01:39 -0700 https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-alertdialog 1300278 1 webkit-bug-importer 2017-04-22 21:02:42 -0700 <rdar://problem/31776294> 1301802 2 308296 jdiggs 2017-04-26 15:54:48 -0700 Created attachment 308296 Patch 1302122 3 jdiggs 2017-04-27 09:27:54 -0700 Chris: This should be a very quick review. Please and thank you. 1302148 4 308296 commit-queue 2017-04-27 10:04:27 -0700 Comment on attachment 308296 Patch Clearing flags on attachment: 308296 Committed r215877: <http://trac.webkit.org/changeset/215877> 1302149 5 commit-queue 2017-04-27 10:04:28 -0700 All reviewed patches have been landed. Closing bug. 308296 2017-04-26 15:54:48 -0700 2017-04-27 10:04:27 -0700 Patch bug-171187-20170426185447.patch text/plain 4745 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE1OGFiZmJkY2Y3NDc0 ZTAwOGQ2ODViNmU3NjI0NGIxNGEzN2M3MC4uNDg0ZDAwMzQxOWQ5YzVkYjc5NTQ4NWEzMmM3NDgw NDVhYjBkMWI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE3LTA0LTI2ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBbQVRLXSBBUklBIGFs ZXJ0ZGlhbG9ncyBzaG91bGQgYmUgZXhwb3NlZCB3aXRoIFJPTEVfRElBTE9HCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzExODcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXAgQXBwbGljYXRpb25BbGVy dERpYWxvZ1JvbGUgdG8gQVRLX1JPTEVfRElBTE9HLiBXaGlsZSBBVEtfUk9MRV9BTEVSVCBpcwor ICAgICAgICBhcHByb3ByaWF0ZSBhcyBmYXIgYXMgQVRLIGlzIGNvbmNlcm5lZCwgdGhlIENvcmUg QWNjZXNzaWJpbGl0eSBBUEkgTWFwcGluZ3MKKyAgICAgICAgbWFwIEFSSUEncyBhbGVydGRpYWxv ZyByb2xlIHRvIEFUS19ST0xFX0RJQUxPRy4gV2Ugc2hvdWxkIGJlIGNvbnNpc3RlbnQKKyAgICAg ICAgd2l0aCB0aGUgc3BlYy4gVGhlIGZhY3QgdGhhdCB0aGlzIGlzIGFuIGFsZXJ0IGRpYWxvZyBj YW4gc3RpbGwgYmUgb2J0YWluZWQKKyAgICAgICAgdmlhIHRoZSBBdGtPYmplY3QgYXR0cmlidXRl cy4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLiBVcGRhdGUgdGhlIGV4cGVjdGF0aW9u cyBmb3Igcm9sZXMtZXhwb3NlZC5odG1sLAorICAgICAgICB4bWwtcm9sZXMtZXhwb3NlZC5odG1s LCBhbmQgYXJpYS1tYXBwaW5ncy5odG1sIHRvIHJlZmxlY3QgdGhlIGNoYW5nZS4KKworICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcDoKKyAg ICAgICAgKGF0a1JvbGUpOgorCisyMDE3LTA0LTI2ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NA aWdhbGlhLmNvbT4KKwogICAgICAgICBbQVRLXSBJbXBsZW1lbnQgc3VwcG9ydCBmb3IgbmV3IEFS SUEgMS4xIHZhbHVlcyBvZiBhcmlhLWhhc3BvcHVwCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzExNjQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsu Y3BwCmluZGV4IDZkZjI1ODdhODA1NzhmNjBhZDgxZTc2YTlmYWIzNmQ4M2M4YzEwMDkuLjQ2NjRi ZjA4YTkxNGY0MjEyZjExMDMyY2ZkN2JkYzVhZDFmOTM2ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3Jh cHBlckF0ay5jcHAKQEAgLTQ1NCw5ICs0NTQsOSBAQCBzdGF0aWMgQXRrUm9sZSBhdGtSb2xlKEFj Y2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QpCiB7CiAgICAgQWNjZXNzaWJpbGl0eVJvbGUg cm9sZSA9IGNvcmVPYmplY3QtPnJvbGVWYWx1ZSgpOwogICAgIHN3aXRjaCAocm9sZSkgewotICAg IGNhc2UgQXBwbGljYXRpb25BbGVydERpYWxvZ1JvbGU6CiAgICAgY2FzZSBBcHBsaWNhdGlvbkFs ZXJ0Um9sZToKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX0FMRVJUOworICAgIGNhc2UgQXBwbGlj YXRpb25BbGVydERpYWxvZ1JvbGU6CiAgICAgY2FzZSBBcHBsaWNhdGlvbkRpYWxvZ1JvbGU6CiAg ICAgICAgIHJldHVybiBBVEtfUk9MRV9ESUFMT0c7CiAgICAgY2FzZSBBcHBsaWNhdGlvblN0YXR1 c1JvbGU6CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggNGFmNTBhYzkzMzhiZGEyMzhlZDlhOWMyYWNmNGE1MGE0OWE3OTNkNy4u ZjhmOWIwOTQyZmY2YzFhNmU4ZThjMGE4NmZiNjA1NWM4ZmE4YWNiZiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE3LTA0LTI2ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4K KworICAgICAgICBbQVRLXSBBUklBIGFsZXJ0ZGlhbG9ncyBzaG91bGQgYmUgZXhwb3NlZCB3aXRo IFJPTEVfRElBTE9HCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzExODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGFjY2Vzc2liaWxpdHkvYXJpYS1tYXBwaW5ncy1leHBlY3RlZC50eHQ6IFVwZGF0ZWQu CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9ndGsveG1sLXJvbGVzLWV4cG9zZWQtZXhwZWN0ZWQu dHh0OiBVcGRhdGVkLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JvbGVz LWV4cG9zZWQtZXhwZWN0ZWQudHh0OiBVcGRhdGVkLgorCiAyMDE3LTA0LTI2ICBNYXR0IExld2lz ICA8amxld2lzM0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFyayBzd2lwZS9tYWluLWZyYW1lLXBp bm5pbmctcmVxdWlyZW1lbnQuaHRtbCBhcyBhIGZsYWt5IGZhaWx1cmUgb24gbWFjLXdrMi4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tYXBwaW5ncy1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtbWFwcGluZ3MtZXhwZWN0ZWQu dHh0CmluZGV4IDYxYTFlYmRiMDc5M2Y1YTNmNDIzZmU5MGE5YzRkMDEwODA3ZmJlMWYuLmJkYjNk OWY2OTNmZmU3NGE5NzQyNzhkZDE1Y2E2ZjM1NjIxMDAxMjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tYXBwaW5ncy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0 VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLW1hcHBpbmdzLWV4cGVjdGVkLnR4dApAQCAtMjEsNyAr MjEsNyBAQCBSb2xlIGZvciAnYWxlcnQnIGRpdiBpczogQVhSb2xlOiBBWEFsZXJ0CiAKIAogcm9s ZT0iYWxlcnRkaWFsb2ciIGlzIGEgZGlhbG9nIHdoaWNoIGNvbnRhaW5zIGFuIGFsZXJ0IG1lc3Nh Z2UuCi1Sb2xlIGZvciAnYWxlcnRkaWFsb2cnIGRpdiBpczogQVhSb2xlOiBBWEFsZXJ0CitSb2xl IGZvciAnYWxlcnRkaWFsb2cnIGRpdiBpczogQVhSb2xlOiBBWERpYWxvZwogCiAKIHJvbGU9ImFy dGljbGUiIGlzIGEgIHNlY3Rpb24gb2YgYSBwYWdlIHRoYXQgY29uc2lzdHMgb2YgYSBjb21wb3Np dGlvbiB0aGF0IGZvcm1zIGFuIGluZGVwZW5kZW50IHBhcnQgb2YgYSBkb2N1bWVudCwgcGFnZSwg b3Igc2l0ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsveG1sLXJv bGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsv eG1sLXJvbGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0CmluZGV4IDI0OTIyYTNjOWZhYWEyMGRhZTcw YjlhOWE4NGNlNjllOWY4NDgwZmUuLjgyNGFlZjBmZGU3ZGJiYzcxM2Y1MGJmNmRjOTgxNWExMjkz MDJlYWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZ3RrL3htbC1yb2xl cy1leHBvc2VkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2d0 ay94bWwtcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQKQEAgLTIzLDcgKzIzLDcgQEAgQVhSZXF1 aXJlZDogMAogQVhDaGVja2VkOiAwCiBBWFBsYXRmb3JtQXR0cmlidXRlczogY29tcHV0ZWQtcm9s ZTphbGVydCwgeG1sLXJvbGVzOmFsZXJ0LCB0YWc6ZGl2LCB0b29sa2l0OldlYktpdEd0awogLS0t LS0tLS0tLS0tCi1BWFJvbGU6IEFYQWxlcnQKK0FYUm9sZTogQVhEaWFsb2cKIEFYUGFyZW50OiBB WFdlYkFyZWEKIEFYQ2hpbGRyZW46IDAKIEFYUG9zaXRpb246IHsgMC4wMDAwMDAsIDAuMDAwMDAw IH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3Jv bGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vz c2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQKaW5kZXggODVkNjNjY2I0Njk2ZjIw YmFlZTNlZWM5Y2FkY2NkZjU3MWMxNDdmMS4uNmE1MjNiODQ0Y2I1N2E4Y2MyMGEzN2QwOGE4ZmRi Yzk3OTc0Y2QyMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2li aWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQKQEAgLTQ4OCw3 ICs0ODgsNyBAQCBkaXZbcm9sZT1hbGVydF0KICAgICAgIEFYUm9sZTogQVhBbGVydAogICAgICAg CiBkaXZbcm9sZT1hbGVydGRpYWxvZ10KLSAgICAgIEFYUm9sZTogQVhBbGVydAorICAgICAgQVhS b2xlOiBBWERpYWxvZwogICAgICAgCiBkaXZbcm9sZT1hcHBsaWNhdGlvbl0KICAgICAgIEFYUm9s ZTogQVhFbWJlZGRlZAo=