171182 2017-04-22 19:02:21 -0700 [ATK] ARIA buttons which have a popup should be ATK_ROLE_PUSH_BUTTON; not ATK_ROLE_COMBO_BOX 2017-04-26 18:17:07 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All Linux RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro buildbot cfleizach commit-queue dmazzoni jcraig samuel_white webkit-bug-importer oldest_to_newest 1300257 0 jdiggs 2017-04-22 19:02:21 -0700 This is not a combobox: <div role="button" aria-haspopup="true">OK</div>. Oops. 1300258 1 webkit-bug-importer 2017-04-22 19:03:17 -0700 <rdar://problem/31776006> 1301860 2 308312 jdiggs 2017-04-26 17:26:27 -0700 Created attachment 308312 Patch 1301879 3 308312 commit-queue 2017-04-26 18:17:06 -0700 Comment on attachment 308312 Patch Clearing flags on attachment: 308312 Committed r215850: <http://trac.webkit.org/changeset/215850> 1301880 4 commit-queue 2017-04-26 18:17:07 -0700 All reviewed patches have been landed. Closing bug. 308312 2017-04-26 17:26:27 -0700 2017-04-26 18:17:06 -0700 Patch bug-171182-20170426202626.patch text/plain 5371 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE1OGFiZmJkY2Y3NDc0 ZTAwOGQ2ODViNmU3NjI0NGIxNGEzN2M3MC4uMTJjZTg0MTI5ZTBhY2FiNmMxNDIzOTkwZDk4NWMx MzYzZDA3NGViZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE3LTA0LTI2ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAorICAgICAgICBbQVRLXSBBUklBIGJ1 dHRvbnMgd2hpY2ggaGF2ZSBhIHBvcHVwIHNob3VsZCBiZSBBVEtfUk9MRV9QVVNIX0JVVFRPTjsg bm90IEFUS19ST0xFX0NPTUJPX0JPWAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTcxMTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJpbGl0eS9ndGsvYnV0dG9uLXdpdGgtYXJpYS1o YXNwb3B1cC1pcy1ub3QtYS1jb21ib2JveC5odG1sCisKKyAgICAgICAgV2ViQ29yZSBBY2Nlc3Np YmlsaXR5IGFzc2lnbnMgUG9wVXBCdXR0b25Sb2xlIHRvIGNvbGxhcHNlZCBzZWxlY3QgZWxlbWVu dHMsCisgICAgICAgIHdoaWNoIHRoZSBBVEsgY29kZSBjb3JyZWN0bHkgbWFwcyB0byBBVEtfUk9M RV9DT01CT19CT1guIEl0IHR1cm5zIG91dCB0aGF0CisgICAgICAgIFdlYkNvcmUgQWNjZXNzaWJp bGl0eSBhbHNvIG1hcHMgdGhlIEFSSUEgYnV0dG9uIHJvbGUgdG8gUG9wVXBCdXR0b25Sb2xlIGlm CisgICAgICAgIGl0IGFsc28gaGFzIGFyaWEtaGFzcG9wdXAuIEFkZCBhIGNoZWNrIHRvIGF0a1Jv bGUoKSBzbyB0aGF0IHRoZSBsYXR0ZXIgY2FzZQorICAgICAgICBpcyBtYXBwZWQgdG8gQVRLX1JP TEVfUFVTSF9CVVRUT04uCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nl c3NpYmxlV3JhcHBlckF0ay5jcHA6CisgICAgICAgIChhdGtSb2xlKToKKworMjAxNy0wNC0yNiAg Sm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CisKICAgICAgICAgW0FUS10gSW1w bGVtZW50IHN1cHBvcnQgZm9yIG5ldyBBUklBIDEuMSB2YWx1ZXMgb2YgYXJpYS1oYXNwb3B1cAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxMTY0CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vz c2libGVXcmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dl YktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAppbmRleCA2ZGYyNTg3YTgwNTc4ZjYwYWQ4MWU3 NmE5ZmFiMzZkODNjOGMxMDA5Li5iZGIxMDNkY2QwYjc5NzRkMWQxNDAwMTVhODBlZDcwY2FlOWVj YzBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRB Y2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCkBAIC01MjcsNiArNTI3LDcgQEAg c3RhdGljIEF0a1JvbGUgYXRrUm9sZShBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0KQog ICAgIGNhc2UgV2luZG93Um9sZToKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX1dJTkRPVzsKICAg ICBjYXNlIFBvcFVwQnV0dG9uUm9sZToKKyAgICAgICAgcmV0dXJuIGNvcmVPYmplY3QtPmFyaWFI YXNQb3B1cCgpID8gQVRLX1JPTEVfUFVTSF9CVVRUT04gOiBBVEtfUk9MRV9DT01CT19CT1g7CiAg ICAgY2FzZSBDb21ib0JveFJvbGU6CiAgICAgICAgIHJldHVybiBBVEtfUk9MRV9DT01CT19CT1g7 CiAgICAgY2FzZSBTcGxpdEdyb3VwUm9sZToKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0YWY1MGFjOTMzOGJkYTIzOGVkOWE5 YzJhY2Y0YTUwYTQ5YTc5M2Q3Li4xZjdjM2ZjNmRiOGI2MDU0YjYwOTQ0NzJiY2M2MDIyMGViN2Q0 ZDU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDQtMjYgIEpvYW5tYXJpZSBEaWdncyAg PGpkaWdnc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtBVEtdIEFSSUEgYnV0dG9ucyB3aGljaCBo YXZlIGEgcG9wdXAgc2hvdWxkIGJlIEFUS19ST0xFX1BVU0hfQlVUVE9OOyBub3QgQVRLX1JPTEVf Q09NQk9fQk9YCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzExODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvZ3RrL2J1dHRvbi13aXRoLWFyaWEtaGFzcG9wdXAtaXMtbm90LWEt Y29tYm9ib3gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0 ay9idXR0b24td2l0aC1hcmlhLWhhc3BvcHVwLWlzLW5vdC1hLWNvbWJvYm94Lmh0bWw6IEFkZGVk LgorCiAyMDE3LTA0LTI2ICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CiAKICAgICAg ICAgTWFyayBzd2lwZS9tYWluLWZyYW1lLXBpbm5pbmctcmVxdWlyZW1lbnQuaHRtbCBhcyBhIGZs YWt5IGZhaWx1cmUgb24gbWFjLXdrMi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvZ3RrL2J1dHRvbi13aXRoLWFyaWEtaGFzcG9wdXAtaXMtbm90LWEtY29tYm9ib3gtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsvYnV0dG9uLXdpdGgtYXJp YS1oYXNwb3B1cC1pcy1ub3QtYS1jb21ib2JveC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYjJk ZmE5YzYxZmIxNTcwY2Y0NjQ1ZDEwNTE3MWYxYjI3ZTk4OTAyOQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZ3RrL2J1dHRvbi13aXRoLWFyaWEtaGFzcG9wdXAt aXMtbm90LWEtY29tYm9ib3gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTkgQEAKK1RoaXMgdmVy aWZpZXMgdGhhdCBidXR0b25zIHdpdGggYXJpYS1oYXNwb3B1cCBhcmUgZXhwb3NlZCBhcyBidXR0 b25zCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCit0ZXN0MSBBWFJvbGU6IEFYQnV0 dG9uCit0ZXN0MiBBWFJvbGU6IEFYQnV0dG9uCit0ZXN0MyBBWFJvbGU6IEFYQnV0dG9uCit0ZXN0 NCBBWFJvbGU6IEFYQnV0dG9uCit0ZXN0NSBBWFJvbGU6IEFYQnV0dG9uCit0ZXN0NiBBWFJvbGU6 IEFYQnV0dG9uCit0ZXN0NyBBWFJvbGU6IEFYQnV0dG9uCit0ZXN0OCBBWFJvbGU6IEFYQnV0dG9u Cit0ZXN0OSBBWFJvbGU6IEFYQnV0dG9uCit0ZXN0MTAgQVhSb2xlOiBBWEJ1dHRvbgorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZ3RrL2J1dHRvbi13aXRoLWFyaWEtaGFzcG9wdXAt aXMtbm90LWEtY29tYm9ib3guaHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZ3RrL2J1 dHRvbi13aXRoLWFyaWEtaGFzcG9wdXAtaXMtbm90LWEtY29tYm9ib3guaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li45ZmQ1OGI1YmE4YzA4MzA1ZDc4NDJmM2U2ODEyOTRiZjY2MDY4OWIyCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsvYnV0dG9uLXdpdGgtYXJpYS1oYXNw b3B1cC1pcy1ub3QtYS1jb21ib2JveC5odG1sCkBAIC0wLDAgKzEsMzUgQEAKKzwhRE9DVFlQRSBI VE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5IGlkPSJib2R5Ij4KKzxkaXYgaWQ9ImNvbnRlbnQiPgorICA8ZGl2IGlkPSJ0ZXN0 MSIgcm9sZT0iYnV0dG9uIj5YPC9kaXY+CisgIDxkaXYgaWQ9InRlc3QyIiByb2xlPSJidXR0b24i IGFyaWEtaGFzcG9wdXA9InRydWUiPlg8L2Rpdj4KKyAgPGRpdiBpZD0idGVzdDMiIHJvbGU9ImJ1 dHRvbiIgYXJpYS1oYXNwb3B1cD0iZmFsc2UiPlg8L2Rpdj4KKyAgPGRpdiBpZD0idGVzdDQiIHJv bGU9ImJ1dHRvbiIgYXJpYS1oYXNwb3B1cD0iZGlhbG9nIj5YPC9kaXY+CisgIDxkaXYgaWQ9InRl c3Q1IiByb2xlPSJidXR0b24iIGFyaWEtaGFzcG9wdXA9ImdyaWQiPlg8L2Rpdj4KKyAgPGRpdiBp ZD0idGVzdDYiIHJvbGU9ImJ1dHRvbiIgYXJpYS1oYXNwb3B1cD0ibGlzdGJveCI+WDwvZGl2Pgor ICA8ZGl2IGlkPSJ0ZXN0NyIgcm9sZT0iYnV0dG9uIiBhcmlhLWhhc3BvcHVwPSJtZW51Ij5YPC9k aXY+CisgIDxkaXYgaWQ9InRlc3Q4IiByb2xlPSJidXR0b24iIGFyaWEtaGFzcG9wdXA9InRyZWUi Plg8L2Rpdj4KKyAgPGRpdiBpZD0idGVzdDkiIHJvbGU9ImJ1dHRvbiIgYXJpYS1oYXNwb3B1cD0i Zm9vIj5YPC9kaXY+CisgIDxkaXYgaWQ9InRlc3QxMCIgcm9sZT0iYnV0dG9uIiBhcmlhLWhhc3Bv cHVwPSIiPlg8L2Rpdj4KKzwvZGl2PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlk PSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24oIlRoaXMgdmVyaWZp ZXMgdGhhdCBidXR0b25zIHdpdGggYXJpYS1oYXNwb3B1cCBhcmUgZXhwb3NlZCBhcyBidXR0b25z Iik7CisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworICAgICAgICBm b3IgKHZhciBpID0gMTsgaSA8PSAxMDsgaSsrKSB7CisgICAgICAgICAgICB2YXIgYXhFbGVtZW50 ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJ0ZXN0IiAr IGkpOworICAgICAgICAgICAgZGVidWcoInRlc3QiICsgaSArICIgIiArIGF4RWxlbWVudC5yb2xl KTsKKyAgICAgICAgfQorCisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb250ZW50 Iikuc3R5bGUudmlzaWJpbGl0eSA9ICJoaWRkZW4iOworICAgIH0KKzwvc2NyaXB0PgorPHNjcmlw dCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgorCg==