<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>17118</bug_id>
          
          <creation_ts>2008-01-31 09:13:49 -0800</creation_ts>
          <short_desc>kjs_navigator.cpp should be re-written to be less crazy</short_desc>
          <delta_ts>2009-01-03 13:44:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>68923</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-01-31 09:13:49 -0800</bug_when>
    <thetext>kjs_navigator.cpp should be re-written to be less crazy

kjs_navigator uses a complicated/hacky memory management scheme and thus I bet leaks in some cases.

Better would be for PluginBase to hold a reference to some PluginInfoCache static.  When the PluginInfoCache ref count drops to 0, it can clear its caches.  Those caches can use Vector&lt;OwnPtr&gt; to avoid ever leaking.

This could/should also be re-written to use the bindings autogen system.  Thus Navigator would become a normal RefCounted class, and Navigator.idl would take care of all the details.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>104133</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-01-02 11:30:10 -0800</bug_when>
    <thetext>Can this bug be closed?  I know Navigator.h/cpp/idl were created a while ago, and the plugin code has undergone many refactorings since this was filed.

</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>