171176 2017-04-22 16:46:24 -0700 [ATK] atk_table_cell_get_position() should return values of aria-rowindex and aria-colindex, if present 2019-05-02 16:17:36 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All Linux RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall akkaran046 apinheiro buildbot cfleizach commit-queue dmazzoni jcraig samuel_white webkit-bug-importer oldest_to_newest 1300243 0 jdiggs 2017-04-22 16:46:24 -0700 For ATK, support for aria-rowindex and aria-colindex requires: 1. Expose the values via the "rowindex" and "colindex" object attributes 2. Returning the values via atk_table_cell_get_position() See: * https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaColIndex * https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaRowIndex 1300244 1 webkit-bug-importer 2017-04-22 16:46:41 -0700 <rdar://problem/31775666> 1304639 2 jdiggs 2017-05-04 08:49:28 -0700 Updating the summary because the object attributes are already done. 1352770 3 321851 jdiggs 2017-09-26 11:39:52 -0700 Created attachment 321851 Patch 1352949 4 321851 cfleizach 2017-09-26 17:53:44 -0700 Comment on attachment 321851 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321851&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:126 > + rowIndex = columnRowRange.first; this should be columRowRange.second right? 1352958 5 jdiggs 2017-09-26 18:00:53 -0700 (In reply to chris fleizach from comment #4) > Comment on attachment 321851 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321851&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:126 > > + rowIndex = columnRowRange.first; > > this should be columRowRange.second right? The index/location is the range's first; the span/length is its second. 1353061 6 321851 commit-queue 2017-09-27 02:45:39 -0700 Comment on attachment 321851 Patch Clearing flags on attachment: 321851 Committed r222551: <http://trac.webkit.org/changeset/222551> 1353062 7 commit-queue 2017-09-27 02:45:40 -0700 All reviewed patches have been landed. Closing bug. 321851 2017-09-26 11:39:52 -0700 2017-09-27 02:45:39 -0700 Patch bug-171176-20170926143951.patch text/plain 6205 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDYyNjYwNmQyYmIwZDJi YWE0NDIxZTZhYzVkMmUzNDI3NmYwNTM5Mi4uOWVjYTY0NGVjYjAwMzU5MDcwYzMxMDgyYTlhODA3 MDQxNWUxOGU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA5LTI2ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbQVRLXSBhdGtfdGFi bGVfY2VsbF9nZXRfcG9zaXRpb24oKSBzaG91bGQgcmV0dXJuIHZhbHVlcyBvZiBhcmlhLXJvd2lu ZGV4IGFuZCBhcmlhLWNvbGluZGV4LCBpZiBwcmVzZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzExNzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb2RpZnkgd2ViS2l0QWNjZXNzaWJsZVRhYmxlQ2Vs bEdldFBvc2l0aW9uKCkgdG8gcHJlZmVyIHRoZSBBUklBIHZhbHVlCisgICAgICAgIG92ZXIgdGhl IERPTS1iYXNlZCB2YWx1ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkOiBXZSBoYXZl IGNvdmVyYWdlIHRocm91Z2ggYXJpYS10YWJsZS1hdHRyaWJ1dGVzLmh0bWwuCisgICAgICAgIFBs YXRmb3JtIGV4cGVjdGF0aW9ucyBmb3IgdGhpcyB0ZXN0IHdlcmUgdXBkYXRlZC4KKworICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VUYWJsZUNlbGwu Y3BwOgorICAgICAgICAod2Via2l0QWNjZXNzaWJsZVRhYmxlQ2VsbEdldFBvc2l0aW9uKToKKwog MjAxNy0wOS0yNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTiAoMjIyMDQwKTogR29vZ2xlIE1hcHMgU3RyZWV0IFZpZXcgQ3Jhc2hUcmFjZXI6 IFtVU0VSXSBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgYXQgY29tLmFw cGxlLldlYkNvcmU6IFdlYkNvcmU6OlByb3BlcnR5V3JhcHBlckFjY2VsZXJhdGVkVHJhbnNmb3Jt OjpibGVuZCBjb25zdCArIDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGFibGVDZWxsLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VUYWJsZUNl bGwuY3BwCmluZGV4IDNkMWU5NjIxMWU5NDVjZGZhNDFlYTgwMmUxZjMxMzBhNzMzNThjMGIuLjFm MDk2ZDFkZGNiNmZjMWUxY2ZmN2RlMzkyZmI5MmI1NmU4M2RhZDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VUYWJs ZUNlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFj Y2Vzc2libGVJbnRlcmZhY2VUYWJsZUNlbGwuY3BwCkBAIC0xMTksMTIgKzExOSwyMiBAQCBnYm9v bGVhbiB3ZWJraXRBY2Nlc3NpYmxlVGFibGVDZWxsR2V0UG9zaXRpb24oQXRrVGFibGVDZWxsKiBj ZWxsLCBnaW50KiByb3csIGdpbgogCiAgICAgc3RkOjpwYWlyPHVuc2lnbmVkLCB1bnNpZ25lZD4g Y29sdW1uUm93UmFuZ2U7CiAgICAgaWYgKHJvdykgewotICAgICAgICBkb3duY2FzdDxBY2Nlc3Np YmlsaXR5VGFibGVDZWxsPigqYXhPYmplY3QpLnJvd0luZGV4UmFuZ2UoY29sdW1uUm93UmFuZ2Up OwotICAgICAgICAqcm93ID0gY29sdW1uUm93UmFuZ2UuZmlyc3Q7CisgICAgICAgIC8vIGFyaWEt cm93aW5kZXggaXMgMS1iYXNlZC4KKyAgICAgICAgaW50IHJvd0luZGV4ID0gZG93bmNhc3Q8QWNj ZXNzaWJpbGl0eVRhYmxlQ2VsbD4oKmF4T2JqZWN0KS5hcmlhUm93SW5kZXgoKSAtIDE7CisgICAg ICAgIGlmIChyb3dJbmRleCA8PSAtMSkgeworICAgICAgICAgICAgZG93bmNhc3Q8QWNjZXNzaWJp bGl0eVRhYmxlQ2VsbD4oKmF4T2JqZWN0KS5yb3dJbmRleFJhbmdlKGNvbHVtblJvd1JhbmdlKTsK KyAgICAgICAgICAgIHJvd0luZGV4ID0gY29sdW1uUm93UmFuZ2UuZmlyc3Q7CisgICAgICAgIH0K KyAgICAgICAgKnJvdyA9IHJvd0luZGV4OwogICAgIH0KICAgICBpZiAoY29sdW1uKSB7Ci0gICAg ICAgIGRvd25jYXN0PEFjY2Vzc2liaWxpdHlUYWJsZUNlbGw+KCpheE9iamVjdCkuY29sdW1uSW5k ZXhSYW5nZShjb2x1bW5Sb3dSYW5nZSk7Ci0gICAgICAgICpjb2x1bW4gPSBjb2x1bW5Sb3dSYW5n ZS5maXJzdDsKKyAgICAgICAgLy8gYXJpYS1jb2xpbmRleCBpcyAxLWJhc2VkLgorICAgICAgICBp bnQgY29sdW1uSW5kZXggPSBkb3duY2FzdDxBY2Nlc3NpYmlsaXR5VGFibGVDZWxsPigqYXhPYmpl Y3QpLmFyaWFDb2x1bW5JbmRleCgpIC0gMTsKKyAgICAgICAgaWYgKGNvbHVtbkluZGV4IDw9IC0x KSB7CisgICAgICAgICAgICBkb3duY2FzdDxBY2Nlc3NpYmlsaXR5VGFibGVDZWxsPigqYXhPYmpl Y3QpLmNvbHVtbkluZGV4UmFuZ2UoY29sdW1uUm93UmFuZ2UpOworICAgICAgICAgICAgY29sdW1u SW5kZXggPSBjb2x1bW5Sb3dSYW5nZS5maXJzdDsKKyAgICAgICAgfQorICAgICAgICAqY29sdW1u ID0gY29sdW1uSW5kZXg7CiAgICAgfQogCiAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzk4ODk3 NzE3YzNkZDg0NzQzYjQ3ZWVkOGI0MzkzYjQxYWIwZWZjNS4uN2QwZTFlNDlhMWE1Yjc2YTI1NjBk MTQ0MmFmNzYxMWQwMTIwYjVjNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTI2ICBK b2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbQVRLXSBhdGtf dGFibGVfY2VsbF9nZXRfcG9zaXRpb24oKSBzaG91bGQgcmV0dXJuIHZhbHVlcyBvZiBhcmlhLXJv d2luZGV4IGFuZCBhcmlhLWNvbGluZGV4LCBpZiBwcmVzZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzExNzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS1h dHRyaWJ1dGVzLmh0bWw6IFVwZGF0ZWQgdG8gcmVmbGVjdCBuZXcgYmVoYXZpb3IuCisgICAgICAg ICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS1hdHRyaWJ1dGVzLWV4cGVj dGVkLnR4dDogVXBkYXRlZCB0byByZWZsZWN0IG5ldyBiZWhhdmlvci4KKwogMjAxNy0wOS0yNiAg QW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAo MjIyMDQwKTogR29vZ2xlIE1hcHMgU3RyZWV0IFZpZXcgQ3Jhc2hUcmFjZXI6IFtVU0VSXSBjb20u YXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgYXQgY29tLmFwcGxlLldlYkNvcmU6 IFdlYkNvcmU6OlByb3BlcnR5V3JhcHBlckFjY2VsZXJhdGVkVHJhbnNmb3JtOjpibGVuZCBjb25z dCArIDkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtdGFibGUt YXR0cmlidXRlcy5odG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLXRhYmxlLWF0 dHJpYnV0ZXMuaHRtbAppbmRleCBhZTU2OTgzZjAyOTk5YWY3MjdlYTE3NWEyNTYwMzEwMWQzNWE2 ZWQ2Li45NWYwN2NmMTAwOWQ2NmRjYzk1ZjVhMjljOGE2NDcxYTlkZDc5ZDdlIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtdGFibGUtYXR0cmlidXRlcy5odG1sCisr KyBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS1hdHRyaWJ1dGVzLmh0bWwK QEAgLTk3LDExICs5NywxNyBAQAogICAgICAgICAgIC8vIGFyaWEtY29saW5kZXggZnJvbSBwYXJl bnQgcm93CiAgICAgICAgICAgc2hvdWxkQmUoImNlbGw0Lm51bWJlckF0dHJpYnV0ZVZhbHVlKCdB WEFSSUFDb2x1bW5JbmRleCcpIiwgIjMiKTsKICAgICAgICAgICAKLSAgICAgICAgICAvLyBhcmlh LWNvbHNwYW4gYW5kIGFyaWEtcm93c3BhbgotICAgICAgICAgIHNob3VsZEJlKCJjZWxsMi5yb3dJ bmRleFJhbmdlKCkiLCAiJ3sxLCAyfSciKTsKLSAgICAgICAgICBzaG91bGRCZSgiY2VsbDUuY29s dW1uSW5kZXhSYW5nZSgpIiwgIid7MiwgM30nIik7Ci0gICAgICAgICAgLy8gYXJpYS1yb3dzcGFu PSIwIgotICAgICAgICAgIHNob3VsZEJlKCJjZWxsMy5yb3dJbmRleFJhbmdlKCkiLCAiJ3sxLCAy fSciKTsKKyAgICAgICAgICAvLyBhcmlhLWNvbHNwYW4gYW5kIGFyaWEtcm93c3BhbiwgaW5jbHVk aW5nIGFyaWEtcm93c3Bhbj0iMCIKKyAgICAgICAgICBpZiAoYWNjZXNzaWJpbGl0eUNvbnRyb2xs ZXIucGxhdGZvcm1OYW1lID09ICJhdGsiKSB7CisgICAgICAgICAgICAgIC8vIDAtYmFzZWQgYmVj YXVzZSB0aGVzZSBtZXRob2RzIHVzZSB0aGUgQXRrVGFibGVDZWxsIGludGVyZmFjZQorICAgICAg ICAgICAgICBzaG91bGRCZSgiY2VsbDIucm93SW5kZXhSYW5nZSgpIiwgIid7NywgMn0nIik7Cisg ICAgICAgICAgICAgIHNob3VsZEJlKCJjZWxsNS5jb2x1bW5JbmRleFJhbmdlKCkiLCAiJ3szLCAz fSciKTsKKyAgICAgICAgICAgICAgc2hvdWxkQmUoImNlbGwzLnJvd0luZGV4UmFuZ2UoKSIsICIn ezcsIDJ9JyIpOworICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgIHNob3VsZEJlKCJj ZWxsMi5yb3dJbmRleFJhbmdlKCkiLCAiJ3sxLCAyfSciKTsKKyAgICAgICAgICAgICAgc2hvdWxk QmUoImNlbGw1LmNvbHVtbkluZGV4UmFuZ2UoKSIsICInezIsIDN9JyIpOworICAgICAgICAgICAg ICBzaG91bGRCZSgiY2VsbDMucm93SW5kZXhSYW5nZSgpIiwgIid7MSwgMn0nIik7CisgICAgICAg ICAgfQogICAgICAgICAgIHNob3VsZEJlKCJjZWxsNi5yb3dJbmRleFJhbmdlKCkiLCAiJ3swLCAy fSciKTsKICAgICAgICAgICAvLyB1c2Ugcm93c3BhbiBmb3IgbmF0aXZlIHRhYmxlCiAgICAgICAg ICAgc2hvdWxkQmUoImNlbGw3LnJvd0luZGV4UmFuZ2UoKSIsICInezAsIDJ9JyIpOwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS1h dHRyaWJ1dGVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3Np YmlsaXR5L2FyaWEtdGFibGUtYXR0cmlidXRlcy1leHBlY3RlZC50eHQKaW5kZXggOTVkNDlhMTY5 ZDNkYzUyOWUxOTg0MDM5MmVlZDhkY2M0NGIyYmJhMi4uMmNlYmI1MDRiZTgyY2Y3MjViMjYyZTA4 NDJlM2ZiMTE3YzYxYTkxZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Fj Y2Vzc2liaWxpdHkvYXJpYS10YWJsZS1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9hcmlhLXRhYmxlLWF0dHJpYnV0ZXMt ZXhwZWN0ZWQudHh0CkBAIC0xMiw5ICsxMiw5IEBAIFBBU1MgY2VsbDEubnVtYmVyQXR0cmlidXRl VmFsdWUoJ0FYQVJJQVJvd0luZGV4JykgaXMgNwogUEFTUyBjZWxsMi5udW1iZXJBdHRyaWJ1dGVW YWx1ZSgnQVhBUklBQ29sdW1uSW5kZXgnKSBpcyA0CiBQQVNTIGNlbGwyLm51bWJlckF0dHJpYnV0 ZVZhbHVlKCdBWEFSSUFSb3dJbmRleCcpIGlzIDgKIFBBU1MgY2VsbDQubnVtYmVyQXR0cmlidXRl VmFsdWUoJ0FYQVJJQUNvbHVtbkluZGV4JykgaXMgMwotUEFTUyBjZWxsMi5yb3dJbmRleFJhbmdl KCkgaXMgJ3sxLCAyfScKLVBBU1MgY2VsbDUuY29sdW1uSW5kZXhSYW5nZSgpIGlzICd7MiwgM30n Ci1QQVNTIGNlbGwzLnJvd0luZGV4UmFuZ2UoKSBpcyAnezEsIDJ9JworUEFTUyBjZWxsMi5yb3dJ bmRleFJhbmdlKCkgaXMgJ3s3LCAyfScKK1BBU1MgY2VsbDUuY29sdW1uSW5kZXhSYW5nZSgpIGlz ICd7MywgM30nCitQQVNTIGNlbGwzLnJvd0luZGV4UmFuZ2UoKSBpcyAnezcsIDJ9JwogUEFTUyBj ZWxsNi5yb3dJbmRleFJhbmdlKCkgaXMgJ3swLCAyfScKIFBBU1MgY2VsbDcucm93SW5kZXhSYW5n ZSgpIGlzICd7MCwgMn0nCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCg==