<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171128</bug_id>
          
          <creation_ts>2017-04-21 12:13:20 -0700</creation_ts>
          <short_desc>Regression(r204605): support for &quot;cp874&quot; charset alias was inadvertently dropped which may cause issues on certain Thai sites</short_desc>
          <delta_ts>2017-04-24 18:44:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>160931</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>ap</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1299756</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-04-21 12:13:20 -0700</bug_when>
    <thetext>text on http://www1.odn.ne.jp/pasto_cbe26550/ looks garbled after r204605, when the system&apos;s default language is Japanese. This is because we inadvertently dropped support for &quot;cp932&quot; character encoding alias.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1299757</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-04-21 12:13:36 -0700</bug_when>
    <thetext>&lt;rdar://problem/31526844&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1299760</commentid>
    <comment_count>2</comment_count>
      <attachid>307771</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-04-21 12:18:24 -0700</bug_when>
    <thetext>Created attachment 307771
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1299813</commentid>
    <comment_count>3</comment_count>
      <attachid>307771</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-04-21 13:06:51 -0700</bug_when>
    <thetext>Comment on attachment 307771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307771&amp;action=review

&gt; Source/WebCore/platform/text/TextCodecICU.cpp:96
&gt; +DECLARE_ALIASES(windows_949, &quot;euc-kr&quot;, &quot;cseuckr&quot;, &quot;csksc56011987&quot;, &quot;iso-ir-149&quot;, &quot;korean&quot;, &quot;ks_c_5601-1987&quot;, &quot;ks_c_5601-1989&quot;, &quot;ksc5601&quot;, &quot;ksc_5601&quot;, &quot;ms949&quot;, &quot;x-KSC5601&quot;, &quot;x-windows-949&quot;, &quot;x-uhc&quot;, &quot;cp949&quot;);

This won&apos;t work - cp949 is a different encoding in ICU than CFString thinks it is.

I don&apos;t see why we would add support for non-standard encoding aliases here. Why not just special case them in defaultTextEncodingNameForSystemLanguage()? That&apos;s the only place where they should be supported, not in Web content.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300683</commentid>
    <comment_count>4</comment_count>
      <attachid>308016</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-04-24 15:11:34 -0700</bug_when>
    <thetext>Created attachment 308016
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300721</commentid>
    <comment_count>5</comment_count>
      <attachid>308016</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-04-24 16:50:39 -0700</bug_when>
    <thetext>Comment on attachment 308016
Patch

r=me assuming that this is the same encoding that we used to map cp874 to in the past.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300725</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-04-24 16:56:38 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #5)
&gt; Comment on attachment 308016 [details]
&gt; Patch
&gt; 
&gt; r=me assuming that this is the same encoding that we used to map cp874 to in
&gt; the past.

I am no sure it is. If you look at http://demo.icu-project.org/icu-bin/convexp. It says that &quot;cp874&quot; alias was using ibm-874_P100-1995 internal encoder in ICU. However, it would now use windows-874-2000. I do not know how big an issue that is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300728</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-04-24 17:00:41 -0700</bug_when>
    <thetext>(In reply to Chris Dumez from comment #6)
&gt; (In reply to Alexey Proskuryakov from comment #5)
&gt; &gt; Comment on attachment 308016 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; r=me assuming that this is the same encoding that we used to map cp874 to in
&gt; &gt; the past.
&gt; 
&gt; I am no sure it is. If you look at
&gt; http://demo.icu-project.org/icu-bin/convexp. It says that &quot;cp874&quot; alias was
&gt; using ibm-874_P100-1995 internal encoder in ICU. However, it would now use
&gt; windows-874-2000. I do not know how big an issue that is.

http://demo.icu-project.org/icu-bin/convexp?conv=windows-874-2000&amp;s=ALL
http://demo.icu-project.org/icu-bin/convexp?conv=ibm-874_P100-1995&amp;s=ALL</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300768</commentid>
    <comment_count>8</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-04-24 18:01:45 -0700</bug_when>
    <thetext>The table attached to bug 160931 says &quot;cp874: (got: windows-874)&quot;. Looking at the ICU links that you posted, and at r204605, I don&apos;t see how that could be the case.

But the table is accurate, then windows-874 is definitely the way to go.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300776</commentid>
    <comment_count>9</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-04-24 18:21:26 -0700</bug_when>
    <thetext>&gt; But the table

But *if* the table</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300794</commentid>
    <comment_count>10</comment_count>
      <attachid>308016</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-04-24 18:44:35 -0700</bug_when>
    <thetext>Comment on attachment 308016
Patch

Clearing flags on attachment: 308016

Committed r215711: &lt;http://trac.webkit.org/changeset/215711&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1300795</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-04-24 18:44:37 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>307771</attachid>
            <date>2017-04-21 12:18:24 -0700</date>
            <delta_ts>2017-04-24 15:11:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171128-20170421121823.patch</filename>
            <type>text/plain</type>
            <size>6711</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2M1MTY5OTk5ZDFmZTY2
ZGYzNDg0ZTg2MTdiNTNmMzIyMjYxZjNjMi4uNjdjZTcyYzViODVjNWRlY2YxYjExYTQ0ZTQ1YzI3
MjMzMWMxOTVjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA0LTIxICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjA0NjA1
KTogdGV4dCBvbiBodHRwOi8vd3d3MS5vZG4ubmUuanAvcGFzdG9fY2JlMjY1NTAvIGxvb2tzIGdh
cmJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3
MTEyOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzE1MjY4NDQ+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGV4dCBvbiBodHRwOi8vd3d3MS5vZG4u
bmUuanAvcGFzdG9fY2JlMjY1NTAvIGxvb2tzIGdhcmJsZWQgYWZ0ZXIgcjIwNDYwNSwgd2hlbiB0
aGUgc3lzdGVtJ3MKKyAgICAgICAgZGVmYXVsdCBsYW5ndWFnZSBpcyBKYXBhbmVzZS4gVGhpcyBp
cyBiZWNhdXNlIHdlIGluYWR2ZXJ0ZW50bHkgZHJvcHBlZCBzdXBwb3J0IGZvciAiY3A5MzIiCisg
ICAgICAgIGNoYXJhY3RlciBlbmNvZGluZyBhbGlhcy4gVGhpcyBwYXRjaCByZS1pbnRyb2R1Y2Vz
IHN1cHBvcnQgZm9yIHRoZSAiY3A5MzIiIGFsaWFzIGFzIHdlbGwKKyAgICAgICAgYXMgYSBjb3Vw
bGUgb2Ygb3RoZXIgd2hpY2ggd2VyZSBkcm9wcGVkIGJ5IG1pc3Rha2UgKCJjcDg3NCIgZm9yIFRo
YWkgJiAiY3A5NDkiIGZvciBLb3JlYW4pLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvbWlz
Yy9jaGFyc2V0LWFsaWFzZXMuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9UZXh0Q29k
ZWNJQ1UuY3BwOgorCiAyMDE3LTA0LTIxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu
QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVkdWNlIGNvcGllcyBhbmQgYWxsb2NhdGlvbnMgaW4g
U2hhcmVkQnVmZmVyOjphcHBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L3RleHQvVGV4dENvZGVjSUNVLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4
dENvZGVjSUNVLmNwcAppbmRleCA0MDIxMmZlM2QwMzJiMzhhYzM5ZTljYmI0YjUyZjIwMWE5NzU5
MWIyLi5mYjNkMjA2NzA3NzRmMzhlMjY2OTk4MThmOGE5M2YwMjEwNTViMzA5IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY0lDVS5jcHAKKysrIGIvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNJQ1UuY3BwCkBAIC05Miw4ICs5Miw4
IEBAIERFQ0xBUkVfQUxJQVNFUyhJU09fODg1OV8xNSwgImNzaXNvbGF0aW45IiwgImlzbzg4NTkt
MTUiLCAiaXNvODg1OTE1IiwgImlzb184ODU5CiBERUNMQVJFX0FMSUFTRVMoS09JOF9SLCAiY3Nr
b2k4ciIsICJrb2kiLCAia29pOCIsICJrb2k4X3IiKTsKIERFQ0xBUkVfQUxJQVNFUyhLT0k4X1Us
ICJrb2k4LXJ1Iik7CiBERUNMQVJFX0FMSUFTRVMobWFjaW50b3NoLCAiY3NtYWNpbnRvc2giLCAi
bWFjIiwgIngtbWFjLXJvbWFuIiwgIm1hY3JvbWFuIiwgIngtbWFjcm9tYW4iKTsKLURFQ0xBUkVf
QUxJQVNFUyh3aW5kb3dzXzg3NCwgImRvcy04NzQiLCAiaXNvLTg4NTktMTEiLCAiaXNvODg1OS0x
MSIsICJpc284ODU5MTEiLCAidGlzLTYyMCIpOwotREVDTEFSRV9BTElBU0VTKHdpbmRvd3NfOTQ5
LCAiZXVjLWtyIiwgImNzZXVja3IiLCAiY3Nrc2M1NjAxMTk4NyIsICJpc28taXItMTQ5IiwgImtv
cmVhbiIsICJrc19jXzU2MDEtMTk4NyIsICJrc19jXzU2MDEtMTk4OSIsICJrc2M1NjAxIiwgImtz
Y181NjAxIiwgIm1zOTQ5IiwgIngtS1NDNTYwMSIsICJ4LXdpbmRvd3MtOTQ5IiwgIngtdWhjIik7
CitERUNMQVJFX0FMSUFTRVMod2luZG93c184NzQsICJkb3MtODc0IiwgImlzby04ODU5LTExIiwg
Imlzbzg4NTktMTEiLCAiaXNvODg1OTExIiwgInRpcy02MjAiLCAiY3A4NzQiKTsKK0RFQ0xBUkVf
QUxJQVNFUyh3aW5kb3dzXzk0OSwgImV1Yy1rciIsICJjc2V1Y2tyIiwgImNza3NjNTYwMTE5ODci
LCAiaXNvLWlyLTE0OSIsICJrb3JlYW4iLCAia3NfY181NjAxLTE5ODciLCAia3NfY181NjAxLTE5
ODkiLCAia3NjNTYwMSIsICJrc2NfNTYwMSIsICJtczk0OSIsICJ4LUtTQzU2MDEiLCAieC13aW5k
b3dzLTk0OSIsICJ4LXVoYyIsICJjcDk0OSIpOwogREVDTEFSRV9BTElBU0VTKHdpbmRvd3NfMTI1
MCwgImNwMTI1MCIsICJ4LWNwMTI1MCIsICJ3aW5sYXRpbjIiKTsKIERFQ0xBUkVfQUxJQVNFUyh3
aW5kb3dzXzEyNTEsICJjcDEyNTEiLCAid2luY3lyaWxsaWMiLCAieC1jcDEyNTEiKTsKIERFQ0xB
UkVfQUxJQVNFUyh3aW5kb3dzXzEyNTMsICJ3aW5ncmVlayIsICJjcDEyNTMiLCAieC1jcDEyNTMi
KTsKQEAgLTEwOCw3ICsxMDgsNyBAQCBERUNMQVJFX0FMSUFTRVMoZ2IxODAzMCwgImlibS0xMzky
IiwgIndpbmRvd3MtNTQ5MzYiKTsKIERFQ0xBUkVfQUxJQVNFUyhCaWc1LCAiY24tYmlnNSIsICJ4
LXgtYmlnNSIsICJjc2JpZzUiLCAid2luZG93cy05NTAiLCAid2luZG93cy05NTAtMjAwMCIsICJt
czk1MCIsICJ4LXdpbmRvd3MtOTUwIiwgIngtYmlnNSIpOwogREVDTEFSRV9BTElBU0VTKEVVQ19K
UCwgIngtZXVjIiwgImNzZXVjcGtkZm10amFwYW5lc2UiLCAieC1ldWMtanAiKTsKIERFQ0xBUkVf
QUxJQVNFUyhJU09fMjAyMl9KUCwgImppczciLCAiY3Npc28yMDIyanAiKTsKLURFQ0xBUkVfQUxJ
QVNFUyhTaGlmdF9KSVMsICJzaGlmdC1qaXMiLCAiY3NzaGlmdGppcyIsICJtczkzMiIsICJtc19r
YW5qaSIsICJzamlzIiwgIndpbmRvd3MtMzFqIiwgIngtc2ppcyIpOworREVDTEFSRV9BTElBU0VT
KFNoaWZ0X0pJUywgInNoaWZ0LWppcyIsICJjc3NoaWZ0amlzIiwgIm1zOTMyIiwgIm1zX2thbmpp
IiwgInNqaXMiLCAid2luZG93cy0zMWoiLCAieC1zamlzIiwgImNwOTMyIik7CiAvLyBFbmNvZGlu
Z3MgYmVsb3cgYXJlIG5vdCBpbiB0aGUgc3RhbmRhcmQuCiBERUNMQVJFX0FMSUFTRVMoVVRGXzMy
LCAiSVNPLTEwNjQ2LVVDUy00IiwgImlibS0xMjM2IiwgImlibS0xMjM3IiwgImNzVUNTNCIsICJ1
Y3MtNCIpOwogREVDTEFSRV9BTElBU0VTKFVURl8zMkxFLCAiVVRGMzJfTGl0dGxlRW5kaWFuIiwg
ImlibS0xMjM0IiwgImlibS0xMjM1Iik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWVhNzg3YjFmOWM2ZTA5YWM1YTY4Y2Y4
MDc4NjZjODQxMjljNmRiYS4uZWUxOGI0ZjAwY2NiYWZjNzc2MTY4M2Y2YTA3NDUxYTU1MDcwMmQy
OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No
YW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTIxICBDaHJpcyBEdW1leiAgPGNkdW1l
ekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjA0NjA1KTogdGV4dCBvbiBodHRw
Oi8vd3d3MS5vZG4ubmUuanAvcGFzdG9fY2JlMjY1NTAvIGxvb2tzIGdhcmJsZWQKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTEyOAorICAgICAgICA8
cmRhcjovL3Byb2JsZW0vMzE1MjY4NDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgQWRkIGxheW91dCB0ZXN0IGNvdmVyYWdlLgorCisgICAgICAgICog
aHR0cC90ZXN0cy9taXNjL2NoYXJzZXQtYWxpYXNlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg
ICAgICAqIGh0dHAvdGVzdHMvbWlzYy9jaGFyc2V0LWFsaWFzZXMuaHRtbDogQWRkZWQuCisgICAg
ICAgICogaHR0cC90ZXN0cy9taXNjL3Jlc291cmNlcy91c2UtY2hhcnNldC5waHA6IEFkZGVkLgor
CiAyMDE3LTA0LTIxICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K
IAogICAgICAgICBFeHBvc2Ugb2JzY3VyZWQgaW5zZXRzIHRvIHdlYiBjb250ZW50IChhcyAic2Fm
ZSBhcmVhIGluc2V0cyIpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mv
Y2hhcnNldC1hbGlhc2VzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlz
Yy9jaGFyc2V0LWFsaWFzZXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4
IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI2MTlkNDNhODg3MTEw
MDAwZjBjZjc1YTZlYWUwYjFiNjAxZjYyNDEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0
cy9odHRwL3Rlc3RzL21pc2MvY2hhcnNldC1hbGlhc2VzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx
LDE1IEBACitUZXN0cyBzZXZlcmFsIGVuY29kaW5nIGFsaWFzZXMuCisKK09uIHN1Y2Nlc3MsIHlv
dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU
IENPTVBMRVRFIi4KKworCisqIFRlc3RpbmcgJ2NwODc0JyBhbGlhcy4KK1BBU1MgZnJhbWUuZG9j
dW1lbnQuY2hhcnNldCBpcyAid2luZG93cy04NzQiCisqIFRlc3RpbmcgJ2NwOTQ5JyBhbGlhcy4K
K1BBU1MgZnJhbWUuZG9jdW1lbnQuY2hhcnNldCBpcyAiRVVDLUtSIgorKiBUZXN0aW5nICdjcDkz
MicgYWxpYXMuCitQQVNTIGZyYW1lLmRvY3VtZW50LmNoYXJzZXQgaXMgIlNoaWZ0X0pJUyIKK1BB
U1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvY2hhcnNldC1hbGlhc2VzLmh0bWwgYi9M
YXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvY2hhcnNldC1hbGlhc2VzLmh0bWwKbmV3IGZpbGUg
bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MC4uYWY4ODQwNjhiOTdhZDY0YWUxZDE0YzM4ZWQzZTJkNmVkOTdiODU0NAotLS0gL2Rldi9udWxs
CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9jaGFyc2V0LWFsaWFzZXMuaHRtbApA
QCAtMCwwICsxLDQyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0
IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3Jp
cHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgc2V2ZXJhbCBlbmNvZGluZyBhbGlhc2VzLiIpOworanNU
ZXN0SXNBc3luYyA9IHRydWU7CisKK3ZhciBhbGlhc2VzID0gWworICAgICJjcDg3NCIsCisgICAg
ImNwOTQ5IiwKKyAgICAiY3A5MzIiLAorXTsKKwordmFyIGV4cGVjdGVkRW5jb2RpbmdzID0gWwor
ICAgICJ3aW5kb3dzLTg3NCIsCisgICAgIkVVQy1LUiIsCisgICAgIlNoaWZ0X0pJUyIsCitdOwor
ICAgIAorZm9yIChsZXQgaSA9IDA7IGkgPCBhbGlhc2VzLmxlbmd0aDsgKytpKSB7CisgICAgY29u
c3QgZnJhbWUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpZnJhbWUiKTsKKyAgICBmcmFtZS5z
ZXRBdHRyaWJ1dGUoInNyYyIsICJyZXNvdXJjZXMvdXNlLWNoYXJzZXQucGhwP2NoYXJzZXQ9IiAr
IGFsaWFzZXNbaV0pOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZnJhbWUpOworfQor
Cit2YXIgZnJhbWVzTGVmdCA9IGFsaWFzZXMubGVuZ3RoOworZnVuY3Rpb24gZnJhbWVMb2FkZWQo
KQoreworICAgIGlmICghLS1mcmFtZXNMZWZ0KSB7CisgICAgICAgIGZvciAobGV0IGkgPSAwOyBp
IDwgYWxpYXNlcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgZnJhbWUgPSBmcmFtZXNbaV07
CisgICAgICAgICAgICBkZWJ1ZygiKiBUZXN0aW5nICciICsgYWxpYXNlc1tpXSArICInIGFsaWFz
LiIpOworICAgICAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJmcmFtZS5kb2N1bWVudC5j
aGFyc2V0IiwgIiIgKyBleHBlY3RlZEVuY29kaW5nc1tpXSk7CisgICAgICAgIH0KKyAgICAgICAg
ZmluaXNoSlNUZXN0KCk7CisgICAgfQorfQorPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iL2pzLXRl
c3QtcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+
CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvcmVzb3VyY2VzL3VzZS1j
aGFyc2V0LnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9yZXNvdXJjZXMvdXNlLWNo
YXJzZXQucGhwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdmYjU1MGUwNTRjMmNjNDI0MGZlZTUwMWE4MmU2ZWE5ODky
ZjliOTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvcmVz
b3VyY2VzL3VzZS1jaGFyc2V0LnBocApAQCAtMCwwICsxLDYgQEAKKzw/cGhwCitlY2hvICc8bWV0
YSBjaGFyc2V0PSInIC4gJF9HRVRbJ2NoYXJzZXQnXSAuICciPic7CitlY2hvICc8Ym9keSBvbmxv
YWQ9InRvcC5mcmFtZUxvYWRlZCgpIj4nOworZWNobyAnPHAgaWQ9Y2hhcnNldD4nIC4gJF9HRVRb
J2NoYXJzZXQnXSAuICc8L3A+JzsKK2VjaG8gJzwvYm9keT4nOworPz4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>308016</attachid>
            <date>2017-04-24 15:11:34 -0700</date>
            <delta_ts>2017-04-24 18:44:35 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171128-20170424151133.patch</filename>
            <type>text/plain</type>
            <size>2362</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM5NTIwZmQ0YWRlMTAy
ZDQ5MTM1N2FjMTMxNTVkNDg4NzNmMDEzZS4uZWM1MjhlNmIzOGZjNWQ2YjA4MTA0OTM4N2UwOGRk
NGY5MmU0NGU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA0LTI0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjA0NjA1
KTogc3VwcG9ydCBmb3IgImNwODc0IiBjaGFyc2V0IGFsaWFzIHdhcyBpbmFkdmVydGVudGx5IGRy
b3BwZWQgd2hpY2ggbWF5IGNhdXNlIGlzc3VlcyBvbiBjZXJ0YWluIFRoYWkgc2l0ZXMKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTEyOAorICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vMzE1MjY4NDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgV2hlbiB1c2luZyBUaGFpIGFzIGRlZmF1bHQgbGFuZ3VhZ2Ug
b24gTWFjT1MsIGRlZmF1bHRUZXh0RW5jb2RpbmdOYW1lRm9yU3lzdGVtTGFuZ3VhZ2UoKQorICAg
ICAgICB3YXMgcmV0dXJuaW5nICJjcDg3NCIgZW5jb2Rpbmcgd2l0aCB3YXMgZHJvcHBlZCBpbiBy
MjA0NjA1IGZvciBub3QgYmVpbmcgcGFydCBvZiB0aGUKKyAgICAgICAgZW5jb2Rpbmcgc3BlY2lm
aWNhdGlvbiAoaHR0cHM6Ly9lbmNvZGluZy5zcGVjLndoYXR3Zy5vcmcvI25hbWVzLWFuZC1sYWJl
bHMpLgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCB3ZSBtYXAgImNwODc0IiBlbmNv
ZGluZyB0byB0aGUgImRvcy04NzQiIGVuY29kaW5nIHdoaWNoIGlzCisgICAgICAgIHByb3Blcmx5
IHJlY29nbml6ZWQuIFdpdGhvdXQgdGhpcywgdGhpcyBjb3VsZCBsZWFkIHRvIGlzc3VlIG9uIFdl
YlNpdGVzIHRoYXQgZG8gbm90CisgICAgICAgIHNwZWNpZnkgYSBjaGFyc2V0LgorCisgICAgICAg
ICogcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2RpbmdSZWdpc3RyeS5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpkZWZhdWx0VGV4dEVuY29kaW5nTmFtZUZvclN5c3RlbUxhbmd1YWdlKToKKwogMjAxNy0w
NC0yNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAg
ICAgIFJlZHVjZSBjb3BpZXMgYW5kIGFsbG9jYXRpb25zIGluIFNoYXJlZEJ1ZmZlcjo6YXBwZW5k
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZ1Jl
Z2lzdHJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVuY29kaW5nUmVn
aXN0cnkuY3BwCmluZGV4IGVhY2U2NDNhMzFmZWM5N2M2MDJjZDI4NzM4ODVjZmNiZDFhZTQ3NDQu
LjUwYzgxNjBhODIzY2ExNWIzYjMyNWNkMmExMjM3NTNmNDMxODNmNjkgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVuY29kaW5nUmVnaXN0cnkuY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVuY29kaW5nUmVnaXN0cnkuY3BwCkBA
IC0zNzcsNiArMzc3LDEzIEBAIFN0cmluZyBkZWZhdWx0VGV4dEVuY29kaW5nTmFtZUZvclN5c3Rl
bUxhbmd1YWdlKCkKICAgICAvLyBPbiBzb21lIE9TIHZlcnNpb25zLCB0aGUgcmVzdWx0IGlzIENQ
OTQ5ICh1cHBlcmNhc2UpLgogICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShz
eXN0ZW1FbmNvZGluZ05hbWUsICJjcDk0OSIpKQogICAgICAgICBzeXN0ZW1FbmNvZGluZ05hbWUg
PSBBU0NJSUxpdGVyYWwoImtzX2NfNTYwMS0xOTg3Iik7CisKKyAgICAvLyBDRlN0cmluZ0NvbnZl
cnRFbmNvZGluZ1RvSUFOQUNoYXJTZXROYW1lKCkgcmV0dXJucyBjcDg3NCBmb3Iga1RleHRFbmNv
ZGluZ0RPU1RoYWksIEFLQSB3aW5kb3dzLTg3NC4KKyAgICAvLyBTaW5jZSAiY3A4NzQiIGFsaWFz
IGlzIG5vdCBzdGFuZGFyZCAoaHR0cHM6Ly9lbmNvZGluZy5zcGVjLndoYXR3Zy5vcmcvI25hbWVz
LWFuZC1sYWJlbHMpLCBtYXAgdG8KKyAgICAvLyAiZG9zLTg3NCIgaW5zdGVhZC4KKyAgICBpZiAo
ZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uoc3lzdGVtRW5jb2RpbmdOYW1lLCAiY3A4NzQi
KSkKKyAgICAgICAgc3lzdGVtRW5jb2RpbmdOYW1lID0gQVNDSUlMaXRlcmFsKCJkb3MtODc0Iik7
CisKICAgICByZXR1cm4gc3lzdGVtRW5jb2RpbmdOYW1lOwogI2Vsc2UKICAgICByZXR1cm4gQVND
SUlMaXRlcmFsKCJJU08tODg1OS0xIik7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>