171118 2017-04-21 10:29:50 -0700 X86-64 assembler doesn't handle xchg with byte register src 2017-04-21 11:28:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff buildbot fpizlo keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1299675 0 msaboff 2017-04-21 10:29:50 -0700 The Intel manual Vol 2A 3-3 shows that byte registers SPL and greater require a REX prefix byte. The is done with the X86Assembler function oneByteOp8(). Use of that function was omitted when the xchg8_*() functions was added. 1299679 1 webkit-bug-importer 2017-04-21 10:32:14 -0700 <rdar://problem/31760529> 1299684 2 307746 msaboff 2017-04-21 10:38:51 -0700 Created attachment 307746 Patch I did verify that all other byte ops use the *Op8() formatter function. 1299688 3 msaboff 2017-04-21 10:42:33 -0700 I fixed the spelling in the bug title, including the ChangeLog. 1299712 4 msaboff 2017-04-21 11:28:53 -0700 Committed r215618: <http://trac.webkit.org/changeset/215618> 307746 2017-04-21 10:38:51 -0700 2017-04-21 11:24:33 -0700 Patch 171118.patch text/plain 1544 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1NjE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE3LTA0LTIxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFg4Ni02NCBhYXNzZW1ibGVyIGRvZXNuJ3QgaGFuZGxlIHhjaGcgd2l0aCBieXRlIHJlZ2lz dGVyIHNyYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcxMTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxlcjo6 eGNoZ2Jfcm0pOiBVc2Ugb25lQnl0ZU9wOCgpIHNpbmNlIHRoZXNlIGFyZSA4IGJpdCBvcGNvZGVz LgorCiAyMDE3LTA0LTIwICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K IAogICAgICAgICBbY21ha2VdIERlZmluZSBGT1JXQVJESU5HX0hFQURFUlNfRElSIGluIFdlYktp dEZTIGFuZCB1c2UgaXQgZXZlcnl3aGVyZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9YODZBc3NlbWJsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCShyZXZpc2lvbiAyMTU2MTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCSh3b3JraW5nIGNvcHkpCkBA IC0yMTU2LDEyICsyMTU2LDEyIEBAIHB1YmxpYzoKIAogICAgIHZvaWQgeGNoZ2Jfcm0oUmVnaXN0 ZXJJRCBzcmMsIGludCBvZmZzZXQsIFJlZ2lzdGVySUQgYmFzZSkKICAgICB7Ci0gICAgICAgIG1f Zm9ybWF0dGVyLm9uZUJ5dGVPcChPUF9YQ0hHX0V2R2IsIHNyYywgYmFzZSwgb2Zmc2V0KTsKKyAg ICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9wOChPUF9YQ0hHX0V2R2IsIHNyYywgYmFzZSwgb2Zm c2V0KTsKICAgICB9CiAKICAgICB2b2lkIHhjaGdiX3JtKFJlZ2lzdGVySUQgc3JjLCBpbnQgb2Zm c2V0LCBSZWdpc3RlcklEIGJhc2UsIFJlZ2lzdGVySUQgaW5kZXgsIGludCBzY2FsZSkKICAgICB7 Ci0gICAgICAgIG1fZm9ybWF0dGVyLm9uZUJ5dGVPcChPUF9YQ0hHX0V2R2IsIHNyYywgYmFzZSwg aW5kZXgsIHNjYWxlLCBvZmZzZXQpOworICAgICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3A4KE9Q X1hDSEdfRXZHYiwgc3JjLCBiYXNlLCBpbmRleCwgc2NhbGUsIG9mZnNldCk7CiAgICAgfQogCiAg ICAgdm9pZCB4Y2hnd19ybShSZWdpc3RlcklEIHNyYywgaW50IG9mZnNldCwgUmVnaXN0ZXJJRCBi YXNlKQo=