171115 2017-04-21 09:09:54 -0700 [cmake] WTF target should not have wtf and subdirectries in public interface 2017-04-21 10:26:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167343 P2 Normal --- 1 annulen annulen lforschler mcatanzaro oldest_to_newest 1299636 0 annulen 2017-04-21 09:09:54 -0700 In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of targets as their public interface, so that linked targets can use them implicitly without copying directory lists around. This matches existing practice for all targets except WTF, headers from which are always included with full path starting from "<wtf/...". Since r209665 it became possible to include headers from wtf or its subdirectories in CMake builds without using "<wtf/..." path. It should not be allowed. 1299637 1 307735 annulen 2017-04-21 09:11:43 -0700 Created attachment 307735 Patch 1299670 2 307735 annulen 2017-04-21 10:26:09 -0700 Comment on attachment 307735 Patch Clearing flags on attachment: 307735 Committed r215614: <http://trac.webkit.org/changeset/215614> 1299671 3 annulen 2017-04-21 10:26:14 -0700 All reviewed patches have been landed. Closing bug. 307735 2017-04-21 09:11:43 -0700 2017-04-21 10:26:09 -0700 Patch bug-171115-20170421191142.patch text/plain 5982 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkZDI3ODE3MDQyZDcxYTU5MWU1NThh MDI5Y2RlM2YzMWY5ZDQ1ZjkuLmE4YWMzMzMxMmVmYTczNmEyZDFmYjBkMWM0ODI4Y2I0ZTY2ZjE2 NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTctMDQtMjEgIEtvbnN0YW50aW4gVG9rYXJldiAg PGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIFtjbWFrZV0gV1RGIHRhcmdldCBzaG91bGQg bm90IGhhdmUgd3RmIGFuZCBzdWJkaXJlY3RyaWVzIGluIHB1YmxpYyBpbnRlcmZhY2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTExNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyMDk2NjUgV0VC Q09SRV9GUkFNRVdPUksgbWFjcm8gc3RhcnRlZCB0byBleHBvcnQgSU5DTFVERV9ESVJFQ1RPUklF UyBvZgorICAgICAgICB0YXJnZXRzIGFzIHRoZWlyIHB1YmxpYyBpbnRlcmZhY2UsIHNvIHRoYXQg bGlua2VkIHRhcmdldHMgY2FuIHVzZSB0aGVtCisgICAgICAgIGltcGxpY2l0bHkgd2l0aG91dCBj b3B5aW5nIGRpcmVjdG9yeSBsaXN0cyBhcm91bmQuIFRoaXMgbWF0Y2hlcyBleGlzdGluZworICAg ICAgICBwcmFjdGljZSBmb3IgYWxsIHRhcmdldHMgZXhjZXB0IFdURiwgaGVhZGVycyBmcm9tIHdo aWNoIGFyZSBhbHdheXMgaW5jbHVkZWQKKyAgICAgICAgd2l0aCBmdWxsIHBhdGggc3RhcnRpbmcg ZnJvbSAiPHd0Zi8uLi4iLgorCisgICAgICAgIFNpbmNlIHIyMDk2NjUgaXQgYmVjYW1lIHBvc3Np YmxlIHRvIGluY2x1ZGUgaGVhZGVycyBmcm9tIHd0ZiBvciBpdHMKKyAgICAgICAgc3ViZGlyZWN0 b3JpZXMgaW4gQ01ha2UgYnVpbGRzIHdpdGhvdXQgdXNpbmcgIjx3dGYvLi4uIiBwYXRoLiBJdCBz aG91bGQKKyAgICAgICAgbm90IGJlIGFsbG93ZWQuCisKKyAgICAgICAgKiB3dGYvQ01ha2VMaXN0 cy50eHQ6IFdURi93dGYgYW5kIGl0cyBzdWRpcmVjdG9yaWVzIHNob3VsZCBub3QgYmUgaW4KKyAg ICAgICAgcHVibGljIGluY2x1ZGUgcGF0aHMgb2YgV1RGIHRhcmdldC4KKwogMjAxNy0wNC0yMCAg U2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgbm90Rm91bmQgaW50 byBpdHMgb3duIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MjUwNGQwNmM3NjU5Y2U0NGZlYmExNDg0OTRl OTBmMmFmNDY4ODIyLi42MTlhNjdkYjc1Y2Q4YTQ4OGJlZDBhNGRjNmE0NDNkNTYxOTNiODUyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTctMDQtMjEgIEtvbnN0YW50aW4gVG9rYXJl diAgPGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIFtjbWFrZV0gV1RGIHRhcmdldCBzaG91 bGQgbm90IGhhdmUgd3RmIGFuZCBzdWJkaXJlY3RyaWVzIGluIHB1YmxpYyBpbnRlcmZhY2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTExNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyMDk2NjUg V0VCQ09SRV9GUkFNRVdPUksgbWFjcm8gc3RhcnRlZCB0byBleHBvcnQgSU5DTFVERV9ESVJFQ1RP UklFUyBvZgorICAgICAgICB0YXJnZXRzIGFzIHRoZWlyIHB1YmxpYyBpbnRlcmZhY2UsIHNvIHRo YXQgbGlua2VkIHRhcmdldHMgY2FuIHVzZSB0aGVtCisgICAgICAgIGltcGxpY2l0bHkgd2l0aG91 dCBjb3B5aW5nIGRpcmVjdG9yeSBsaXN0cyBhcm91bmQuIFRoaXMgbWF0Y2hlcyBleGlzdGluZwor ICAgICAgICBwcmFjdGljZSBmb3IgYWxsIHRhcmdldHMgZXhjZXB0IFdURiwgaGVhZGVycyBmcm9t IHdoaWNoIGFyZSBhbHdheXMgaW5jbHVkZWQKKyAgICAgICAgd2l0aCBmdWxsIHBhdGggc3RhcnRp bmcgZnJvbSAiPHd0Zi8uLi4iLgorCisgICAgICAgIFNpbmNlIHIyMDk2NjUgaXQgYmVjYW1lIHBv c3NpYmxlIHRvIGluY2x1ZGUgaGVhZGVycyBmcm9tIHd0ZiBvciBpdHMKKyAgICAgICAgc3ViZGly ZWN0b3JpZXMgaW4gQ01ha2UgYnVpbGRzIHdpdGhvdXQgdXNpbmcgIjx3dGYvLi4uIiBwYXRoLiBJ dCBzaG91bGQKKyAgICAgICAgbm90IGJlIGFsbG93ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvVGlsZWRCYWNraW5nU3RvcmUuY3BwOiBGaXgKKyAg ICAgICAgaW5jb3JyZWN0IGluY2x1ZGUgb2YgV1RGIGhlYWRlci4KKwogMjAxNy0wNC0yMSAgVGlt b3RoeSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRXhwb3Nl IG9ic2N1cmVkIGluc2V0cyB0byB3ZWIgY29udGVudCAoYXMgInNhZmUgYXJlYSBpbnNldHMiKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV1RGL3d0 Zi9DTWFrZUxpc3RzLnR4dAppbmRleCAxYmFlM2JiOTBiMzcxMjBhNTFjNDg5OWQ5ODdkOGEzNDEy NTQwZDY3Li5mODhhNTcyZTllMTZjMGYyOWNlOWEyMTQwYjQ0ZWQ5OTEwNjIyOWJjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9D TWFrZUxpc3RzLnR4dApAQCAtMjg2LDYgKzI4NiwxMiBAQCBzZXQoV1RGX1NPVVJDRVMKIHNldChX VEZfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke0JNQUxMT0NfRElSfSIKICAgICAiJHtXVEZf RElSfSIKKyAgICAiJHtDTUFLRV9CSU5BUllfRElSfSIKKyAgICAiJHtERVJJVkVEX1NPVVJDRVNf RElSfSIKKyAgICAiJHtUSElSRFBBUlRZX0RJUn0iCispCisKK3NldChXVEZfUFJJVkFURV9JTkNM VURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V1RGX0RJUn0vd3RmIgogICAgICIke1dURl9ESVJ9L3d0 Zi9kdG9hIgogICAgICIke1dURl9ESVJ9L3d0Zi9wZXJzaXN0ZW5jZSIKQEAgLTI5Myw5ICsyOTks NiBAQCBzZXQoV1RGX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAiJHtXVEZfRElSfS93dGYvdGV4 dC9pY3UiCiAgICAgIiR7V1RGX0RJUn0vd3RmL3RocmVhZHMiCiAgICAgIiR7V1RGX0RJUn0vd3Rm L3VuaWNvZGUiCi0gICAgIiR7VEhJUkRQQVJUWV9ESVJ9IgotICAgICIke0NNQUtFX0JJTkFSWV9E SVJ9IgotICAgICIke0RFUklWRURfU09VUkNFU19ESVJ9IgogKQogCiBzZXQoV1RGX0xJQlJBUklF UwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nv b3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKaW5kZXgg YjYzODkxNjVhYzZiMTkxNWEzOTNjZjlmNGZkMDU0Njc3MTZmOWQ5MC4uZWNiMzFiNDU3ZTg0NzNh Mjg5NmM0OTc0ZjM3MTY1YTJlNTVlOGE5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQv VGlsZWRCYWNraW5nU3RvcmUuY3BwCkBAIC0yMiw5ICsyMiw5IEBACiAKICNpZiBVU0UoQ09PUkRJ TkFURURfR1JBUEhJQ1MpCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCi0jaW5jbHVkZSAi TWVtb3J5UHJlc3N1cmVIYW5kbGVyLmgiCiAjaW5jbHVkZSAiVGlsZWRCYWNraW5nU3RvcmVDbGll bnQuaCIKICNpbmNsdWRlIDx3dGYvQ2hlY2tlZEFyaXRobWV0aWMuaD4KKyNpbmNsdWRlIDx3dGYv TWVtb3J5UHJlc3N1cmVIYW5kbGVyLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApkaWZmIC0t Z2l0IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJL aXRNYWNyb3MuY21ha2UKaW5kZXggZGE4MTZiMmE5YzYwNzQ3YTEyYzg1M2FkZWU3NzMzMTVkYmQ1 Y2Q0My4uYTBlODFlZTUwZGRkNDBjZTU2NDQyNjNiNDU5M2I1ZDEwOTRjNDBhNiAxMDA2NDQKLS0t IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlCkBAIC0yODMsNiArMjgzLDcgQEAgbWFjcm8oV0VCS0lUX0ZSQU1FV09S SyBfdGFyZ2V0KQogICAgICAgICAkeyR7X3RhcmdldH1fU09VUkNFU30KICAgICApCiAgICAgdGFy Z2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMoJHtfdGFyZ2V0fSBQVUJMSUMgIiQ8QlVJTERfSU5URVJG QUNFOiR7JHtfdGFyZ2V0fV9JTkNMVURFX0RJUkVDVE9SSUVTfT4iKQorICAgIHRhcmdldF9pbmNs dWRlX2RpcmVjdG9yaWVzKCR7X3RhcmdldH0gUFJJVkFURSAiJDxCVUlMRF9JTlRFUkZBQ0U6JHsk e190YXJnZXR9X1BSSVZBVEVfSU5DTFVERV9ESVJFQ1RPUklFU30+IikKICAgICB0YXJnZXRfbGlu a19saWJyYXJpZXMoJHtfdGFyZ2V0fSAkeyR7X3RhcmdldH1fTElCUkFSSUVTfSkKICAgICBzZXRf dGFyZ2V0X3Byb3BlcnRpZXMoJHtfdGFyZ2V0fSBQUk9QRVJUSUVTIENPTVBJTEVfREVGSU5JVElP TlMgIkJVSUxESU5HXyR7X3RhcmdldH0iKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggNzYyOTNjY2YwOWQ1NDc0MGE0N2M3M2U1YjQ1MTM5YTQyYzkxYTY4Ni4uYjUw MjUwMTA2ZjZhOTI2NjUzNmM0NTU0NjNkODcyNjhmNzhkZTMxNiAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA0LTIxICBLb25zdGFu dGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBbY21ha2VdIFdURiB0 YXJnZXQgc2hvdWxkIG5vdCBoYXZlIHd0ZiBhbmQgc3ViZGlyZWN0cmllcyBpbiBwdWJsaWMgaW50 ZXJmYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzExMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ biByMjA5NjY1IFdFQkNPUkVfRlJBTUVXT1JLIG1hY3JvIHN0YXJ0ZWQgdG8gZXhwb3J0IElOQ0xV REVfRElSRUNUT1JJRVMgb2YKKyAgICAgICAgdGFyZ2V0cyBhcyB0aGVpciBwdWJsaWMgaW50ZXJm YWNlLCBzbyB0aGF0IGxpbmtlZCB0YXJnZXRzIGNhbiB1c2UgdGhlbQorICAgICAgICBpbXBsaWNp dGx5IHdpdGhvdXQgY29weWluZyBkaXJlY3RvcnkgbGlzdHMgYXJvdW5kLiBUaGlzIG1hdGNoZXMg ZXhpc3RpbmcKKyAgICAgICAgcHJhY3RpY2UgZm9yIGFsbCB0YXJnZXRzIGV4Y2VwdCBXVEYsIGhl YWRlcnMgZnJvbSB3aGljaCBhcmUgYWx3YXlzIGluY2x1ZGVkCisgICAgICAgIHdpdGggZnVsbCBw YXRoIHN0YXJ0aW5nIGZyb20gIjx3dGYvLi4uIi4KKworICAgICAgICBTaW5jZSByMjA5NjY1IGl0 IGJlY2FtZSBwb3NzaWJsZSB0byBpbmNsdWRlIGhlYWRlcnMgZnJvbSB3dGYgb3IgaXRzCisgICAg ICAgIHN1YmRpcmVjdG9yaWVzIGluIENNYWtlIGJ1aWxkcyB3aXRob3V0IHVzaW5nICI8d3RmLy4u LiIgcGF0aC4gSXQgc2hvdWxkCisgICAgICAgIG5vdCBiZSBhbGxvd2VkLgorCisgICAgICAgICog U291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZTogU3VwcG9ydCB4eHhfUFJJVkFURV9IRUFE RVJTCisgICAgICAgIENNYWtlIHZhcmlhYmxlcy4KKwogMjAxNy0wNC0yMCAgS29uc3RhbnRpbiBU b2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAgICAgICAgW2NtYWtlXSBEZWZpbmUgRk9S V0FSRElOR19IRUFERVJTX0RJUiBpbiBXZWJLaXRGUyBhbmQgdXNlIGl0IGV2ZXJ5d2hlcmUK