171112 2017-04-21 07:51:25 -0700 [GTK] Make the ENABLE_SUBTLE_CRYPTO option depend on libgcrypt 1.7.0 2017-04-24 11:10:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan jiewen_tan mcatanzaro oldest_to_newest 1299621 0 zan 2017-04-21 07:51:25 -0700 [GTK] Expose the ENABLE_SUBTLE_CRYPTO CMake option, have it depend on libgcrypt 1.7.0 1299623 1 307729 zan 2017-04-21 07:56:00 -0700 Created attachment 307729 Patch 1299631 2 307729 mcatanzaro 2017-04-21 08:52:33 -0700 Comment on attachment 307729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307729&action=review I think this should be renamed to ENABLE_WEB_CRYPTO before it's made public. > Source/cmake/OptionsGTK.cmake:142 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SUBTLE_CRYPTO PUBLIC OFF) Not ready to turn it ON yet? I think we should make it public in the same patch that we turn it ON. The point of making it public is to provide users a way to turn it off if they don't have new enough libgcrypt. If it's not ON by default, then no point in making it public yet. 1300311 3 307729 zan 2017-04-23 03:07:48 -0700 Comment on attachment 307729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307729&action=review >> Source/cmake/OptionsGTK.cmake:142 >> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SUBTLE_CRYPTO PUBLIC OFF) > > Not ready to turn it ON yet? > > I think we should make it public in the same patch that we turn it ON. The point of making it public is to provide users a way to turn it off if they don't have new enough libgcrypt. If it's not ON by default, then no point in making it public yet. No, we shouldn't turn it ON before completing the support and doing another round of reviews. 1300312 4 zan 2017-04-23 03:08:56 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 307729 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307729&action=review > > I think this should be renamed to ENABLE_WEB_CRYPTO before it's made public. > OK. 1300315 5 307929 zan 2017-04-23 03:51:39 -0700 Created attachment 307929 Patch 1300472 6 307929 zan 2017-04-24 06:15:37 -0700 Comment on attachment 307929 Patch Clearing flags on attachment: 307929 Committed r215681: <http://trac.webkit.org/changeset/215681> 1300473 7 zan 2017-04-24 06:15:41 -0700 All reviewed patches have been landed. Closing bug. 1300522 8 mcatanzaro 2017-04-24 09:20:05 -0700 Minor problem: cgarcia: Zan: btw, not a big deal but I have #define ENABLE_SUBTLE_CRYPTO 1 duplicated in cmakehader.h mcatanzaro: That's a regression from http://trac.webkit.org/changeset/215681/webkit mcatanzaro: We should not use SET_AND_EXPOSE_TO_BUILD there 1300574 9 zan 2017-04-24 11:10:30 -0700 (In reply to Michael Catanzaro from comment #8) > Minor problem: > > cgarcia: Zan: btw, not a big deal but I have #define ENABLE_SUBTLE_CRYPTO 1 > duplicated in cmakehader.h > mcatanzaro: That's a regression from > http://trac.webkit.org/changeset/215681/webkit > mcatanzaro: We should not use SET_AND_EXPOSE_TO_BUILD there Fixed in r215684. https://trac.webkit.org/changeset/215684/webkit 307729 2017-04-21 07:56:00 -0700 2017-04-23 03:51:35 -0700 Patch bug-171112-20170421165559.patch text/plain 2058 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGEyZjBl MTAyNGYwNTgzY2NmZDAxNGM0OTkwYjg2YjY5OTliNjEwMTguLjc5ZWVjOWFhZjRiM2U4NzVmODdj MTQzNzFkNWFkNmMxMmQ0ZjM5ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzksNiArMTM5 LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0lDT05EQVRBQkFT RSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfSklU IFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TQU1Q TElOR19QUk9GSUxFUiBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfU1BFTExDSEVDSyBQVUJMSUMgT04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfU1VCVExFX0NSWVBUTyBQVUJMSUMgT0ZGKQogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1RPVUNIX0VWRU5UUyBQVUJMSUMgT04pCiBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVklERU8gUFVCTElDIE9OKQogV0VCS0lU X09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9BVURJTyBQVUJMSUMgT04pCkBA IC0yNjgsNiArMjY5LDEyIEBAIGlmIChFTkFCTEVfTUVESUFfU1RSRUFNIE9SIEVOQUJMRV9XRUJf UlRDKQogICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9PUEVOV0VCUlRDIFRSVUUpCiBl bmRpZiAoKQogCitpZiAoRU5BQkxFX1NVQlRMRV9DUllQVE8pCisgICAgaWYgKExJQkdDUllQVF9W RVJTSU9OIFZFUlNJT05fTEVTUyAxLjcuMCkKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAi bGliZ2NyeXB0IDEuNy4wIGlzIHJlcXVpcmVkIHRvIGVuYWJsZSBXZWIgQ3J5cHRvIEFQSSBzdXBw b3J0LiIpCisgICAgZW5kaWYgKCkKK2VuZGlmICgpCisKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxE KFVTRV9URVhUVVJFX01BUFBFUiBUUlVFKQogCiBpZiAoRU5BQkxFX09QRU5HTCkKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3NjI5M2NjZjA5ZDU0NzQwYTQ3YzczZTVi NDUxMzlhNDJjOTFhNjg2Li5iYmY3NDMxMmY5Y2E1YTMyOTM2ZjVlOWVhN2Q1NWEyZjg2MWY2MGMw IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTctMDQtMjEgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIEV4cG9zZSB0aGUgRU5BQkxFX1NVQlRMRV9DUllQVE8gQ01ha2Ugb3B0aW9uLCBo YXZlIGl0IGRlcGVuZCBvbiBsaWJnY3J5cHQgMS43LjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6 IFB1YmxpY2x5IGV4cG9zZSB0aGUgRU5BQkxFX1NVQlRMRV9DUllQVE8gQ01ha2UKKyAgICAgICAg b3B0aW9uLCBzZXR0aW5nIGl0IHRvIG9mZiBieSBkZWZhdWx0LCBmb3Igbm93LiBXaGVuIGVuYWJs ZWQsIHRoZSBkZXRlY3RlZAorICAgICAgICBsaWJnY3J5cHQgbGlicmFyeSB2ZXJzaW9uIHNob3Vs ZCBiZSBhdCBsZWFzdCAxLjcuMCBzaW5jZSB3ZSdsbCBiZSByZWx5aW5nIG9uIEFQSQorICAgICAg ICB0aGF0IHdhcyBpbnRyb2R1Y2VkIGluIHRoYXQgdmVyc2lvbi4KKwogMjAxNy0wNC0yMCAgS29u c3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAgICAgICAgW2NtYWtlXSBE ZWZpbmUgRk9SV0FSRElOR19IRUFERVJTX0RJUiBpbiBXZWJLaXRGUyBhbmQgdXNlIGl0IGV2ZXJ5 d2hlcmUK 307929 2017-04-23 03:51:39 -0700 2017-04-24 06:15:37 -0700 Patch bug-171112-20170423125138.patch text/plain 1506 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGEyZjBl MTAyNGYwNTgzY2NmZDAxNGM0OTkwYjg2YjY5OTliNjEwMTguLjRkOGU1Nzc4NTdmMmNmMWU4NjJj YTIyOGY1YjUzMDAyZGIzODI5NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yNjgsNiArMjY4 LDEzIEBAIGlmIChFTkFCTEVfTUVESUFfU1RSRUFNIE9SIEVOQUJMRV9XRUJfUlRDKQogICAgIFNF VF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9PUEVOV0VCUlRDIFRSVUUpCiBlbmRpZiAoKQogCitp ZiAoRU5BQkxFX1NVQlRMRV9DUllQVE8pCisgICAgaWYgKExJQkdDUllQVF9WRVJTSU9OIFZFUlNJ T05fTEVTUyAxLjcuMCkKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAibGliZ2NyeXB0IDEu Ny4wIGlzIHJlcXVpcmVkIHRvIGVuYWJsZSBXZWIgQ3J5cHRvIEFQSSBzdXBwb3J0LiIpCisgICAg ZW5kaWYgKCkKKyAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChFTkFCTEVfU1VCVExFX0NSWVBU TyBUUlVFKQorZW5kaWYgKCkKKwogU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX1RFWFRVUkVf TUFQUEVSIFRSVUUpCiAKIGlmIChFTkFCTEVfT1BFTkdMKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IGY1YmJiMTQyYzMyMGM0M2QxNDllZDIzODdiMjU3ZGUyOTBlZmZh M2YuLmVmZDBiNWViZjIwYjIwNmNiOWU3MGYwNjhhOGZjYzZhNDBmNjk1NDEgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0wNC0yMyAg WmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gTWFr ZSB0aGUgRU5BQkxFX1NVQlRMRV9DUllQVE8gb3B0aW9uIGRlcGVuZCBvbiBsaWJnY3J5cHQgMS43 LjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTEx MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291 cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IFdoZW4gRU5BQkxFX1NVQlRMRV9DUllQVE8gZmVh dHVyZSBpcyBlbmFibGVkLAorICAgICAgICB0aGUgZGV0ZWN0ZWQgbGliZ2NyeXB0IGxpYnJhcnkg dmVyc2lvbiBzaG91bGQgYmUgYXQgbGVhc3QgMS43LjAgc2luY2Ugd2UnbGwgYmUKKyAgICAgICAg cmVseWluZyBvbiBBUEkgdGhhdCB3YXMgaW50cm9kdWNlZCBpbiB0aGF0IHZlcnNpb24uCisKIDIw MTctMDQtMjEgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgogCiAgICAg ICAgIFtjbWFrZV0gV1RGIHRhcmdldCBzaG91bGQgbm90IGhhdmUgd3RmIGFuZCBzdWJkaXJlY3Ry aWVzIGluIHB1YmxpYyBpbnRlcmZhY2UK