171095 2017-04-20 19:08:44 -0700 [MediaCapture][iOS] AVAudioSession must be active and the correct category before IO AudioUnits start producing data. 2017-04-22 11:38:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171168 1 jer.noble jer.noble commit-queue eric.carlson jer.noble webkit-bug-importer youennf oldest_to_newest 1299451 0 jer.noble 2017-04-20 19:08:44 -0700 [MediaCapture][iOS] AVAudioSession must be active and the correct category before IO AudioUnits start producing data. 1299460 1 307681 jer.noble 2017-04-20 19:19:25 -0700 Created attachment 307681 Patch 1299477 2 307681 youennf 2017-04-20 20:11:20 -0700 Comment on attachment 307681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307681&action=review > Source/WebCore/Modules/mediastream/MediaStream.cpp:448 > + if (m_private->hasAudio() && m_isProducingData && m_private->hasCaptureAudioSource()) It would seem logic to have m_private->hasAudio() if m_private->hasCaptureAudioSource(). Is there a redundant check? 1299789 3 307681 commit-queue 2017-04-21 12:59:10 -0700 Comment on attachment 307681 Patch Clearing flags on attachment: 307681 Committed r215626: <http://trac.webkit.org/changeset/215626> 1299790 4 commit-queue 2017-04-21 12:59:12 -0700 All reviewed patches have been landed. Closing bug. 307681 2017-04-20 19:19:25 -0700 2017-04-21 12:59:10 -0700 Patch bug-171095-20170420191924.patch text/plain 7090 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UzOGYyMjkyNzU0OWQ4 MGI1N2Q3MmYwYjI3NmNiY2ExZWQxOTNjZi4uYjIxYzJiNTlmMmU4MjBkNzM3NDhkZjczZWIwZmE5 MjY2YzZkMDhlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE3LTA0LTIwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYUNhcHR1cmVdW2lP U10gQVZBdWRpb1Nlc3Npb24gbXVzdCBiZSBhY3RpdmUgYW5kIHRoZSBjb3JyZWN0IGNhdGVnb3J5 IGJlZm9yZSBJTyBBdWRpb1VuaXRzIHN0YXJ0IHByb2R1Y2luZyBkYXRhLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxMDk1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgYW4gaW5wdXQgYXVkaW8gdW5p dCBpcyBhc2tlZCB0byBzdGFydCBiZWZvcmUgdGhlIEFWQXVkaW9TZXNzaW9uIGlzIGluIGEgcmVj b3JkaW5nIGNhdGVnb3J5IGFuZCBhY3RpdmUsCisgICAgICAgIENvcmVBdWRpbyB3aWxsIHJldHVy biBhbiBlcnJvciBzdGF0aW5nIHRoYXQgbm8gaW5wdXQgZGV2aWNlIGlzIGF2YWlsYWJsZS4KKwor ICAgICAgICBUaGUgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyIHdpbGwgYXV0b21hdGljYWxs eSBzZXQgdGhlIGNhdGVnb3J5IG9mIGFuZCBhY3RpdmF0ZSB0aGUgQVZBdWRpb1Nlc3Npb24gd2hl biBvbmUKKyAgICAgICAgb2YgaXRzIGFzc29jaWF0ZWQgTWVkaWFTdHJlYW1zIGhhcyBhIGNhcHR1 cmluZyBSZWFsdGltZU1lZGlhU291cmNlIGFuZCBpcyBjdXJyZW50bHkgcHJvZHVjaW5nIGRhdGEu ICBUbyBzb2x2ZQorICAgICAgICB0aGUgY2hpY2tlbi1vci1lZ2cgcHJvYmxlbSBvZiBhY3RpdmF0 aW5nIHRoZSBBVkF1ZGlvU2Vzc2lvbiBiZWZvcmUgdGhlIHNvdXJjZSBwcm9kdWNlcyBkYXRhLCBt b3ZlIHRoZSBzdGF0ZSBiaXQKKyAgICAgICAgb2YgInByb2R1Y2luZyBkYXRhIiBkaXJlY3RseSBp bnRvIE1lZGlhU3RyZWFtcywgYW5kIG5vdGlmeSB0aGUgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5h Z2VyIHRoYXQgY2FwdHVyaW5nIGlzCisgICAgICAgIG9jY3VycmluZyBhZnRlciBmbGlwcGluZyB0 aGF0IGJpdCwgYnV0IGJlZm9yZSBhc2tpbmcgdGhlIGNvbnN0aXR1ZW50IHRyYWNrcyB0byBiZWdp biBwcm9kdWNpbmcgZGF0YS4KKworICAgICAgICBJbiBwbGFjZXMgKGkuZS4gVXNlck1lZGlhUmVx dWVzdCkgd2hlcmUgd2UgcHJldmlvdXNseSB0b2xkIGEgc3RyZWFtJ3MgdHJhY2tzIHRvIGJlZ2lu IHByb2R1Y2luZyBkYXRhLCBpbnN0ZWFkCisgICAgICAgIGFsbG93IHRoZSBzdHJlYW0gdG8gaGFu ZGxlIHRoYXQgYnkgdGVsbGluZyBpdCB0byBwcm9kdWNlIGRhdGEgZGlyZWN0bHkuCisKKyAgICAg ICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhU3RyZWFtOjpzdGFydFByb2R1Y2luZ0RhdGEpOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFTdHJlYW06OnN0b3BQcm9kdWNpbmdEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh U3RyZWFtOjptZWRpYVN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtOjptZWRp YVR5cGUpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW06OmNoYXJhY3RlcmlzdGljcyk6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVN0cmVhbTo6Y2FuUHJvZHVjZUF1ZGlvKToKKyAgICAg ICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmg6CisgICAgICAgICogTW9kdWxl cy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVz ZXJNZWRpYVJlcXVlc3Q6OmFsbG93KToKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9t YWMvQ29yZUF1ZGlvQ2FwdHVyZVNvdXJjZS5oOgorCiAyMDE3LTA0LTIwICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG9uZSB1c2Ugb2YgdG9Q YXltZW50QXV0aG9yaXphdGlvblN0YXR1cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcAppbmRleCBiNDgxMWVhNWE0MTUyYTE5ZDE1ZmQ2 NTA5ZWUxZDc2ODgzMWRkZDlkLi45NWQyNTIwN2M1OGY1OTE1NWU5MmJlMThiM2MwNDUwYTQ4MWNj NDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlh U3RyZWFtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlh U3RyZWFtLmNwcApAQCAtMjk0LDExICsyOTQsMjMgQEAgdm9pZCBNZWRpYVN0cmVhbTo6c3RhcnRQ cm9kdWNpbmdEYXRhKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChtX2lzUHJv ZHVjaW5nRGF0YSkKKyAgICAgICAgcmV0dXJuOworICAgIG1faXNQcm9kdWNpbmdEYXRhID0gdHJ1 ZTsKKworICAgIG1fbWVkaWFTZXNzaW9uLT5jYW5Qcm9kdWNlQXVkaW9DaGFuZ2VkKCk7CisKICAg ICBtX3ByaXZhdGUtPnN0YXJ0UHJvZHVjaW5nRGF0YSgpOwogfQogCiB2b2lkIE1lZGlhU3RyZWFt OjpzdG9wUHJvZHVjaW5nRGF0YSgpCiB7CisgICAgaWYgKCFtX2lzUHJvZHVjaW5nRGF0YSkKKyAg ICAgICAgcmV0dXJuOworICAgIG1faXNQcm9kdWNpbmdEYXRhID0gZmFsc2U7CisKKyAgICBtX21l ZGlhU2Vzc2lvbi0+Y2FuUHJvZHVjZUF1ZGlvQ2hhbmdlZCgpOworCiAgICAgbV9wcml2YXRlLT5z dG9wUHJvZHVjaW5nRGF0YSgpOwogfQogCkBAIC0zMjQsNyArMzM2LDcgQEAgTWVkaWFQcm9kdWNl cjo6TWVkaWFTdGF0ZUZsYWdzIE1lZGlhU3RyZWFtOjptZWRpYVN0YXRlKCkgY29uc3QKICAgICBp ZiAobV9wcml2YXRlLT5oYXNBdWRpbygpKSB7CiAgICAgICAgIHN0YXRlIHw9IEhhc0F1ZGlvT3JW aWRlbzsKICAgICAgICAgaWYgKG1fcHJpdmF0ZS0+aGFzQ2FwdHVyZUF1ZGlvU291cmNlKCkpIHsK LSAgICAgICAgICAgIGlmIChtX3ByaXZhdGUtPmlzUHJvZHVjaW5nRGF0YSgpKQorICAgICAgICAg ICAgaWYgKG1faXNQcm9kdWNpbmdEYXRhKQogICAgICAgICAgICAgICAgIHN0YXRlIHw9IEhhc0Fj dGl2ZUF1ZGlvQ2FwdHVyZURldmljZTsKICAgICAgICAgICAgIGVsc2UgaWYgKG1fcHJpdmF0ZS0+ bXV0ZWQoKSkKICAgICAgICAgICAgICAgICBzdGF0ZSB8PSBIYXNNdXRlZEF1ZGlvQ2FwdHVyZURl dmljZTsKQEAgLTMzNCw3ICszNDYsNyBAQCBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0YXRlRmxhZ3Mg TWVkaWFTdHJlYW06Om1lZGlhU3RhdGUoKSBjb25zdAogICAgIGlmIChtX3ByaXZhdGUtPmhhc1Zp ZGVvKCkpIHsKICAgICAgICAgc3RhdGUgfD0gSGFzQXVkaW9PclZpZGVvOwogICAgICAgICBpZiAo bV9wcml2YXRlLT5oYXNDYXB0dXJlVmlkZW9Tb3VyY2UoKSkgewotICAgICAgICAgICAgaWYgKG1f cHJpdmF0ZS0+aXNQcm9kdWNpbmdEYXRhKCkpCisgICAgICAgICAgICBpZiAobV9pc1Byb2R1Y2lu Z0RhdGEpCiAgICAgICAgICAgICAgICAgc3RhdGUgfD0gSGFzQWN0aXZlVmlkZW9DYXB0dXJlRGV2 aWNlOwogICAgICAgICAgICAgZWxzZSBpZiAobV9wcml2YXRlLT5tdXRlZCgpKQogICAgICAgICAg ICAgICAgIHN0YXRlIHw9IEhhc011dGVkVmlkZW9DYXB0dXJlRGV2aWNlOwpAQCAtNDMzLDcgKzQ0 NSw3IEBAIFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpNZWRpYVR5cGUgTWVkaWFTdHJlYW06Om1lZGlh VHlwZSgpIGNvbnN0CiB7CiAgICAgLy8gV2Ugb25seSBuZWVkIHRvIG92ZXJyaWRlIHRoZSB0eXBl IHdoZW4gY2FwdHVyaW5nIGF1ZGlvLCBIVE1MTWVkaWFFbGVtZW50IGFuZC9vciBXZWJBdWRpbwog ICAgIC8vIHdpbGwgZG8gdGhlIHJpZ2h0IHRoaW5nIHdoZW4gYSBzdHJlYW0gaXMgYXR0YWNoZWQg dG8gYSBtZWRpYSBlbGVtZW50IG9yIGFuIGF1ZGlvIGNvbnRleHQuCi0gICAgaWYgKG1fcHJpdmF0 ZS0+aGFzQXVkaW8oKSAmJiBtX3ByaXZhdGUtPmlzUHJvZHVjaW5nRGF0YSgpICYmIG1fcHJpdmF0 ZS0+aGFzQ2FwdHVyZUF1ZGlvU291cmNlKCkpCisgICAgaWYgKG1fcHJpdmF0ZS0+aGFzQXVkaW8o KSAmJiBtX2lzUHJvZHVjaW5nRGF0YSAmJiBtX3ByaXZhdGUtPmhhc0NhcHR1cmVBdWRpb1NvdXJj ZSgpKQogICAgICAgICByZXR1cm4gUGxhdGZvcm1NZWRpYVNlc3Npb246Ok1lZGlhU3RyZWFtQ2Fw dHVyaW5nQXVkaW87CiAKICAgICByZXR1cm4gUGxhdGZvcm1NZWRpYVNlc3Npb246Ok5vbmU7CkBA IC00NDgsNyArNDYwLDcgQEAgUGxhdGZvcm1NZWRpYVNlc3Npb246OkNoYXJhY3RlcmlzdGljc0Zs YWdzIE1lZGlhU3RyZWFtOjpjaGFyYWN0ZXJpc3RpY3MoKSBjb25zdAogewogICAgIFBsYXRmb3Jt TWVkaWFTZXNzaW9uOjpDaGFyYWN0ZXJpc3RpY3NGbGFncyBzdGF0ZSA9IFBsYXRmb3JtTWVkaWFT ZXNzaW9uOjpIYXNOb3RoaW5nOwogCi0gICAgaWYgKCFtX3ByaXZhdGUtPmlzUHJvZHVjaW5nRGF0 YSgpKQorICAgIGlmICghbV9pc1Byb2R1Y2luZ0RhdGEpCiAgICAgICAgIHJldHVybiBzdGF0ZTsK IAogICAgIGlmIChtX3ByaXZhdGUtPmhhc0F1ZGlvKCkpCkBAIC00ODMsNyArNDk1LDcgQEAgU3Ry aW5nIE1lZGlhU3RyZWFtOjpzb3VyY2VBcHBsaWNhdGlvbklkZW50aWZpZXIoKSBjb25zdAogCiBi b29sIE1lZGlhU3RyZWFtOjpjYW5Qcm9kdWNlQXVkaW8oKSBjb25zdAogewotICAgIHJldHVybiAh bXV0ZWQoKSAmJiBhY3RpdmUoKSAmJiBtX3ByaXZhdGUtPmhhc0F1ZGlvKCkgJiYgbV9wcml2YXRl LT5pc1Byb2R1Y2luZ0RhdGEoKTsKKyAgICByZXR1cm4gIW11dGVkKCkgJiYgYWN0aXZlKCkgJiYg bV9wcml2YXRlLT5oYXNBdWRpbygpICYmIG1faXNQcm9kdWNpbmdEYXRhOwogfQogCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL01lZGlhU3RyZWFtLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L01lZGlhU3RyZWFtLmgKaW5kZXggNTI1NzcxZDNkYTFmYzMxMDNiN2Q2NjAzNDg1ZDY3ZWNiMzg5 NDc5OS4uZjZlMDRhMjM1NGFkMzdjZWRlYmJhZjAxODkyYzg3NWUzY2YxZWFiNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0uaApAQCAtMTc0 LDYgKzE3NCw3IEBAIHByaXZhdGU6CiAKICAgICBib29sIG1faXNBY3RpdmUgeyBmYWxzZSB9Owog ICAgIGJvb2wgbV9pc011dGVkIHsgdHJ1ZSB9OworICAgIGJvb2wgbV9pc1Byb2R1Y2luZ0RhdGEg eyBmYWxzZSB9OwogICAgIGJvb2wgbV9pc1dhaXRpbmdVbnRpbE1lZGlhQ2FuU3RhcnQgeyBmYWxz ZSB9OwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh bS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKaW5kZXggNjkzZThmZGEyYzU2NTBiMDZiMmM5YWI1ZGRi NWZmY2Y3ZjNiMDc1Ni4uNmViNDE5NDFhNzI0NWEyMTZkNzA4NDQ2NDk1NjNmNjBlOGY4YzY1NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFS ZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJN ZWRpYVJlcXVlc3QuY3BwCkBAIC0xNzQsMTEgKzE3NCw3IEBAIHZvaWQgVXNlck1lZGlhUmVxdWVz dDo6YWxsb3coY29uc3QgU3RyaW5nJiBhdWRpb0RldmljZVVJRCwgY29uc3QgU3RyaW5nJiB2aWRl b0RlCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBmb3IgKGF1dG8m IHRyYWNrIDogc3RyZWFtLT5nZXRBdWRpb1RyYWNrcygpKQotICAgICAgICAgICAgdHJhY2stPnNv dXJjZSgpLnN0YXJ0UHJvZHVjaW5nRGF0YSgpOwotCi0gICAgICAgIGZvciAoYXV0byYgdHJhY2sg OiBzdHJlYW0tPmdldFZpZGVvVHJhY2tzKCkpCi0gICAgICAgICAgICB0cmFjay0+c291cmNlKCku c3RhcnRQcm9kdWNpbmdEYXRhKCk7CisgICAgICAgIHN0cmVhbS0+c3RhcnRQcm9kdWNpbmdEYXRh KCk7CiAgICAgICAgIAogICAgICAgICBtX3Byb21pc2UucmVzb2x2ZShzdHJlYW0pOwogICAgIH07 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQ29y ZUF1ZGlvQ2FwdHVyZVNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJl YW0vbWFjL0NvcmVBdWRpb0NhcHR1cmVTb3VyY2UuaAppbmRleCAzOTY5ZjJkMzBmOGNjOWQ1MTJi NTUxYjM2MGFkYmQ5NDZkNWI0MWUzLi45MDhmMmM1NTNmMTFkNTYzYjcyODllNTdiOWJhZjkyNWZj ZmU2ODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9t YWMvQ29yZUF1ZGlvQ2FwdHVyZVNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJlU291cmNlLmgKQEAgLTcxLDYgKzcxLDcg QEAgcHJpdmF0ZToKICAgICBDb3JlQXVkaW9DYXB0dXJlU291cmNlKGNvbnN0IFN0cmluZyYgZGV2 aWNlSUQpOwogICAgIHZpcnR1YWwgfkNvcmVBdWRpb0NhcHR1cmVTb3VyY2UoKTsKIAorICAgIGJv b2wgaXNDYXB0dXJlU291cmNlKCkgY29uc3QgZmluYWwgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZv aWQgc3RhcnRQcm9kdWNpbmdEYXRhKCkgZmluYWw7CiAgICAgdm9pZCBzdG9wUHJvZHVjaW5nRGF0 YSgpIGZpbmFsOwogICAgIGJvb2wgaXNQcm9kdWNpbmdEYXRhKCkgY29uc3QgZmluYWwgeyByZXR1 cm4gbV9pb1VuaXRTdGFydGVkOyB9Cg==