171087 2017-04-20 16:00:43 -0700 com.apple.WebCore: non-virtual thunk to WebCore::LibWebRTCDataChannelHandler::OnBufferedAmountChange + 39 2017-04-21 17:56:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170701 InRadar P2 Normal --- 1 ryanhaddad youennf achristensen commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1299357 0 ryanhaddad 2017-04-20 16:00:43 -0700 This is a flaky crash seen with webrtc/datachannel/bufferedAmountLowThreshold.html Thread 17 Crashed:: Thread 0x0x7ff7a13a05 0 com.apple.WebCore 0x000000010e949ff7 non-virtual thunk to WebCore::LibWebRTCDataChannelHandler::OnBufferedAmountChange(unsigned long long) + 39 1 libwebrtc.dylib 0x000000010b529d05 webrtc::DataChannel::OnChannelReady(bool) + 37 (datachannel.cc:409) 2 libwebrtc.dylib 0x000000010b54fefe webrtc::WebRtcSession::OnSctpTransportReadyToSendData_s(bool) + 62 (webrtcsession.cc:1970) 3 libwebrtc.dylib 0x000000010b3f3fa4 rtc::AsyncInvoker::OnMessage(rtc::Message*) + 20 (asyncinvoker.cc:44) 4 libwebrtc.dylib 0x000000010b4d191f rtc::MessageQueue::Dispatch(rtc::Message*) + 255 (messagequeue.cc:539) 5 libwebrtc.dylib 0x000000010b5f8cdc rtc::Thread::Run() + 124 (thread.cc:327) 6 libwebrtc.dylib 0x000000010b5f897a rtc::Thread::PreRun(void*) + 170 (thread.cc:318) 7 libsystem_pthread.dylib 0x00007fffdc0fa9af _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffdc0fa8fb _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffdc0fa101 thread_start + 13 https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r215564%20(856)/webrtc/datachannel/bufferedAmountLowThreshold-crash-log.txt https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fdatachannel%2FbufferedAmountLowThreshold.html 1299360 1 ryanhaddad 2017-04-20 16:01:10 -0700 <rdar://problem/31739051> 1299895 2 307808 youennf 2017-04-21 14:25:41 -0700 Created attachment 307808 Patch 1300039 3 307808 commit-queue 2017-04-21 17:56:08 -0700 Comment on attachment 307808 Patch Clearing flags on attachment: 307808 Committed r215658: <http://trac.webkit.org/changeset/215658> 1300040 4 commit-queue 2017-04-21 17:56:25 -0700 All reviewed patches have been landed. Closing bug. 307808 2017-04-21 14:25:41 -0700 2017-04-21 17:56:08 -0700 Patch bug-171087-20170421142540.patch text/plain 4165 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzk1MGJmZmY4NjI4Y2E2 MmY4NDMyZGRjNGZlNTUwN2U3NWQyZmI0YS4uNWE0ZmJhNmIxOWQ5ZjQ5NmU1YjU3N2QxZmRmMTli OWQxODBjMjVlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE3LTA0LTIxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBjb20uYXBwbGUuV2ViQ29y ZTogbm9uLXZpcnR1YWwgdGh1bmsgdG8gV2ViQ29yZTo6TGliV2ViUlRDRGF0YUNoYW5uZWxIYW5k bGVyOjpPbkJ1ZmZlcmVkQW1vdW50Q2hhbmdlICsgMzkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTA4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzE3MzkwNTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKyAgICAgICAgTm8gdGVzdCBhZGRlZCBhcyB0 aGlzIGJlaGF2aW9yIGlzIHJlYWxseSBsaWJ3ZWJydGMgc3BlY2lmaWMgYW5kIGNhbm5vdCBiZSB0 cmlnZ2VyZWQgZWFzaWx5LgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENEYXRh Q2hhbm5lbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSVENEYXRhQ2hhbm5lbDo6Y2xvc2UpOiBT dG9wcGluZyBvYnNlcnZpbmcgbGlid2VicnRjIGRhdGEgY2hhbm5lbCBiZWZvcmUgY2xvc2luZyBp dC4KKyAgICAgICAgVGhpcyBlbnN1cmVzIHdlIHdpbGwgc3RvcCBnZXR0aW5nIG5vdGlmaWVkIGFz IHNvb24gYXMgdGhlcmUgaXMgbm8gbW9yZSBpbnRlcmVzdC4KKyAgICAgICAgKiBNb2R1bGVzL21l ZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TGliV2ViUlRDRGF0YUNoYW5uZWxIYW5kbGVyOjpPblN0YXRlQ2hhbmdl KTogbGlid2VicnRjIGNhbiBzdGlsbCBub3RpZnkgdXMgZXZlbiB0aG91Z2ggd2Ugc2FpZCB3ZSB3 ZXJlCisgICAgICAgIG5vdCBpbnRlcmVzdGVkLiBFbnN1cmluZyB3ZSBkbyBub3QgY2FsbCB0aGUg Y2xpZW50IGlmIHdlIGFyZSBubyBsb25nZXIgaW50ZXJlc3RlZC4KKyAgICAgICAgKFdlYkNvcmU6 OkxpYldlYlJUQ0RhdGFDaGFubmVsSGFuZGxlcjo6T25NZXNzYWdlKTogRGl0dG8uCisgICAgICAg IChXZWJDb3JlOjpMaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXI6Ok9uQnVmZmVyZWRBbW91bnRD aGFuZ2UpOiBEaXR0by4KKworMjAxNy0wNC0yMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CisKICAgICAgICAgU2V0IGRlZmF1bHRzIHZpZGVvIGdldFVzZXJNZWRpYSBjb25zdHJh aW50cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcx MTI3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRD RGF0YUNoYW5uZWwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENE YXRhQ2hhbm5lbC5jcHAKaW5kZXggZjBkYzM0NTNhMWZmMTdmYWMzODFiMjljMzcyOGEwMThkZTk3 OTY5Yy4uNWM0YWU0Njk5NmQ2NjM4NTViOGU2Njk3ZjdhNGY1MmRlZWRiYzE0NiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENEYXRhQ2hhbm5lbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENEYXRhQ2hhbm5lbC5j cHAKQEAgLTE1OCw4ICsxNTgsOCBAQCB2b2lkIFJUQ0RhdGFDaGFubmVsOjpjbG9zZSgpCiAgICAg bV9zdG9wcGVkID0gdHJ1ZTsKICAgICBtX3JlYWR5U3RhdGUgPSBSVENEYXRhQ2hhbm5lbFN0YXRl OjpDbG9zZWQ7CiAKLSAgICBtX2hhbmRsZXItPmNsb3NlKCk7CiAgICAgbV9oYW5kbGVyLT5zZXRD bGllbnQobnVsbHB0cik7CisgICAgbV9oYW5kbGVyLT5jbG9zZSgpOwogICAgIG1faGFuZGxlciA9 IG51bGxwdHI7CiAgICAgdW5zZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENE YXRhQ2hhbm5lbEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh bS9saWJ3ZWJydGMvTGliV2ViUlRDRGF0YUNoYW5uZWxIYW5kbGVyLmNwcAppbmRleCA0Mjk2ZDc1 NTQzZTg3OWVhODBhMjQ4YzkzYTU3OWNlNmU5MjJkNjc3Li40YzM2MTM3Zjg4OWU0YmQ5MzQxNGUx ZDA2NzkyZGQ4NjA5MDg4Y2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0Rh dGFDaGFubmVsSGFuZGxlci5jcHAKQEAgLTY0LDYgKzY0LDkgQEAgdm9pZCBMaWJXZWJSVENEYXRh Q2hhbm5lbEhhbmRsZXI6OmNsb3NlKCkKIAogdm9pZCBMaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRs ZXI6Ok9uU3RhdGVDaGFuZ2UoKQogeworICAgIGlmICghbV9jbGllbnQpCisgICAgICAgIHJldHVy bjsKKwogICAgIFJUQ0RhdGFDaGFubmVsU3RhdGUgc3RhdGU7CiAgICAgc3dpdGNoIChtX2NoYW5u ZWwtPnN0YXRlKCkpIHsKICAgICBjYXNlIHdlYnJ0Yzo6RGF0YUNoYW5uZWxJbnRlcmZhY2U6OmtD b25uZWN0aW5nOgpAQCAtNzksNyArODIsNiBAQCB2b2lkIExpYldlYlJUQ0RhdGFDaGFubmVsSGFu ZGxlcjo6T25TdGF0ZUNoYW5nZSgpCiAgICAgICAgIHN0YXRlID0gUlRDRGF0YUNoYW5uZWxTdGF0 ZTo6Q2xvc2VkOwogICAgICAgICBicmVhazsKICAgICB9Ci0gICAgQVNTRVJUKG1fY2xpZW50KTsK ICAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90ZWN0ZWRDbGllbnQgPSBtYWtlUmVmKCptX2NsaWVu dCksIHN0YXRlXSB7CiAgICAgICAgIHByb3RlY3RlZENsaWVudC0+ZGlkQ2hhbmdlUmVhZHlTdGF0 ZShzdGF0ZSk7CiAgICAgfSk7CkBAIC04Nyw3ICs4OSw5IEBAIHZvaWQgTGliV2ViUlRDRGF0YUNo YW5uZWxIYW5kbGVyOjpPblN0YXRlQ2hhbmdlKCkKIAogdm9pZCBMaWJXZWJSVENEYXRhQ2hhbm5l bEhhbmRsZXI6Ok9uTWVzc2FnZShjb25zdCB3ZWJydGM6OkRhdGFCdWZmZXImIGJ1ZmZlcikKIHsK LSAgICBBU1NFUlQobV9jbGllbnQpOworICAgIGlmICghbV9jbGllbnQpCisgICAgICAgIHJldHVy bjsKKwogICAgIHN0ZDo6dW5pcXVlX3B0cjx3ZWJydGM6OkRhdGFCdWZmZXI+IHByb3RlY3RlZEJ1 ZmZlcihuZXcgd2VicnRjOjpEYXRhQnVmZmVyKGJ1ZmZlcikpOwogICAgIGNhbGxPbk1haW5UaHJl YWQoW3Byb3RlY3RlZENsaWVudCA9IG1ha2VSZWYoKm1fY2xpZW50KSwgYnVmZmVyID0gV1RGTW92 ZShwcm90ZWN0ZWRCdWZmZXIpXSB7CiAgICAgICAgIC8vIEZJWE1FOiBFbnN1cmUgdGhpcyBpcyBj b3JyZWN0IGJ5IGFkZGluZyBzb21lIHRlc3RzIHdpdGggbm9uLUFTQ0lJIGNoYXJhY3RlcnMuCkBA IC0xMDEsOSArMTA1LDEyIEBAIHZvaWQgTGliV2ViUlRDRGF0YUNoYW5uZWxIYW5kbGVyOjpPbk1l c3NhZ2UoY29uc3Qgd2VicnRjOjpEYXRhQnVmZmVyJiBidWZmZXIpCiAKIHZvaWQgTGliV2ViUlRD RGF0YUNoYW5uZWxIYW5kbGVyOjpPbkJ1ZmZlcmVkQW1vdW50Q2hhbmdlKHVpbnQ2NF90IHByZXZp b3VzQW1vdW50KQogeworICAgIGlmICghbV9jbGllbnQpCisgICAgICAgIHJldHVybjsKKwogICAg IGlmIChwcmV2aW91c0Ftb3VudCA8PSBtX2NoYW5uZWwtPmJ1ZmZlcmVkX2Ftb3VudCgpKQogICAg ICAgICByZXR1cm47Ci0gICAgQVNTRVJUKG1fY2xpZW50KTsKKwogICAgIGNhbGxPbk1haW5UaHJl YWQoW3Byb3RlY3RlZENsaWVudCA9IG1ha2VSZWYoKm1fY2xpZW50KSwgYW1vdW50ID0gbV9jaGFu bmVsLT5idWZmZXJlZF9hbW91bnQoKV0gewogICAgICAgICBwcm90ZWN0ZWRDbGllbnQtPmJ1ZmZl cmVkQW1vdW50SXNEZWNyZWFzaW5nKHN0YXRpY19jYXN0PHNpemVfdD4oYW1vdW50KSk7CiAgICAg fSk7Cg==