171028 2017-04-19 18:49:55 -0700 -Wformat warning on HistoryController.cpp:295:5 2017-04-20 14:57:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply buildbot cdumez dbates japhet mcatanzaro oldest_to_newest 1298958 0 mcatanzaro 2017-04-19 18:49:55 -0700 Cannot use enum as int without a cast: [881/3415] Building CXX object Source/...ore.dir/loader/HistoryController.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:34:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/loader/HistoryController.cpp:31: ../../Source/WebCore/loader/HistoryController.cpp: In member function ‘void WebCore::HistoryController::goToItem(WebCore::HistoryItem&, WebCore::FrameLoadType)’: ../../Source/WTF/wtf/Assertions.h:407:68: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘WebCore::FrameLoadType’ [-Wformat=] #define LOG(channel, ...) WTFLog(&LOG_CHANNEL(channel), __VA_ARGS__) ^ ../../Source/WebCore/loader/HistoryController.cpp:295:5: note: in expansion of macro ‘LOG’ LOG(History, "HistoryController %p goToItem %p type=%d", this, &targetItem, type); ^~~ 1298959 1 307539 mcatanzaro 2017-04-19 18:51:04 -0700 Created attachment 307539 Patch 1298994 2 307539 dbates 2017-04-19 21:33:50 -0700 Comment on attachment 307539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307539&action=review I am assuming that -Wall does not include -Wformat and that we do not enable -Wformat on the Mac, iOS, or Windows bots as I have not seen this failure. We should look to enable -Wformat on these bots. > Source/WebCore/ChangeLog:7 > + Please explain the change. 1299144 3 mcatanzaro 2017-04-20 09:46:57 -0700 (In reply to Daniel Bates from comment #2) > Comment on attachment 307539 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307539&action=review > > I am assuming that -Wall does not include -Wformat No, -Wall does include -Wformat (at least in GCC). > and that we do not enable > -Wformat on the Mac, iOS, or Windows bots as I have not seen this failure. > We should look to enable -Wformat on these bots. I don't know about that. Certainly the Apple builds seem to be less-strict about such issues. > > Source/WebCore/ChangeLog:7 > > + > > Please explain the change. Aw man. :P 1299315 4 mcatanzaro 2017-04-20 14:57:03 -0700 Committed r215580: <http://trac.webkit.org/changeset/215580> 307539 2017-04-19 18:51:04 -0700 2017-04-19 21:34:05 -0700 Patch bug-171028-20170419205103.patch text/plain 1462 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjYyYWJmZGY1NGZmMWMy NDVjZGExZDA5MDE2MjAxY2Q2MzE1YzQwNi4uYTAzZjRlODE1MTJiMTgxNTJjODc2YmNkMGQ5MmVl MTc2NTAwZmJiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA0LTE5ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV2Zvcm1h dCB3YXJuaW5nIG9uIEhpc3RvcnlDb250cm9sbGVyLmNwcDoyOTU6NQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxMDI4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xs ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6OmdvVG9JdGVtKToK KwogMjAxNy0wNC0xOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFN0b3AgdXNpbmcgZGVwcmVjYXRlZCBBUElzLCBwYXJ0IDMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCmluZGV4IDQ0NDdjNzdiNmVjYjhmNWI4MDU3 OGQ5YWMxZGFiYmMzMWVhNzBhNTguLjZiOWZkM2JmNzY5NDgyMDdiNDBkOTMxYzg4YWMyYTEyYzU4 OTRiMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcApA QCAtMjkyLDcgKzI5Miw3IEBAIGJvb2wgSGlzdG9yeUNvbnRyb2xsZXI6OnNob3VsZFN0b3BMb2Fk aW5nRm9ySGlzdG9yeUl0ZW0oSGlzdG9yeUl0ZW0mIHRhcmdldEl0ZW0pCiAvLyBUaGlzIGluY2x1 ZGVzIHJlY3Vyc2lvbiB0byBoYW5kbGUgbG9hZGluZyBpbnRvIGZyYW1lc2V0cyBwcm9wZXJseQog dm9pZCBIaXN0b3J5Q29udHJvbGxlcjo6Z29Ub0l0ZW0oSGlzdG9yeUl0ZW0mIHRhcmdldEl0ZW0s IEZyYW1lTG9hZFR5cGUgdHlwZSkKIHsKLSAgICBMT0coSGlzdG9yeSwgIkhpc3RvcnlDb250cm9s bGVyICVwIGdvVG9JdGVtICVwIHR5cGU9JWQiLCB0aGlzLCAmdGFyZ2V0SXRlbSwgdHlwZSk7Cisg ICAgTE9HKEhpc3RvcnksICJIaXN0b3J5Q29udHJvbGxlciAlcCBnb1RvSXRlbSAlcCB0eXBlPSVk IiwgdGhpcywgJnRhcmdldEl0ZW0sIHN0YXRpY19jYXN0PGludD4odHlwZSkpOwogCiAgICAgQVNT RVJUKCFtX2ZyYW1lLnRyZWUoKS5wYXJlbnQoKSk7CiAgICAgCg==