171024 2017-04-19 18:07:26 -0700 [Win] REGRESSION(r215486): Windows Release build is broken 2017-04-20 13:15:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 65589 1 bfulgham bfulgham ap bfulgham buildbot commit-queue fujii keith_miller mark.lam msaboff pvollan ryanhaddad saam webkit-bug-importer oldest_to_newest 1298939 0 bfulgham 2017-04-19 18:07:26 -0700 Threading the isolatedWorld state through the event handling caused the Release build of Windows WebKit to become upset that it could not find Heap::vm() and Heap::mutatorFence. This patch exposes these two methods so that the linker is happy. 1298940 1 webkit-bug-importer 2017-04-19 18:08:11 -0700 <rdar://problem/31722618> 1298942 2 307534 bfulgham 2017-04-19 18:09:25 -0700 Created attachment 307534 Patch 1298947 3 307534 mark.lam 2017-04-19 18:12:24 -0700 Comment on attachment 307534 Patch This is not right because these 2 methods are inlined methods. There's nothing to link against. 1298948 4 mark.lam 2017-04-19 18:12:41 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 307534 [details] > Patch > > This is not right because these 2 methods are inlined methods. There's > nothing to link against. See HeapInlines.h. 1298950 5 bfulgham 2017-04-19 18:16:13 -0700 (In reply to Mark Lam from comment #4) > (In reply to Mark Lam from comment #3) > > Comment on attachment 307534 [details] > > Patch > > > > This is not right because these 2 methods are inlined methods. There's > > nothing to link against. > > See HeapInlines.h. So should WebKit/win/... sources be including HeapInlines.h, or is some JSC header supposed to be including it, and isn't? 1298951 6 307536 bfulgham 2017-04-19 18:22:30 -0700 Created attachment 307536 Patch v2 1298967 7 307536 mark.lam 2017-04-19 19:26:42 -0700 Comment on attachment 307536 Patch v2 r=me. I think this is fine. Alternatively, you can #include <JavaScriptCore/JSCInlines.h> which will include many inline goodies. #include'ing HeapInlines.h is probably best for now. JSCInlines.h is recommended if you need to include multiple *Inlines.h files. 1298995 8 307536 commit-queue 2017-04-19 21:37:00 -0700 Comment on attachment 307536 Patch v2 Clearing flags on attachment: 307536 Committed r215551: <http://trac.webkit.org/changeset/215551> 1298996 9 commit-queue 2017-04-19 21:37:02 -0700 All reviewed patches have been landed. Closing bug. 1299081 10 fujii 2017-04-20 02:54:58 -0700 Reopened. Still broken. 1299083 11 fujii 2017-04-20 02:56:53 -0700 This patch make Windows build happy. But, I'm not sure this is a right fix. diff --git a/Source/WebCore/bindings/js/JSDOMGlobalObject.h b/Source/WebCore/bindings/js/JSDOMGlobalObject.h index fb63f24..d07d17b 100644 --- a/Source/WebCore/bindings/js/JSDOMGlobalObject.h +++ b/Source/WebCore/bindings/js/JSDOMGlobalObject.h @@ -28,6 +28,7 @@ #include "PlatformExportMacros.h" #include "WebCoreJSBuiltinInternals.h" +#include <heap/HeapInlines.h> #include <heap/LockDuringMarking.h> #include <runtime/JSGlobalObject.h> #include <runtime/StructureInlines.h> 1299121 12 bfulgham 2017-04-20 08:41:22 -0700 (In reply to Fujii Hironori from comment #11) > This patch make Windows build happy. But, I'm not sure this is a right fix. > > diff --git a/Source/WebCore/bindings/js/JSDOMGlobalObject.h > b/Source/WebCore/bindings/js/JSDOMGlobalObject.h > index fb63f24..d07d17b 100644 > --- a/Source/WebCore/bindings/js/JSDOMGlobalObject.h > +++ b/Source/WebCore/bindings/js/JSDOMGlobalObject.h > @@ -28,6 +28,7 @@ > > #include "PlatformExportMacros.h" > #include "WebCoreJSBuiltinInternals.h" > +#include <heap/HeapInlines.h> > #include <heap/LockDuringMarking.h> > #include <runtime/JSGlobalObject.h> > #include <runtime/StructureInlines.h> Another option might be to add "#include <JavaScriptCore/JSCInlines.h>" to the Source/WebKit/win/WebKitPrefix.h file. That would at least limit the change to the one platform that is unhappy. I'm trying that locally. 1299127 13 bfulgham 2017-04-20 08:49:41 -0700 (In reply to Brent Fulgham from comment #12) > Another option might be to add "#include <JavaScriptCore/JSCInlines.h>" to > the Source/WebKit/win/WebKitPrefix.h file. That would at least limit the > change to the one platform that is unhappy. > > I'm trying that locally. That doesn't work either. I think I've figured it out; I believe the various AllInOne.cpp files are getting prematurely optimized by the compiler, and the inlines for these two methods are getting removed because it doesn't see them being used. When WebKit.dll and TestWebCoreLib get built, they attempt to access them, but the defines have been optimized away. I'm going to try adding the inline includes to the AllInOne files and see if that resolves it. 1299135 14 ap 2017-04-20 09:33:58 -0700 > Another option might be to add "#include <JavaScriptCore/JSCInlines.h>" to the Source/WebKit/win/WebKitPrefix.h file. I think that the reason for having separate inline implementation files is that it's not desirable to include them everywhere (compilation time issues, I believe). We only want to include them from individual .cpp files, not from headers. But, we do include them from some headers! Source/WebCore//bindings/js/JSCustomXPathNSResolver.h:#include <runtime/JSCInlines.h> Source/WebCore//bridge/c/c_utility.h:#include <runtime/JSCInlines.h> Source/WebCore//bridge/jsc/BridgeJSC.h:#include <runtime/JSCInlines.h> Source/WebCore//platform/SerializedPlatformRepresentation.h:#include <runtime/JSCInlines.h> 1299211 15 bfulgham 2017-04-20 12:24:57 -0700 (In reply to Fujii Hironori from comment #11) > This patch make Windows build happy. But, I'm not sure this is a right fix. > > diff --git a/Source/WebCore/bindings/js/JSDOMGlobalObject.h > b/Source/WebCore/bindings/js/JSDOMGlobalObject.h > index fb63f24..d07d17b 100644 > --- a/Source/WebCore/bindings/js/JSDOMGlobalObject.h > +++ b/Source/WebCore/bindings/js/JSDOMGlobalObject.h > @@ -28,6 +28,7 @@ > > #include "PlatformExportMacros.h" > #include "WebCoreJSBuiltinInternals.h" > +#include <heap/HeapInlines.h> > #include <heap/LockDuringMarking.h> > #include <runtime/JSGlobalObject.h> > #include <runtime/StructureInlines.h> I can't get anything else to work, so let's go with this. 1299213 16 307613 bfulgham 2017-04-20 12:28:54 -0700 Created attachment 307613 Patch 1299214 17 307613 mark.lam 2017-04-20 12:29:24 -0700 Comment on attachment 307613 Patch r=me 1299215 18 307536 mark.lam 2017-04-20 12:30:23 -0700 Comment on attachment 307536 Patch v2 Un-obsoleting the previous patch because it was correct and landed. We didn't revert it. 1299253 19 307613 commit-queue 2017-04-20 13:14:58 -0700 Comment on attachment 307613 Patch Clearing flags on attachment: 307613 Committed r215575: <http://trac.webkit.org/changeset/215575> 1299254 20 commit-queue 2017-04-20 13:15:00 -0700 All reviewed patches have been landed. Closing bug. 307534 2017-04-19 18:09:25 -0700 2017-04-19 18:22:30 -0700 Patch bug-171024-20170419180925.patch text/plain 1588 bfulgham SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1NTQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE3LTA0LTE5ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIFJFR1JFU1NJT04ocjIxNTQ4Nik6IFdpbmRvd3MgUmVsZWFzZSBidWlsZCBpcyBi cm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 MTAyNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzE3MjI2MTg+CisKKyAgICAgICAgQWRqdXN0 aW5nIHRoZSB3b3JsZCBoYW5kbGluZyBjYXVzZWQgV2luZG93cyBXZWJLaXQgdG8gYmVjb21lIHVw c2V0IHRoYXQKKyAgICAgICAgaXQgY291bGQgbm90IGZpbmQgSGVhcDo6dm0oKSBhbmQgSGVhcDo6 bXV0YXRvckZlbmNlLgorCisgICAgICAgICogaGVhcC9IZWFwLmg6IEV4cG9ydCB0d28gbWV0aG9k cyBuZWVkZWQgYnkgV2ViS2l0LmRsbCBvbiBXaW5kb3dzLgorCiAyMDE3LTA0LTE5ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFR1bmUgR0MgcmVsYXRlZCBK U0Mgb3B0aW9ucyBmb3IgaU9TCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCShyZXZp c2lvbiAyMTU1NDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgJKHdvcmtp bmcgY29weSkKQEAgLTEyNSw3ICsxMjUsNyBAQCBwdWJsaWM6CiAgICAgCiAgICAgdm9pZCB3cml0 ZUJhcnJpZXJXaXRob3V0RmVuY2UoY29uc3QgSlNDZWxsKiBmcm9tKTsKICAgICAKLSAgICB2b2lk IG11dGF0b3JGZW5jZSgpOworICAgIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgbXV0YXRvckZlbmNl KCk7CiAgICAgCiAgICAgLy8gVGFrZSB0aGlzIGlmIHlvdSBrbm93IHRoYXQgZnJvbS0+Y2VsbFN0 YXRlKCkgPCBiYXJyaWVyVGhyZXNob2xkLgogICAgIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgd3Jp dGVCYXJyaWVyU2xvd1BhdGgoY29uc3QgSlNDZWxsKiBmcm9tKTsKQEAgLTEzNSw3ICsxMzUsNyBA QCBwdWJsaWM6CiAgICAgdm9pZCBsYXN0Q2hhbmNlVG9GaW5hbGl6ZSgpOwogICAgIHZvaWQgcmVs ZWFzZURlbGF5ZWRSZWxlYXNlZE9iamVjdHMoKTsKIAotICAgIFZNKiB2bSgpIGNvbnN0OworICAg IEpTX0VYUE9SVF9QUklWQVRFIFZNKiB2bSgpIGNvbnN0OwogCiAgICAgTWFya2VkU3BhY2UmIG9i amVjdFNwYWNlKCkgeyByZXR1cm4gbV9vYmplY3RTcGFjZTsgfQogICAgIE1hY2hpbmVUaHJlYWRz JiBtYWNoaW5lVGhyZWFkcygpIHsgcmV0dXJuICptX21hY2hpbmVUaHJlYWRzOyB9Cg== 307536 2017-04-19 18:22:30 -0700 2017-04-20 12:30:23 -0700 Patch v2 heapInlines.patch text/plain 2353 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTU0NikKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA0LTE5 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFJF R1JFU1NJT04ocjIxNTQ4Nik6IFdpbmRvd3MgUmVsZWFzZSBidWlsZCBpcyBicm9rZW4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTAyNAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzE3MjI2MTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2luZG93cyBXZWJLaXQgcmVmZXJzIHRvIGEgaGFuZGZ1bCBv ZiBKU0MgbWV0aG9kcyB0aGF0IGFyZSBhbHdheXMKKyAgICAgICAgaW5saW5lLiBXZSBuZWVkIHRv IGluY2x1ZGUgJ0hlYXBJbmxpbmVzLmgnIHRvIGdldCB0aGUgaW1wbGVtZW50YXRpb24KKyAgICAg ICAgb2YgdGhlc2UgbWV0aG9kcy4KKworICAgICAgICAqIFBsdWdpbnMvUGx1Z2luUGFja2FnZS5j cHA6CisgICAgICAgICogV2ViRnJhbWUuY3BwOgorICAgICAgICAqIFdlYlZpZXcuY3BwOgorCiAy MDE3LTA0LTE1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIGZpeCB0aGUgV2luZG93cyBidWlsZCBhZnRlciByMjE1Mzg1CkluZGV4 OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC93aW4vV2ViRnJhbWUuY3BwCShyZXZpc2lvbiAyMTU1NDIpCisrKyBTb3VyY2UvV2ViS2l0 L3dpbi9XZWJGcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMCw2ICsxMDAsNyBAQAogI2lu Y2x1ZGUgPFdlYkNvcmUvU2NyaXB0Q29udHJvbGxlci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2Vj dXJpdHlPcmlnaW4uaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9BUElDYXN0Lmg+CisjaW5j bHVkZSA8SmF2YVNjcmlwdENvcmUvSGVhcElubGluZXMuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0 Q29yZS9KU0NKU1ZhbHVlLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSlNMb2NrLmg+CiAj aW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSlNPYmplY3QuaD4KSW5kZXg6IFNvdXJjZS9XZWJLaXQv d2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcu Y3BwCShyZXZpc2lvbiAyMTU1NDIpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAko d29ya2luZyBjb3B5KQpAQCAtNzcsNiArNzcsNyBAQAogI2luY2x1ZGUgInJlc291cmNlLmgiCiAj aW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRD b3JlL0V4Y2VwdGlvbi5oPgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0hlYXBJbmxpbmVzLmg+ CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSW5pdGlhbGl6ZVRocmVhZGluZy5oPgogI2luY2x1 ZGUgPEphdmFTY3JpcHRDb3JlL0pTQ0pTVmFsdWUuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29y ZS9KU0xvY2suaD4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1BsdWdpbnMvUGx1Z2luUGFja2Fn ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vUGx1Z2lucy9QbHVnaW5QYWNr YWdlLmNwcAkocmV2aXNpb24gMjE1NTQyKQorKysgU291cmNlL1dlYktpdC93aW4vUGx1Z2lucy9Q bHVnaW5QYWNrYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1 ZGUgIlBsdWdpbkRlYnVnLmgiCiAjaW5jbHVkZSAiUGx1Z2luVmlldy5oIgogI2luY2x1ZGUgPEph dmFTY3JpcHRDb3JlL0NvbXBsZXRpb24uaD4KKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9IZWFw SW5saW5lcy5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTR2xvYmFsT2JqZWN0Lmg+CiAj aW5jbHVkZSA8V2ViQ29yZS9JZGVudGlmaWVyUmVwLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9NSU1F VHlwZVJlZ2lzdHJ5Lmg+Cg== 307613 2017-04-20 12:28:54 -0700 2017-04-20 13:14:58 -0700 Patch bug-171024-20170420122854.patch text/plain 1544 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTU2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA0LTIwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFJFR1JFU1NJT04o cjIxNTQ4Nik6IFdpbmRvd3MgUmVsZWFzZSBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTAyNAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMzE3MjI2MTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIG1pc3NpbmcgaW5jbHVkZSBuZWVkZWQgZm9yIGNsZWFuIFJlbGVhc2Ug YnVpbGQgb24gV2luZG93cyAocHJvcGVyCisgICAgICAgIGZpeCBmb3VuZCBieSBGdWppaSBIaXJv bm9yaSkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5oOgorCiAy MDE3LTA0LTIwICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtN ZWRpYUNhcHR1cmVdIGdVTSgpIHdpdGggQ29yZUF1ZGlvIGZhaWxzIGlmIGNhcHR1cmluZyBhdWRp byBpbiB0aGUgVUlQcm9jZXNzLgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNE T01HbG9iYWxPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RPTUdsb2JhbE9iamVjdC5oCShyZXZpc2lvbiAyMTU1NDIpCisrKyBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUg KzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwOCwgMjAxMiBBcHBsZSBJbmMuIEFsbCBS aWdodHMgUmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDgtMjAxNyBBcHBsZSBJbmMuIEFs bCBSaWdodHMgUmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3Vy Y2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI4 LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgIlBsYXRmb3JtRXhwb3J0TWFjcm9zLmgiCiAjaW5jbHVk ZSAiV2ViQ29yZUpTQnVpbHRpbkludGVybmFscy5oIgorI2luY2x1ZGUgPGhlYXAvSGVhcElubGlu ZXMuaD4KICNpbmNsdWRlIDxoZWFwL0xvY2tEdXJpbmdNYXJraW5nLmg+CiAjaW5jbHVkZSA8cnVu dGltZS9KU0dsb2JhbE9iamVjdC5oPgogI2luY2x1ZGUgPHJ1bnRpbWUvU3RydWN0dXJlSW5saW5l cy5oPgo=