171010 2017-04-19 14:32:26 -0700 Vector.h: error: 'auto' not allowed in lambda parameter 2017-04-23 22:58:34 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=171038 InRadar P2 Normal --- 170102 170994 1 ddkilzer ddkilzer andersca benjamin bfulgham buildbot cdumez cmarcelo commit-queue dbates fpizlo jfbastien saam webkit-bug-importer oldest_to_newest 1298821 0 ddkilzer 2017-04-19 14:32:26 -0700 In file included from $(INSTALL_ROOT)/System/Library/Frameworks/WebKit.framework/PrivateHeaders/EnvironmentUtilities.h:29: In file included from $(SDKROOT)/usr/local/include/wtf/text/WTFString.h:30: In file included from $(SDKROOT)/usr/local/include/wtf/text/StringImpl.h:35: $(SDKROOT)/usr/local/include/wtf/Vector.h:1526:47: error: 'auto' not allowed in lambda parameter return removeRepeatedElements(vector, [] (auto& a, auto& b) { return a == b; }); ^~~~ $(SDKROOT)/usr/local/include/wtf/Vector.h:1526:56: error: 'auto' not allowed in lambda parameter return removeRepeatedElements(vector, [] (auto& a, auto& b) { return a == b; }); ^~~~ 2 errors generated. This code was committed in Bug 170102, but was triggered by a change in Bug 170994 that exposed EnvironmentUtilities.h as a private header in WebKit.framework. 1298822 1 ddkilzer 2017-04-19 14:32:35 -0700 <rdar://problem/31716076> 1298825 2 307509 ddkilzer 2017-04-19 14:38:50 -0700 Created attachment 307509 Patch 1298826 3 buildbot 2017-04-19 14:39:55 -0700 Attachment 307509 did not pass style-queue: ERROR: Source/WTF/wtf/Vector.h:1526: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1298827 4 307509 saam 2017-04-19 14:45:10 -0700 Comment on attachment 307509 Patch r=me 1298884 5 307509 commit-queue 2017-04-19 16:21:23 -0700 Comment on attachment 307509 Patch Clearing flags on attachment: 307509 Committed r215538: <http://trac.webkit.org/changeset/215538> 1298885 6 commit-queue 2017-04-19 16:21:25 -0700 All reviewed patches have been landed. Closing bug. 1298900 7 307509 cdumez 2017-04-19 16:33:49 -0700 Comment on attachment 307509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307509&action=review > Source/WTF/ChangeLog:3 > + Vector.h: error: 'auto' not allowed in lambda parameter It is allowed with c++14. The issue is that the project in question is building with c++11 support instead of c++14. I think we should fix this instead. 1298901 8 307509 cdumez 2017-04-19 16:36:14 -0700 Comment on attachment 307509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307509&action=review >> Source/WTF/ChangeLog:3 >> + Vector.h: error: 'auto' not allowed in lambda parameter > > It is allowed with c++14. The issue is that the project in question is building with c++11 support instead of c++14. I think we should fix this instead. Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig:OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti; We likely want c++14 here. 1298910 9 307509 bfulgham 2017-04-19 16:44:30 -0700 Comment on attachment 307509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307509&action=review >>> Source/WTF/ChangeLog:3 >>> + Vector.h: error: 'auto' not allowed in lambda parameter >> >> It is allowed with c++14. The issue is that the project in question is building with c++11 support instead of c++14. I think we should fix this instead. > > Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig:OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti; > > We likely want c++14 here. I think this also broke the Windows build, so we may want to be careful. 1299218 10 cdumez 2017-04-20 12:32:41 -0700 Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? 1299225 11 bfulgham 2017-04-20 12:37:40 -0700 (In reply to Chris Dumez from comment #10) > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? It also breaks Windows, so I don't think so. 1299641 12 bfulgham 2017-04-21 09:23:49 -0700 (In reply to Chris Dumez from comment #10) > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? I think we can roll this workaround out once we update our Windows build infrastructure to Visual Studio 2017. 1299677 13 bfulgham 2017-04-21 10:30:57 -0700 (In reply to Brent Fulgham from comment #12) > (In reply to Chris Dumez from comment #10) > > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? > > I think we can roll this workaround out once we update our Windows build > infrastructure to Visual Studio 2017. I'm wrong! I just rolled this patch out locally, and was able to build WebKit without trouble on Windows. So it looks like VS2015 Update 3's C++14 support is sufficient here. 1300375 14 ddkilzer 2017-04-23 15:58:53 -0700 (In reply to Brent Fulgham from comment #13) > (In reply to Brent Fulgham from comment #12) > > (In reply to Chris Dumez from comment #10) > > > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? > > > > I think we can roll this workaround out once we update our Windows build > > infrastructure to Visual Studio 2017. > > I'm wrong! > > I just rolled this patch out locally, and was able to build WebKit without > trouble on Windows. So it looks like VS2015 Update 3's C++14 support is > sufficient here. Based on Source/WebKit2/Configurations/Base.xcconfig, we can't roll out this change until we switch to c++14 (or gnu++14) for this: OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti; 1300438 15 ap 2017-04-23 22:58:34 -0700 Ideally, we would not make any C++ headers WebKit SPI, and then we won't need to worry about InstallAPI here. 307509 2017-04-19 14:38:50 -0700 2017-04-19 16:21:23 -0700 Patch bug-171010-20170419143849.patch text/plain 1520 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRkYjZmYmVjMzliZmFmNzkxYTc5ODk4 NDAxOTYxM2YwODU3MWFjMzcuLjFhMTIwNTJmNTBjZTMzNTgwN2ZiNTc2MTI0ZjQ3NTBkZjU2Y2Vk M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDQtMTkgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBWZWN0b3IuaDogZXJyb3I6ICdhdXRvJyBub3QgYWxs b3dlZCBpbiBsYW1iZGEgcGFyYW1ldGVyCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8x NzEwMTA+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTcxNjA3Nj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAg ICAgKFdURjo6cmVtb3ZlUmVwZWF0ZWRFbGVtZW50cyk6IFJlcGxhY2UgJ2F1dG8nIHdpdGggYSBz cGVjaWZpYworICAgICAgICB0eXBlLCAnVCcsIGJhc2VkIG9uIGEgVmVjdG9yPD4gdGVtcGxhdGUg dHlwZS4KKwogMjAxNy0wNC0xOSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIE1vdmUgbm90Rm91bmQgaW50byBpdHMgb3duIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL1ZlY3Rvci5oIGIvU291cmNlL1dURi93dGYvVmVjdG9yLmgKaW5kZXggM2I2ZmFmOGZj MzNhNjI2NjBmYjU3MjYzZDc0Y2RiZWI2YjM1ZGI3OC4uNjFiNDEwYmQ0Y2EyZTY3MzJjNjBkOGQx MjgxMDMwZDQxYzhiNTZkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVmVjdG9yLmgKKysr IGIvU291cmNlL1dURi93dGYvVmVjdG9yLmgKQEAgLTE1MjAsMTAgKzE1MjAsMTAgQEAgc2l6ZV90 IHJlbW92ZVJlcGVhdGVkRWxlbWVudHMoVmVjdG9yVHlwZSYgdmVjdG9yLCBjb25zdCBGdW5jJiBm dW5jKQogICAgIHJldHVybiBuZXdTaXplOwogfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBWZWN0b3JU eXBlPgotc2l6ZV90IHJlbW92ZVJlcGVhdGVkRWxlbWVudHMoVmVjdG9yVHlwZSYgdmVjdG9yKQor dGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5LCB0eXBlbmFtZSBPdmVy Zmxvd0hhbmRsZXIsIHNpemVfdCBtaW5DYXBhY2l0eT4KK3NpemVfdCByZW1vdmVSZXBlYXRlZEVs ZW1lbnRzKFZlY3RvcjxULCBpbmxpbmVDYXBhY2l0eSwgT3ZlcmZsb3dIYW5kbGVyLCBtaW5DYXBh Y2l0eT4mIHZlY3RvcikKIHsKLSAgICByZXR1cm4gcmVtb3ZlUmVwZWF0ZWRFbGVtZW50cyh2ZWN0 b3IsIFtdIChhdXRvJiBhLCBhdXRvJiBiKSB7IHJldHVybiBhID09IGI7IH0pOworICAgIHJldHVy biByZW1vdmVSZXBlYXRlZEVsZW1lbnRzKHZlY3RvciwgW10gKFQmIGEsIFQmIGIpIHsgcmV0dXJu IGEgPT0gYjsgfSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdURgo=