170987 2017-04-19 05:12:47 -0700 [GTK] WebKitAutocleanups.h regression in v2.16.1 release 2017-04-19 06:00:41 -0700 1 1 1 Unclassified WebKit WebKitGTK Other All Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez berto bugs-noreply buildbot cgarcia commit-queue gustavo mcatanzaro oldest_to_newest 1298652 0 aperez 2017-04-19 05:12:47 -0700 As reported in this post by Robert Bisewski: https://lists.webkit.org/pipermail/webkit-gtk/2017-April/003012.html Original e-mail text follows. ---- I was attempting to compile my webkit2-based browser `sighte` using the new v2.16.1 release of webkit2-gtk when I noticed the following warning from my gcc v6.3.0 compiler: /usr/include/webkitgtk-4.0/webkit2/WebKitAutocleanups.h:83:77: warning: ISO C does not allow extra ‘;’ outside of a function [-Wpedantic] G_DEFINE_AUTOPTR_CLEANUP_FUNC (WebKitWebsiteData, webkit_website_data_unref); This is no means a hold up for my project, but the warning did not appear before, so I figured taking a bit of time to track down exactly what was causing it would be in order. While I am not exactly well-versed at your code base, just glancing quickly from Trac leads me to believe that the specific commit appears to be this one: https://trac.webkit.org/changeset/214163/webkit Simply removing the aforementioned ; character from the file WebKitAutocleanups.h on line 83 seems to resolve the warning in question. If adding the semi-colon is not intended, then I hope you find this helpful :) 1298653 1 307476 aperez 2017-04-19 05:15:08 -0700 Created attachment 307476 Patch 1298654 2 buildbot 2017-04-19 05:18:00 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1298662 3 307476 commit-queue 2017-04-19 06:00:40 -0700 Comment on attachment 307476 Patch Clearing flags on attachment: 307476 Committed r215508: <http://trac.webkit.org/changeset/215508> 1298663 4 commit-queue 2017-04-19 06:00:41 -0700 All reviewed patches have been landed. Closing bug. 307476 2017-04-19 05:15:08 -0700 2017-04-19 06:00:40 -0700 Patch bug-170987-20170419151506.patch text/plain 1658 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGI2OTliM2NkMjk3ZTY0 MzI0MmI0MjBmMTAwZjE4NWZkZTA1NjEzMS4uZGFmZjhmNTNlOWVmNGNjZTQ4NTY3NjY1OTJjNWVi Y2NhZjVhNmEwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA0LTE5ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g V2ViS2l0QXV0b2NsZWFudXBzLmggcmVncmVzc2lvbiBpbiB2Mi4xNi4xIHJlbGVhc2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDk4NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0QXV0b2NsZWFudXBzLmg6IFJlbW92ZSBzdHJheSBzZW1pY29sb24uCisKIDIw MTctMDQtMTggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IERyYWdnaW5nIGEgZmV3IGl0ZW1zIG92ZXIgTWluaUJyb3dzZXIgaGFzIDAgaW4gdGhlIHJlZCBp bmRpY2F0b3IuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRBdXRvY2xlYW51cHMuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdEF1dG9jbGVhbnVwcy5oCmluZGV4IDU2N2ExMjI4MjBkZmQ3MTNmZTc3M2ZkMzY0MDliMTcx NmNmY2QwYjYuLmMzMmMwOTljMDQ5YmQxYzFlOThmYmNjOWU2YmJlOTBhNWE2MDdhODEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dG9jbGVhbnVw cy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dG9jbGVh bnVwcy5oCkBAIC04MCw3ICs4MCw3IEBAIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChX ZWJLaXROZXR3b3JrUHJveHlTZXR0aW5ncywgd2Via2l0X25ldHdvcmtfcHJveHlfCiBHX0RFRklO RV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0U2VjdXJpdHlPcmlnaW4sIHdlYmtpdF9zZWN1 cml0eV9vcmlnaW5fdW5yZWYpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0 VXNlclNjcmlwdCwgd2Via2l0X3VzZXJfc2NyaXB0X3VucmVmKQogR19ERUZJTkVfQVVUT1BUUl9D TEVBTlVQX0ZVTkMgKFdlYktpdFVzZXJTdHlsZVNoZWV0LCB3ZWJraXRfdXNlcl9zdHlsZV9zaGVl dF91bnJlZikKLUdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRXZWJzaXRlRGF0 YSwgd2Via2l0X3dlYnNpdGVfZGF0YV91bnJlZik7CitHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBf RlVOQyAoV2ViS2l0V2Vic2l0ZURhdGEsIHdlYmtpdF93ZWJzaXRlX2RhdGFfdW5yZWYpCiBHX0RF RklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2ViVmlld1Nlc3Npb25TdGF0ZSwgd2Vi a2l0X3dlYl92aWV3X3Nlc3Npb25fc3RhdGVfdW5yZWYpCiAKICNlbmRpZiAvLyBfX0dJX1NDQU5O RVJfXwo=