170931 2017-04-17 22:25:05 -0700 Web Inspector: DOM/XHR breakpoint sections should be collapsed by default 2017-04-24 12:48:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1298174 0 mattbaker 2017-04-17 22:25:05 -0700 Summary: DOM/XHR breakpoint sections should be collapsed by default. I think it makes sense for the DOM Breakpoints section to auto-expand when a breakpoint is added. 1298175 1 webkit-bug-importer 2017-04-17 22:26:17 -0700 <rdar://problem/31674190> 1298177 2 307342 mattbaker 2017-04-17 22:28:37 -0700 Created attachment 307342 Patch 1299681 3 307342 bburg 2017-04-21 10:35:35 -0700 Comment on attachment 307342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307342&action=review Did you test that this works correctly when reloading and reopening Inspector while the XHR / DOM breakpoint is selected? > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1156 > + this._domBreakpointsSection.collapsed = false; Shouldn't there be a similar line for XHR breakpoints? 1299768 4 307342 mattbaker 2017-04-21 12:29:41 -0700 Comment on attachment 307342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307342&action=review >> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1156 >> + this._domBreakpointsSection.collapsed = false; > > Shouldn't there be a similar line for XHR breakpoints? It isn't possible to add an XHR breakpoint without first expanding the section, to reveal the "+" button. 1299772 5 mattbaker 2017-04-21 12:34:58 -0700 (In reply to Brian Burg from comment #3) > Comment on attachment 307342 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307342&action=review > > Did you test that this works correctly when reloading and reopening > Inspector while the XHR / DOM breakpoint is selected? Non-script breakpoints don't have their selection restored on reload, since they have no meaningful represented object to show in the Debugger tab. 1300605 6 307342 bburg 2017-04-24 12:18:38 -0700 Comment on attachment 307342 Patch r=me 1300617 7 307342 commit-queue 2017-04-24 12:48:23 -0700 Comment on attachment 307342 Patch Clearing flags on attachment: 307342 Committed r215690: <http://trac.webkit.org/changeset/215690> 1300618 8 commit-queue 2017-04-24 12:48:25 -0700 All reviewed patches have been landed. Closing bug. 307342 2017-04-17 22:28:37 -0700 2017-04-24 12:48:23 -0700 Patch bug-170931-20170417222836.patch text/plain 3656 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk OThkNzI2OTRmNDZhOTVjN2MzN2I1OGJjZDA5YTViZjI2N2Y3YmM2Li5iZjNhZWZmYTkwYTFjNDA3 NmY4ZTRlM2IxZjI5Y2MzYjg1OTM0ODNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wNC0xNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRE9NL1hIUiBicmVha3BvaW50IHNlY3Rpb25zIHNo b3VsZCBiZSBjb2xsYXBzZWQgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwOTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2V0IHRoZSBkZWZhdWx0IGNvbGxhcHNlZCBwYXJhbWV0ZXIg Zm9yIERPTSAvIFhIUiBCcmVha3BvaW50cyBzZWN0aW9ucywKKyAgICAgICAgYW5kIGF1dG8tZXhw YW5kIHRoZSBET00gQnJlYWtwb2ludHMgd2hlbiBhIGJyZWFrcG9pbnQgaXMgYWRkZWQuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5EZWJ1Z2dlclNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2RvbUJyZWFrcG9pbnRBZGRl ZE9yUmVtb3ZlZCk6CisKIDIwMTctMDQtMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEb2Vzbid0IHNob3cgc2l6ZSBvZiBj b21wcmVzc2VkIGNvbnRlbnQgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVs LmpzCmluZGV4IGU2NDgwNGE1MGZjZmIxMDc5ZjYwOGE0YjhlYjg3NGE5N2E0ZjU5MzAuLmZkZDlh NjYzMTk4YTRiZWYzNTk4MmFjNTQ3YWEyMGRiM2M4YmQwNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2Vy U2lkZWJhclBhbmVsLmpzCkBAIC0xNzYsOSArMTc2LDExIEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dl clNpZGViYXJQYW5lbCA9IGNsYXNzIERlYnVnZ2VyU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5z cGVjCiAgICAgICAgICAgICB0aGlzLl9kb21CcmVha3BvaW50c1Jvdy5lbGVtZW50LmFwcGVuZENo aWxkKHRoaXMuX2RvbUJyZWFrcG9pbnRzQ29udGVudFRyZWVPdXRsaW5lLmVsZW1lbnQpOwogICAg ICAgICAgICAgdGhpcy5fZG9tQnJlYWtwb2ludHNSb3cuc2hvd0VtcHR5TWVzc2FnZSgpOwogCisg ICAgICAgICAgICBjb25zdCBkZWZhdWx0Q29sbGFwc2VkID0gdHJ1ZTsKKwogICAgICAgICAgICAg bGV0IGRvbUJyZWFrcG9pbnRzR3JvdXAgPSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNTZWN0aW9u R3JvdXAoW3RoaXMuX2RvbUJyZWFrcG9pbnRzUm93XSk7Ci0gICAgICAgICAgICBsZXQgZG9tQnJl YWtwb2ludHNTZWN0aW9uID0gbmV3IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvbigiZG9tLWJy ZWFrcG9pbnRzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJET00gQnJlYWtwb2ludHMiKSwgW2Rv bUJyZWFrcG9pbnRzR3JvdXBdKTsKLSAgICAgICAgICAgIHRoaXMuY29udGVudFZpZXcuZWxlbWVu dC5hcHBlbmRDaGlsZChkb21CcmVha3BvaW50c1NlY3Rpb24uZWxlbWVudCk7CisgICAgICAgICAg ICB0aGlzLl9kb21CcmVha3BvaW50c1NlY3Rpb24gPSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNT ZWN0aW9uKCJkb20tYnJlYWtwb2ludHMiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkRPTSBCcmVh a3BvaW50cyIpLCBbZG9tQnJlYWtwb2ludHNHcm91cF0sIG51bGwsIGRlZmF1bHRDb2xsYXBzZWQp OworICAgICAgICAgICAgdGhpcy5jb250ZW50Vmlldy5lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMu X2RvbUJyZWFrcG9pbnRzU2VjdGlvbi5lbGVtZW50KTsKIAogICAgICAgICAgICAgdGhpcy5feGhy QnJlYWtwb2ludHNDb250ZW50VHJlZU91dGxpbmUgPSB0aGlzLmNyZWF0ZUNvbnRlbnRUcmVlT3V0 bGluZSh0cnVlKTsKICAgICAgICAgICAgIHRoaXMuX3hockJyZWFrcG9pbnRUcmVlQ29udHJvbGxl ciA9IG5ldyBXZWJJbnNwZWN0b3IuWEhSQnJlYWtwb2ludFRyZWVDb250cm9sbGVyKHRoaXMuX3ho ckJyZWFrcG9pbnRzQ29udGVudFRyZWVPdXRsaW5lKTsKQEAgLTE5NSw3ICsxOTcsNyBAQCBXZWJJ bnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwgPSBjbGFzcyBEZWJ1Z2dlclNpZGViYXJQYW5l bCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICAgICAgbmF2aWdhdGlvbkJhci5hZGROYXZpZ2F0 aW9uSXRlbShhZGRYSFJCcmVha3BvaW50QnV0dG9uKTsKIAogICAgICAgICAgICAgbGV0IHhockJy ZWFrcG9pbnRzR3JvdXAgPSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNTZWN0aW9uR3JvdXAoW3Ro aXMuX3hockJyZWFrcG9pbnRzUm93XSk7Ci0gICAgICAgICAgICBsZXQgeGhyQnJlYWtwb2ludHNT ZWN0aW9uID0gbmV3IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvbigieGhyLWJyZWFrcG9pbnRz IiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJYSFIgQnJlYWtwb2ludHMiKSwgW3hockJyZWFrcG9p bnRzR3JvdXBdLCBuYXZpZ2F0aW9uQmFyV3JhcHBlcik7CisgICAgICAgICAgICBsZXQgeGhyQnJl YWtwb2ludHNTZWN0aW9uID0gbmV3IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvbigieGhyLWJy ZWFrcG9pbnRzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJYSFIgQnJlYWtwb2ludHMiKSwgW3ho ckJyZWFrcG9pbnRzR3JvdXBdLCBuYXZpZ2F0aW9uQmFyV3JhcHBlciwgZGVmYXVsdENvbGxhcHNl ZCk7CiAgICAgICAgICAgICB0aGlzLmNvbnRlbnRWaWV3LmVsZW1lbnQuYXBwZW5kQ2hpbGQoeGhy QnJlYWtwb2ludHNTZWN0aW9uLmVsZW1lbnQpOwogICAgICAgICB9CiAKQEAgLTExNTAsNiArMTE1 Miw4IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclNpZGViYXJQYW5lbCA9IGNsYXNzIERlYnVnZ2Vy U2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjCiAKICAgICAgICAgdGhpcy5fZG9tQnJlYWtw b2ludHNSb3cuaGlkZUVtcHR5TWVzc2FnZSgpOwogICAgICAgICB0aGlzLl9kb21CcmVha3BvaW50 c1Jvdy5lbGVtZW50LmFwcGVuZCh0aGlzLl9kb21CcmVha3BvaW50c0NvbnRlbnRUcmVlT3V0bGlu ZS5lbGVtZW50KTsKKworICAgICAgICB0aGlzLl9kb21CcmVha3BvaW50c1NlY3Rpb24uY29sbGFw c2VkID0gZmFsc2U7CiAgICAgfQogCiAgICAgX2FkZFhIUkJyZWFrcG9pbnRCdXR0b25DbGlja2Vk KGV2ZW50KQo=