170930 2017-04-17 22:02:16 -0700 Web Inspector: XHR breakpoints shouldn't be cleared from the sidebar on reload 2017-04-18 11:50:29 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1298168 0 mattbaker 2017-04-17 22:02:16 -0700 Summary: XHR breakpoints shouldn't be cleared from the sidebar on reload. Unlike other breakpoints, XHR breakpoints are global and should only be detached (removed from the backend) when deleted. 1298170 1 webkit-bug-importer 2017-04-17 22:03:18 -0700 <rdar://problem/31674009> 1298171 2 307340 mattbaker 2017-04-17 22:05:48 -0700 Created attachment 307340 Patch 1298361 3 307340 joepeck 2017-04-18 11:22:26 -0700 Comment on attachment 307340 Patch r=me 1298371 4 307340 commit-queue 2017-04-18 11:50:24 -0700 Comment on attachment 307340 Patch Clearing flags on attachment: 307340 Committed r215473: <http://trac.webkit.org/changeset/215473> 1298372 5 commit-queue 2017-04-18 11:50:29 -0700 All reviewed patches have been landed. Closing bug. 307340 2017-04-17 22:05:48 -0700 2017-04-18 11:50:24 -0700 Patch bug-170930-20170417220548.patch text/plain 3576 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk OThkNzI2OTRmNDZhOTVjN2MzN2I1OGJjZDA5YTViZjI2N2Y3YmM2Li42ZjU0OTBlNDkyOWNmZjdm MmMzM2UxYTk3OWVhMDRhMWIyMmIxMTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0wNC0xNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogWEhSIGJyZWFrcG9pbnRzIHNob3VsZG4ndCBiZSBj bGVhcmVkIGZyb20gdGhlIHNpZGViYXIgb24gcmVsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA5MzAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYSFIgYnJlYWtwb2ludHMgYXJlbid0IGFzc29jaWF0 ZWQgd2l0aCB0aGUgbWFpbiByZXNvdXJjZSwgYW5kIHNob3VsZG4ndAorICAgICAgICBiZSBjbGVh cmVkIGZyb20gdGhlIG1hbmFnZXIgb3Igc2lkZWJhciBVSSBXaGVuIHRoZSBtYWluIHJlc291cmNl IGNoYW5nZXMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTURlYnVn Z2VyTWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01EZWJ1Z2dlck1hbmFnZXIu cHJvdG90eXBlLl9tYWluUmVzb3VyY2VEaWRDaGFuZ2UpOgorICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvWEhSQnJlYWtwb2ludFRyZWVDb250cm9sbGVyLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlhIUkJyZWFrcG9pbnRUcmVlQ29udHJvbGxlcik6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuWEhSQnJlYWtwb2ludFRyZWVDb250cm9sbGVyLnByb3RvdHlwZS5fbWFpblJlc291 cmNlRGlkQ2hhbmdlKTogRGVsZXRlZC4KKwogMjAxNy0wNC0xNyAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERvZXNuJ3Qgc2hv dyBzaXplIG9mIGNvbXByZXNzZWQgY29udGVudCBjb3JyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTURlYnVnZ2VyTWFu YWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L0RPTURlYnVnZ2VyTWFuYWdlci5qcwppbmRleCBjZTlkMTgxN2RhZjlmOTQ0ZGIzNGVkOTQ1YmJk MDQ1MDkxZWFkMzAwLi44YmZjNTM2MzIwYWMxNWIwMjI2NmFhYmJiY2MzY2ZjN2FmNDM3MjQxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9ET01EZWJ1Z2dlck1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpzCkBAIC00MjksOSArNDI5 LDYgQEAgV2ViSW5zcGVjdG9yLkRPTURlYnVnZ2VyTWFuYWdlciA9IGNsYXNzIERPTURlYnVnZ2Vy TWFuYWdlciBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgICAgICAgICBicmVha3BvaW50 cy5mb3JFYWNoKChicmVha3BvaW50KSA9PiB7IGJyZWFrcG9pbnQuZG9tTm9kZUlkZW50aWZpZXIg PSBudWxsOyB9KTsKIAogICAgICAgICAgICAgdGhpcy5fZG9tQnJlYWtwb2ludEZyYW1lSWRlbnRp Zmllck1hcC5jbGVhcigpOwotCi0gICAgICAgICAgICBmb3IgKGxldCBicmVha3BvaW50IG9mIHRo aXMuX3hockJyZWFrcG9pbnRzKQotICAgICAgICAgICAgICAgIHRoaXMuX2RldGFjaFhIUkJyZWFr cG9pbnQoYnJlYWtwb2ludCk7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgdGhpcy5fZGV0 YWNoQnJlYWtwb2ludHNGb3JGcmFtZShmcmFtZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1hIUkJyZWFrcG9pbnRUcmVlQ29u dHJvbGxlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL1hIUkJyZWFrcG9pbnRUcmVlQ29udHJvbGxlci5qcwppbmRleCAyZDEwZTI5MWU4YjAxY2M3 NTY1Mjc5ZmJiNWYxMGExNTk0NGIyNDVjLi5mOGM4OTUxNDE0YzVmNTQzMzIyYWI5NWRlYzlkY2Mz N2U1Y2U4NGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Db250cm9sbGVycy9YSFJCcmVha3BvaW50VHJlZUNvbnRyb2xsZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvWEhSQnJlYWtwb2ludFRy ZWVDb250cm9sbGVyLmpzCkBAIC0zMSw4ICszMSw2IEBAIFdlYkluc3BlY3Rvci5YSFJCcmVha3Bv aW50VHJlZUNvbnRyb2xsZXIgPSBjbGFzcyBYSFJCcmVha3BvaW50c1RyZWVDb250cm9sbGVyIGV4 CiAKICAgICAgICAgdGhpcy5fdHJlZU91dGxpbmUgPSB0cmVlT3V0bGluZTsKIAotICAgICAgICBX ZWJJbnNwZWN0b3IuRnJhbWUuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRnJhbWUuRXZl bnQuTWFpblJlc291cmNlRGlkQ2hhbmdlLCB0aGlzLl9tYWluUmVzb3VyY2VEaWRDaGFuZ2UsIHRo aXMpOwotCiAgICAgICAgIFdlYkluc3BlY3Rvci5kb21EZWJ1Z2dlck1hbmFnZXIuYWRkRXZlbnRM aXN0ZW5lcihXZWJJbnNwZWN0b3IuRE9NRGVidWdnZXJNYW5hZ2VyLkV2ZW50LlhIUkJyZWFrcG9p bnRBZGRlZCwgdGhpcy5feGhyQnJlYWtwb2ludEFkZGVkLCB0aGlzKTsKICAgICAgICAgV2ViSW5z cGVjdG9yLmRvbURlYnVnZ2VyTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5E T01EZWJ1Z2dlck1hbmFnZXIuRXZlbnQuWEhSQnJlYWtwb2ludFJlbW92ZWQsIHRoaXMuX3hockJy ZWFrcG9pbnRSZW1vdmVkLCB0aGlzKTsKIApAQCAtNzgsMTUgKzc2LDYgQEAgV2ViSW5zcGVjdG9y LlhIUkJyZWFrcG9pbnRUcmVlQ29udHJvbGxlciA9IGNsYXNzIFhIUkJyZWFrcG9pbnRzVHJlZUNv bnRyb2xsZXIgZXgKICAgICAgICAgdGhpcy5fdHJlZU91dGxpbmUucmVtb3ZlQ2hpbGQodHJlZUVs ZW1lbnQpOwogICAgIH0KIAotICAgIF9tYWluUmVzb3VyY2VEaWRDaGFuZ2UoZXZlbnQpCi0gICAg ewotICAgICAgICBpZiAoIWV2ZW50LnRhcmdldC5pc01haW5GcmFtZSgpKQotICAgICAgICAgICAg cmV0dXJuOwotCi0gICAgICAgIHdoaWxlICh0aGlzLl90cmVlT3V0bGluZS5jaGlsZHJlbi5sZW5n dGggPiAxKQotICAgICAgICAgICAgdGhpcy5fdHJlZU91dGxpbmUucmVtb3ZlQ2hpbGQodGhpcy5f dHJlZU91dGxpbmUuY2hpbGRyZW4ubGFzdFZhbHVlKTsKLSAgICB9Ci0KICAgICBfYWRkVHJlZUVs ZW1lbnQoYnJlYWtwb2ludCkKICAgICB7CiAgICAgICAgIGxldCB0cmVlRWxlbWVudCA9IHRoaXMu X3RyZWVPdXRsaW5lLmZpbmRUcmVlRWxlbWVudChicmVha3BvaW50KTsK