170910 2017-04-17 12:27:54 -0700 JSEventListener::m_isolatedWorld should be a Ref 2017-04-18 16:34:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham fpizlo ggaren webkit-bug-importer oldest_to_newest 1297974 0 bfulgham 2017-04-17 12:27:54 -0700 It doesn't seem like m_isolatedWorld can ever be nullptr. We should switch from RefPtr -> Ref so we can catch any cases where this is set improperly. 1298433 1 webkit-bug-importer 2017-04-18 14:13:52 -0700 <rdar://problem/31690856> 1298435 2 307417 bfulgham 2017-04-18 14:28:48 -0700 Created attachment 307417 Patch 1298503 3 bfulgham 2017-04-18 16:34:19 -0700 Committed r215487: <http://trac.webkit.org/changeset/215487> 307417 2017-04-18 14:28:48 -0700 2017-04-18 15:07:01 -0700 Patch bug-170910-20170418142847.patch text/plain 4463 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTQ3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE3LTA0LTE4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEpTRXZlbnRMaXN0ZW5lcjo6 bV9pc29sYXRlZFdvcmxkIHNob3VsZCBiZSBhIFJlZgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwOTEwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z MDQ3MDMzMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTaW5jZSBtX2lzb2xhdGVkV29ybGQgc2hvdWxkIG5ldmVyIGJlIG51bGxwdHIsIGNoYW5nZSB0 aGUgaW1wbGVtZW50YXRpb24gb2YgbV9pc29sYXRlZFdvcmxkCisgICAgICAgIGZyb20gYSBSZWZQ dHIgdG8gYSBSZWYsIGFuZCBhZGp1c3QgdGhlIHZhcmlvdXMgY2FsbCBzaXRlcyB0byBzdXBwb3J0 IHRoaXMgY2hhbmdlLgorCisgICAgICAgIFRoaXMgc2hvdWxkIGhlbHAgdXMgY2F0Y2ggYW55IGNo YW5nZXMgdGhhdCBwZXJtaXQgdGhlIGlzb2xhdGVkV29ybGQgdG8gYmUgc2V0IHRvIG51bGxwdHIu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoZXJlIHNob3VsZCBiZSBubyBjaGFuZ2Ug aW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SlNFdmVudExpc3RlbmVyOjpKU0V2ZW50TGlzdGVuZXIpOgor ICAgICAgICAoV2ViQ29yZTo6SlNFdmVudExpc3RlbmVyOjppbml0aWFsaXplSlNGdW5jdGlvbik6 CisgICAgICAgIChXZWJDb3JlOjpKU0V2ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50KToKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkpT RXZlbnRMaXN0ZW5lcjo6Y2FzdCk6CisgICAgICAgIChXZWJDb3JlOjpKU0V2ZW50TGlzdGVuZXI6 Omlzb2xhdGVkV29ybGQpOgorICAgICAgICAoV2ViQ29yZTo6SlNFdmVudExpc3RlbmVyOjpqc0Z1 bmN0aW9uKToKKwogMjAxNy0wNC0xOCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBTYWZhcmkgY3Jhc2ggd2hlbiBjbGlja2luZyBwaG9uZSBudW1iZXIg ZGF0YSBkZXRlY3RvciBwb3BvdmVyIGJ1dHRvbgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNFdmVudExpc3RlbmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIuY3BwCShyZXZpc2lvbiAyMTU0MTcpCisrKyBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00Nyw3ICs0Nyw3IEBAIEpTRXZlbnRMaXN0ZW5lcjo6SlNFdmVudExpc3RlbmVyKEpTT2Jq ZWMKICAgICA6IEV2ZW50TGlzdGVuZXIoSlNFdmVudExpc3RlbmVyVHlwZSkKICAgICAsIG1fd3Jh cHBlcih3cmFwcGVyKQogICAgICwgbV9pc0F0dHJpYnV0ZShpc0F0dHJpYnV0ZSkKLSAgICAsIG1f aXNvbGF0ZWRXb3JsZCgmaXNvbGF0ZWRXb3JsZCkKKyAgICAsIG1faXNvbGF0ZWRXb3JsZChpc29s YXRlZFdvcmxkKQogewogICAgIGlmICh3cmFwcGVyKSB7CiAgICAgICAgIEpTQzo6SGVhcDo6aGVh cCh3cmFwcGVyKS0+d3JpdGVCYXJyaWVyKHdyYXBwZXIsIGZ1bmN0aW9uKTsKQEAgLTYyLDcgKzYy LDcgQEAgSlNFdmVudExpc3RlbmVyOjp+SlNFdmVudExpc3RlbmVyKCkKIAogSlNPYmplY3QqIEpT RXZlbnRMaXN0ZW5lcjo6aW5pdGlhbGl6ZUpTRnVuY3Rpb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCopIGNvbnN0CiB7Ci0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIHZv aWQgSlNFdmVudExpc3RlbmVyOjp2aXNpdEpTRnVuY3Rpb24oU2xvdFZpc2l0b3ImIHZpc2l0b3Ip CkBAIC0xMDEsNyArMTAxLDcgQEAgdm9pZCBKU0V2ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50KFNj cmlwdAogICAgIGlmICghanNGdW5jdGlvbikKICAgICAgICAgcmV0dXJuOwogCi0gICAgSlNET01H bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IHRvSlNET01HbG9iYWxPYmplY3Qoc2NyaXB0RXhl Y3V0aW9uQ29udGV4dCwgKm1faXNvbGF0ZWRXb3JsZCk7CisgICAgSlNET01HbG9iYWxPYmplY3Qq IGdsb2JhbE9iamVjdCA9IHRvSlNET01HbG9iYWxPYmplY3Qoc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCwgbV9pc29sYXRlZFdvcmxkKTsKICAgICBpZiAoIWdsb2JhbE9iamVjdCkKICAgICAgICAgcmV0 dXJuOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVu ZXIuaAkocmV2aXNpb24gMjE1NDE3KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNF dmVudExpc3RlbmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNiArMSw2IEBACiAvKgogICogIENv cHlyaWdodCAoQykgMjAwMSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQotICogIENvcHlyaWdo dCAoQykgMjAwMywgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiAgQ29weXJpZ2h0IChDKSAyMDAzLTIwMTcgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3Ry aWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IExlc3NlciBHZW5lcmFsIFB1YmxpYwpAQCAtNTQsNyArNTQsNyBAQCBwdWJsaWM6CiAgICAgewog ICAgICAgICByZXR1cm4gbGlzdGVuZXItPnR5cGUoKSA9PSBKU0V2ZW50TGlzdGVuZXJUeXBlCiAg ICAgICAgICAgICA/IHN0YXRpY19jYXN0PGNvbnN0IEpTRXZlbnRMaXN0ZW5lcio+KGxpc3RlbmVy KQotICAgICAgICAgICAgOiAwOworICAgICAgICAgICAgOiBudWxscHRyOwogICAgIH0KIAogICAg IHZpcnR1YWwgfkpTRXZlbnRMaXN0ZW5lcigpOwpAQCAtNjUsNyArNjUsNyBAQCBwdWJsaWM6CiAg ICAgYm9vbCBpc0F0dHJpYnV0ZSgpIGNvbnN0IHsgcmV0dXJuIG1faXNBdHRyaWJ1dGU7IH0KIAog ICAgIEpTQzo6SlNPYmplY3QqIGpzRnVuY3Rpb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCopIGNv bnN0OwotICAgIERPTVdyYXBwZXJXb3JsZCYgaXNvbGF0ZWRXb3JsZCgpIGNvbnN0IHsgcmV0dXJu ICptX2lzb2xhdGVkV29ybGQ7IH0KKyAgICBET01XcmFwcGVyV29ybGQmIGlzb2xhdGVkV29ybGQo KSBjb25zdCB7IHJldHVybiBtX2lzb2xhdGVkV29ybGQ7IH0KIAogICAgIEpTQzo6SlNPYmplY3Qq IHdyYXBwZXIoKSBjb25zdCB7IHJldHVybiBtX3dyYXBwZXIuZ2V0KCk7IH0KICAgICB2b2lkIHNl dFdyYXBwZXIoSlNDOjpWTSYsIEpTQzo6SlNPYmplY3QqIHdyYXBwZXIpIGNvbnN0IHsgbV93cmFw cGVyID0gSlNDOjpXZWFrPEpTQzo6SlNPYmplY3Q+KHdyYXBwZXIpOyB9CkBAIC04Nyw3ICs4Nyw3 IEBAIHByaXZhdGU6CiAgICAgbXV0YWJsZSBKU0M6OldlYWs8SlNDOjpKU09iamVjdD4gbV93cmFw cGVyOwogCiAgICAgYm9vbCBtX2lzQXR0cmlidXRlOwotICAgIFJlZlB0cjxET01XcmFwcGVyV29y bGQ+IG1faXNvbGF0ZWRXb3JsZDsKKyAgICBSZWY8RE9NV3JhcHBlcldvcmxkPiBtX2lzb2xhdGVk V29ybGQ7CiB9OwogCiAvLyBGb3IgIm9ueHh4IiBhdHRyaWJ1dGVzIHRoYXQgYXV0b21hdGljYWxs eSBzZXQgdXAgSmF2YVNjcmlwdCBldmVudCBsaXN0ZW5lcnMuCkBAIC0xMjgsNyArMTI4LDcgQEAg aW5saW5lIEpTQzo6SlNPYmplY3QqIEpTRXZlbnRMaXN0ZW5lcjo6agogCiAgICAgLy8gSWYgbV93 cmFwcGVyIGlzIDAsIHRoZW4gbV9qc0Z1bmN0aW9uIGlzIHpvbWJpZWQsIGFuZCBzaG91bGQgbmV2 ZXIgYmUgYWNjZXNzZWQuCiAgICAgaWYgKCFtX3dyYXBwZXIpCi0gICAgICAgIHJldHVybiAwOwor ICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIC8vIFRyeSB0byB2ZXJpZnkgdGhhdCBtX2pz RnVuY3Rpb24gd2Fzbid0IHJlY3ljbGVkLiAoTm90IGV4YWN0LCBzaW5jZSBhbgogICAgIC8vIGV2 ZW50IGxpc3RlbmVyIGNhbiBiZSBhbG1vc3QgYW55dGhpbmcsIGJ1dCB0aGlzIG1ha2VzIHRlc3Qt d3JpdGluZyBlYXNpZXIpLgo=