170894 2017-04-16 15:43:00 -0700 RTCPeerConnection addTrack does not require a stream parameter 2017-04-17 08:27:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen commit-queue oldest_to_newest 1297815 0 youennf 2017-04-16 15:43:00 -0700 RTCPeerConnection addTrack does not require a stream parameter as per the spec and https://github.com/w3c/webrtc-pc/issues/288 1297816 1 307243 youennf 2017-04-16 15:44:05 -0700 Created attachment 307243 Patch 1297817 2 youennf 2017-04-16 15:44:59 -0700 (In reply to youenn fablet from comment #1) > Created attachment 307243 [details] > Patch Playing the stream before it gets the second track is changing the results. Probably worth investigating that further. 1297857 3 307243 achristensen 2017-04-17 00:09:50 -0700 Comment on attachment 307243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307243&action=review > LayoutTests/webrtc/video-addTrack-expected.txt:10 > +FAIL Testing image result, wait = false The index is not in the allowed range. Let's make this not say FAIL if it's the intended behavior. 1297902 4 youennf 2017-04-17 07:59:45 -0700 Thanks for the review (In reply to Alex Christensen from comment #3) > Comment on attachment 307243 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307243&action=review > > > LayoutTests/webrtc/video-addTrack-expected.txt:10 > > +FAIL Testing image result, wait = false The index is not in the allowed range. > > Let's make this not say FAIL if it's the intended Will need to check with Eric but I am not sure this is the expected behavior. 1297909 5 307243 commit-queue 2017-04-17 08:27:44 -0700 Comment on attachment 307243 Patch Clearing flags on attachment: 307243 Committed r215412: <http://trac.webkit.org/changeset/215412> 1297910 6 commit-queue 2017-04-17 08:27:45 -0700 All reviewed patches have been landed. Closing bug. 307243 2017-04-16 15:44:05 -0700 2017-04-17 08:27:44 -0700 Patch bug-170894-20170416154404.patch text/plain 6421 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI0NGY1OWExZjVjMGY3 ZDY1OTE1MmU4ZWMyNGIyMjA1ZjM4YzE3Yy4uODIyOGU3ZTczMDNmNzc5N2RiZDU0M2ExYzY3NmRk YjQxNGJkMzRlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSVENQZWVyQ29ubmVjdGlv biBhZGRUcmFjayBkb2VzIG5vdCByZXF1aXJlIGEgc3RyZWFtIHBhcmFtZXRlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwODk0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogd2VicnRjL3ZpZGVv LWFkZFRyYWNrLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNv bm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OmFkZFRy YWNrKTogUmVtb3Zpbmcgb2Jzb2xldGUgZXJyb3IgdGhyb3dpbmcuCisKIDIwMTctMDQtMTUgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBleHRlcm5h bCBsaWJ3ZWJydGMgZW5jb2RlciBmYWN0b3J5IGluIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAKaW5k ZXggODQ5YjdhMjY2ODdmNzBkZTkzNzc4ODVkYzZkN2Q3NTMxOGYxOTk0MC4uOWNmNWYwN2UyZjQ3 ZDc2ZjQwOTYxMWJjZTYxMmUxNDNkODg5NTNjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAKQEAgLTEwMywx MCArMTAzLDYgQEAgRXhjZXB0aW9uT3I8UmVmPFJUQ1J0cFNlbmRlcj4+IFJUQ1BlZXJDb25uZWN0 aW9uOjphZGRUcmFjayhSZWY8TWVkaWFTdHJlYW1UcmFjaz4KICAgICBpZiAobV9zaWduYWxpbmdT dGF0ZSA9PSBSVENTaWduYWxpbmdTdGF0ZTo6Q2xvc2VkKQogICAgICAgICByZXR1cm4gRXhjZXB0 aW9uIHsgSU5WQUxJRF9TVEFURV9FUlIgfTsKIAotICAgIC8vIFJlcXVpcmUgYXQgbGVhc3Qgb25l IHN0cmVhbSB1bnRpbCBodHRwczovL2dpdGh1Yi5jb20vdzNjL3dlYnJ0Yy1wYy9pc3N1ZXMvMjg4 IGlzIHJlc29sdmVkCi0gICAgaWYgKCFzdHJlYW1zLnNpemUoKSkKLSAgICAgICAgcmV0dXJuIEV4 Y2VwdGlvbiB7IE5PVF9TVVBQT1JURURfRVJSIH07Ci0KICAgICBmb3IgKFJUQ1J0cFNlbmRlciYg c2VuZGVyIDogbV90cmFuc2NlaXZlclNldC0+c2VuZGVycygpKSB7CiAgICAgICAgIGlmIChzZW5k ZXIudHJhY2tJZCgpID09IHRyYWNrLT5pZCgpKQogICAgICAgICAgICAgcmV0dXJuIEV4Y2VwdGlv biB7IElOVkFMSURfQUNDRVNTX0VSUiB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUwMmZjMDY3ZjFiYWFhOTY4MGJiNTM2 MTU4MGMxYThmMmJmM2FlOTEuLjc1MGRjYzBmNzJiZmE3ZDQzOTM3MmY4YzViMDBmMTg2NjkxYTA5 Y2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNC0xNiAgWW91ZW5uIEZhYmxldCAgPHlv dWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgUlRDUGVlckNvbm5lY3Rpb24gYWRkVHJhY2sgZG9l cyBub3QgcmVxdWlyZSBhIHN0cmVhbSBwYXJhbWV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDg5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2VicnRjL3ZpZGVvLWFkZFRyYWNrLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogd2VicnRjL3ZpZGVvLWFkZFRyYWNrLmh0bWw6IEFkZGVk LgorCiAyMDE3LTA0LTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBBY3RpdmF0ZSBXZWJSVEMgZGF0YSBjaGFubmVsIHRlc3RzIGZvciBXSzEKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1hZGRUcmFjay1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy93ZWJydGMvdmlkZW8tYWRkVHJhY2stZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYw OWUyODlkYWU5MWEyNmQ1NjRmZjJjNTE4ODA0YTcwZTNiYTMwNDQKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tYWRkVHJhY2stZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMTEgQEAKKyAKKworUEFTUyBCYXNpYyB2aWRlbyBleGNoYW5nZSB3aXRoIGFkZFRyYWNrIC0g d2FpdGluZyBmb3Igc2Vjb25kIHRyYWNrIGJlZm9yZSBwbGF5aW5nIAorUEFTUyBCYXNpYyB2aWRl byBleGNoYW5nZSB3aXRoIGFkZFRyYWNrIC0gbm90IHdhaXRpbmcgZm9yIHNlY29uZCB0cmFjayB0 byBwbGF5IAorUEFTUyAgdHJhY2sgMCwgd2FpdCA9IHRydWUgCitQQVNTICB0cmFjayAxLCB3YWl0 ID0gdHJ1ZSAKK1BBU1MgVGVzdGluZyBpbWFnZSByZXN1bHQsIHdhaXQgPSB0cnVlIAorUEFTUyAg dHJhY2sgMCwgd2FpdCA9IGZhbHNlIAorUEFTUyAgdHJhY2sgMSwgd2FpdCA9IGZhbHNlIAorRkFJ TCBUZXN0aW5nIGltYWdlIHJlc3VsdCwgd2FpdCA9IGZhbHNlIFRoZSBpbmRleCBpcyBub3QgaW4g dGhlIGFsbG93ZWQgcmFuZ2UuCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRl by1hZGRUcmFjay5odG1sIGIvTGF5b3V0VGVzdHMvd2VicnRjL3ZpZGVvLWFkZFRyYWNrLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uMTM3ZDRlOWE3MjQyZGFlYTA0MGU5YjljZTVmMGNkMzY1MjRjYjBkYgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1hZGRUcmFjay5odG1sCkBA IC0wLDAgKzEsODIgQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAg ICAgIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICAgICAgPHRpdGxlPlRlc3RpbmcgYmFzaWMg dmlkZW8gZXhjaGFuZ2UgZnJvbSBvZmZlcmVyIHRvIHJlY2VpdmVyPC90aXRsZT4KKyAgICAgICAg PHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+CisgICAg ICAgIDxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvdGVzdGhhcm5lc3NyZXBvcnQuanMiPjwvc2Ny aXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICAgICAgPHZpZGVvIGlkPSJ2aWRlbyIg YXV0b3BsYXk9IiI+PC92aWRlbz4KKyAgICAgICAgPGNhbnZhcyBpZD0iY2FudmFzIiB3aWR0aD0i NjQwIiBoZWlnaHQ9IjQ4MCI+PC9jYW52YXM+CisgICAgICAgIDxzY3JpcHQgc3JjID0icm91dGlu ZXMuanMiPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0PgordmlkZW8gPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidmlkZW8iKTsKK2NhbnZhcyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJj YW52YXMiKTsKKworZnVuY3Rpb24gdGVzdEltYWdlKHdhaXQpCit7CisgIHRlc3QoKCkgPT4gewor ICAgIGNhbnZhcy53aWR0aCA9IHZpZGVvLnZpZGVvV2lkdGg7CisgICAgY2FudmFzLmhlaWdodCA9 IHZpZGVvLnZpZGVvSGVpZ2h0OworICAgIGNhbnZhcy5nZXRDb250ZXh0KCcyZCcpLmRyYXdJbWFn ZSh2aWRlbywgMCwgMCwgY2FudmFzLndpZHRoLCBjYW52YXMuaGVpZ2h0KTsKKworICAgIGltYWdl RGF0YSA9IGNhbnZhcy5nZXRDb250ZXh0KCcyZCcpLmdldEltYWdlRGF0YSgxMCwgMzI1LCAyNTAs IDEpOworICAgIGRhdGEgPSBpbWFnZURhdGEuZGF0YTsKKworICAgIHZhciBpbmRleCA9IDIwOwor ICAgIGFzc2VydF90cnVlKGRhdGFbaW5kZXhdIDwgMTAwKTsKKyAgICBhc3NlcnRfdHJ1ZShkYXRh W2luZGV4ICsgMV0gPCAxMDApOworICAgIGFzc2VydF90cnVlKGRhdGFbaW5kZXggKyAyXSA8IDEw MCk7CisKKyAgICBpbmRleCA9IDgwOworICAgIGFzc2VydF90cnVlKGRhdGFbaW5kZXhdID4gMjAw KTsKKyAgICBhc3NlcnRfdHJ1ZShkYXRhW2luZGV4ICsgMV0gPiAyMDApOworICAgIGFzc2VydF90 cnVlKGRhdGFbaW5kZXggKyAyXSA+IDIwMCk7CisKKyAgICBpbmRleCArPSA4MDsKKyAgICBhc3Nl cnRfdHJ1ZShkYXRhW2luZGV4XSA+IDIwMCk7CisgICAgYXNzZXJ0X3RydWUoZGF0YVtpbmRleCAr IDFdID4gMjAwKTsKKyAgICBhc3NlcnRfdHJ1ZShkYXRhW2luZGV4ICsgMl0gPCAxMDApOworICB9 LCAiVGVzdGluZyBpbWFnZSByZXN1bHQsIHdhaXQgPSAiICsgd2FpdCk7Cit9CisKK2Z1bmN0aW9u IHRlc3RCYXNpY1ZpZGVvRXhjaGFuZ2VXaXRoQWRkVHJhY2sod2FpdEZvclNlY29uZFRyYWNrKQor eworICBwcm9taXNlX3Rlc3QoKHRlc3QpID0+IHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp CisgICAgICAgIHRlc3RSdW5uZXIuc2V0VXNlck1lZGlhUGVybWlzc2lvbih0cnVlKTsKKworICAg IHJldHVybiBuYXZpZ2F0b3IubWVkaWFEZXZpY2VzLmdldFVzZXJNZWRpYSh7YXVkaW86IHRydWUs IHZpZGVvOiB0cnVlfSkudGhlbigoc3RyZWFtKSA9PiB7CisgICAgICAgIHJldHVybiBuZXcgUHJv bWlzZSgocmVzb2x2ZSwgcmVqZWN0KSA9PiB7CisgICAgICAgICAgICBjcmVhdGVDb25uZWN0aW9u cygoZmlyc3RDb25uZWN0aW9uKSA9PiB7CisgICAgICAgICAgICAgICAgYXNzZXJ0X2VxdWFscyhz dHJlYW0uZ2V0VHJhY2tzKCkubGVuZ3RoLCAyKTsKKyAgICAgICAgICAgICAgICBzdHJlYW0uZ2V0 VHJhY2tzKCkuZm9yRWFjaCh0cmFjayA9PiBmaXJzdENvbm5lY3Rpb24uYWRkVHJhY2sodHJhY2sp KTsKKyAgICAgICAgICAgIH0sIChzZWNvbmRDb25uZWN0aW9uKSA9PiB7CisgICAgICAgICAgICAg ICAgdmFyIGNvdW50ID0gMDsKKyAgICAgICAgICAgICAgICBzZWNvbmRDb25uZWN0aW9uLm9udHJh Y2sgPSAodHJhY2tFdmVudCkgPT4geworICAgICAgICAgICAgICAgICAgICB3aW5kb3cudGVzdChm dW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmICh0cmFja0V2ZW50LnRyYWNr LmtpbmQgPT09ICJ2aWRlbyIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXNzZXJ0X2Vx dWFscyh0cmFja0V2ZW50LnRyYWNrLmlkLCBzdHJlYW0uZ2V0VmlkZW9UcmFja3MoKVswXS5pZCk7 CisgICAgICAgICAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYXNzZXJ0X2VxdWFscyh0cmFja0V2ZW50LnRyYWNrLmlkLCBzdHJlYW0uZ2V0QXVkaW9UcmFj a3MoKVswXS5pZCk7CisgICAgICAgICAgICAgICAgICAgIH0sICIgdHJhY2sgIiArIGNvdW50ICsg Iiwgd2FpdCA9ICIgKyB3YWl0Rm9yU2Vjb25kVHJhY2spOworICAgICAgICAgICAgICAgICAgICBp ZiAoY291bnQrKyA9PT0gKHdhaXRGb3JTZWNvbmRUcmFjayA/IDEgOiAwKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgIHJlc29sdmUodHJhY2tFdmVudC5zdHJlYW1zWzBdKTsKKyAgICAgICAgICAg ICAgICB9OworICAgICAgICAgICAgfSk7CisgICAgICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHJl amVjdCgiVGVzdCB0aW1lZCBvdXQiKSwgNTAwMCk7CisgICAgICAgIH0pOworICAgIH0pLnRoZW4o KHN0cmVhbSkgPT4geworICAgICAgICB2aWRlby5zcmNPYmplY3QgPSBzdHJlYW07CisgICAgICAg IHJldHVybiB2aWRlby5wbGF5KCk7CisgICAgfSkudGhlbigoKSA9PiB7CisgICAgICAgIHRlc3RJ bWFnZSh3YWl0Rm9yU2Vjb25kVHJhY2spOworICAgIH0pOworICB9LCAiQmFzaWMgdmlkZW8gZXhj aGFuZ2Ugd2l0aCBhZGRUcmFjayAtICIgKyAod2FpdEZvclNlY29uZFRyYWNrID8gIndhaXRpbmcg Zm9yIHNlY29uZCB0cmFjayBiZWZvcmUgcGxheWluZyIgOiAibm90IHdhaXRpbmcgZm9yIHNlY29u ZCB0cmFjayB0byBwbGF5IikpOworfQordGVzdEJhc2ljVmlkZW9FeGNoYW5nZVdpdGhBZGRUcmFj ayh0cnVlKTsKK3Rlc3RCYXNpY1ZpZGVvRXhjaGFuZ2VXaXRoQWRkVHJhY2soZmFsc2UpOworICAg ICAgICA8L3NjcmlwdD4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==