170889 2017-04-16 12:33:37 -0700 com.apple.WebKit.Networking.Development crashed in com.apple.WebKit: WebKit::NetworkRTCProvider::resolvedName 2017-04-17 17:20:48 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen commit-queue sam oldest_to_newest 1297787 0 youennf 2017-04-16 12:33:37 -0700 com.apple.WebKit.Networking.Development crashed in com.apple.WebKit: WebKit::NetworkRTCProvider::resolvedName. See rdar 31581795 1297788 1 307235 youennf 2017-04-16 12:40:33 -0700 Created attachment 307235 Patch 1297795 2 307235 sam 2017-04-16 13:06:07 -0700 Comment on attachment 307235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307235&action=review > Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp:166 > + CFRelease(host); host should be a RetainPtr<CFHostRef>. It seems odd that this file is using CFHost, and not an abstraction, since it is not guarded by any COCOA or CORE_FOUNDATION guards. 1297796 3 sam 2017-04-16 13:06:50 -0700 If there is a crash, can you provide a test case? If not, can you explain why in the changelog? 1297809 4 youennf 2017-04-16 14:21:25 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 307235 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307235&action=review > > > Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp:166 > > + CFRelease(host); > > host should be a RetainPtr<CFHostRef>. It seems odd that this file is using > CFHost, and not an abstraction, since it is not guarded by any COCOA or > CORE_FOUNDATION guards. I'll update the patch to use RetainPtr. NetworkRTCProvider is Cocoa specific at the moment. We will see how to make NetworkRTCProvider abstract when/if other ports will start supporting libwebrtc backend. Other ports may actually want to directly implement the future model we intent to follow for COCOA: create sockets on the UIProcess, pass them to the WebProcess and do networking in the WebProcess. (In reply to Sam Weinig from comment #3) > If there is a crash, can you provide a test case? If not, can you explain > why in the changelog? It is difficult to provide a test case. The crash happens in case the Resolver is destroyed after being stopped. CFHostCancelInfoResolution is called but sometimes NetworkRTCProvider::resolvedName is called after the resolver being cancelled. These additional clean-up lines will hopefully make sure things work well. 1297950 5 307283 youennf 2017-04-17 11:17:46 -0700 Created attachment 307283 Patch 1298106 6 307283 commit-queue 2017-04-17 17:14:25 -0700 Comment on attachment 307283 Patch Clearing flags on attachment: 307283 Committed r215443: <http://trac.webkit.org/changeset/215443> 1298107 7 commit-queue 2017-04-17 17:14:26 -0700 All reviewed patches have been landed. Closing bug. 307235 2017-04-16 12:40:33 -0700 2017-04-17 11:17:45 -0700 Patch bug-170889-20170416124032.patch text/plain 2358 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTM0ZjY0NDI3OTA5MDgz MmM3ZWZhZWFmZTU0ZTFhZWYzZDJmMjdjNi4uZTY1OTEwYTRiMjVhY2EyZjQ2Y2Q2N2U0M2E4NTU3 MjQxMjVkOWM0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA0LTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBjb20uYXBwbGUuV2ViS2l0 Lk5ldHdvcmtpbmcuRGV2ZWxvcG1lbnQgY3Jhc2hlZCBpbiBjb20uYXBwbGUuV2ViS2l0OiBXZWJL aXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6cmVzb2x2ZWROYW1lCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA4ODkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3 b3JrUlRDUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUlRDUHJvdmlkZXI6 OlJlc29sdmVyOjp+UmVzb2x2ZXIpOiBVbnNjaGVkdWxlIHRoZSBob3N0IHJlc29sdXRpb24gaW4g YWRkaXRpb24gdG8gY2FuY2VsbGluZyBpdC4KKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy93ZWJy dGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmg6CisKIDIwMTctMDQtMTEgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFdlYktpdCB1bm5lY2Vzc2FyaWx5IHNv ZnQtbGlua3MgQ29yZVByZWRpY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdv cmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwIGIvU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKaW5kZXggZTJhMTA4 MGViMzhlMzdmMTEzYzNkMjQ3YzMzNGRlZTAzMmZkMDcxMS4uYzI4ZDJmODkyMGU4NDViMTNmZGFk NDNjNjQzMDk0N2EwMzUwNWI0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKQEAgLTE1OSw2ICsx NTksMTMgQEAgdm9pZCBOZXR3b3JrUlRDUHJvdmlkZXI6OmNyZWF0ZVJlc29sdmVyKHVpbnQ2NF90 IGlkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYgYWRkcmUKICAgICBtX3Jlc29sdmVycy5hZGQoaWRl bnRpZmllciwgV1RGTW92ZShyZXNvbHZlcikpOwogfQogCitOZXR3b3JrUlRDUHJvdmlkZXI6OlJl c29sdmVyOjp+UmVzb2x2ZXIoKQoreworICAgIENGSG9zdFVuc2NoZWR1bGVGcm9tUnVuTG9vcCho b3N0LCBDRlJ1bkxvb3BHZXRDdXJyZW50KCksIGtDRlJ1bkxvb3BEZWZhdWx0TW9kZSk7CisgICAg Q0ZIb3N0U2V0Q2xpZW50KGhvc3QsIG51bGxwdHIsIG51bGxwdHIpOworICAgIENGUmVsZWFzZSho b3N0KTsKK30KKwogdm9pZCBOZXR3b3JrUlRDUHJvdmlkZXI6OnN0b3BSZXNvbHZlcih1aW50NjRf dCBpZGVudGlmaWVyKQogewogICAgIGF1dG8gcmVzb2x2ZXIgPSBtX3Jlc29sdmVycy50YWtlKGlk ZW50aWZpZXIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvd2Vi cnRjL05ldHdvcmtSVENQcm92aWRlci5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mv d2VicnRjL05ldHdvcmtSVENQcm92aWRlci5oCmluZGV4IDM0ZmY1ZGIyMjk1OWI3M2YxOGFmYTky NDI2ZDY2YmRkM2ZjYzk4ZWUuLjYwY2Q5MThmY2RlNzZjMTk3NDg0NThkNTFmMmQ5ZGUxNTU4MmU5 ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3 b3JrUlRDUHJvdmlkZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93ZWJy dGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmgKQEAgLTkxLDcgKzkxLDcgQEAgcHJpdmF0ZToKICAgICAg ICAgICAgIDogaWRlbnRpZmllcihpZGVudGlmaWVyKQogICAgICAgICAgICAgLCBydGNQcm92aWRl cihydGNQcm92aWRlcikKICAgICAgICAgICAgICwgaG9zdChXVEZNb3ZlKGhvc3QpKSB7IH0KLSAg ICAgICAgflJlc29sdmVyKCkgeyBDRlJlbGVhc2UoaG9zdCk7IH0KKyAgICAgICAgflJlc29sdmVy KCk7CiAKICAgICAgICAgdWludDY0X3QgaWRlbnRpZmllcjsKICAgICAgICAgTmV0d29ya1JUQ1By b3ZpZGVyJiBydGNQcm92aWRlcjsK 307283 2017-04-17 11:17:46 -0700 2017-04-17 17:14:25 -0700 Patch bug-170889-20170417111746.patch text/plain 3032 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTM0ZjY0NDI3OTA5MDgz MmM3ZWZhZWFmZTU0ZTFhZWYzZDJmMjdjNi4uMDQwOTQxZWZiMGM2MTEzYTBjMGY0YzFmYzg3MDIx YTk0ZTRkYzRkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA0LTE3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBjb20uYXBwbGUuV2ViS2l0 Lk5ldHdvcmtpbmcuRGV2ZWxvcG1lbnQgY3Jhc2hlZCBpbiBjb20uYXBwbGUuV2ViS2l0OiBXZWJL aXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6cmVzb2x2ZWROYW1lCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA4ODkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3 b3JrUlRDUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUlRDUHJvdmlkZXI6 OlJlc29sdmVyOjp+UmVzb2x2ZXIpOiBVbnNjaGVkdWxlIHRoZSBob3N0IHJlc29sdXRpb24gaW4g YWRkaXRpb24gdG8gY2FuY2VsbGluZyBpdC4KKyAgICAgICAgUHJvdmlkaW5nIGEgdGVzdCB3b3Vs ZCBuZWVkIHRvIHN0b3AgdGhlIHJlc29sdmVyIGJldHdlZW4gdGhlIHRpbWUgdGhlIHJlc29sdmVy IGlzIGNyZWF0ZWQgYW5kIGdldHMKKyAgICAgICAgZGF0YSBpbiB0aGUgbmV0d29yayBwcm9jZXNz LiBPciB3ZSB3b3VsZCBuZWVkIHRvIGNoYW5nZSBSZXNvbHZlciB0byBiZSBpbnN0YW50aWF0ZWQv dGVzdGVkIG9uIGl0cyBvd24uCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdv cmtSVENQcm92aWRlci5oOgorCiAyMDE3LTA0LTExICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBXZWJLaXQgdW5uZWNlc3NhcmlseSBzb2Z0LWxpbmtz IENvcmVQcmVkaWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwCmluZGV4IGUyYTEwODBlYjM4ZTM3 ZjExM2MzZDI0N2MzMzRkZWUwMzJmZDA3MTEuLjQ5NDM1MTFiMGQwMzU3ZTFkZDIwNmMwOWJmNTlk MWRlNzZkYzZiODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3dl YnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwCkBAIC0xNTksMTEgKzE1OSwxNyBA QCB2b2lkIE5ldHdvcmtSVENQcm92aWRlcjo6Y3JlYXRlUmVzb2x2ZXIodWludDY0X3QgaWRlbnRp ZmllciwgY29uc3QgU3RyaW5nJiBhZGRyZQogICAgIG1fcmVzb2x2ZXJzLmFkZChpZGVudGlmaWVy LCBXVEZNb3ZlKHJlc29sdmVyKSk7CiB9CiAKK05ldHdvcmtSVENQcm92aWRlcjo6UmVzb2x2ZXI6 On5SZXNvbHZlcigpCit7CisgICAgQ0ZIb3N0VW5zY2hlZHVsZUZyb21SdW5Mb29wKGhvc3QuZ2V0 KCksIENGUnVuTG9vcEdldEN1cnJlbnQoKSwga0NGUnVuTG9vcERlZmF1bHRNb2RlKTsKKyAgICBD Rkhvc3RTZXRDbGllbnQoaG9zdC5nZXQoKSwgbnVsbHB0ciwgbnVsbHB0cik7Cit9CisKIHZvaWQg TmV0d29ya1JUQ1Byb3ZpZGVyOjpzdG9wUmVzb2x2ZXIodWludDY0X3QgaWRlbnRpZmllcikKIHsK ICAgICBhdXRvIHJlc29sdmVyID0gbV9yZXNvbHZlcnMudGFrZShpZGVudGlmaWVyKTsKICAgICBp ZiAocmVzb2x2ZXIpCi0gICAgICAgIENGSG9zdENhbmNlbEluZm9SZXNvbHV0aW9uKHJlc29sdmVy LT5ob3N0LCBDRkhvc3RJbmZvVHlwZTo6a0NGSG9zdEFkZHJlc3Nlcyk7CisgICAgICAgIENGSG9z dENhbmNlbEluZm9SZXNvbHV0aW9uKHJlc29sdmVyLT5ob3N0LmdldCgpLCBDRkhvc3RJbmZvVHlw ZTo6a0NGSG9zdEFkZHJlc3Nlcyk7CiB9CiAKIHZvaWQgTmV0d29ya1JUQ1Byb3ZpZGVyOjpyZXNv bHZlZE5hbWUoQ0ZIb3N0UmVmIGhvc3RSZWYsIENGSG9zdEluZm9UeXBlIHR5cGVJbmZvLCBjb25z dCBDRlN0cmVhbUVycm9yICplcnJvciwgdm9pZCAqaW5mbykKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuaCBiL1NvdXJj ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuaAppbmRl eCAzNGZmNWRiMjI5NTliNzNmMThhZmE5MjQyNmQ2NmJkZDNmY2M5OGVlLi5kOGZiM2NkYWI1YmVi MmUyZjQ2ZmQ1NDk1MTgxNWYyZDViODBhMWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmgKKysrIGIvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5oCkBAIC05MSwx MSArOTEsMTEgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIDogaWRlbnRpZmllcihpZGVudGlmaWVy KQogICAgICAgICAgICAgLCBydGNQcm92aWRlcihydGNQcm92aWRlcikKICAgICAgICAgICAgICwg aG9zdChXVEZNb3ZlKGhvc3QpKSB7IH0KLSAgICAgICAgflJlc29sdmVyKCkgeyBDRlJlbGVhc2Uo aG9zdCk7IH0KKyAgICAgICAgflJlc29sdmVyKCk7CiAKICAgICAgICAgdWludDY0X3QgaWRlbnRp ZmllcjsKICAgICAgICAgTmV0d29ya1JUQ1Byb3ZpZGVyJiBydGNQcm92aWRlcjsKLSAgICAgICAg Q0ZIb3N0UmVmIGhvc3Q7CisgICAgICAgIFJldGFpblB0cjxDRkhvc3RSZWY+IGhvc3Q7CiAgICAg fTsKIAogICAgIEhhc2hNYXA8dWludDY0X3QsIHN0ZDo6dW5pcXVlX3B0cjxSZXNvbHZlcj4+IG1f cmVzb2x2ZXJzOwo=