170875 2017-04-15 08:26:25 -0700 Cannot compile JavaScriptCore/runtime/VMTraps.cpp on FreeBSD because std::pair has a non-trivial copy constructor 2017-04-19 11:25:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lantw44 jfbastien buildbot commit-queue fujii jfbastien keith_miller mark.lam msaboff saam ysuzuki oldest_to_newest 1297669 0 lantw44 2017-04-15 08:26:25 -0700 In JavaScriptCore/runtime/VMTraps.cpp, function findActiveVMAndStackBounds returns a WTF::Expected<std::pair<JSC::VM*, WTF::StackBounds>, JSC::VMTraps::Error>. The parent class of this type is WTF::ExpectedDetail::ConstexprBase<std::pair<JSC::VM*, WTF::StackBounds>, JSC::VMTraps::Error>. WTF::ExpectedDetail::ConstexprBase doesn't have a user-defined copy constructor, and its implicitly-defined copy constructor is deleted because the default std::pair implementation on FreeBSD has a non-trivial copy constructor. /usr/include/c++/v1/__config says _LIBCPP_TRIVIAL_PAIR_COPY_CTOR is disabled in order to keep ABI compatibility: https://svnweb.freebsd.org/changeset/base/261801. Error messages showed by the compiler (clang 3.8): /path/to/WebKit/Source/JavaScriptCore/runtime/VMTraps.cpp:96:9: error: returning object of type 'Expected<std::pair<VM *, StackBounds>, VMTraps::Error>' invokes deleted constructor return makeUnexpected(VMTraps::Error::LockUnavailable); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/Expected.h:262:5: note: explicitly defaulted function was implicitly deleted here Expected(const Expected&) = default; ^ ../../Source/WTF/wtf/Expected.h:248:18: note: copy constructor of 'Expected<std::__1::pair<JSC::VM *, WTF::StackBounds>, JSC::VMTraps::Error>' is implicitly deleted because base class 'ExpectedDetail::BaseSelect<pair<VM *, StackBounds>, Error>' (aka 'WTF::ExpectedDetail::ConstexprBase<std::__1::pair<JSC::VM *, WTF::StackBounds>, JSC::VMTraps::Error>') has a deleted copy constructor class Expected : private ExpectedDetail::BaseSelect<T, E> { ^ ../../Source/WTF/wtf/Expected.h:145:44: note: copy constructor of 'ConstexprBase<std::__1::pair<JSC::VM *, WTF::StackBounds>, JSC::VMTraps::Error>' is implicitly deleted because field 's' has a deleted copy constructor ConstexprStorage<ValueType, ErrorType> s; ^ ../../Source/WTF/wtf/Expected.h:87:15: note: copy constructor of 'ConstexprStorage<std::__1::pair<JSC::VM *, WTF::StackBounds>, JSC::VMTraps::Error>' is implicitly deleted because variant field 'val' has a non-trivial copy constructor ValueType val; ^ 1298636 1 jfbastien 2017-04-19 01:25:59 -0700 It is surprising to see the constexpr version being instantiated here. 1298680 2 lantw44 2017-04-19 08:27:47 -0700 (In reply to JF Bastien from comment #1) > It is surprising to see the constexpr version being instantiated here. JSC::VM*, WTF::StackBounds, JSC::VMTraps::Error are all trivially destructible, so WTF::ExpectedDetail::BaseSelect is WTF::ExpectedDetail::ConstexprBase here. 1298709 3 307486 jfbastien 2017-04-19 09:54:47 -0700 Created attachment 307486 patch (In reply to Ting-Wei Lan from comment #2) > (In reply to JF Bastien from comment #1) > > It is surprising to see the constexpr version being instantiated here. > > JSC::VM*, WTF::StackBounds, JSC::VMTraps::Error are all trivially > destructible, so WTF::ExpectedDetail::BaseSelect is > WTF::ExpectedDetail::ConstexprBase here. Derp, right you are! Here's a patch that works around the issue. 1298712 4 307486 mark.lam 2017-04-19 09:56:53 -0700 Comment on attachment 307486 patch r=me if EWS bots build and are happy. 1298728 5 307486 jfbastien 2017-04-19 10:40:40 -0700 Comment on attachment 307486 patch Tests are broken for unrelated reason. Fetch or somesuch. cq+ 1298745 6 307486 commit-queue 2017-04-19 11:25:46 -0700 Comment on attachment 307486 patch Clearing flags on attachment: 307486 Committed r215522: <http://trac.webkit.org/changeset/215522> 1298746 7 commit-queue 2017-04-19 11:25:48 -0700 All reviewed patches have been landed. Closing bug. 307486 2017-04-19 09:54:47 -0700 2017-04-19 11:25:46 -0700 patch 0001-expected-pair.patch text/plain 3973 jfbastien RnJvbSA1ZjM4ZjdiOTM1NjI0ODcyMmEwZTg3NTRkOTk1NDMyYWJkZWI0YTYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBXZWQsIDE5IEFwciAyMDE3IDA5OjU0OjA0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gZXhwZWN0 ZWQtcGFpcgoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICB8 IDI0ICsrKysrKysrKysrKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk1UcmFwcy5jcHAgfCAxNSArKysrKysrKysrLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMzQg aW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRl eCBmNDZhY2YzLi5kMDcxOThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy NyBAQAorMjAxNy0wNC0xOSAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CisKKyAg ICAgICAgQ2Fubm90IGNvbXBpbGUgSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTVRyYXBzLmNwcCBv biBGcmVlQlNEIGJlY2F1c2Ugc3RkOjpwYWlyIGhhcyBhIG5vbi10cml2aWFsIGNvcHkgY29uc3Ry dWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 MDg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdU Rjo6RXhwZWN0ZWREZXRhaWw6OkNvbnN0ZXhwckJhc2UgZG9lc24ndCBoYXZlIGEgdXNlci1kZWZp bmVkCisgICAgICAgIGNvcHkgY29uc3RydWN0b3IsIGFuZCBpdHMgaW1wbGljaXRseS1kZWZpbmVk IGNvcHkgY29uc3RydWN0b3IgaXMKKyAgICAgICAgZGVsZXRlZCBiZWNhdXNlIHRoZSBkZWZhdWx0 IHN0ZDo6cGFpciBpbXBsZW1lbnRhdGlvbiBvbiBGcmVlQlNECisgICAgICAgIGhhcyBhIG5vbi10 cml2aWFsIGNvcHkgY29uc3RydWN0b3IuIC91c3IvaW5jbHVkZS9jKysvdjEvX19jb25maWcKKyAg ICAgICAgc2F5cyBfTElCQ1BQX1RSSVZJQUxfUEFJUl9DT1BZX0NUT1IgaXMgZGlzYWJsZWQgaW4g b3JkZXIgdG8ga2VlcAorICAgICAgICBBQkkgY29tcGF0aWJpbGl0eToKKyAgICAgICAgaHR0cHM6 Ly9zdm53ZWIuZnJlZWJzZC5vcmcvY2hhbmdlc2V0L2Jhc2UvMjYxODAxLgorCisgICAgICAgIFRo YXQncyBhIGh1Z2UgYnVtbWVyLCBhbmQgSSdtIG5vdCBhIGZhbiBvZiBicm9rZW4gc3RkbGlicywg YnV0IGluCisgICAgICAgIHRoaXMgY2FzZSBpdCdzIHByZXR0eSBuaWNlIHRvIGhhdmUgYSBjdXN0 b20gbmFtZWQgdHlwZSBhbnl3YXlzIGFuZAorICAgICAgICBjb3N0cyBub3RoaW5nLgorCisgICAg ICAgICogcnVudGltZS9WTVRyYXBzLmNwcDoKKyAgICAgICAgKEpTQzo6ZmluZEFjdGl2ZVZNQW5k U3RhY2tCb3VuZHMpOgorICAgICAgICAoSlNDOjpoYW5kbGVTaWd1c3IxKToKKyAgICAgICAgKEpT Qzo6aGFuZGxlU2lndHJhcCk6CisKIDIwMTctMDQtMTggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIHIyMTE2NzAgYnJva2UgZG91YmxlIHRvIGludCBjb252ZXJzaW9u LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTVRyYXBzLmNwcAppbmRleCAxMTYzZmZi Li5lNjI4NWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTVRy YXBzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTVRyYXBzLmNwcApA QCAtODgsNyArODgsMTIgQEAgaW5saW5lIHN0YXRpYyBib29sIHZtSXNJbmFjdGl2ZShWTSYgdm0p CiAgICAgcmV0dXJuICF2bS5lbnRyeVNjb3BlICYmICF2bS5vd25lclRocmVhZCgpOwogfQogCi1z dGF0aWMgRXhwZWN0ZWQ8c3RkOjpwYWlyPFZNKiwgU3RhY2tCb3VuZHM+LCBWTVRyYXBzOjpFcnJv cj4gZmluZEFjdGl2ZVZNQW5kU3RhY2tCb3VuZHMoU2lnbmFsQ29udGV4dCYgY29udGV4dCkKK3N0 cnVjdCBWTUFuZFN0YWNrQm91bmRzIHsKKyAgICBWTSogdm07CisgICAgU3RhY2tCb3VuZHMgc3Rh Y2tCb3VuZHM7Cit9OworCitzdGF0aWMgRXhwZWN0ZWQ8Vk1BbmRTdGFja0JvdW5kcywgVk1UcmFw czo6RXJyb3I+IGZpbmRBY3RpdmVWTUFuZFN0YWNrQm91bmRzKFNpZ25hbENvbnRleHQmIGNvbnRl eHQpCiB7CiAgICAgVk1JbnNwZWN0b3ImIGluc3BlY3RvciA9IFZNSW5zcGVjdG9yOjppbnN0YW5j ZSgpOwogICAgIGF1dG8gbG9ja2VyID0gdHJ5SG9sZExvY2soaW5zcGVjdG9yLmdldExvY2soKSk7 CkBAIC0xMjQsNyArMTI5LDcgQEAgc3RhdGljIEV4cGVjdGVkPHN0ZDo6cGFpcjxWTSosIFN0YWNr Qm91bmRzPiwgVk1UcmFwczo6RXJyb3I+IGZpbmRBY3RpdmVWTUFuZFN0YWMKIAogICAgIGlmICgh YWN0aXZlVk0gJiYgdW5hYmxlVG9BY3F1aXJlTWFjaGluZVRocmVhZHNMb2NrKQogICAgICAgICBy ZXR1cm4gbWFrZVVuZXhwZWN0ZWQoVk1UcmFwczo6RXJyb3I6OkxvY2tVbmF2YWlsYWJsZSk7Ci0g ICAgcmV0dXJuIHN0ZDo6bWFrZV9wYWlyKGFjdGl2ZVZNLCBzdGFja0JvdW5kcyk7CisgICAgcmV0 dXJuIFZNQW5kU3RhY2tCb3VuZHMgeyBhY3RpdmVWTSwgc3RhY2tCb3VuZHMgfTsKIH0KIAogc3Rh dGljIHZvaWQgaGFuZGxlU2lndXNyMShpbnQgc2lnbmFsTnVtYmVyLCBzaWdpbmZvX3QqIGluZm8s IHZvaWQqIHVhcCkKQEAgLTEzMiw5ICsxMzcsOSBAQCBzdGF0aWMgdm9pZCBoYW5kbGVTaWd1c3Ix KGludCBzaWduYWxOdW1iZXIsIHNpZ2luZm9fdCogaW5mbywgdm9pZCogdWFwKQogICAgIFNpZ25h bENvbnRleHQgY29udGV4dChzdGF0aWNfY2FzdDx1Y29udGV4dF90Kj4odWFwKS0+dWNfbWNvbnRl eHQpOwogICAgIGF1dG8gYWN0aXZlVk1BbmRTdGFja0JvdW5kcyA9IGZpbmRBY3RpdmVWTUFuZFN0 YWNrQm91bmRzKGNvbnRleHQpOwogICAgIGlmIChhY3RpdmVWTUFuZFN0YWNrQm91bmRzKSB7Ci0g ICAgICAgIFZNKiB2bSA9IGFjdGl2ZVZNQW5kU3RhY2tCb3VuZHMudmFsdWUoKS5maXJzdDsKKyAg ICAgICAgVk0qIHZtID0gYWN0aXZlVk1BbmRTdGFja0JvdW5kcy52YWx1ZSgpLnZtOwogICAgICAg ICBpZiAodm0pIHsKLSAgICAgICAgICAgIFN0YWNrQm91bmRzIHN0YWNrQm91bmRzID0gYWN0aXZl Vk1BbmRTdGFja0JvdW5kcy52YWx1ZSgpLnNlY29uZDsKKyAgICAgICAgICAgIFN0YWNrQm91bmRz IHN0YWNrQm91bmRzID0gYWN0aXZlVk1BbmRTdGFja0JvdW5kcy52YWx1ZSgpLnN0YWNrQm91bmRz OwogICAgICAgICAgICAgVk1UcmFwcyYgdHJhcHMgPSB2bS0+dHJhcHMoKTsKICAgICAgICAgICAg IGlmICh0cmFwcy5uZWVkVHJhcEhhbmRsaW5nKCkpCiAgICAgICAgICAgICAgICAgdHJhcHMudHJ5 SW5zdGFsbFRyYXBCcmVha3BvaW50cyhjb250ZXh0LCBzdGFja0JvdW5kcyk7CkBAIC0xNTMsNyAr MTU4LDcgQEAgc3RhdGljIHZvaWQgaGFuZGxlU2lndHJhcChpbnQgc2lnbmFsTnVtYmVyLCBzaWdp bmZvX3QqIGluZm8sIHZvaWQqIHVhcCkKICAgICBpZiAoIWFjdGl2ZVZNQW5kU3RhY2tCb3VuZHMp CiAgICAgICAgIHJldHVybjsgLy8gTGV0IHRoZSBTaWduYWxTZW5kZXIgdHJ5IGFnYWluIGxhdGVy LgogCi0gICAgVk0qIHZtID0gYWN0aXZlVk1BbmRTdGFja0JvdW5kcy52YWx1ZSgpLmZpcnN0Owor ICAgIFZNKiB2bSA9IGFjdGl2ZVZNQW5kU3RhY2tCb3VuZHMudmFsdWUoKS52bTsKICAgICBpZiAo dm0pIHsKICAgICAgICAgVk1UcmFwcyYgdHJhcHMgPSB2bS0+dHJhcHMoKTsKICAgICAgICAgaWYg KCF0cmFwcy5uZWVkVHJhcEhhbmRsaW5nKCkpCi0tIAoyLjEwLjEKCg==