170866 2017-04-14 17:10:16 -0700 Include resource size in some existing logging 2017-04-15 19:40:15 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 krollin krollin achristensen commit-queue oldest_to_newest 1297583 0 krollin 2017-04-14 17:10:16 -0700 In order to correlate resource load times with resource size, we log when the resource is starting to be downloaded and when the resource is finished loading. In NetworkResourceLoader::didReceiveResponse, we also log the expected resource size. However, we can only log the length if it is provided in Content-Length, which is not always the case. If it's not provided, we end up logging "length = -1". To make up for this, change NetworkResourceLoader::didFinishLoading and WebResourceLoader:: didFinishLoading to log the length once we know it. 1297591 1 307170 krollin 2017-04-14 17:39:11 -0700 Created attachment 307170 Patch 1297722 2 307170 commit-queue 2017-04-15 19:40:13 -0700 Comment on attachment 307170 Patch Clearing flags on attachment: 307170 Committed r215397: <http://trac.webkit.org/changeset/215397> 1297723 3 commit-queue 2017-04-15 19:40:15 -0700 All reviewed patches have been landed. Closing bug. 307170 2017-04-14 17:39:11 -0700 2017-04-15 19:40:13 -0700 Patch bug-170866-20170414173910.patch text/plain 6517 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1Mzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjlkNmYwNDRiZDQ4OTUw YzlkMTQzYjI2ODg3MTYwNTdkNTU3ZDE3Ni4uNDBjMWFlMGRmODgxZmI3Y2UxZGEzMWM4Yzc3MGRj YTU2M2I2NTRhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE3LTA0LTE0ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNsdWRlIHJlc291cmNl IHNpemUgaW4gc29tZSBleGlzdGluZyBsb2dnaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA4NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbiBvcmRlciB0byBjb3JyZWxhdGUgcmVzb3VyY2UgbG9h ZCB0aW1lcyB3aXRoIHJlc291cmNlIHNpemUsIHdlIGxvZworICAgICAgICB3aGVuIHRoZSByZXNv dXJjZSBpcyBzdGFydGluZyB0byBiZSBsb2FkZWQgYW5kIHdoZW4gdGhlIHJlc291cmNlIGlzCisg ICAgICAgIGZpbmlzaGVkIGxvYWRpbmcuIEluIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkUmVj ZWl2ZVJlc3BvbnNlLCB3ZQorICAgICAgICBhbHNvIGxvZyB0aGUgZXhwZWN0ZWQgcmVzb3VyY2Ug bGVuZ3RoLiBIb3dldmVyLCB3ZSBjYW4gb25seSBsb2cgdGhlCisgICAgICAgIGxlbmd0aCBpZiBp dCBpcyBwcm92aWRlZCBpbiBDb250ZW50LUxlbmd0aCwgd2hpY2ggaXMgbm90IGFsd2F5cyB0aGUK KyAgICAgICAgY2FzZS4gSWYgaXQncyBub3QgcHJvdmlkZWQsIHdlIGVuZCB1cCBsb2dnaW5nICJs ZW5ndGggPSAtMSIuIFRvIG1ha2UKKyAgICAgICAgdXAgZm9yIHRoaXMsIGNoYW5nZSBOZXR3b3Jr UmVzb3VyY2VMb2FkZXI6OmRpZEZpbmlzaExvYWRpbmcgYW5kCisgICAgICAgIFdlYlJlc291cmNl TG9hZGVyOjogZGlkRmluaXNoTG9hZGluZyB0byBsb2cgdGhlIGxlbmd0aCBvbmNlIHdlIGtub3cK KyAgICAgICAgaXQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VM b2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZFJl Y2VpdmVCdWZmZXIpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRp ZEZpbmlzaExvYWRpbmcpOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJj ZUxvYWRlci5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRl ci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0 YSk6CisgICAgICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZGVyOjpkaWRGaW5pc2hSZXNvdXJj ZUxvYWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5o OgorCiAyMDE3LTA0LTE0ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFtNZWRpYVNvdXJjZV0gUHVzaCBjYXBhYmlsaXRpZXMgYWNyb3NzIHByb2Nlc3MgYm91bmRh cnkgZHVyaW5nIFVJUHJvY2VzcyBjYXB0dXJlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggOGZkYTA3NTFk OWQ5YWZiMWMzNjQ1YWE3YTZlMDA0NWEwODIwNTNkMy4uOGY3NTk4ZGMzYjE5MTdjNWMyM2MyYmVh MjM3ZDE2NDFjMjBlZDc3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0zNjYsMTAgKzM2NiwxMCBAQCBh dXRvIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKFJlc291cmNlUmVz cG9uc2UmJiByZWNlaXZlZFJlc3BvbgogCiB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlk UmVjZWl2ZUJ1ZmZlcihSZWY8U2hhcmVkQnVmZmVyPiYmIGJ1ZmZlciwgaW50IHJlcG9ydGVkRW5j b2RlZERhdGFMZW5ndGgpCiB7Ci0gICAgaWYgKCFtX2hhc1JlY2VpdmVkRGF0YSkgeworICAgIGlm ICghbV9udW1CeXRlc1JlY2VpdmVkKSB7CiAgICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQo ImRpZFJlY2VpdmVCdWZmZXI6IFN0YXJ0ZWQgcmVjZWl2aW5nIGRhdGEgKHBhZ2VJRCA9ICUiIFBS SXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJdTY0ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1NjQgIiki LCBtX3BhcmFtZXRlcnMud2ViUGFnZUlELCBtX3BhcmFtZXRlcnMud2ViRnJhbWVJRCwgbV9wYXJh bWV0ZXJzLmlkZW50aWZpZXIpOwotICAgICAgICBtX2hhc1JlY2VpdmVkRGF0YSA9IHRydWU7CiAg ICAgfQorICAgIG1fbnVtQnl0ZXNSZWNlaXZlZCArPSBidWZmZXItPnNpemUoKTsKIAogI2lmIEVO QUJMRShORVRXT1JLX0NBQ0hFKQogICAgIEFTU0VSVCghbV9jYWNoZUVudHJ5Rm9yVmFsaWRhdGlv bik7CkBAIC0zOTgsNyArMzk4LDcgQEAgdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZFJl Y2VpdmVCdWZmZXIoUmVmPFNoYXJlZEJ1ZmZlcj4mJiBidWZmZXIsIGludCByZXAKIAogdm9pZCBO ZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZEZpbmlzaExvYWRpbmcoY29uc3QgTmV0d29ya0xvYWRN ZXRyaWNzJiBuZXR3b3JrTG9hZE1ldHJpY3MpCiB7Ci0gICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dF RCgiZGlkRmluaXNoTG9hZGluZzogKHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIg UFJJdTY0ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1NjQgIikiLCBtX3BhcmFtZXRlcnMud2ViUGFn ZUlELCBtX3BhcmFtZXRlcnMud2ViRnJhbWVJRCwgbV9wYXJhbWV0ZXJzLmlkZW50aWZpZXIpOwor ICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoImRpZEZpbmlzaExvYWRpbmc6IChwYWdlSUQgPSAl IiBQUkl1NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCByZXNvdXJjZUlEID0gJSIgUFJJdTY0 ICIsIGxlbmd0aCA9ICV6ZCkiLCBtX3BhcmFtZXRlcnMud2ViUGFnZUlELCBtX3BhcmFtZXRlcnMu d2ViRnJhbWVJRCwgbV9wYXJhbWV0ZXJzLmlkZW50aWZpZXIsIG1fbnVtQnl0ZXNSZWNlaXZlZCk7 CiAKICNpZiBFTkFCTEUoTkVUV09SS19DQUNIRSkKICAgICBpZiAobV9jYWNoZUVudHJ5Rm9yVmFs aWRhdGlvbikgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0 d29ya1Jlc291cmNlTG9hZGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuaAppbmRleCAxMGExMGZhYzk0Y2QyMjMwYzE5MzNlYTk4MjU3MTQy Zjk2MWE2MjZiLi5mY2M5OTIyMzZlNDAzYWI4NTkwYzMwNDhkMjdmZmVmMjliYmMwYjc1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2Fk ZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VM b2FkZXIuaApAQCAtMTUzLDcgKzE1Myw3IEBAIHByaXZhdGU6CiAKICAgICBib29sIG1fZGlkQ29u c3VtZVNhbmRib3hFeHRlbnNpb25zIHsgZmFsc2UgfTsKICAgICBib29sIG1fZGVmZXJzTG9hZGlu ZyB7IGZhbHNlIH07Ci0gICAgYm9vbCBtX2hhc1JlY2VpdmVkRGF0YSB7IGZhbHNlIH07CisgICAg c2l6ZV90IG1fbnVtQnl0ZXNSZWNlaXZlZCB7IDAgfTsKIAogICAgIHVuc2lnbmVkIG1fcmV0cmll dmVkRGVyaXZlZERhdGFDb3VudCB7IDAgfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggZjhjZDYxM2Fi MWUxNzJlMDZlNzg5ZTlmNGExYWI2MWUwZWRhMGRkMy4uYTNiOWNhY2RjNmY0NGMwNGY1NGJlZWQx NzRlMjM3OWRmOGYyYzFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0xMjcsMTAgKzEyNywxMCBAQCB2 b2lkIFdlYlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YShjb25zdCBJUEM6OkRhdGFSZWZl cmVuY2UmIGRhdGEsIGludDY0X3QgZQogewogICAgIExPRyhOZXR3b3JrLCAiKFdlYlByb2Nlc3Mp IFdlYlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YSBvZiBzaXplICVsdSBmb3IgJyVzJyIs IGRhdGEuc2l6ZSgpLCBtX2NvcmVMb2FkZXItPnVybCgpLnN0cmluZygpLmxhdGluMSgpLmRhdGEo KSk7CiAKLSAgICBpZiAoIW1faGFzUmVjZWl2ZWREYXRhKSB7CisgICAgaWYgKCFtX251bUJ5dGVz UmVjZWl2ZWQpIHsKICAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgiZGlkUmVjZWl2ZURh dGE6IFN0YXJ0ZWQgcmVjZWl2aW5nIGRhdGEgKHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlE ID0gJSIgUFJJdTY0ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1NjQgIikiLCBtX3RyYWNraW5nUGFy YW1ldGVycy5wYWdlSUQsIG1fdHJhY2tpbmdQYXJhbWV0ZXJzLmZyYW1lSUQsIG1fdHJhY2tpbmdQ YXJhbWV0ZXJzLnJlc291cmNlSUQpOwotICAgICAgICBtX2hhc1JlY2VpdmVkRGF0YSA9IHRydWU7 CiAgICAgfQorICAgIG1fbnVtQnl0ZXNSZWNlaXZlZCArPSBkYXRhLnNpemUoKTsKIAogICAgIG1f Y29yZUxvYWRlci0+ZGlkUmVjZWl2ZURhdGEocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4o ZGF0YS5kYXRhKCkpLCBkYXRhLnNpemUoKSwgZW5jb2RlZERhdGFMZW5ndGgsIERhdGFQYXlsb2Fk Qnl0ZXMpOwogfQpAQCAtMTQ2LDcgKzE0Niw3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkZXI6OmRp ZFJldHJpZXZlRGVyaXZlZERhdGEoY29uc3QgU3RyaW5nJiB0eXBlLCBjb25zdCBJUEM6OkRhCiB2 b2lkIFdlYlJlc291cmNlTG9hZGVyOjpkaWRGaW5pc2hSZXNvdXJjZUxvYWQoY29uc3QgTmV0d29y a0xvYWRNZXRyaWNzJiBuZXR3b3JrTG9hZE1ldHJpY3MpCiB7CiAgICAgTE9HKE5ldHdvcmssICIo V2ViUHJvY2VzcykgV2ViUmVzb3VyY2VMb2FkZXI6OmRpZEZpbmlzaFJlc291cmNlTG9hZCBmb3Ig JyVzJyIsIG1fY29yZUxvYWRlci0+dXJsKCkuc3RyaW5nKCkubGF0aW4xKCkuZGF0YSgpKTsKLSAg ICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJkaWRGaW5pc2hSZXNvdXJjZUxvYWQ6IChwYWdlSUQg PSAlIiBQUkl1NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCByZXNvdXJjZUlEID0gJSIgUFJJ dTY0ICIpIiwgbV90cmFja2luZ1BhcmFtZXRlcnMucGFnZUlELCBtX3RyYWNraW5nUGFyYW1ldGVy cy5mcmFtZUlELCBtX3RyYWNraW5nUGFyYW1ldGVycy5yZXNvdXJjZUlEKTsKKyAgICBSRUxFQVNF X0xPR19JRl9BTExPV0VEKCJkaWRGaW5pc2hSZXNvdXJjZUxvYWQ6IChwYWdlSUQgPSAlIiBQUkl1 NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCByZXNvdXJjZUlEID0gJSIgUFJJdTY0ICIsIGxl bmd0aCA9ICV6ZCkiLCBtX3RyYWNraW5nUGFyYW1ldGVycy5wYWdlSUQsIG1fdHJhY2tpbmdQYXJh bWV0ZXJzLmZyYW1lSUQsIG1fdHJhY2tpbmdQYXJhbWV0ZXJzLnJlc291cmNlSUQsIG1fbnVtQnl0 ZXNSZWNlaXZlZCk7CiAKICAgICBtX2NvcmVMb2FkZXItPmRpZEZpbmlzaExvYWRpbmcobmV0d29y a0xvYWRNZXRyaWNzKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv TmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmgKaW5kZXggYjU0ZDJmYTEwZmMwZGZjM2NjMGQzNThk MjY5MDU5YzJjZDk0ZGNiNC4uNjQyMWMyMzM1YmVkMWI3NGU1ZjA4ZTY0ZTk3MTc3MGIzY2RiNWJm NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291 cmNlTG9hZGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJl c291cmNlTG9hZGVyLmgKQEAgLTg3LDcgKzg3LDcgQEAgcHJpdmF0ZToKIAogICAgIFJlZlB0cjxX ZWJDb3JlOjpSZXNvdXJjZUxvYWRlcj4gbV9jb3JlTG9hZGVyOwogICAgIFRyYWNraW5nUGFyYW1l dGVycyBtX3RyYWNraW5nUGFyYW1ldGVyczsKLSAgICBib29sIG1faGFzUmVjZWl2ZWREYXRhIHsg ZmFsc2UgfTsKKyAgICBzaXplX3QgbV9udW1CeXRlc1JlY2VpdmVkIHsgMCB9OwogfTsKIAogfSAv LyBuYW1lc3BhY2UgV2ViS2l0Cg==