<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>170865</bug_id>
          
          <creation_ts>2017-04-14 16:21:35 -0700</creation_ts>
          <short_desc>ParseInt intrinsic in DFG backend doesn&apos;t properly flush its operands</short_desc>
          <delta_ts>2017-07-01 12:15:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cedric.bellegarde</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1297562</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-04-14 16:21:35 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297569</commentid>
    <comment_count>1</comment_count>
      <attachid>307166</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-04-14 16:27:20 -0700</bug_when>
    <thetext>Created attachment 307166
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297570</commentid>
    <comment_count>2</comment_count>
      <attachid>307166</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-04-14 16:29:07 -0700</bug_when>
    <thetext>Comment on attachment 307166
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307166&amp;action=review

&gt; Source/JavaScriptCore/dfg/DFGOperations.h:176
&gt; +EncodedJSValue JIT_OPERATION operationParseIntNoRadixGeneric(ExecState*, EncodedJSValue) WTF_INTERNAL;
&gt; +EncodedJSValue JIT_OPERATION operationParseIntStringNoRadix(ExecState*, JSString*) WTF_INTERNAL;
&gt; +EncodedJSValue JIT_OPERATION operationParseIntString(ExecState*, JSString*, int32_t) WTF_INTERNAL;
&gt; +EncodedJSValue JIT_OPERATION operationParseIntGeneric(ExecState*, EncodedJSValue, int32_t) WTF_INTERNAL;

I&apos;ll revert this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297571</commentid>
    <comment_count>3</comment_count>
      <attachid>307167</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-04-14 16:29:53 -0700</bug_when>
    <thetext>Created attachment 307167
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297572</commentid>
    <comment_count>4</comment_count>
      <attachid>307167</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-04-14 16:33:46 -0700</bug_when>
    <thetext>Comment on attachment 307167
patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297573</commentid>
    <comment_count>5</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2017-04-14 16:39:45 -0700</bug_when>
    <thetext>r=me

Big twist in the C++ auto soap opera as Saam uses auto voluntarily!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297588</commentid>
    <comment_count>6</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-04-14 17:25:30 -0700</bug_when>
    <thetext>(In reply to Geoffrey Garen from comment #5)
&gt; r=me
&gt; 
&gt; Big twist in the C++ auto soap opera as Saam uses auto voluntarily!

I was actually thinking of reverting it!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297618</commentid>
    <comment_count>7</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-04-14 19:13:35 -0700</bug_when>
    <thetext>landed in:
https://trac.webkit.org/changeset/215387/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1299733</commentid>
    <comment_count>8</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2017-04-21 11:43:41 -0700</bug_when>
    <thetext>&lt;rdar://problem/31223764&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1324838</commentid>
    <comment_count>9</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-07-01 12:15:39 -0700</bug_when>
    <thetext>*** Bug 173539 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>307166</attachid>
            <date>2017-04-14 16:27:20 -0700</date>
            <delta_ts>2017-04-14 16:29:53 -0700</delta_ts>
            <desc>patch</desc>
            <filename>b-backup.diff</filename>
            <type>text/plain</type>
            <size>5940</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMTUzNzkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE0IEBACisyMDE3LTA0LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu
Y29tPgorCisgICAgICAgIFBhcnNlSW50IGludHJpbnNpYyBpbiBERkcgYmFja2VuZCBkb2Vzbid0
IHByb3Blcmx5IGZsdXNoIGl0cyBvcGVyYW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvcGFyc2UtaW50LWludHJpbnNpYy1kZmctYmFj
a2VuZC1mbHVzaC5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAoZm9vKToK
KwogMjAxNy0wNC0xNCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgogCiAgICAg
ICAgIFtKU0NdIHVzZSBFeHByZXNzaW9uRXJyb3JDbGFzc2lmaWVyIGZvciBBd2FpdEV4cHJlc3Np
b24gb3BlcmFuZApJbmRleDogSlNUZXN0cy9zdHJlc3MvcGFyc2UtaW50LWludHJpbnNpYy1kZmct
YmFja2VuZC1mbHVzaC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9wYXJzZS1pbnQt
aW50cmluc2ljLWRmZy1iYWNrZW5kLWZsdXNoLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMv
c3RyZXNzL3BhcnNlLWludC1pbnRyaW5zaWMtZGZnLWJhY2tlbmQtZmx1c2guanMJKHdvcmtpbmcg
Y29weSkKQEAgLTAsMCArMSwxNCBAQAorZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIp
CisgICAgICAgIHRocm93IG5ldyBFcnJvcigiQmFkIikKK30KKworZnVuY3Rpb24gZm9vKHgpIHsK
KyAgICByZXR1cm4geCA9PT0gcGFyc2VJbnQoeCwgMTApOworfQorbm9JbmxpbmUoZm9vKTsKKwor
Zm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7CisgICAgYXNzZXJ0KCFmb28oYCR7aX1g
KSk7CisgICAgYXNzZXJ0KGZvbyhpKSk7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJ
KHJldmlzaW9uIDIxNTM3NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdv
cmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxNy0wNC0xNCAgU2FhbSBCYXJhdGkgIDxz
YmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBQYXJzZUludCBpbnRyaW5zaWMgaW4gREZHIGJh
Y2tlbmQgZG9lc24ndCBwcm9wZXJseSBmbHVzaCBpdHMgb3BlcmFuZHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDg2NQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBERkcgYmFja2VuZCBjb2RlIG5l
ZWRlZCB0byBmaXJzdCBjYWxsaW5nIC5ncHIoKS8uanNWYWx1ZVJlZ3MoKQorICAgICAgICBiZWZv
cmUgY2FsbGluZyBmbHVzaFJlZ2lzdGVycygpLCBvciB0aGUgaW5wdXQgSlNWYWx1ZU9wZXJhbmQg
d291bGQKKyAgICAgICAgbm90IGJlIGZsdXNoZWQuCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0
aW9ucy5oOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChK
U0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQYXJzZUludCk6CisKIDIwMTctMDQtMTQg
IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBG
aXggV2luZG93cyBidWlsZCBhZnRlciByMjE1MzY4LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL2RmZy9ERkdPcGVyYXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD
b3JlL2RmZy9ERkdPcGVyYXRpb25zLmgJKHJldmlzaW9uIDIxNTM3NSkKKysrIFNvdXJjZS9KYXZh
U2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzAsMTAg
KzE3MCwxMCBAQCBpbnQzMl90IEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uTWFwSGFzaChFCiBKU0Nl
bGwqIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uSlNNYXBGaW5kQnVja2V0KEV4ZWNTdGF0ZSosIEpT
Q2VsbCosIEVuY29kZWRKU1ZhbHVlLCBpbnQzMl90KTsKIEpTQ2VsbCogSklUX09QRVJBVElPTiBv
cGVyYXRpb25KU1NldEZpbmRCdWNrZXQoRXhlY1N0YXRlKiwgSlNDZWxsKiwgRW5jb2RlZEpTVmFs
dWUsIGludDMyX3QpOwogCi1FbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblBh
cnNlSW50Tm9SYWRpeEdlbmVyaWMoRXhlY1N0YXRlKiwgRW5jb2RlZEpTVmFsdWUpOwotRW5jb2Rl
ZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25QYXJzZUludFN0cmluZ05vUmFkaXgoRXhl
Y1N0YXRlKiwgSlNTdHJpbmcqKTsKLUVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0
aW9uUGFyc2VJbnRTdHJpbmcoRXhlY1N0YXRlKiwgSlNTdHJpbmcqLCBpbnQzMl90KTsKLUVuY29k
ZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uUGFyc2VJbnRHZW5lcmljKEV4ZWNTdGF0
ZSosIEVuY29kZWRKU1ZhbHVlLCBpbnQzMl90KTsKK0VuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJ
T04gb3BlcmF0aW9uUGFyc2VJbnROb1JhZGl4R2VuZXJpYyhFeGVjU3RhdGUqLCBFbmNvZGVkSlNW
YWx1ZSkgV1RGX0lOVEVSTkFMOworRW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRp
b25QYXJzZUludFN0cmluZ05vUmFkaXgoRXhlY1N0YXRlKiwgSlNTdHJpbmcqKSBXVEZfSU5URVJO
QUw7CitFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblBhcnNlSW50U3RyaW5n
KEV4ZWNTdGF0ZSosIEpTU3RyaW5nKiwgaW50MzJfdCkgV1RGX0lOVEVSTkFMOworRW5jb2RlZEpT
VmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25QYXJzZUludEdlbmVyaWMoRXhlY1N0YXRlKiwg
RW5jb2RlZEpTVmFsdWUsIGludDMyX3QpIFdURl9JTlRFUk5BTDsKIAogSlNDZWxsKiBKSVRfT1BF
UkFUSU9OIG9wZXJhdGlvbk5ld1N0cmluZ09iamVjdChFeGVjU3RhdGUqLCBKU1N0cmluZyosIFN0
cnVjdHVyZSopOwogSlNDZWxsKiBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblRvU3RyaW5nT25DZWxs
KEV4ZWNTdGF0ZSosIEpTQ2VsbCopOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E
RkdTcGVjdWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl
L2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDIxNTM3NSkKKysrIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC0zMTUzLDM3ICszMTUzLDQ0IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQYXJzZUlu
dChOb2QKICAgICAgICAgR1BSUmVnIHJhZGl4R1BSID0gcmFkaXguZ3ByKCk7CiAgICAgICAgIGlm
IChub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkgPT0gVW50eXBlZFVzZSkgewogICAgICAgICAgICAg
SlNWYWx1ZU9wZXJhbmQgdmFsdWUodGhpcywgbm9kZS0+Y2hpbGQxKCkpOwotCi0gICAgICAgICAg
ICBmbHVzaFJlZ2lzdGVycygpOwogI2lmIFVTRShKU1ZBTFVFNjQpCi0gICAgICAgICAgICBjYWxs
T3BlcmF0aW9uKG9wZXJhdGlvblBhcnNlSW50R2VuZXJpYywgcmVzdWx0UmVncy5ncHIoKSwgdmFs
dWUuZ3ByKCksIHJhZGl4R1BSKTsKKyAgICAgICAgICAgIGF1dG8gcmVzdWx0ID0gcmVzdWx0UmVn
cy5ncHIoKTsKKyAgICAgICAgICAgIGF1dG8gdmFsdWVSZWcgPSB2YWx1ZS5ncHIoKTsKICNlbHNl
Ci0gICAgICAgICAgICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlvblBhcnNlSW50R2VuZXJpYywgcmVz
dWx0UmVncywgdmFsdWUuanNWYWx1ZVJlZ3MoKSwgcmFkaXhHUFIpOworICAgICAgICAgICAgYXV0
byByZXN1bHQgPSByZXN1bHRSZWdzOworICAgICAgICAgICAgYXV0byB2YWx1ZVJlZyA9IHZhbHVl
LmpzVmFsdWVSZWdzKCk7CiAjZW5kaWYKKworICAgICAgICAgICAgZmx1c2hSZWdpc3RlcnMoKTsK
KyAgICAgICAgICAgIGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uUGFyc2VJbnRHZW5lcmljLCByZXN1
bHQsIHZhbHVlUmVnLCByYWRpeEdQUik7CiAgICAgICAgICAgICBtX2ppdC5leGNlcHRpb25DaGVj
aygpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgU3BlY3VsYXRlQ2VsbE9wZXJhbmQg
dmFsdWUodGhpcywgbm9kZS0+Y2hpbGQxKCkpOwogICAgICAgICAgICAgR1BSUmVnIHZhbHVlR1BS
ID0gdmFsdWUuZ3ByKCk7CiAgICAgICAgICAgICBzcGVjdWxhdGVTdHJpbmcobm9kZS0+Y2hpbGQx
KCksIHZhbHVlR1BSKTsKIAotICAgICAgICAgICAgZmx1c2hSZWdpc3RlcnMoKTsKICNpZiBVU0Uo
SlNWQUxVRTY0KQotICAgICAgICAgICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb25QYXJzZUludFN0
cmluZywgcmVzdWx0UmVncy5ncHIoKSwgdmFsdWVHUFIsIHJhZGl4R1BSKTsKKyAgICAgICAgICAg
IGF1dG8gcmVzdWx0ID0gcmVzdWx0UmVncy5ncHIoKTsKICNlbHNlCi0gICAgICAgICAgICBjYWxs
T3BlcmF0aW9uKG9wZXJhdGlvblBhcnNlSW50U3RyaW5nLCByZXN1bHRSZWdzLCB2YWx1ZUdQUiwg
cmFkaXhHUFIpOworICAgICAgICAgICAgYXV0byByZXN1bHQgPSByZXN1bHRSZWdzOwogI2VuZGlm
CisKKyAgICAgICAgICAgIGZsdXNoUmVnaXN0ZXJzKCk7CisgICAgICAgICAgICBjYWxsT3BlcmF0
aW9uKG9wZXJhdGlvblBhcnNlSW50U3RyaW5nLCByZXN1bHQsIHZhbHVlR1BSLCByYWRpeEdQUik7
CiAgICAgICAgICAgICBtX2ppdC5leGNlcHRpb25DaGVjaygpOwogICAgICAgICB9CiAgICAgfSBl
bHNlIHsKICAgICAgICAgaWYgKG5vZGUtPmNoaWxkMSgpLnVzZUtpbmQoKSA9PSBVbnR5cGVkVXNl
KSB7CiAgICAgICAgICAgICBKU1ZhbHVlT3BlcmFuZCB2YWx1ZSh0aGlzLCBub2RlLT5jaGlsZDEo
KSk7Ci0KLSAgICAgICAgICAgIGZsdXNoUmVnaXN0ZXJzKCk7CiAjaWYgVVNFKEpTVkFMVUU2NCkK
LSAgICAgICAgICAgIGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uUGFyc2VJbnROb1JhZGl4R2VuZXJp
YywgcmVzdWx0UmVncy5ncHIoKSwgdmFsdWUuanNWYWx1ZVJlZ3MoKSk7CisgICAgICAgICAgICBh
dXRvIHJlc3VsdCA9IHJlc3VsdFJlZ3MuZ3ByKCk7CiAjZWxzZQotICAgICAgICAgICAgY2FsbE9w
ZXJhdGlvbihvcGVyYXRpb25QYXJzZUludE5vUmFkaXhHZW5lcmljLCByZXN1bHRSZWdzLCB2YWx1
ZS5qc1ZhbHVlUmVncygpKTsKKyAgICAgICAgICAgIGF1dG8gcmVzdWx0ID0gcmVzdWx0UmVnczsK
ICNlbmRpZgorICAgICAgICAgICAgSlNWYWx1ZVJlZ3MgdmFsdWVSZWdzID0gdmFsdWUuanNWYWx1
ZVJlZ3MoKTsKKworICAgICAgICAgICAgZmx1c2hSZWdpc3RlcnMoKTsKKyAgICAgICAgICAgIGNh
bGxPcGVyYXRpb24ob3BlcmF0aW9uUGFyc2VJbnROb1JhZGl4R2VuZXJpYywgcmVzdWx0LCB2YWx1
ZVJlZ3MpOwogICAgICAgICAgICAgbV9qaXQuZXhjZXB0aW9uQ2hlY2soKTsKICAgICAgICAgfSBl
bHNlIHsKICAgICAgICAgICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5kIHZhbHVlKHRoaXMsIG5vZGUt
PmNoaWxkMSgpKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>307167</attachid>
            <date>2017-04-14 16:29:53 -0700</date>
            <delta_ts>2017-04-14 16:33:46 -0700</delta_ts>
            <desc>patch</desc>
            <filename>b-backup.diff</filename>
            <type>text/plain</type>
            <size>4492</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMTUzNzkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE0IEBACisyMDE3LTA0LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu
Y29tPgorCisgICAgICAgIFBhcnNlSW50IGludHJpbnNpYyBpbiBERkcgYmFja2VuZCBkb2Vzbid0
IHByb3Blcmx5IGZsdXNoIGl0cyBvcGVyYW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvcGFyc2UtaW50LWludHJpbnNpYy1kZmctYmFj
a2VuZC1mbHVzaC5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAoZm9vKToK
KwogMjAxNy0wNC0xNCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgogCiAgICAg
ICAgIFtKU0NdIHVzZSBFeHByZXNzaW9uRXJyb3JDbGFzc2lmaWVyIGZvciBBd2FpdEV4cHJlc3Np
b24gb3BlcmFuZApJbmRleDogSlNUZXN0cy9zdHJlc3MvcGFyc2UtaW50LWludHJpbnNpYy1kZmct
YmFja2VuZC1mbHVzaC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9wYXJzZS1pbnQt
aW50cmluc2ljLWRmZy1iYWNrZW5kLWZsdXNoLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMv
c3RyZXNzL3BhcnNlLWludC1pbnRyaW5zaWMtZGZnLWJhY2tlbmQtZmx1c2guanMJKHdvcmtpbmcg
Y29weSkKQEAgLTAsMCArMSwxNCBAQAorZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIp
CisgICAgICAgIHRocm93IG5ldyBFcnJvcigiQmFkIikKK30KKworZnVuY3Rpb24gZm9vKHgpIHsK
KyAgICByZXR1cm4geCA9PT0gcGFyc2VJbnQoeCwgMTApOworfQorbm9JbmxpbmUoZm9vKTsKKwor
Zm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7CisgICAgYXNzZXJ0KCFmb28oYCR7aX1g
KSk7CisgICAgYXNzZXJ0KGZvbyhpKSk7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJ
KHJldmlzaW9uIDIxNTM3NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdv
cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0wNC0xNCAgU2FhbSBCYXJhdGkgIDxz
YmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBQYXJzZUludCBpbnRyaW5zaWMgaW4gREZHIGJh
Y2tlbmQgZG9lc24ndCBwcm9wZXJseSBmbHVzaCBpdHMgb3BlcmFuZHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDg2NQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBERkcgYmFja2VuZCBjb2RlIG5l
ZWRlZCB0byBmaXJzdCBjYWxsaW5nIC5ncHIoKS8uanNWYWx1ZVJlZ3MoKQorICAgICAgICBiZWZv
cmUgY2FsbGluZyBmbHVzaFJlZ2lzdGVycygpLCBvciB0aGUgaW5wdXQgSlNWYWx1ZU9wZXJhbmQg
d291bGQKKyAgICAgICAgbm90IGJlIGZsdXNoZWQuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3Vs
YXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxl
UGFyc2VJbnQpOgorCiAyMDE3LTA0LTE0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu
QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjIxNTM2OC4K
SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQu
Y3BwCShyZXZpc2lvbiAyMTUzNzUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw
ZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE1MywzNyArMzE1Myw0NCBAQCB2
b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlUGFyc2VJbnQoTm9kCiAgICAgICAgIEdQUlJlZyBy
YWRpeEdQUiA9IHJhZGl4LmdwcigpOwogICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCkudXNlS2lu
ZCgpID09IFVudHlwZWRVc2UpIHsKICAgICAgICAgICAgIEpTVmFsdWVPcGVyYW5kIHZhbHVlKHRo
aXMsIG5vZGUtPmNoaWxkMSgpKTsKLQotICAgICAgICAgICAgZmx1c2hSZWdpc3RlcnMoKTsKICNp
ZiBVU0UoSlNWQUxVRTY0KQotICAgICAgICAgICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb25QYXJz
ZUludEdlbmVyaWMsIHJlc3VsdFJlZ3MuZ3ByKCksIHZhbHVlLmdwcigpLCByYWRpeEdQUik7Cisg
ICAgICAgICAgICBhdXRvIHJlc3VsdCA9IHJlc3VsdFJlZ3MuZ3ByKCk7CisgICAgICAgICAgICBh
dXRvIHZhbHVlUmVnID0gdmFsdWUuZ3ByKCk7CiAjZWxzZQotICAgICAgICAgICAgY2FsbE9wZXJh
dGlvbihvcGVyYXRpb25QYXJzZUludEdlbmVyaWMsIHJlc3VsdFJlZ3MsIHZhbHVlLmpzVmFsdWVS
ZWdzKCksIHJhZGl4R1BSKTsKKyAgICAgICAgICAgIGF1dG8gcmVzdWx0ID0gcmVzdWx0UmVnczsK
KyAgICAgICAgICAgIGF1dG8gdmFsdWVSZWcgPSB2YWx1ZS5qc1ZhbHVlUmVncygpOwogI2VuZGlm
CisKKyAgICAgICAgICAgIGZsdXNoUmVnaXN0ZXJzKCk7CisgICAgICAgICAgICBjYWxsT3BlcmF0
aW9uKG9wZXJhdGlvblBhcnNlSW50R2VuZXJpYywgcmVzdWx0LCB2YWx1ZVJlZywgcmFkaXhHUFIp
OwogICAgICAgICAgICAgbV9qaXQuZXhjZXB0aW9uQ2hlY2soKTsKICAgICAgICAgfSBlbHNlIHsK
ICAgICAgICAgICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5kIHZhbHVlKHRoaXMsIG5vZGUtPmNoaWxk
MSgpKTsKICAgICAgICAgICAgIEdQUlJlZyB2YWx1ZUdQUiA9IHZhbHVlLmdwcigpOwogICAgICAg
ICAgICAgc3BlY3VsYXRlU3RyaW5nKG5vZGUtPmNoaWxkMSgpLCB2YWx1ZUdQUik7CiAKLSAgICAg
ICAgICAgIGZsdXNoUmVnaXN0ZXJzKCk7CiAjaWYgVVNFKEpTVkFMVUU2NCkKLSAgICAgICAgICAg
IGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uUGFyc2VJbnRTdHJpbmcsIHJlc3VsdFJlZ3MuZ3ByKCks
IHZhbHVlR1BSLCByYWRpeEdQUik7CisgICAgICAgICAgICBhdXRvIHJlc3VsdCA9IHJlc3VsdFJl
Z3MuZ3ByKCk7CiAjZWxzZQotICAgICAgICAgICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb25QYXJz
ZUludFN0cmluZywgcmVzdWx0UmVncywgdmFsdWVHUFIsIHJhZGl4R1BSKTsKKyAgICAgICAgICAg
IGF1dG8gcmVzdWx0ID0gcmVzdWx0UmVnczsKICNlbmRpZgorCisgICAgICAgICAgICBmbHVzaFJl
Z2lzdGVycygpOworICAgICAgICAgICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb25QYXJzZUludFN0
cmluZywgcmVzdWx0LCB2YWx1ZUdQUiwgcmFkaXhHUFIpOwogICAgICAgICAgICAgbV9qaXQuZXhj
ZXB0aW9uQ2hlY2soKTsKICAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgIGlmIChub2Rl
LT5jaGlsZDEoKS51c2VLaW5kKCkgPT0gVW50eXBlZFVzZSkgewogICAgICAgICAgICAgSlNWYWx1
ZU9wZXJhbmQgdmFsdWUodGhpcywgbm9kZS0+Y2hpbGQxKCkpOwotCi0gICAgICAgICAgICBmbHVz
aFJlZ2lzdGVycygpOwogI2lmIFVTRShKU1ZBTFVFNjQpCi0gICAgICAgICAgICBjYWxsT3BlcmF0
aW9uKG9wZXJhdGlvblBhcnNlSW50Tm9SYWRpeEdlbmVyaWMsIHJlc3VsdFJlZ3MuZ3ByKCksIHZh
bHVlLmpzVmFsdWVSZWdzKCkpOworICAgICAgICAgICAgYXV0byByZXN1bHQgPSByZXN1bHRSZWdz
LmdwcigpOwogI2Vsc2UKLSAgICAgICAgICAgIGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uUGFyc2VJ
bnROb1JhZGl4R2VuZXJpYywgcmVzdWx0UmVncywgdmFsdWUuanNWYWx1ZVJlZ3MoKSk7CisgICAg
ICAgICAgICBhdXRvIHJlc3VsdCA9IHJlc3VsdFJlZ3M7CiAjZW5kaWYKKyAgICAgICAgICAgIEpT
VmFsdWVSZWdzIHZhbHVlUmVncyA9IHZhbHVlLmpzVmFsdWVSZWdzKCk7CisKKyAgICAgICAgICAg
IGZsdXNoUmVnaXN0ZXJzKCk7CisgICAgICAgICAgICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlvblBh
cnNlSW50Tm9SYWRpeEdlbmVyaWMsIHJlc3VsdCwgdmFsdWVSZWdzKTsKICAgICAgICAgICAgIG1f
aml0LmV4Y2VwdGlvbkNoZWNrKCk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBTcGVj
dWxhdGVDZWxsT3BlcmFuZCB2YWx1ZSh0aGlzLCBub2RlLT5jaGlsZDEoKSk7Cg==
</data>
<flag name="review"
          id="328458"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
          </attachment>
      

    </bug>

</bugzilla>