170863 2017-04-14 15:36:11 -0700 WebAssembly: B3IRGenerator should use phis for result types 2017-04-14 16:20:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller buildbot commit-queue fpizlo mark.lam msaboff saam oldest_to_newest 1297537 0 keith_miller 2017-04-14 15:36:11 -0700 WebAssembly: B3IRGenerator should use phis for result types 1297540 1 307158 keith_miller 2017-04-14 15:40:23 -0700 Created attachment 307158 Patch 1297560 2 307158 commit-queue 2017-04-14 16:20:23 -0700 Comment on attachment 307158 Patch Clearing flags on attachment: 307158 Committed r215379: <http://trac.webkit.org/changeset/215379> 1297561 3 commit-queue 2017-04-14 16:20:24 -0700 All reviewed patches have been landed. Closing bug. 307158 2017-04-14 15:40:23 -0700 2017-04-14 16:20:23 -0700 Patch bug-170863-20170414154022.patch text/plain 6076 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NTExYTQ0MjdjMDlkYzJlYjQ0NTE1ZWU5NzkwYjg4ZjY0M2ZiZTIxLi43OTQ3MjFkMGFlZWY5NGU2 M2EyODg4ZTA1MDQyMjNkZmM3ZTRlZjIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNy0wNC0xNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBXZWJBc3NlbWJseTogQjNJUkdlbmVyYXRvciBzaG91bGQgdXNlIHBo aXMgZm9yIHJlc3VsdCB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcwODYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ3VycmVudGx5LCB3ZSB1c2UgdmFyaWFibGVzIGZvciB0aGUgcmVzdWx0IHR5 cGVzIG9mIGNvbnRyb2wgZmxvdyBpbgorICAgICAgICBXYXNtLiBXZSBkaWQgdGhpcyBvcmlnaW5h bGx5IHNpbmNlIHdlIHdlcmVuJ3Qgc3VyZSB0aGF0IHRoZSBwaGlzIHdlCisgICAgICAgIGdlbmVy YXRlZCB3b3VsZCBiZSBvcHRpbWFsLiBTaW5jZSB0aGVuLCB3ZSBoYXZlIHZlcmlmaWVkIHRoYXQg dGhlIGVkZ2VzCisgICAgICAgIGluIHdhc20gY29udHJvbCBmbG93IGVuc3VyZSB0aGF0IGVhY2gg dXBzaWxvbiB3aWxsIGRvbWluYXRlIGl0cyBwaGkKKyAgICAgICAgc28gd2UgZG9uJ3QgbmVlZCB0 byB1c2UgdmFyaWFibGVzLgorCisgICAgICAgICogd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHA6 CisgICAgICAgIChKU0M6Oldhc206OkIzSVJHZW5lcmF0b3I6OkNvbnRyb2xEYXRhOjpDb250cm9s RGF0YSk6CisgICAgICAgIChKU0M6Oldhc206OkIzSVJHZW5lcmF0b3I6OmFkZFRvcExldmVsKToK KyAgICAgICAgKEpTQzo6V2FzbTo6QjNJUkdlbmVyYXRvcjo6YWRkQmxvY2spOgorICAgICAgICAo SlNDOjpXYXNtOjpCM0lSR2VuZXJhdG9yOjphZGRMb29wKToKKyAgICAgICAgKEpTQzo6V2FzbTo6 QjNJUkdlbmVyYXRvcjo6dW5pZnkpOgorCiAyMDE3LTA0LTE0ICBDYWl0bGluIFBvdHRlciAgPGNh aXRwQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pTQ10gdXNlIEV4cHJlc3Npb25FcnJvckNsYXNz aWZpZXIgZm9yIEF3YWl0RXhwcmVzc2lvbiBvcGVyYW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHAKaW5kZXggYzgzZDM2ZWM2MmFhYzgzNDRl Yjg0NWIxNmI5OGMxYTU3OTEyNDJlNS4uMzdjZTI5YjQzOTQ2OTFiMTkxNzUxMmE3OGI4NmY5N2Vm ZWQ4Yjg0NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJH ZW5lcmF0b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CM0lSR2Vu ZXJhdG9yLmNwcApAQCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgIkIzU2xvdEJhc2VWYWx1ZS5o IgogI2luY2x1ZGUgIkIzU3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1zLmgiCiAjaW5jbHVkZSAiQjNT d2l0Y2hWYWx1ZS5oIgorI2luY2x1ZGUgIkIzVXBzaWxvblZhbHVlLmgiCiAjaW5jbHVkZSAiQjNW YWxpZGF0ZS5oIgogI2luY2x1ZGUgIkIzVmFsdWVJbmxpbmVzLmgiCiAjaW5jbHVkZSAiQjNWYWx1 ZUtleS5oIgpAQCAtNzcsMTMgKzc4LDEzIEBAIGNvbnN0IGJvb2wgdmVyYm9zZSA9IGZhbHNlOwog Y2xhc3MgQjNJUkdlbmVyYXRvciB7CiBwdWJsaWM6CiAgICAgc3RydWN0IENvbnRyb2xEYXRhIHsK LSAgICAgICAgQ29udHJvbERhdGEoUHJvY2VkdXJlJiBwcm9jLCBUeXBlIHNpZ25hdHVyZSwgQmxv Y2tUeXBlIHR5cGUsIEJhc2ljQmxvY2sqIGNvbnRpbnVhdGlvbiwgQmFzaWNCbG9jayogc3BlY2lh bCA9IG51bGxwdHIpCisgICAgICAgIENvbnRyb2xEYXRhKFByb2NlZHVyZSYgcHJvYywgT3JpZ2lu IG9yaWdpbiwgVHlwZSBzaWduYXR1cmUsIEJsb2NrVHlwZSB0eXBlLCBCYXNpY0Jsb2NrKiBjb250 aW51YXRpb24sIEJhc2ljQmxvY2sqIHNwZWNpYWwgPSBudWxscHRyKQogICAgICAgICAgICAgOiBi bG9ja1R5cGUodHlwZSkKICAgICAgICAgICAgICwgY29udGludWF0aW9uKGNvbnRpbnVhdGlvbikK ICAgICAgICAgICAgICwgc3BlY2lhbChzcGVjaWFsKQogICAgICAgICB7CiAgICAgICAgICAgICBp ZiAoc2lnbmF0dXJlICE9IFZvaWQpCi0gICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZChwcm9j LmFkZFZhcmlhYmxlKHRvQjNUeXBlKHNpZ25hdHVyZSkpKTsKKyAgICAgICAgICAgICAgICByZXN1 bHQuYXBwZW5kKHByb2MuYWRkPFZhbHVlPihQaGksIHRvQjNUeXBlKHNpZ25hdHVyZSksIG9yaWdp bikpOwogICAgICAgICB9CiAKICAgICAgICAgQ29udHJvbERhdGEoKQpAQCAtMTMxLDcgKzEzMiw3 IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHNwZWNpYWwgPSBudWxscHRyOwogICAgICAgICB9CiAK LSAgICAgICAgdXNpbmcgUmVzdWx0TGlzdCA9IFZlY3RvcjxWYXJpYWJsZSosIDE+OworICAgICAg ICB1c2luZyBSZXN1bHRMaXN0ID0gVmVjdG9yPFZhbHVlKiwgMT47IC8vIFZhbHVlIG11c3QgYmUg YSBQaGkKIAogICAgICAgICBSZXN1bHRMaXN0IHJlc3VsdEZvckJyYW5jaCgpIGNvbnN0CiAgICAg ICAgIHsKQEAgLTIzMSw3ICsyMzIsNyBAQCBwcml2YXRlOgogICAgIEV4cHJlc3Npb25UeXBlIGVt aXRMb2FkT3AoTG9hZE9wVHlwZSwgRXhwcmVzc2lvblR5cGUgcG9pbnRlciwgdWludDMyX3Qgb2Zm c2V0KTsKICAgICB2b2lkIGVtaXRTdG9yZU9wKFN0b3JlT3BUeXBlLCBFeHByZXNzaW9uVHlwZSBw b2ludGVyLCBFeHByZXNzaW9uVHlwZSB2YWx1ZSwgdWludDMyX3Qgb2Zmc2V0KTsKIAotICAgIHZv aWQgdW5pZnkoVmFyaWFibGUqIHRhcmdldCwgY29uc3QgRXhwcmVzc2lvblR5cGUgc291cmNlKTsK KyAgICB2b2lkIHVuaWZ5KGNvbnN0IEV4cHJlc3Npb25UeXBlIHBoaSwgY29uc3QgRXhwcmVzc2lv blR5cGUgc291cmNlKTsKICAgICB2b2lkIHVuaWZ5VmFsdWVzV2l0aEJsb2NrKGNvbnN0IEV4cHJl c3Npb25MaXN0JiByZXN1bHRTdGFjaywgY29uc3QgUmVzdWx0TGlzdCYgc3RhY2spOwogCiAgICAg dm9pZCBlbWl0Q2hlY2tzRm9yTW9kT3JEaXYoQjM6Ok9wY29kZSwgRXhwcmVzc2lvblR5cGUgbGVm dCwgRXhwcmVzc2lvblR5cGUgcmlnaHQpOwpAQCAtODAxLDEyICs4MDIsMTIgQEAgQjNJUkdlbmVy YXRvcjo6RXhwcmVzc2lvblR5cGUgQjNJUkdlbmVyYXRvcjo6YWRkQ29uc3RhbnQoVHlwZSB0eXBl LCB1aW50NjRfdCB2YWwKIAogQjNJUkdlbmVyYXRvcjo6Q29udHJvbERhdGEgQjNJUkdlbmVyYXRv cjo6YWRkVG9wTGV2ZWwoVHlwZSBzaWduYXR1cmUpCiB7Ci0gICAgcmV0dXJuIENvbnRyb2xEYXRh KG1fcHJvYywgc2lnbmF0dXJlLCBCbG9ja1R5cGU6OlRvcExldmVsLCBtX3Byb2MuYWRkQmxvY2so KSk7CisgICAgcmV0dXJuIENvbnRyb2xEYXRhKG1fcHJvYywgT3JpZ2luKCksIHNpZ25hdHVyZSwg QmxvY2tUeXBlOjpUb3BMZXZlbCwgbV9wcm9jLmFkZEJsb2NrKCkpOwogfQogCiBCM0lSR2VuZXJh dG9yOjpDb250cm9sRGF0YSBCM0lSR2VuZXJhdG9yOjphZGRCbG9jayhUeXBlIHNpZ25hdHVyZSkK IHsKLSAgICByZXR1cm4gQ29udHJvbERhdGEobV9wcm9jLCBzaWduYXR1cmUsIEJsb2NrVHlwZTo6 QmxvY2ssIG1fcHJvYy5hZGRCbG9jaygpKTsKKyAgICByZXR1cm4gQ29udHJvbERhdGEobV9wcm9j LCBvcmlnaW4oKSwgc2lnbmF0dXJlLCBCbG9ja1R5cGU6OkJsb2NrLCBtX3Byb2MuYWRkQmxvY2so KSk7CiB9CiAKIEIzSVJHZW5lcmF0b3I6OkNvbnRyb2xEYXRhIEIzSVJHZW5lcmF0b3I6OmFkZExv b3AoVHlwZSBzaWduYXR1cmUpCkBAIC04MTYsNyArODE3LDcgQEAgQjNJUkdlbmVyYXRvcjo6Q29u dHJvbERhdGEgQjNJUkdlbmVyYXRvcjo6YWRkTG9vcChUeXBlIHNpZ25hdHVyZSkKICAgICBtX2N1 cnJlbnRCbG9jay0+YXBwZW5kTmV3Q29udHJvbFZhbHVlKG1fcHJvYywgSnVtcCwgb3JpZ2luKCks IGJvZHkpOwogICAgIGJvZHktPmFkZFByZWRlY2Vzc29yKG1fY3VycmVudEJsb2NrKTsKICAgICBt X2N1cnJlbnRCbG9jayA9IGJvZHk7Ci0gICAgcmV0dXJuIENvbnRyb2xEYXRhKG1fcHJvYywgc2ln bmF0dXJlLCBCbG9ja1R5cGU6Okxvb3AsIGNvbnRpbnVhdGlvbiwgYm9keSk7CisgICAgcmV0dXJu IENvbnRyb2xEYXRhKG1fcHJvYywgb3JpZ2luKCksIHNpZ25hdHVyZSwgQmxvY2tUeXBlOjpMb29w LCBjb250aW51YXRpb24sIGJvZHkpOwogfQogCiBhdXRvIEIzSVJHZW5lcmF0b3I6OmFkZElmKEV4 cHJlc3Npb25UeXBlIGNvbmRpdGlvbiwgVHlwZSBzaWduYXR1cmUsIENvbnRyb2xUeXBlJiByZXN1 bHQpIC0+IFBhcnRpYWxSZXN1bHQKQEAgLTgzMyw3ICs4MzQsNyBAQCBhdXRvIEIzSVJHZW5lcmF0 b3I6OmFkZElmKEV4cHJlc3Npb25UeXBlIGNvbmRpdGlvbiwgVHlwZSBzaWduYXR1cmUsIENvbnRy b2xUeXBlJgogICAgIG5vdFRha2VuLT5hZGRQcmVkZWNlc3NvcihtX2N1cnJlbnRCbG9jayk7CiAK ICAgICBtX2N1cnJlbnRCbG9jayA9IHRha2VuOwotICAgIHJlc3VsdCA9IENvbnRyb2xEYXRhKG1f cHJvYywgc2lnbmF0dXJlLCBCbG9ja1R5cGU6OklmLCBjb250aW51YXRpb24sIG5vdFRha2VuKTsK KyAgICByZXN1bHQgPSBDb250cm9sRGF0YShtX3Byb2MsIG9yaWdpbigpLCBzaWduYXR1cmUsIEJs b2NrVHlwZTo6SWYsIGNvbnRpbnVhdGlvbiwgbm90VGFrZW4pOwogICAgIHJldHVybiB7IH07CiB9 CiAKQEAgLTkxOCw4ICs5MTksMTAgQEAgYXV0byBCM0lSR2VuZXJhdG9yOjphZGRFbmRUb1VucmVh Y2hhYmxlKENvbnRyb2xFbnRyeSYgZW50cnkpIC0+IFBhcnRpYWxSZXN1bHQKICAgICAgICAgbV9j dXJyZW50QmxvY2stPmFkZFByZWRlY2Vzc29yKGRhdGEuc3BlY2lhbCk7CiAgICAgfQogCi0gICAg Zm9yIChWYXJpYWJsZSogcmVzdWx0IDogZGF0YS5yZXN1bHQpCi0gICAgICAgIGVudHJ5LmVuY2xv c2VkRXhwcmVzc2lvblN0YWNrLmFwcGVuZChtX2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PFZhcmlh YmxlVmFsdWU+KG1fcHJvYywgQjM6OkdldCwgb3JpZ2luKCksIHJlc3VsdCkpOworICAgIGZvciAo VmFsdWUqIHJlc3VsdCA6IGRhdGEucmVzdWx0KSB7CisgICAgICAgIG1fY3VycmVudEJsb2NrLT5h cHBlbmQocmVzdWx0KTsKKyAgICAgICAgZW50cnkuZW5jbG9zZWRFeHByZXNzaW9uU3RhY2suYXBw ZW5kKHJlc3VsdCk7CisgICAgfQogCiAgICAgLy8gVG9wTGV2ZWwgZG9lcyBub3QgaGF2ZSBhbnkg Y29kZSBhZnRlciB0aGlzIHNvIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHdlIGVtaXQgYSByZXR1cm4g aGVyZS4KICAgICBpZiAoZGF0YS50eXBlKCkgPT0gQmxvY2tUeXBlOjpUb3BMZXZlbCkKQEAgLTEw OTcsOSArMTEwMCw5IEBAIGF1dG8gQjNJUkdlbmVyYXRvcjo6YWRkQ2FsbEluZGlyZWN0KGNvbnN0 IFNpZ25hdHVyZSYgc2lnbmF0dXJlLCBWZWN0b3I8RXhwcmVzc2lvCiAgICAgcmV0dXJuIHsgfTsK IH0KIAotdm9pZCBCM0lSR2VuZXJhdG9yOjp1bmlmeShWYXJpYWJsZSogdmFyaWFibGUsIEV4cHJl c3Npb25UeXBlIHNvdXJjZSkKK3ZvaWQgQjNJUkdlbmVyYXRvcjo6dW5pZnkoY29uc3QgRXhwcmVz c2lvblR5cGUgcGhpLCBjb25zdCBFeHByZXNzaW9uVHlwZSBzb3VyY2UpCiB7Ci0gICAgbV9jdXJy ZW50QmxvY2stPmFwcGVuZE5ldzxWYXJpYWJsZVZhbHVlPihtX3Byb2MsIFNldCwgb3JpZ2luKCks IHZhcmlhYmxlLCBzb3VyY2UpOworICAgIG1fY3VycmVudEJsb2NrLT5hcHBlbmROZXc8VXBzaWxv blZhbHVlPihtX3Byb2MsIG9yaWdpbigpLCBzb3VyY2UsIHBoaSk7CiB9CiAKIHZvaWQgQjNJUkdl bmVyYXRvcjo6dW5pZnlWYWx1ZXNXaXRoQmxvY2soY29uc3QgRXhwcmVzc2lvbkxpc3QmIHJlc3Vs dFN0YWNrLCBjb25zdCBSZXN1bHRMaXN0JiByZXN1bHQpCg==