170861 2017-04-14 15:23:09 -0700 Use AVAudioSession to enumerate audio capture devices on iOS 2017-05-01 15:07:29 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jer.noble commit-queue eric.carlson jonlee ryanhaddad webkit-bug-importer oldest_to_newest 1297527 0 jeremyj-wk 2017-04-14 15:23:09 -0700 Right now iOS is using AVCaptureDeviceManager, but it should move to AVAudioSession. 1297865 1 webkit-bug-importer 2017-04-17 01:12:59 -0700 <rdar://problem/31653658> 1303379 2 308763 jer.noble 2017-05-01 13:59:43 -0700 Created attachment 308763 Patch 1303380 3 308763 eric.carlson 2017-05-01 14:02:57 -0700 Comment on attachment 308763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308763&action=review > Source/WebCore/ChangeLog:10 > + Hook up the new AVAudioSessionCaptureDeviceManager class to CoreAudioCaptureSource and to the (increasingly ill-named) > + RealtimeMediaSourceCenterMac. Magic eight ball says "Outlook good for a rename" 1303414 4 308763 commit-queue 2017-05-01 14:38:42 -0700 Comment on attachment 308763 Patch Clearing flags on attachment: 308763 Committed r216029: <http://trac.webkit.org/changeset/216029> 1303415 5 commit-queue 2017-05-01 14:38:43 -0700 All reviewed patches have been landed. Closing bug. 1303425 6 ryanhaddad 2017-05-01 15:03:52 -0700 (In reply to WebKit Commit Bot from comment #4) > Comment on attachment 308763 [details] > Patch > > Clearing flags on attachment: 308763 > > Committed r216029: <http://trac.webkit.org/changeset/216029> As EWS predicted, this broke the iOS build: https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20%28Build%29/builds/1264 1303426 7 ryanhaddad 2017-05-01 15:05:34 -0700 (In reply to Ryan Haddad from comment #6) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 308763 [details] > > Patch > > > > Clearing flags on attachment: 308763 > > > > Committed r216029: <http://trac.webkit.org/changeset/216029> > > As EWS predicted, this broke the iOS build: > > https://build.webkit.org/builders/ > Apple%20iOS%2010%20Simulator%20Release%20%28Build%29/builds/1264 Apparently I left this comment 20 seconds after a fix was landed in https://trac.webkit.org/r216034 1303429 8 jer.noble 2017-05-01 15:07:29 -0700 (In reply to Ryan Haddad from comment #7) > (In reply to Ryan Haddad from comment #6) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 308763 [details] > > > Patch > > > > > > Clearing flags on attachment: 308763 > > > > > > Committed r216029: <http://trac.webkit.org/changeset/216029> > > > > As EWS predicted, this broke the iOS build: > > > > https://build.webkit.org/builders/ > > Apple%20iOS%2010%20Simulator%20Release%20%28Build%29/builds/1264 > > Apparently I left this comment 20 seconds after a fix was landed in > https://trac.webkit.org/r216034 My apologies. I was building against an old ToT where this error didn't show up. 308763 2017-05-01 13:59:43 -0700 2017-05-01 14:38:42 -0700 Patch bug-170861-20170501135942.patch text/plain 3439 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1OTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc0ZWFhMDlkOGU0NTRl MDJhYWJlMDJkYTM0NjUwYTIzMGFhNjRjZS4uMTIyZmUwMTIzNDk0ZjZiYWNiODYxYjE5Y2M2MGZl ZThhYzJkZThiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA1LTAxICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBBVkF1ZGlvU2Vzc2lv biB0byBlbnVtZXJhdGUgYXVkaW8gY2FwdHVyZSBkZXZpY2VzIG9uIGlPUworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwODYxCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zMTY1MzY1OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBIb29rIHVwIHRoZSBuZXcgQVZBdWRpb1Nlc3Npb25DYXB0dXJlRGV2aWNl TWFuYWdlciBjbGFzcyB0byBDb3JlQXVkaW9DYXB0dXJlU291cmNlIGFuZCB0byB0aGUgKGluY3Jl YXNpbmdseSBpbGwtbmFtZWQpCisgICAgICAgIFJlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJNYWMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQ29yZUF1ZGlvQ2FwdHVyZVNv dXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb3JlQXVkaW9DYXB0dXJlU291cmNlOjpjcmVh dGUpOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU1lZGlhU291 cmNlQ2VudGVyTWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VD ZW50ZXJNYWM6OnNldFVzZUFWRm91bmRhdGlvbkF1ZGlvQ2FwdHVyZSk6CisKIDIwMTctMDQtMjcg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGF1ZGlvIGRl dmljZSBjaGFuZ2Ugbm90aWZpY2F0aW9ucyB0byBBdWRpb1Nlc3Npb24uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQ29yZUF1ZGlvQ2FwdHVyZVNv dXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQ29yZUF1 ZGlvQ2FwdHVyZVNvdXJjZS5jcHAKaW5kZXggOGYyNGM2MzAwOWViZGM5Y2M0MWUxYWJjNWRlYTFh MTdlMTRiZjc1OS4uN2Q3NDA3ZGVkY2E4YzBhYzU5ZGU4M2I0YTVhMjViODI5ZmI5MmJmOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0NvcmVBdWRp b0NhcHR1cmVTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJlU291cmNlLmNwcApAQCAtMjgsNiArMjgsOCBAQAogCiAj aWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKIAorI2luY2x1ZGUgIkFWQXVkaW9TZXNzaW9uQ2FwdHVy ZURldmljZS5oIgorI2luY2x1ZGUgIkFWQXVkaW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXIu aCIKICNpbmNsdWRlICJBdWRpb1NhbXBsZUJ1ZmZlckxpc3QuaCIKICNpbmNsdWRlICJBdWRpb1Nh bXBsZURhdGFTb3VyY2UuaCIKICNpbmNsdWRlICJBdWRpb1Nlc3Npb24uaCIKQEAgLTcwLDYgKzcy LDEyIEBAIFJlZlB0cjxDb3JlQXVkaW9DYXB0dXJlU291cmNlPiBDb3JlQXVkaW9DYXB0dXJlU291 cmNlOjpjcmVhdGUoY29uc3QgU3RyaW5nJiBkZXZpCiAKICAgICBsYWJlbCA9IGRldmljZS0+bGFi ZWwoKTsKICAgICBwZXJzaXN0ZW50SUQgPSBkZXZpY2UtPmRldmljZUlEKCk7CisjZWxpZiBQTEFU Rk9STShJT1MpCisgICAgYXV0byBkZXZpY2UgPSBBVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VN YW5hZ2VyOjpzaW5nbGV0b24oKS5hdWRpb1Nlc3Npb25EZXZpY2VXaXRoVUlEKGRldmljZUlEKTsK KyAgICBpZiAoIWRldmljZSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICBsYWJlbCA9 IGRldmljZS0+bGFiZWwoKTsKICNlbmRpZgogICAgIGF1dG8gc291cmNlID0gYWRvcHRSZWYobmV3 IENvcmVBdWRpb0NhcHR1cmVTb3VyY2UoZGV2aWNlSUQsIGxhYmVsLCBwZXJzaXN0ZW50SUQpKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1Jl YWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJNYWMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJNYWMuY3BwCmluZGV4IDZm NGJmNjEwMTUwMmM3YTQwNWFiNWNmYjEyNzFlYzhmNTMzNzM1MmMuLmVhZWFkMDUzNzcwM2ViYjgx OWIyYTk0NzZlYjlkYzlkNDNhOGJmNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU1lZGlhU291cmNlQ2VudGVyTWFjLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVNZWRpYVNv dXJjZUNlbnRlck1hYy5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJSZWFsdGltZU1l ZGlhU291cmNlQ2VudGVyTWFjLmgiCiAKICNpbmNsdWRlICJBVkF1ZGlvQ2FwdHVyZVNvdXJjZS5o IgorI2luY2x1ZGUgIkFWQXVkaW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXIuaCIKICNpbmNs dWRlICJBVkNhcHR1cmVEZXZpY2VNYW5hZ2VyLmgiCiAjaW5jbHVkZSAiQVZWaWRlb0NhcHR1cmVT b3VyY2UuaCIKICNpbmNsdWRlICJDb3JlQXVkaW9DYXB0dXJlRGV2aWNlTWFuYWdlci5oIgpAQCAt NTksOCArNjAsNyBAQCB2b2lkIFJlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJNYWM6OnNldFVzZUFW Rm91bmRhdGlvbkF1ZGlvQ2FwdHVyZShib29sIGVuYWJsZWQpCiAjaWYgUExBVEZPUk0oTUFDKQog ICAgICAgICBSZWFsdGltZU1lZGlhU291cmNlQ2VudGVyOjpzaW5nbGV0b24oKS5zZXRBdWRpb0Nh cHR1cmVEZXZpY2VNYW5hZ2VyKENvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyOjpzaW5nbGV0 b24oKSk7CiAjZWxzZQotICAgICAgICAvLyBGSVhNRSAxNzA4NjE6IFVzZSBBVkF1ZGlvU2Vzc2lv biB0byBlbnVtZXJhdGUgYXVkaW8gY2FwdHVyZSBkZXZpY2VzIG9uIGlPUwotICAgICAgICBSZWFs dGltZU1lZGlhU291cmNlQ2VudGVyOjpzaW5nbGV0b24oKS5zZXRBdWRpb0NhcHR1cmVEZXZpY2VN YW5hZ2VyKEFWQ2FwdHVyZURldmljZU1hbmFnZXI6OnNpbmdsZXRvbigpKTsKKyAgICAgICAgUmVh bHRpbWVNZWRpYVNvdXJjZUNlbnRlcjo6c2luZ2xldG9uKCkuc2V0QXVkaW9DYXB0dXJlRGV2aWNl TWFuYWdlcihBVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyOjpzaW5nbGV0b24oKSk7 CiAjZW5kaWYKICAgICB9CiB9Cg==