170859 2017-04-14 14:27:40 -0700 webkit-patch failed to detect git repository 2017-04-14 17:09:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Windows 10 RESOLVED FIXED PlatformOnly P2 Normal --- 169003 1 mbbill webkit-unassigned achristensen bfulgham buildbot commit-queue dbates kocsen_chung lforschler mmaxfield oldest_to_newest 1297511 0 mbbill 2017-04-14 14:27:40 -0700 Following error is thrown even user.name is set. Failed to determine ChangeLog name. Either: set CHANGE_LOG_NAME in your environment OR pass --name= on the command line OR set REAL_NAME in your environment OR git users can set 'git config user.name' This is because in VCSUtils.pm, isGitDirectory giving a wrong path to git.exe Having single quote on *nix systems are fine but on Windows it only accepts double quote. Therefore, using double quote should work on all platforms. 1297512 1 307146 mbbill 2017-04-14 14:30:28 -0700 Created attachment 307146 Patch 1297541 2 307146 dbates 2017-04-14 15:45:08 -0700 Comment on attachment 307146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307146&action=review Thank you for filing this bug and posting a patch. There are more places that we need to modify. You may find it useful to look at the patch on bug #169003,, which added the -C option to various code paths. Please grep through the code as well to find any other occurrences that have been added since the patch for bug #169003. > Tools/ChangeLog:3 > + This change makes isGitDirectory() work on Windows. This line should be the Bugzilla bug title verbatim. The description of the change goes below the "Reviewed by" line. 1297550 3 307162 mbbill 2017-04-14 15:59:28 -0700 Created attachment 307162 Patch 1297556 4 307162 dbates 2017-04-14 16:08:34 -0700 Comment on attachment 307162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307162&action=review The change looks good. The ChangeLog is out-of-date and I noticed some minor stylistic issues with it. Please update it. You do not need to post this patch for review again (though feel free to ask for one if you want one or make changes other than fixing the ChangeLog entry). When you update the ChangeLog entry change the "Reviewed by NOBODY (OOPS!)" line to "Reviewed by Daniel Bates." and upload the patch without a review flag and with the cq flag set to ?. > Tools/ChangeLog:3 > + webkit-patch failed to detect git repository. Minor: Remove the period at the end of this line so that it matches the Bugzilla title verbatim. > Tools/ChangeLog:8 > + When -C is given to git, using double quotes for the path. Please add an empty line below this line. > Tools/ChangeLog:10 > + * Scripts/VCSUtils.pm: > + (isGitDirectory): This file/function listing is out-of-date. Please generate this ChangeLog entry again using prepare-ChangeLog. 1297557 5 307162 dbates 2017-04-14 16:11:19 -0700 Comment on attachment 307162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307162&action=review >> Tools/ChangeLog:8 >> + When -C is given to git, using double quotes for the path. > > Please add an empty line below this line. Please elaborate on why we need to use double quotes for the path. From my understanding the Window prompt (cmd.exe) only supports quoting parameters using double quotes. That is, it does not support quoting parameters using single quotes. 1297559 6 dbates 2017-04-14 16:13:06 -0700 (In reply to Daniel Bates from comment #5) > [...] From my > understanding the Window prompt (cmd.exe) only supports quoting parameters > using double quotes. You actually mentioned this in comment #0. For convenience, I suggest that you mention it as well in your ChangeLog description. 1297563 7 307165 mbbill 2017-04-14 16:22:27 -0700 Created attachment 307165 Patch 1297566 8 mbbill 2017-04-14 16:22:50 -0700 Thanks for the review! 1297574 9 307165 dbates 2017-04-14 16:41:33 -0700 Comment on attachment 307165 Patch Thank you for updating the patch, Bill. r=me 1297581 10 307165 commit-queue 2017-04-14 17:09:39 -0700 Comment on attachment 307165 Patch Clearing flags on attachment: 307165 Committed r215381: <http://trac.webkit.org/changeset/215381> 1297582 11 commit-queue 2017-04-14 17:09:40 -0700 All reviewed patches have been landed. Closing bug. 307146 2017-04-14 14:30:28 -0700 2017-04-14 15:59:25 -0700 Patch bug-170859-20170414143027.patch text/plain 1129 mbbill U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MzY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA3YjQ1Y2QwNDQ5ZWJiZjU1NjAyYmQxYWM5NzRkNjJh YjFlZjkyNi4uNGQ2MDM4YTcwOWM2ZTNlMWQzYWUxZmFiZmNlMTFlNzc4MmViMDc4YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE3LTA0LTE0ICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgorCisgICAgICAg IFRoaXMgY2hhbmdlIG1ha2VzIGlzR2l0RGlyZWN0b3J5KCkgd29yayBvbiBXaW5kb3dzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwODU5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL1ZD U1V0aWxzLnBtOgorICAgICAgICAoaXNHaXREaXJlY3RvcnkpOgorCiAyMDE3LTA0LTE0ICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIyMTUzNjMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBt IGIvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQppbmRleCA4ZTA3ODdjOGE0YzNkMTNjOTU1MWUz NThjMTI3NmMxZDQ3NWQyMDZjLi4wNDU2OTNjNGVjZGI3OGMyZWJkNzk0MzM3ZDE3N2Y0Y2E3YzBm ODQyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCisrKyBiL1Rvb2xzL1Nj cmlwdHMvVkNTVXRpbHMucG0KQEAgLTIyMyw3ICsyMjMsNyBAQCBzdWIgc2NtUmVtb3ZlRXhlY3V0 YWJsZUJpdCgkKQogc3ViIGlzR2l0RGlyZWN0b3J5KCQpCiB7CiAgICAgbXkgKCRkaXJlY3Rvcnkp ID0gQF87Ci0gICAgcmV0dXJuIHN5c3RlbSgiZ2l0IC1DICckZGlyZWN0b3J5JyByZXYtcGFyc2Ug PiAiIC4gRmlsZTo6U3BlYy0+ZGV2bnVsbCgpIC4gIiAyPiYxIikgPT0gMDsKKyAgICByZXR1cm4g c3lzdGVtKCJnaXQgLUMgXCIkZGlyZWN0b3J5XCIgcmV2LXBhcnNlID4gIiAuIEZpbGU6OlNwZWMt PmRldm51bGwoKSAuICIgMj4mMSIpID09IDA7CiB9CiAKIHN1YiBpc0dpdCgpCg== 307162 2017-04-14 15:59:28 -0700 2017-04-14 16:22:24 -0700 Patch bug-170859-20170414155927.patch text/plain 2583 mbbill U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MzY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA3YjQ1Y2QwNDQ5ZWJiZjU1NjAyYmQxYWM5NzRkNjJh YjFlZjkyNi4uMGQxYTVhMTMyYzllZGY5MDQxYmY4YTUxYjQxNjBhYWU0OWRiYTgwNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE3LTA0LTE0ICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgorCisgICAgICAg IHdlYmtpdC1wYXRjaCBmYWlsZWQgdG8gZGV0ZWN0IGdpdCByZXBvc2l0b3J5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwODU5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiAtQyBpcyBnaXZlbiB0 byBnaXQsIHVzaW5nIGRvdWJsZSBxdW90ZXMgZm9yIHRoZSBwYXRoLgorICAgICAgICAqIFNjcmlw dHMvVkNTVXRpbHMucG06CisgICAgICAgIChpc0dpdERpcmVjdG9yeSk6CisKIDIwMTctMDQtMTQg IFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjIxNTM2My4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRp bHMucG0gYi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCmluZGV4IDhlMDc4N2M4YTRjM2QxM2M5 NTUxZTM1OGMxMjc2YzFkNDc1ZDIwNmMuLjRkNmNkMjkzZjIyNTBhNjhlMzljZjQwYzVlNzYzZmIz ZTViMjBlYjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KKysrIGIvVG9v bHMvU2NyaXB0cy9WQ1NVdGlscy5wbQpAQCAtMjIzLDcgKzIyMyw3IEBAIHN1YiBzY21SZW1vdmVF eGVjdXRhYmxlQml0KCQpCiBzdWIgaXNHaXREaXJlY3RvcnkoJCkKIHsKICAgICBteSAoJGRpcmVj dG9yeSkgPSBAXzsKLSAgICByZXR1cm4gc3lzdGVtKCJnaXQgLUMgJyRkaXJlY3RvcnknIHJldi1w YXJzZSA+ICIgLiBGaWxlOjpTcGVjLT5kZXZudWxsKCkgLiAiIDI+JjEiKSA9PSAwOworICAgIHJl dHVybiBzeXN0ZW0oImdpdCAtQyBcIiRkaXJlY3RvcnlcIiByZXYtcGFyc2UgPiAiIC4gRmlsZTo6 U3BlYy0+ZGV2bnVsbCgpIC4gIiAyPiYxIikgPT0gMDsKIH0KIAogc3ViIGlzR2l0KCkKQEAgLTI0 MSw3ICsyNDEsNyBAQCBzdWIgaXNHaXRTVk5EaXJlY3RvcnkoJCkKICAgICAjIFRoZXJlIGRvZXNu J3Qgc2VlbSB0byBiZSBhbiBvZmZpY2lhbGx5IGRvY3VtZW50ZWQgd2F5IHRvIGRldGVybWluZQog ICAgICMgaWYgeW91J3JlIGluIGEgZ2l0LXN2biBjaGVja291dC4gVGhlIGJlc3Qgc3VnZ2VzdGlv bnMgc2VlbiBzbyBmYXIKICAgICAjIGFsbCB1c2Ugc29tZXRoaW5nIGxpa2UgdGhlIGZvbGxvd2lu ZzoKLSAgICBteSAkb3V0cHV0ID0gYGdpdCAtQyAnJGRpcmVjdG9yeScgY29uZmlnIC0tZ2V0IHN2 bi1yZW1vdGUuc3ZuLmZldGNoIDI+JjFgOworICAgIG15ICRvdXRwdXQgPSBgZ2l0IC1DIFwiJGRp cmVjdG9yeVwiIGNvbmZpZyAtLWdldCBzdm4tcmVtb3RlLnN2bi5mZXRjaCAyPiYxYDsKICAgICAk aXNHaXRTVk4gPSBleGl0U3RhdHVzKCQ/KSA9PSAwICYmICRvdXRwdXQgbmUgIiI7CiAgICAgcmV0 dXJuICRpc0dpdFNWTjsKIH0KQEAgLTQzMiw3ICs0MzIsNyBAQCBzdWIgc3ZuUmV2aXNpb25Gb3JE aXJlY3RvcnkoJCkKICAgICAgICAgbXkgJHN2bkluZm8gPSBgJGNvbW1hbmRgOwogICAgICAgICAo JHJldmlzaW9uKSA9ICgkc3ZuSW5mbyA9fiBtL1JldmlzaW9uOiAoXGQrKS4qL2cpOwogICAgIH0g ZWxzaWYgKGlzR2l0RGlyZWN0b3J5KCRkaXJlY3RvcnkpKSB7Ci0gICAgICAgIG15ICRjb21tYW5k ID0gImdpdCAtQyAnJGRpcmVjdG9yeScgbG9nIC0tZ3JlcD1cImdpdC1zdm4taWQ6IFwiIC1uIDEg fCBncmVwIGdpdC1zdm4taWQ6IjsKKyAgICAgICAgbXkgJGNvbW1hbmQgPSAiZ2l0IC1DIFwiJGRp cmVjdG9yeVwiIGxvZyAtLWdyZXA9XCJnaXQtc3ZuLWlkOiBcIiAtbiAxIHwgZ3JlcCBnaXQtc3Zu LWlkOiI7CiAgICAgICAgICRjb21tYW5kID0gIkxDX0FMTD1DICRjb21tYW5kIiBpZiAhaXNXaW5k b3dzKCk7CiAgICAgICAgIG15ICRnaXRMb2cgPSBgJGNvbW1hbmRgOwogICAgICAgICAoJHJldmlz aW9uKSA9ICgkZ2l0TG9nID1+IG0vICtnaXQtc3ZuLWlkOiAuK0AoXGQrKSAvZyk7CkBAIC00NTYs NyArNDU2LDcgQEAgc3ViIHN2bkluZm9Gb3JQYXRoKCQpCiAgICAgICAgICRjb21tYW5kID0gIkxD X0FMTD1DICRjb21tYW5kIiBpZiAhaXNXaW5kb3dzKCk7CiAgICAgICAgICRzdm5JbmZvID0gYCRj b21tYW5kYDsKICAgICB9IGVsc2lmIChpc0dpdERpcmVjdG9yeSgkZmlsZSkpIHsKLSAgICAgICAg bXkgJGNvbW1hbmQgPSAiZ2l0IC1DICckZmlsZScgc3ZuIGluZm8iOworICAgICAgICBteSAkY29t bWFuZCA9ICJnaXQgLUMgXCIkZmlsZVwiIHN2biBpbmZvIjsKICAgICAgICAgJGNvbW1hbmQgPSAi TENfQUxMPUMgJGNvbW1hbmQiIGlmICFpc1dpbmRvd3MoKTsKICAgICAgICAgJHN2bkluZm8gPSBg JGNvbW1hbmRgOwogICAgIH0K 307165 2017-04-14 16:22:27 -0700 2017-04-14 17:09:39 -0700 Patch bug-170859-20170414162226.patch text/plain 2748 mbbill U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MzY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA3YjQ1Y2QwNDQ5ZWJiZjU1NjAyYmQxYWM5NzRkNjJh YjFlZjkyNi4uZGIyNDFiZGFiMmIxZGYyMWY5NmE2YTRmYzhiZGM5NmM3Yjc0N2JlNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTA0LTE0ICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgorCisgICAgICAg IHdlYmtpdC1wYXRjaCBmYWlsZWQgdG8gZGV0ZWN0IGdpdCByZXBvc2l0b3J5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA4NTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaW5kb3dzIGNtZCBkb2VzIG5v dCBhY2NlcHQgc2luZ2xlIHF1b3RlZCBwYXRoLiBTbywgdXNpbmcKKyAgICAgICAgZG91YmxlIHF1 b3RlcyBoZXJlIHdpbGwgcHJvdmlkZSBiZXR0ZXIgcGxhdGZvcm0gY29tcGF0aWJpbGl0eS4KKwor ICAgICAgICAqIFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAgIChpc0dpdERpcmVjdG9yeSk6 CisgICAgICAgIChpc0dpdFNWTkRpcmVjdG9yeSk6CisgICAgICAgIChzdm5SZXZpc2lvbkZvckRp cmVjdG9yeSk6CisgICAgICAgIChzdm5JbmZvRm9yUGF0aCk6CisKIDIwMTctMDQtMTQgIFJ5YW4g SGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjIxNTM2My4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0g Yi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCmluZGV4IDhlMDc4N2M4YTRjM2QxM2M5NTUxZTM1 OGMxMjc2YzFkNDc1ZDIwNmMuLjRkNmNkMjkzZjIyNTBhNjhlMzljZjQwYzVlNzYzZmIzZTViMjBl YjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KKysrIGIvVG9vbHMvU2Ny aXB0cy9WQ1NVdGlscy5wbQpAQCAtMjIzLDcgKzIyMyw3IEBAIHN1YiBzY21SZW1vdmVFeGVjdXRh YmxlQml0KCQpCiBzdWIgaXNHaXREaXJlY3RvcnkoJCkKIHsKICAgICBteSAoJGRpcmVjdG9yeSkg PSBAXzsKLSAgICByZXR1cm4gc3lzdGVtKCJnaXQgLUMgJyRkaXJlY3RvcnknIHJldi1wYXJzZSA+ ICIgLiBGaWxlOjpTcGVjLT5kZXZudWxsKCkgLiAiIDI+JjEiKSA9PSAwOworICAgIHJldHVybiBz eXN0ZW0oImdpdCAtQyBcIiRkaXJlY3RvcnlcIiByZXYtcGFyc2UgPiAiIC4gRmlsZTo6U3BlYy0+ ZGV2bnVsbCgpIC4gIiAyPiYxIikgPT0gMDsKIH0KIAogc3ViIGlzR2l0KCkKQEAgLTI0MSw3ICsy NDEsNyBAQCBzdWIgaXNHaXRTVk5EaXJlY3RvcnkoJCkKICAgICAjIFRoZXJlIGRvZXNuJ3Qgc2Vl bSB0byBiZSBhbiBvZmZpY2lhbGx5IGRvY3VtZW50ZWQgd2F5IHRvIGRldGVybWluZQogICAgICMg aWYgeW91J3JlIGluIGEgZ2l0LXN2biBjaGVja291dC4gVGhlIGJlc3Qgc3VnZ2VzdGlvbnMgc2Vl biBzbyBmYXIKICAgICAjIGFsbCB1c2Ugc29tZXRoaW5nIGxpa2UgdGhlIGZvbGxvd2luZzoKLSAg ICBteSAkb3V0cHV0ID0gYGdpdCAtQyAnJGRpcmVjdG9yeScgY29uZmlnIC0tZ2V0IHN2bi1yZW1v dGUuc3ZuLmZldGNoIDI+JjFgOworICAgIG15ICRvdXRwdXQgPSBgZ2l0IC1DIFwiJGRpcmVjdG9y eVwiIGNvbmZpZyAtLWdldCBzdm4tcmVtb3RlLnN2bi5mZXRjaCAyPiYxYDsKICAgICAkaXNHaXRT Vk4gPSBleGl0U3RhdHVzKCQ/KSA9PSAwICYmICRvdXRwdXQgbmUgIiI7CiAgICAgcmV0dXJuICRp c0dpdFNWTjsKIH0KQEAgLTQzMiw3ICs0MzIsNyBAQCBzdWIgc3ZuUmV2aXNpb25Gb3JEaXJlY3Rv cnkoJCkKICAgICAgICAgbXkgJHN2bkluZm8gPSBgJGNvbW1hbmRgOwogICAgICAgICAoJHJldmlz aW9uKSA9ICgkc3ZuSW5mbyA9fiBtL1JldmlzaW9uOiAoXGQrKS4qL2cpOwogICAgIH0gZWxzaWYg KGlzR2l0RGlyZWN0b3J5KCRkaXJlY3RvcnkpKSB7Ci0gICAgICAgIG15ICRjb21tYW5kID0gImdp dCAtQyAnJGRpcmVjdG9yeScgbG9nIC0tZ3JlcD1cImdpdC1zdm4taWQ6IFwiIC1uIDEgfCBncmVw IGdpdC1zdm4taWQ6IjsKKyAgICAgICAgbXkgJGNvbW1hbmQgPSAiZ2l0IC1DIFwiJGRpcmVjdG9y eVwiIGxvZyAtLWdyZXA9XCJnaXQtc3ZuLWlkOiBcIiAtbiAxIHwgZ3JlcCBnaXQtc3ZuLWlkOiI7 CiAgICAgICAgICRjb21tYW5kID0gIkxDX0FMTD1DICRjb21tYW5kIiBpZiAhaXNXaW5kb3dzKCk7 CiAgICAgICAgIG15ICRnaXRMb2cgPSBgJGNvbW1hbmRgOwogICAgICAgICAoJHJldmlzaW9uKSA9 ICgkZ2l0TG9nID1+IG0vICtnaXQtc3ZuLWlkOiAuK0AoXGQrKSAvZyk7CkBAIC00NTYsNyArNDU2 LDcgQEAgc3ViIHN2bkluZm9Gb3JQYXRoKCQpCiAgICAgICAgICRjb21tYW5kID0gIkxDX0FMTD1D ICRjb21tYW5kIiBpZiAhaXNXaW5kb3dzKCk7CiAgICAgICAgICRzdm5JbmZvID0gYCRjb21tYW5k YDsKICAgICB9IGVsc2lmIChpc0dpdERpcmVjdG9yeSgkZmlsZSkpIHsKLSAgICAgICAgbXkgJGNv bW1hbmQgPSAiZ2l0IC1DICckZmlsZScgc3ZuIGluZm8iOworICAgICAgICBteSAkY29tbWFuZCA9 ICJnaXQgLUMgXCIkZmlsZVwiIHN2biBpbmZvIjsKICAgICAgICAgJGNvbW1hbmQgPSAiTENfQUxM PUMgJGNvbW1hbmQiIGlmICFpc1dpbmRvd3MoKTsKICAgICAgICAgJHN2bkluZm8gPSBgJGNvbW1h bmRgOwogICAgIH0K