170836 2017-04-13 16:53:56 -0700 The Incomplete asynchronously decoded image frame should be decoded every time it's drawn 2017-05-11 19:34:14 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172009 1 sabouhallawa sabouhallawa simon.fraser thorton webkit-bug-importer oldest_to_newest 1297212 0 sabouhallawa 2017-04-13 16:53:56 -0700 The asynchronously decoded image frames has to be cached to prevent flickering, but we have to keep requesting new decoding for the incomplete frame every time it's drawn. This is to avoid drawing an incomplete image frame even after all its encoded data is received. 1297214 1 307048 sabouhallawa 2017-04-13 16:55:22 -0700 Created attachment 307048 Patch 1297215 2 sabouhallawa 2017-04-13 16:56:18 -0700 <rdar://problem/31132092> 1297428 3 307122 sabouhallawa 2017-04-14 10:38:40 -0700 Created attachment 307122 Patch 1297935 4 thorton 2017-04-17 10:27:35 -0700 Can we test this? 1306154 5 309441 sabouhallawa 2017-05-08 16:59:58 -0700 Created attachment 309441 Patch 1306210 6 309441 sabouhallawa 2017-05-08 18:53:56 -0700 Comment on attachment 309441 Patch Clearing flags on attachment: 309441 Committed r216471: <http://trac.webkit.org/changeset/216471> 1306211 7 sabouhallawa 2017-05-08 18:53:57 -0700 All reviewed patches have been landed. Closing bug. 307048 2017-04-13 16:55:22 -0700 2017-04-14 10:38:39 -0700 Patch bug-170836-20170413165521.patch text/plain 3499 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU3MDc4ZWVlYTg5YTRk OGE2NTE4YzcyNDA0MzNjYmY4ZWI1N2M3MS4uNDQzNmE1ZWFkMGVmNGIwY2Y2OTU2MzBjN2NkM2Qz YTFjZjc1ZjAwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA0LTEzICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIElu Y29tcGxldGUgYXN5bmNocm9ub3VzbHkgZGVjb2RlZCBpbWFnZSBmcmFtZSBzaG91bGQgYmUgZGVj b2RlZCBldmVyeSB0aW1lIGl0J3MgZHJhd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3MDgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBhc3luY2hyb25vdXNseSBkZWNvZGVkIGltYWdlIGZyYW1l cyBoYXMgdG8gYmUgY2FjaGVkIHRvIHByZXZlbnQgZmxpY2tlcmluZywKKyAgICAgICAgYnV0IHdl IGhhdmUgdG8ga2VlcCByZXF1ZXN0aW5nIG5ldyBkZWNvZGluZyBmb3IgdGhlIGluY29tcGxldGUg ZnJhbWUgZXZlcnkgdGltZQorICAgICAgICBpdCdzIGRyYXduLiBUaGlzIGlzIHRvIGF2b2lkIGRy YXdpbmcgYW4gaW5jb21wbGV0ZSBpbWFnZSBmcmFtZSBldmVuIGFmdGVyIGFsbAorICAgICAgICBp dHMgZW5jb2RlZCBkYXRhIGlzIHJlY2VpdmVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvQml0bWFwSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwSW1hZ2U6OmRyYXcp OgorCiAyMDE3LTA0LTEwICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5j b20+CiAKICAgICAgICAgQ2FjaGVkSW1hZ2Ugc2hvdWxkIHN0b3AgZGVjb2RpbmcgaW1hZ2VzIHdo ZW4gdW5rbm93biB0eXBlIGlzIGRldGVjdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKaW5kZXggMzk4YTVkZDQ5ZjcxNzE2Y2ExOWRmOTBk MGNmODc2YTEzODc2MjBjMy4uNzc0YjZmZTZjMjk0NDA4MzllODRhM2ExMjAzYWUwMmIyNWQ1NjY5 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1h Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdl LmNwcApAQCAtMTczLDEwICsxNzMsMTYgQEAgdm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFwaGlj c0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgZGVzdFJlY3QsIGNvbnMKICAgICBp ZiAoZGVjb2RpbmdNb2RlID09IERlY29kaW5nTW9kZTo6QXN5bmNocm9ub3VzICYmIHNob3VsZFVz ZUFzeW5jRGVjb2RpbmdGb3JMYXJnZUltYWdlcygpKSB7CiAgICAgICAgIEFTU0VSVCghY2FuQW5p bWF0ZSgpICYmICFtX2N1cnJlbnRGcmFtZSk7CiAKLSAgICAgICAgaWYgKCFmcmFtZUhhc0RlY29k ZWROYXRpdmVJbWFnZUNvbXBhdGlibGVXaXRoT3B0aW9uc0F0SW5kZXgobV9jdXJyZW50RnJhbWUs IG1fY3VycmVudFN1YnNhbXBsaW5nTGV2ZWwsIERlY29kaW5nT3B0aW9ucyhzaXplRm9yRHJhd2lu ZykpCi0gICAgICAgICAgICAmJiAhZnJhbWVJc0JlaW5nRGVjb2RlZEFuZElzQ29tcGF0aWJsZVdp dGhPcHRpb25zQXRJbmRleChtX2N1cnJlbnRGcmFtZSwgRGVjb2RpbmdPcHRpb25zKHNpemVGb3JE cmF3aW5nKSkpIHsKKyAgICAgICAgYm9vbCBmcmFtZUlzQ29tcGF0aWJsZSA9IGZyYW1lSGFzRGVj b2RlZE5hdGl2ZUltYWdlQ29tcGF0aWJsZVdpdGhPcHRpb25zQXRJbmRleChtX2N1cnJlbnRGcmFt ZSwgbV9jdXJyZW50U3Vic2FtcGxpbmdMZXZlbCwgRGVjb2RpbmdPcHRpb25zKHNpemVGb3JEcmF3 aW5nKSk7CisgICAgICAgIGJvb2wgZnJhbWVJc0JlaW5nRGVjb2RlZCA9IGZyYW1lSXNCZWluZ0Rl Y29kZWRBbmRJc0NvbXBhdGlibGVXaXRoT3B0aW9uc0F0SW5kZXgobV9jdXJyZW50RnJhbWUsIERl Y29kaW5nT3B0aW9ucyhzaXplRm9yRHJhd2luZykpOworICAgICAgICBib29sIGZyYW1lSXNDb21w bGV0ZSA9IGZyYW1lSXNDb21wbGV0ZUF0SW5kZXgobV9jdXJyZW50RnJhbWUpOworCisgICAgICAg IC8vIElmIHRoZSBkZWNvZGVkIGZyYW1lIGlzIGNvbXBhdGlibGUgd2l0aCBzaXplRm9yRHJhd2lu ZyBhbmQgdGhlIGZyYW1lIGlzIGNvbXBsZXRlIG9yCisgICAgICAgIC8vIHRoZSBmcmFtZSBpcyBi ZWluZyBkZWNvZGVkLCB0aGVyZSBpcyBubyBuZWVkIHRvIHJlcXVlc3QgYSBuZXcgYXN5bmMgaW1h Z2UgZGVjb2RpbmcuCisgICAgICAgIGlmICghKChmcmFtZUlzQ29tcGF0aWJsZSAmJiBmcmFtZUlz Q29tcGxldGUpIHx8IGZyYW1lSXNCZWluZ0RlY29kZWQpKSB7CiAgICAgICAgICAgICBMT0coSW1h Z2VzLCAiQml0bWFwSW1hZ2U6OiVzIC0gJXAgLSB1cmw6ICVzIFtyZXF1ZXN0aW5nIGxhcmdlIGFz eW5jIGRlY29kaW5nXSIsIF9fRlVOQ1RJT05fXywgdGhpcywgc291cmNlVVJMKCkudXRmOCgpLmRh dGEoKSk7CiAgICAgICAgICAgICBtX3NvdXJjZS5yZXF1ZXN0RnJhbWVBc3luY0RlY29kaW5nQXRJ bmRleCgwLCBtX2N1cnJlbnRTdWJzYW1wbGluZ0xldmVsLCBzaXplRm9yRHJhd2luZyk7CisgICAg ICAgICAgICBmcmFtZUlzQmVpbmdEZWNvZGVkID0gdHJ1ZTsKICAgICAgICAgfQogCiAgICAgICAg IGlmICghZnJhbWVIYXNEZWNvZGVkTmF0aXZlSW1hZ2VDb21wYXRpYmxlV2l0aE9wdGlvbnNBdElu ZGV4KG1fY3VycmVudEZyYW1lLCBtX2N1cnJlbnRTdWJzYW1wbGluZ0xldmVsLCBEZWNvZGluZ01v ZGU6OkFzeW5jaHJvbm91cykpIHsKQEAgLTE4Niw2ICsxOTIsNyBAQCB2b2lkIEJpdG1hcEltYWdl OjpkcmF3KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVj dCwgY29ucwogICAgICAgICB9CiAKICAgICAgICAgaW1hZ2UgPSBmcmFtZUltYWdlQXRJbmRleCht X2N1cnJlbnRGcmFtZSk7CisgICAgICAgIEFTU0VSVF9JTVBMSUVTKGVuY29kZWREYXRhU3RhdHVz KCkgPT0gRW5jb2RlZERhdGFTdGF0dXM6OkNvbXBsZXRlLCBmcmFtZUlzQmVpbmdEZWNvZGVkIHx8 IGZyYW1lSXNDb21wbGV0ZSk7CiAgICAgICAgIExPRyhJbWFnZXMsICJCaXRtYXBJbWFnZTo6JXMg LSAlcCAtIHVybDogJXMgW2EgZGVjb2RlZCBpbWFnZSBmcmFtZSBpcyBhdmFpbGFibGUgZm9yIGRy YXdpbmddIiwgX19GVU5DVElPTl9fLCB0aGlzLCBzb3VyY2VVUkwoKS51dGY4KCkuZGF0YSgpKTsK ICAgICB9IGVsc2UgewogICAgICAgICBTdGFydEFuaW1hdGlvblN0YXR1cyBzdGF0dXMgPSBpbnRl cm5hbFN0YXJ0QW5pbWF0aW9uKCk7Cg== 307122 2017-04-14 10:38:40 -0700 2017-05-08 16:59:56 -0700 Patch bug-170836-20170414103840.patch text/plain 6089 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU3MDc4ZWVlYTg5YTRk OGE2NTE4YzcyNDA0MzNjYmY4ZWI1N2M3MS4uZTYxYmQ2NzkzY2RjY2YxMTM0YmJiY2I2YzZmMTAx NDQ2MTEwOGJlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA0LTE0ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIElu Y29tcGxldGUgYXN5bmNocm9ub3VzbHkgZGVjb2RlZCBpbWFnZSBmcmFtZSBzaG91bGQgYmUgZGVj b2RlZCBldmVyeSB0aW1lIGl0J3MgZHJhd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3MDgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBhc3luY2hyb25vdXNseSBkZWNvZGVkIGltYWdlIGZyYW1l cyBoYXMgdG8gYmUgY2FjaGVkIHRvIHByZXZlbnQgZmxpY2tlcmluZywKKyAgICAgICAgYnV0IHdl IGhhdmUgdG8ga2VlcCByZXF1ZXN0aW5nIG5ldyBkZWNvZGluZyBmb3IgdGhlIGluY29tcGxldGUg ZnJhbWUgZXZlcnkgdGltZQorICAgICAgICBpdCdzIGRyYXduLiBUaGlzIGlzIHRvIGF2b2lkIGRy YXdpbmcgYW4gaW5jb21wbGV0ZSBpbWFnZSBmcmFtZSBldmVuIGFmdGVyIGFsbAorICAgICAgICBp dHMgZW5jb2RlZCBkYXRhIGlzIHJlY2VpdmVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvQml0bWFwSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwSW1hZ2U6OmRyYXcp OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlRnJhbWVDYWNoZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbWFnZUZyYW1lQ2FjaGU6OmNhY2hlQXN5bmNGcmFtZU5hdGl2ZUltYWdl QXRJbmRleCk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUZyYW1lQ2FjaGU6OnJlcXVlc3RGcmFt ZUFzeW5jRGVjb2RpbmdBdEluZGV4KToKKwogMjAxNy0wNC0xMCAgU2FpZCBBYm91LUhhbGxhd2Eg IDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIENhY2hlZEltYWdlIHNob3VsZCBz dG9wIGRlY29kaW5nIGltYWdlcyB3aGVuIHVua25vd24gdHlwZSBpcyBkZXRlY3RlZApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCmluZGV4IDM5 OGE1ZGQ0OWY3MTcxNmNhMTlkZjkwZDBjZjg3NmExMzg3NjIwYzMuLjg0NGZlNTI0ZGI1NjM1NmEw NjY3YjEzZTMxYzBiZTY5ZTkxZmM2MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKQEAgLTE3MywxMCArMTczLDE1IEBAIHZvaWQgQml0 bWFwSW1hZ2U6OmRyYXcoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBGbG9hdFJlY3Qm IGRlc3RSZWN0LCBjb25zCiAgICAgaWYgKGRlY29kaW5nTW9kZSA9PSBEZWNvZGluZ01vZGU6OkFz eW5jaHJvbm91cyAmJiBzaG91bGRVc2VBc3luY0RlY29kaW5nRm9yTGFyZ2VJbWFnZXMoKSkgewog ICAgICAgICBBU1NFUlQoIWNhbkFuaW1hdGUoKSAmJiAhbV9jdXJyZW50RnJhbWUpOwogCi0gICAg ICAgIGlmICghZnJhbWVIYXNEZWNvZGVkTmF0aXZlSW1hZ2VDb21wYXRpYmxlV2l0aE9wdGlvbnNB dEluZGV4KG1fY3VycmVudEZyYW1lLCBtX2N1cnJlbnRTdWJzYW1wbGluZ0xldmVsLCBEZWNvZGlu Z09wdGlvbnMoc2l6ZUZvckRyYXdpbmcpKQotICAgICAgICAgICAgJiYgIWZyYW1lSXNCZWluZ0Rl Y29kZWRBbmRJc0NvbXBhdGlibGVXaXRoT3B0aW9uc0F0SW5kZXgobV9jdXJyZW50RnJhbWUsIERl Y29kaW5nT3B0aW9ucyhzaXplRm9yRHJhd2luZykpKSB7CisgICAgICAgIGJvb2wgZnJhbWVJc0Nv bXBhdGlibGUgPSBmcmFtZUhhc0RlY29kZWROYXRpdmVJbWFnZUNvbXBhdGlibGVXaXRoT3B0aW9u c0F0SW5kZXgobV9jdXJyZW50RnJhbWUsIG1fY3VycmVudFN1YnNhbXBsaW5nTGV2ZWwsIERlY29k aW5nT3B0aW9ucyhzaXplRm9yRHJhd2luZykpOworICAgICAgICBib29sIGZyYW1lSXNCZWluZ0Rl Y29kZWQgPSBmcmFtZUlzQmVpbmdEZWNvZGVkQW5kSXNDb21wYXRpYmxlV2l0aE9wdGlvbnNBdElu ZGV4KG1fY3VycmVudEZyYW1lLCBEZWNvZGluZ09wdGlvbnMoc2l6ZUZvckRyYXdpbmcpKTsKKyAg ICAgICAgYm9vbCBmcmFtZUlzQ29tcGxldGUgPSBmcmFtZUlzQ29tcGxldGVBdEluZGV4KG1fY3Vy cmVudEZyYW1lKTsKKyAgICAgICAgCisgICAgICAgIC8vIElmIHRoZSBkZWNvZGVkIGZyYW1lIGlz IGNvbXBhdGlibGUgd2l0aCBzaXplRm9yRHJhd2luZyBvciB0aGUgZnJhbWUgaXMgYmVpbmcgZGVj b2RlZCwgdGhlcmUKKyAgICAgICAgLy8gaXMgbm8gbmVlZCB0byByZXF1ZXN0IGEgbmV3IGFzeW5j IGltYWdlIGRlY29kaW5nIHVubGVzcyB0aGUgY3VycmVudCBmcmFtZSBpcyBpbmNvbXBsZXRlLgor ICAgICAgICBpZiAoISgoZnJhbWVJc0NvbXBhdGlibGUgfHwgZnJhbWVJc0JlaW5nRGVjb2RlZCkg JiYgZnJhbWVJc0NvbXBsZXRlKSkgewogICAgICAgICAgICAgTE9HKEltYWdlcywgIkJpdG1hcElt YWdlOjolcyAtICVwIC0gdXJsOiAlcyBbcmVxdWVzdGluZyBsYXJnZSBhc3luYyBkZWNvZGluZ10i LCBfX0ZVTkNUSU9OX18sIHRoaXMsIHNvdXJjZVVSTCgpLnV0ZjgoKS5kYXRhKCkpOwotICAgICAg ICAgICAgbV9zb3VyY2UucmVxdWVzdEZyYW1lQXN5bmNEZWNvZGluZ0F0SW5kZXgoMCwgbV9jdXJy ZW50U3Vic2FtcGxpbmdMZXZlbCwgc2l6ZUZvckRyYXdpbmcpOworICAgICAgICAgICAgZnJhbWVJ c0JlaW5nRGVjb2RlZCA9IG1fc291cmNlLnJlcXVlc3RGcmFtZUFzeW5jRGVjb2RpbmdBdEluZGV4 KDAsIG1fY3VycmVudFN1YnNhbXBsaW5nTGV2ZWwsIHNpemVGb3JEcmF3aW5nKTsKICAgICAgICAg fQogCiAgICAgICAgIGlmICghZnJhbWVIYXNEZWNvZGVkTmF0aXZlSW1hZ2VDb21wYXRpYmxlV2l0 aE9wdGlvbnNBdEluZGV4KG1fY3VycmVudEZyYW1lLCBtX2N1cnJlbnRTdWJzYW1wbGluZ0xldmVs LCBEZWNvZGluZ01vZGU6OkFzeW5jaHJvbm91cykpIHsKQEAgLTE4Niw2ICsxOTEsNyBAQCB2b2lk IEJpdG1hcEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgRmxvYXRS ZWN0JiBkZXN0UmVjdCwgY29ucwogICAgICAgICB9CiAKICAgICAgICAgaW1hZ2UgPSBmcmFtZUlt YWdlQXRJbmRleChtX2N1cnJlbnRGcmFtZSk7CisgICAgICAgIEFTU0VSVF9JTVBMSUVTKGVuY29k ZWREYXRhU3RhdHVzKCkgPT0gRW5jb2RlZERhdGFTdGF0dXM6OkNvbXBsZXRlLCBmcmFtZUlzQmVp bmdEZWNvZGVkIHx8IGZyYW1lSXNDb21wbGV0ZSk7CiAgICAgICAgIExPRyhJbWFnZXMsICJCaXRt YXBJbWFnZTo6JXMgLSAlcCAtIHVybDogJXMgW2EgZGVjb2RlZCBpbWFnZSBmcmFtZSBpcyBhdmFp bGFibGUgZm9yIGRyYXdpbmddIiwgX19GVU5DVElPTl9fLCB0aGlzLCBzb3VyY2VVUkwoKS51dGY4 KCkuZGF0YSgpKTsKICAgICB9IGVsc2UgewogICAgICAgICBTdGFydEFuaW1hdGlvblN0YXR1cyBz dGF0dXMgPSBpbnRlcm5hbFN0YXJ0QW5pbWF0aW9uKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUZyYW1lQ2FjaGUuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VGcmFtZUNhY2hlLmNwcAppbmRleCAzODViNjQzOWQx YTc0NzE5YzVjZWQxZTYxZWVkODlmODVkOGFlYjAzLi5lMjhiNGM1ZDY5NTg5OWJlMGI2YjYyMDZi YmVhNWQ2NGU3YjhhN2JjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9JbWFnZUZyYW1lQ2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ltYWdlRnJhbWVDYWNoZS5jcHAKQEAgLTI0Niw3ICsyNDYsNyBAQCB2b2lkIEltYWdl RnJhbWVDYWNoZTo6Y2FjaGVBc3luY0ZyYW1lTmF0aXZlSW1hZ2VBdEluZGV4KE5hdGl2ZUltYWdl UHRyJiYgbmF0aXZlSQogICAgICAgICByZXR1cm47CiAKICAgICBBU1NFUlQoaW5kZXggPCBtX2Zy YW1lcy5zaXplKCkpOwotICAgIEFTU0VSVCghZnJhbWVIYXNEZWNvZGVkTmF0aXZlSW1hZ2VDb21w YXRpYmxlV2l0aE9wdGlvbnNBdEluZGV4KGluZGV4LCBzdWJzYW1wbGluZ0xldmVsLCBkZWNvZGlu Z09wdGlvbnMpKTsKKyAgICBBU1NFUlQoIWZyYW1lSXNDb21wbGV0ZUF0SW5kZXgoaW5kZXgpIHx8 ICFmcmFtZUhhc0RlY29kZWROYXRpdmVJbWFnZUNvbXBhdGlibGVXaXRoT3B0aW9uc0F0SW5kZXgo aW5kZXgsIHN1YnNhbXBsaW5nTGV2ZWwsIGRlY29kaW5nT3B0aW9ucykpOwogCiAgICAgLy8gQ2xl YW4gdGhlIG9sZCBuYXRpdmUgaW1hZ2UgYW5kIHNldCBhIG5ldyBvbmUKICAgICBjYWNoZUZyYW1l TmF0aXZlSW1hZ2VBdEluZGV4KFdURk1vdmUobmF0aXZlSW1hZ2UpLCBpbmRleCwgc3Vic2FtcGxp bmdMZXZlbCwgZGVjb2RpbmdPcHRpb25zKTsKQEAgLTMwOSwxNiArMzA5LDE4IEBAIGJvb2wgSW1h Z2VGcmFtZUNhY2hlOjpyZXF1ZXN0RnJhbWVBc3luY0RlY29kaW5nQXRJbmRleChzaXplX3QgaW5k ZXgsIFN1YnNhbXBsaW5nCiAgICAgaWYgKCFpc0RlY29kZXJBdmFpbGFibGUoKSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogCisgICAgLy8gQWxsb3cgbmV3IHJlcXVlc3RzIGZvciB0aGUgc2FtZSBm cmFtZSBpZiB0aGUgZnJhbWUgaXMgaW5jb21wbGV0ZS4KICAgICBBU1NFUlQoaW5kZXggPCBtX2Zy YW1lcy5zaXplKCkpOwotCi0gICAgLy8gV2UgbmVlZCB0byBjb2FsZXNjZSBtdWx0aXBsZSByZXF1 ZXN0cyBmb3IgZGVjb2RpbmcgdGhlIHNhbWUgSW1hZ2VGcmFtZSB3aGlsZSBpdAotICAgIC8vIGlz IHN0aWxsIGJlaW5nIGRlY29kZWQuIFRoaXMgbWF5IGhhcHBlbiBpZiB0aGUgaW1hZ2UgcmVjdGFu Z2xlIGlzIHJlcGFpbnRlZAotICAgIC8vIG11bHRpcGxlIHRpbWVzIHdoaWxlIHRoZSBJbWFnZUZy YW1lIGhhcyBub3QgZmluaXNoZWQgZGVjb2RpbmcuCi0gICAgaWYgKGZyYW1lSXNCZWluZ0RlY29k ZWRBbmRJc0NvbXBhdGlibGVXaXRoT3B0aW9uc0F0SW5kZXgoaW5kZXgsIHNpemVGb3JEcmF3aW5n KSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0KLSAgICBpZiAoZnJhbWVIYXNEZWNvZGVkTmF0aXZl SW1hZ2VDb21wYXRpYmxlV2l0aE9wdGlvbnNBdEluZGV4KGluZGV4LCBzdWJzYW1wbGluZ0xldmVs LCBzaXplRm9yRHJhd2luZykpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAoZnJhbWVJ c0NvbXBsZXRlQXRJbmRleChpbmRleCkpIHsKKyAgICAgICAgLy8gV2UgbmVlZCB0byBjb2FsZXNj ZSBtdWx0aXBsZSByZXF1ZXN0cyBmb3IgZGVjb2RpbmcgdGhlIHNhbWUgSW1hZ2VGcmFtZSB3aGls ZSBpdAorICAgICAgICAvLyBpcyBzdGlsbCBiZWluZyBkZWNvZGVkLiBUaGlzIG1heSBoYXBwZW4g aWYgdGhlIGltYWdlIHJlY3RhbmdsZSBpcyByZXBhaW50ZWQKKyAgICAgICAgLy8gbXVsdGlwbGUg dGltZXMgd2hpbGUgdGhlIEltYWdlRnJhbWUgaGFzIG5vdCBmaW5pc2hlZCBkZWNvZGluZy4KKyAg ICAgICAgaWYgKGZyYW1lSXNCZWluZ0RlY29kZWRBbmRJc0NvbXBhdGlibGVXaXRoT3B0aW9uc0F0 SW5kZXgoaW5kZXgsIHNpemVGb3JEcmF3aW5nKSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOwor CisgICAgICAgIGlmIChmcmFtZUhhc0RlY29kZWROYXRpdmVJbWFnZUNvbXBhdGlibGVXaXRoT3B0 aW9uc0F0SW5kZXgoaW5kZXgsIHN1YnNhbXBsaW5nTGV2ZWwsIHNpemVGb3JEcmF3aW5nKSkKKyAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICBpZiAoIWhhc0FzeW5jRGVjb2Rp bmdRdWV1ZSgpKQogICAgICAgICBzdGFydEFzeW5jRGVjb2RpbmdRdWV1ZSgpOwo= 309441 2017-05-08 16:59:58 -0700 2017-05-08 16:59:58 -0700 Patch bug-170836-20170508170002.patch text/plain 5767 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjQ2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA1LTA4ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIEluY29t cGxldGUgYXN5bmNocm9ub3VzbHkgZGVjb2RlZCBpbWFnZSBmcmFtZSBzaG91bGQgYmUgZGVjb2Rl ZCBldmVyeSB0aW1lIGl0J3MgZHJhd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MDgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24u CisKKyAgICAgICAgVGhlIGFzeW5jaHJvbm91c2x5IGRlY29kZWQgaW1hZ2UgZnJhbWVzIGhhcyB0 byBiZSBjYWNoZWQgdG8gcHJldmVudCBmbGlja2VyaW5nLAorICAgICAgICBidXQgd2UgaGF2ZSB0 byBrZWVwIHJlcXVlc3RpbmcgbmV3IGRlY29kaW5nIGZvciB0aGUgaW5jb21wbGV0ZSBmcmFtZSBl dmVyeSB0aW1lCisgICAgICAgIGl0J3MgZHJhd24uIFRoaXMgaXMgdG8gYXZvaWQgZHJhd2luZyBh biBpbmNvbXBsZXRlIGltYWdlIGZyYW1lIGV2ZW4gYWZ0ZXIgYWxsCisgICAgICAgIGl0cyBlbmNv ZGVkIGRhdGEgaXMgcmVjZWl2ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9CaXRt YXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6ZHJhdyk6CisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VGcmFtZUNhY2hlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkltYWdlRnJhbWVDYWNoZTo6Y2FjaGVBc3luY0ZyYW1lTmF0aXZlSW1hZ2VBdEluZGV4 KToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRnJhbWVDYWNoZTo6cmVxdWVzdEZyYW1lQXN5bmNE ZWNvZGluZ0F0SW5kZXgpOgorCiAyMDE3LTA1LTA4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgcmVhZGluZyBhbmQgd3JpdGluZyBz ZXR0aW5ncyBmcm9tIFVJUHJvY2VzcyBhdWRpbyBjYXB0dXJlCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCShyZXZpc2lvbiAyMTY0 NTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE4MywxMCArMTgzLDE1IEBAIHZvaWQgQml0bWFwSW1hZ2U6OmRy YXcoR3JhcGhpY3NDb250ZXh0JiAKICAgICBpZiAoZGVjb2RpbmdNb2RlID09IERlY29kaW5nTW9k ZTo6QXN5bmNocm9ub3VzICYmIHNob3VsZFVzZUFzeW5jRGVjb2RpbmdGb3JMYXJnZUltYWdlcygp KSB7CiAgICAgICAgIEFTU0VSVCghY2FuQW5pbWF0ZSgpICYmICFtX2N1cnJlbnRGcmFtZSk7CiAK LSAgICAgICAgaWYgKCFmcmFtZUhhc0RlY29kZWROYXRpdmVJbWFnZUNvbXBhdGlibGVXaXRoT3B0 aW9uc0F0SW5kZXgobV9jdXJyZW50RnJhbWUsIG1fY3VycmVudFN1YnNhbXBsaW5nTGV2ZWwsIERl Y29kaW5nT3B0aW9ucyhzaXplRm9yRHJhd2luZykpCi0gICAgICAgICAgICAmJiAhZnJhbWVJc0Jl aW5nRGVjb2RlZEFuZElzQ29tcGF0aWJsZVdpdGhPcHRpb25zQXRJbmRleChtX2N1cnJlbnRGcmFt ZSwgRGVjb2RpbmdPcHRpb25zKHNpemVGb3JEcmF3aW5nKSkpIHsKKyAgICAgICAgYm9vbCBmcmFt ZUlzQ29tcGF0aWJsZSA9IGZyYW1lSGFzRGVjb2RlZE5hdGl2ZUltYWdlQ29tcGF0aWJsZVdpdGhP cHRpb25zQXRJbmRleChtX2N1cnJlbnRGcmFtZSwgbV9jdXJyZW50U3Vic2FtcGxpbmdMZXZlbCwg RGVjb2RpbmdPcHRpb25zKHNpemVGb3JEcmF3aW5nKSk7CisgICAgICAgIGJvb2wgZnJhbWVJc0Jl aW5nRGVjb2RlZCA9IGZyYW1lSXNCZWluZ0RlY29kZWRBbmRJc0NvbXBhdGlibGVXaXRoT3B0aW9u c0F0SW5kZXgobV9jdXJyZW50RnJhbWUsIERlY29kaW5nT3B0aW9ucyhzaXplRm9yRHJhd2luZykp OworICAgICAgICBib29sIGZyYW1lSXNDb21wbGV0ZSA9IGZyYW1lSXNDb21wbGV0ZUF0SW5kZXgo bV9jdXJyZW50RnJhbWUpOworCisgICAgICAgIC8vIElmIHRoZSBjdXJyZW50IGZyYW1lIGlzIGlu Y29tcGxldGUsIGEgbmV3IHJlcXVlc3QgZm9yIGRlY29kaW5nIHRoaXMgZnJhbWUgaGFzIHRvIGJl IG1hZGUgZXZlbiBpZgorICAgICAgICAvLyBpdCBpcyBjdXJyZW50bHkgYmVpbmcgZGVjb2RlZC4g TmV3IGRhdGEgbWF5IGhhdmUgYmVlbiByZWNlaXZlZCBzaW5jZSB0aGUgcHJldmlvdXMgcmVxdWVz dCB3YXMgbWFkZS4KKyAgICAgICAgaWYgKCghZnJhbWVJc0NvbXBhdGlibGUgJiYgIWZyYW1lSXNC ZWluZ0RlY29kZWQpIHx8ICFmcmFtZUlzQ29tcGxldGUpIHsKICAgICAgICAgICAgIExPRyhJbWFn ZXMsICJCaXRtYXBJbWFnZTo6JXMgLSAlcCAtIHVybDogJXMgW3JlcXVlc3RpbmcgbGFyZ2UgYXN5 bmMgZGVjb2RpbmddIiwgX19GVU5DVElPTl9fLCB0aGlzLCBzb3VyY2VVUkwoKS5zdHJpbmcoKS51 dGY4KCkuZGF0YSgpKTsKLSAgICAgICAgICAgIG1fc291cmNlLnJlcXVlc3RGcmFtZUFzeW5jRGVj b2RpbmdBdEluZGV4KDAsIG1fY3VycmVudFN1YnNhbXBsaW5nTGV2ZWwsIHNpemVGb3JEcmF3aW5n KTsKKyAgICAgICAgICAgIGZyYW1lSXNCZWluZ0RlY29kZWQgPSBtX3NvdXJjZS5yZXF1ZXN0RnJh bWVBc3luY0RlY29kaW5nQXRJbmRleCgwLCBtX2N1cnJlbnRTdWJzYW1wbGluZ0xldmVsLCBzaXpl Rm9yRHJhd2luZyk7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoIWZyYW1lSGFzRGVjb2RlZE5h dGl2ZUltYWdlQ29tcGF0aWJsZVdpdGhPcHRpb25zQXRJbmRleChtX2N1cnJlbnRGcmFtZSwgbV9j dXJyZW50U3Vic2FtcGxpbmdMZXZlbCwgRGVjb2RpbmdNb2RlOjpBc3luY2hyb25vdXMpKSB7CkBA IC0xOTYsNiArMjAxLDcgQEAgdm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFwaGljc0NvbnRleHQm IAogICAgICAgICB9CiAKICAgICAgICAgaW1hZ2UgPSBmcmFtZUltYWdlQXRJbmRleChtX2N1cnJl bnRGcmFtZSk7CisgICAgICAgIEFTU0VSVF9JTVBMSUVTKGVuY29kZWREYXRhU3RhdHVzKCkgPT0g RW5jb2RlZERhdGFTdGF0dXM6OkNvbXBsZXRlLCBmcmFtZUlzQmVpbmdEZWNvZGVkIHx8IGZyYW1l SXNDb21wbGV0ZSk7CiAgICAgICAgIExPRyhJbWFnZXMsICJCaXRtYXBJbWFnZTo6JXMgLSAlcCAt IHVybDogJXMgW2EgZGVjb2RlZCBpbWFnZSBmcmFtZSBpcyBhdmFpbGFibGUgZm9yIGRyYXdpbmdd IiwgX19GVU5DVElPTl9fLCB0aGlzLCBzb3VyY2VVUkwoKS5zdHJpbmcoKS51dGY4KCkuZGF0YSgp KTsKICAgICB9IGVsc2UgewogICAgICAgICBTdGFydEFuaW1hdGlvblN0YXR1cyBzdGF0dXMgPSBp bnRlcm5hbFN0YXJ0QW5pbWF0aW9uKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9JbWFnZUZyYW1lQ2FjaGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlRnJhbWVDYWNoZS5jcHAJKHJldmlzaW9uIDIxNjQ1MikK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlRnJhbWVDYWNoZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI0Nyw3ICsyNDcsNyBAQCB2b2lkIEltYWdlRnJhbWVDYWNoZTo6 Y2FjaGVBc3luY0ZyYW1lTmF0CiAgICAgICAgIHJldHVybjsKIAogICAgIEFTU0VSVChpbmRleCA8 IG1fZnJhbWVzLnNpemUoKSk7Ci0gICAgQVNTRVJUKCFmcmFtZUhhc0RlY29kZWROYXRpdmVJbWFn ZUNvbXBhdGlibGVXaXRoT3B0aW9uc0F0SW5kZXgoaW5kZXgsIHN1YnNhbXBsaW5nTGV2ZWwsIGRl Y29kaW5nT3B0aW9ucykpOworICAgIEFTU0VSVCghZnJhbWVJc0NvbXBsZXRlQXRJbmRleChpbmRl eCkgfHwgIWZyYW1lSGFzRGVjb2RlZE5hdGl2ZUltYWdlQ29tcGF0aWJsZVdpdGhPcHRpb25zQXRJ bmRleChpbmRleCwgc3Vic2FtcGxpbmdMZXZlbCwgZGVjb2RpbmdPcHRpb25zKSk7CiAKICAgICAv LyBDbGVhbiB0aGUgb2xkIG5hdGl2ZSBpbWFnZSBhbmQgc2V0IGEgbmV3IG9uZQogICAgIGNhY2hl RnJhbWVOYXRpdmVJbWFnZUF0SW5kZXgoV1RGTW92ZShuYXRpdmVJbWFnZSksIGluZGV4LCBzdWJz YW1wbGluZ0xldmVsLCBkZWNvZGluZ09wdGlvbnMpOwpAQCAtMzEwLDE2ICszMTAsMTggQEAgYm9v bCBJbWFnZUZyYW1lQ2FjaGU6OnJlcXVlc3RGcmFtZUFzeW5jRAogICAgIGlmICghaXNEZWNvZGVy QXZhaWxhYmxlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIC8vIEFsbG93IG5ldyBy ZXF1ZXN0cyBmb3IgdGhlIHNhbWUgZnJhbWUgaWYgdGhlIGZyYW1lIGlzIGluY29tcGxldGUuCiAg ICAgQVNTRVJUKGluZGV4IDwgbV9mcmFtZXMuc2l6ZSgpKTsKKyAgICBpZiAoZnJhbWVJc0NvbXBs ZXRlQXRJbmRleChpbmRleCkpIHsKKyAgICAgICAgLy8gV2UgbmVlZCB0byBjb2FsZXNjZSBtdWx0 aXBsZSByZXF1ZXN0cyBmb3IgZGVjb2RpbmcgdGhlIHNhbWUgSW1hZ2VGcmFtZSB3aGlsZSBpdAor ICAgICAgICAvLyBpcyBzdGlsbCBiZWluZyBkZWNvZGVkLiBUaGlzIG1heSBoYXBwZW4gaWYgdGhl IGltYWdlIHJlY3RhbmdsZSBpcyByZXBhaW50ZWQKKyAgICAgICAgLy8gbXVsdGlwbGUgdGltZXMg d2hpbGUgdGhlIEltYWdlRnJhbWUgaGFzIG5vdCBmaW5pc2hlZCBkZWNvZGluZy4KKyAgICAgICAg aWYgKGZyYW1lSXNCZWluZ0RlY29kZWRBbmRJc0NvbXBhdGlibGVXaXRoT3B0aW9uc0F0SW5kZXgo aW5kZXgsIHNpemVGb3JEcmF3aW5nKSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAg Ly8gV2UgbmVlZCB0byBjb2FsZXNjZSBtdWx0aXBsZSByZXF1ZXN0cyBmb3IgZGVjb2RpbmcgdGhl IHNhbWUgSW1hZ2VGcmFtZSB3aGlsZSBpdAotICAgIC8vIGlzIHN0aWxsIGJlaW5nIGRlY29kZWQu IFRoaXMgbWF5IGhhcHBlbiBpZiB0aGUgaW1hZ2UgcmVjdGFuZ2xlIGlzIHJlcGFpbnRlZAotICAg IC8vIG11bHRpcGxlIHRpbWVzIHdoaWxlIHRoZSBJbWFnZUZyYW1lIGhhcyBub3QgZmluaXNoZWQg ZGVjb2RpbmcuCi0gICAgaWYgKGZyYW1lSXNCZWluZ0RlY29kZWRBbmRJc0NvbXBhdGlibGVXaXRo T3B0aW9uc0F0SW5kZXgoaW5kZXgsIHNpemVGb3JEcmF3aW5nKSkKLSAgICAgICAgcmV0dXJuIHRy dWU7Ci0KLSAgICBpZiAoZnJhbWVIYXNEZWNvZGVkTmF0aXZlSW1hZ2VDb21wYXRpYmxlV2l0aE9w dGlvbnNBdEluZGV4KGluZGV4LCBzdWJzYW1wbGluZ0xldmVsLCBzaXplRm9yRHJhd2luZykpCi0g ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgaWYgKGZyYW1lSGFzRGVjb2RlZE5hdGl2ZUlt YWdlQ29tcGF0aWJsZVdpdGhPcHRpb25zQXRJbmRleChpbmRleCwgc3Vic2FtcGxpbmdMZXZlbCwg c2l6ZUZvckRyYXdpbmcpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KIAogICAg IGlmICghaGFzQXN5bmNEZWNvZGluZ1F1ZXVlKCkpCiAgICAgICAgIHN0YXJ0QXN5bmNEZWNvZGlu Z1F1ZXVlKCk7Cg==