170828 2017-04-13 14:41:24 -0700 Remove unused SharedBuffer constructor 2017-04-15 23:31:09 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen beidson buildbot darin mmaxfield ryanhaddad oldest_to_newest 1297139 0 achristensen 2017-04-13 14:41:24 -0700 Remove unused SharedBuffer constructor 1297141 1 307027 achristensen 2017-04-13 14:42:08 -0700 Created attachment 307027 Patch 1297147 2 307029 achristensen 2017-04-13 14:52:03 -0700 Created attachment 307029 Patch 1297207 3 307029 beidson 2017-04-13 16:48:46 -0700 Comment on attachment 307029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307029&action=review > Source/WebCore/platform/SharedBuffer.cpp:230 > + // This copies data unnecessarily right now. We should just use the Vector instead of always copying it. I don't find any value-add from this comment. 1297213 4 achristensen 2017-04-13 16:54:29 -0700 http://trac.webkit.org/r215350 1297246 5 307029 darin 2017-04-13 18:22:14 -0700 Comment on attachment 307029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307029&action=review >> Source/WebCore/platform/SharedBuffer.cpp:230 >> + // This copies data unnecessarily right now. We should just use the Vector instead of always copying it. > > I don't find any value-add from this comment. I asked for a comment here after reviewing another bug. The comment I would write is slightly different. Something like this: // This takes its argument as a rvalue reference because we intend to have a future // version take ownership of the vector rather than copying. 1297407 6 ryanhaddad 2017-04-14 09:53:07 -0700 (In reply to Alex Christensen from comment #4) > http://trac.webkit.org/r215350 I think this change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/674 C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\graphics\win\FontPlatformDataWin.cpp(81): error C2665: 'WebCore::SharedBuffer::create': none of the 4 overloads could convert all the argument types [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] 1297424 7 ryanhaddad 2017-04-14 10:31:55 -0700 Reverted r215350 for reason: This change broke the Windows build. Committed r215364: <http://trac.webkit.org/changeset/215364> 1297701 8 307207 achristensen 2017-04-15 17:01:09 -0700 Created attachment 307207 Patch 1297703 9 achristensen 2017-04-15 17:10:16 -0700 http://trac.webkit.org/r215396 1297738 10 achristensen 2017-04-15 23:31:09 -0700 https://trac.webkit.org/changeset/215398/webkit 307027 2017-04-13 14:42:08 -0700 2017-04-13 14:52:02 -0700 Patch bug-170828-20170413144207.patch text/plain 2527 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTMzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTEzICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVu dXNlZCBTaGFyZWRCdWZmZXIgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDgyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6YXBwZW5kKToKKyAgICAgICAgKiBwbGF0Zm9ybS9T aGFyZWRCdWZmZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKToK KwogMjAxNy0wNC0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVcGRhdGUgdGhlIGNvbW1lbnRzIGZvciB0aGUgbnVtYmVyIG9mIGJpdHMgaW4gUmVuZGVyU3R5 bGU6OkluaGVyaXRlZEZsYWdzLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVk QnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRC dWZmZXIuY3BwCShyZXZpc2lvbiAyMTUzMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T aGFyZWRCdWZmZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NiwxMiArNjYsNiBAQCBTaGFyZWRC dWZmZXI6OlNoYXJlZEJ1ZmZlcigpCiB7CiB9CiAKLVNoYXJlZEJ1ZmZlcjo6U2hhcmVkQnVmZmVy KHVuc2lnbmVkIHNpemUpCi0gICAgOiBtX3NpemUoc2l6ZSkKLSAgICAsIG1fYnVmZmVyKGFkb3B0 UmVmKCpuZXcgRGF0YUJ1ZmZlcikpCi17Ci19Ci0KIFNoYXJlZEJ1ZmZlcjo6U2hhcmVkQnVmZmVy KGNvbnN0IGNoYXIqIGRhdGEsIHVuc2lnbmVkIHNpemUpCiAgICAgOiBtX2J1ZmZlcihhZG9wdFJl ZigqbmV3IERhdGFCdWZmZXIpKQogewpAQCAtMjMzLDYgKzIyNyw3IEBAIHZvaWQgU2hhcmVkQnVm ZmVyOjphcHBlbmQoY29uc3QgY2hhciogZGEKIAogdm9pZCBTaGFyZWRCdWZmZXI6OmFwcGVuZChW ZWN0b3I8Y2hhcj4mJiBkYXRhKQogeworICAgIC8vIFRoaXMgY29waWVzIGRhdGEgdW5uZWNlc3Nh cmlseSByaWdodCBub3cuIFdlIHNob3VsZCBqdXN0IHVzZSB0aGUgVmVjdG9yIGluc3RlYWQgb2Yg YWx3YXlzIGNvcHlpbmcgaXQuCiAgICAgYXBwZW5kKGRhdGEuZGF0YSgpLCBkYXRhLnNpemUoKSk7 CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5oCShyZXZpc2lv biAyMTUzMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuaAkod29y a2luZyBjb3B5KQpAQCAtNTIsNyArNTIsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBT aGFyZWRCdWZmZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxTaGFyZWRCdWZmZXI+IHsKIHB1YmxpYzoK ICAgICBzdGF0aWMgUmVmPFNoYXJlZEJ1ZmZlcj4gY3JlYXRlKCkgeyByZXR1cm4gYWRvcHRSZWYo Km5ldyBTaGFyZWRCdWZmZXIpOyB9Ci0gICAgc3RhdGljIFJlZjxTaGFyZWRCdWZmZXI+IGNyZWF0 ZSh1bnNpZ25lZCBzaXplKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IFNoYXJlZEJ1ZmZlcihzaXpl KSk7IH0KICAgICBzdGF0aWMgUmVmPFNoYXJlZEJ1ZmZlcj4gY3JlYXRlKGNvbnN0IGNoYXIqIGMs IHVuc2lnbmVkIGkpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgU2hhcmVkQnVmZmVyKGMsIGkpKTsg fQogICAgIHN0YXRpYyBSZWY8U2hhcmVkQnVmZmVyPiBjcmVhdGUoY29uc3QgdW5zaWduZWQgY2hh ciogZGF0YSwgdW5zaWduZWQgc2l6ZSkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBTaGFyZWRCdWZm ZXIoZGF0YSwgc2l6ZSkpOyB9CiAKQEAgLTEyMyw3ICsxMjIsNiBAQCBwdWJsaWM6CiAKIHByaXZh dGU6CiAgICAgV0VCQ09SRV9FWFBPUlQgU2hhcmVkQnVmZmVyKCk7Ci0gICAgZXhwbGljaXQgU2hh cmVkQnVmZmVyKHVuc2lnbmVkKTsKICAgICBXRUJDT1JFX0VYUE9SVCBTaGFyZWRCdWZmZXIoY29u c3QgY2hhciosIHVuc2lnbmVkKTsKICAgICBXRUJDT1JFX0VYUE9SVCBTaGFyZWRCdWZmZXIoY29u c3QgdW5zaWduZWQgY2hhciosIHVuc2lnbmVkKTsKICAgICBleHBsaWNpdCBTaGFyZWRCdWZmZXIo TWFwcGVkRmlsZURhdGEmJik7Cg== 307029 2017-04-13 14:52:03 -0700 2017-04-15 17:01:08 -0700 Patch bug-170828-20170413145203.patch text/plain 3656 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTMzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTEzICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVu dXNlZCBTaGFyZWRCdWZmZXIgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDgyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6YXBwZW5kKToKKyAgICAgICAgKiBwbGF0Zm9ybS9T aGFyZWRCdWZmZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKToK KwogMjAxNy0wNC0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVcGRhdGUgdGhlIGNvbW1lbnRzIGZvciB0aGUgbnVtYmVyIG9mIGJpdHMgaW4gUmVuZGVyU3R5 bGU6OkluaGVyaXRlZEZsYWdzLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVk QnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRC dWZmZXIuY3BwCShyZXZpc2lvbiAyMTUzMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T aGFyZWRCdWZmZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NiwxMiArNjYsNiBAQCBTaGFyZWRC dWZmZXI6OlNoYXJlZEJ1ZmZlcigpCiB7CiB9CiAKLVNoYXJlZEJ1ZmZlcjo6U2hhcmVkQnVmZmVy KHVuc2lnbmVkIHNpemUpCi0gICAgOiBtX3NpemUoc2l6ZSkKLSAgICAsIG1fYnVmZmVyKGFkb3B0 UmVmKCpuZXcgRGF0YUJ1ZmZlcikpCi17Ci19Ci0KIFNoYXJlZEJ1ZmZlcjo6U2hhcmVkQnVmZmVy KGNvbnN0IGNoYXIqIGRhdGEsIHVuc2lnbmVkIHNpemUpCiAgICAgOiBtX2J1ZmZlcihhZG9wdFJl ZigqbmV3IERhdGFCdWZmZXIpKQogewpAQCAtMjMzLDYgKzIyNyw3IEBAIHZvaWQgU2hhcmVkQnVm ZmVyOjphcHBlbmQoY29uc3QgY2hhciogZGEKIAogdm9pZCBTaGFyZWRCdWZmZXI6OmFwcGVuZChW ZWN0b3I8Y2hhcj4mJiBkYXRhKQogeworICAgIC8vIFRoaXMgY29waWVzIGRhdGEgdW5uZWNlc3Nh cmlseSByaWdodCBub3cuIFdlIHNob3VsZCBqdXN0IHVzZSB0aGUgVmVjdG9yIGluc3RlYWQgb2Yg YWx3YXlzIGNvcHlpbmcgaXQuCiAgICAgYXBwZW5kKGRhdGEuZGF0YSgpLCBkYXRhLnNpemUoKSk7 CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5oCShyZXZpc2lv biAyMTUzMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuaAkod29y a2luZyBjb3B5KQpAQCAtNTIsNyArNTIsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBT aGFyZWRCdWZmZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxTaGFyZWRCdWZmZXI+IHsKIHB1YmxpYzoK ICAgICBzdGF0aWMgUmVmPFNoYXJlZEJ1ZmZlcj4gY3JlYXRlKCkgeyByZXR1cm4gYWRvcHRSZWYo Km5ldyBTaGFyZWRCdWZmZXIpOyB9Ci0gICAgc3RhdGljIFJlZjxTaGFyZWRCdWZmZXI+IGNyZWF0 ZSh1bnNpZ25lZCBzaXplKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IFNoYXJlZEJ1ZmZlcihzaXpl KSk7IH0KICAgICBzdGF0aWMgUmVmPFNoYXJlZEJ1ZmZlcj4gY3JlYXRlKGNvbnN0IGNoYXIqIGMs IHVuc2lnbmVkIGkpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgU2hhcmVkQnVmZmVyKGMsIGkpKTsg fQogICAgIHN0YXRpYyBSZWY8U2hhcmVkQnVmZmVyPiBjcmVhdGUoY29uc3QgdW5zaWduZWQgY2hh ciogZGF0YSwgdW5zaWduZWQgc2l6ZSkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBTaGFyZWRCdWZm ZXIoZGF0YSwgc2l6ZSkpOyB9CiAKQEAgLTEyMyw3ICsxMjIsNiBAQCBwdWJsaWM6CiAKIHByaXZh dGU6CiAgICAgV0VCQ09SRV9FWFBPUlQgU2hhcmVkQnVmZmVyKCk7Ci0gICAgZXhwbGljaXQgU2hh cmVkQnVmZmVyKHVuc2lnbmVkKTsKICAgICBXRUJDT1JFX0VYUE9SVCBTaGFyZWRCdWZmZXIoY29u c3QgY2hhciosIHVuc2lnbmVkKTsKICAgICBXRUJDT1JFX0VYUE9SVCBTaGFyZWRCdWZmZXIoY29u c3QgdW5zaWduZWQgY2hhciosIHVuc2lnbmVkKTsKICAgICBleHBsaWNpdCBTaGFyZWRCdWZmZXIo TWFwcGVkRmlsZURhdGEmJik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFG cmVlVHlwZS5jcHAJKHJldmlzaW9uIDIxNTMyNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTM2MiwxNiArMzYyLDEzIEBAIFJlZlB0cjxTaGFyZWRCdWZmZXI+IEZvbnRQbGF0 Zm9ybURhdGE6Om8KICAgICBpZiAoRlRfTG9hZF9TZm50X1RhYmxlKGZyZWVUeXBlRmFjZSwgdGFn LCAwLCAwLCAmdGFibGVTaXplKSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKLSAgICBSZWZQ dHI8U2hhcmVkQnVmZmVyPiBidWZmZXIgPSBTaGFyZWRCdWZmZXI6OmNyZWF0ZSh0YWJsZVNpemUp OwotICAgIGlmIChidWZmZXItPnNpemUoKSAhPSB0YWJsZVNpemUpCi0gICAgICAgIHJldHVybiBu dWxscHRyOwotCisgICAgVmVjdG9yPGNoYXI+IGRhdGEodGFibGVTaXplKTsKICAgICBGVF9VTG9u ZyBleHBlY3RlZFRhYmxlU2l6ZSA9IHRhYmxlU2l6ZTsKLSAgICBGVF9FcnJvciBlcnJvciA9IEZU X0xvYWRfU2ZudF9UYWJsZShmcmVlVHlwZUZhY2UsIHRhZywgMCwgcmVpbnRlcnByZXRfY2FzdDxG VF9CeXRlKj4oY29uc3RfY2FzdDxjaGFyKj4oYnVmZmVyLT5kYXRhKCkpKSwgJnRhYmxlU2l6ZSk7 CisgICAgRlRfRXJyb3IgZXJyb3IgPSBGVF9Mb2FkX1NmbnRfVGFibGUoZnJlZVR5cGVGYWNlLCB0 YWcsIDAsIHJlaW50ZXJwcmV0X2Nhc3Q8RlRfQnl0ZSo+KGRhdGEuZGF0YSgpKSwgJnRhYmxlU2l6 ZSk7CiAgICAgaWYgKGVycm9yIHx8IHRhYmxlU2l6ZSAhPSBleHBlY3RlZFRhYmxlU2l6ZSkKICAg ICAgICAgcmV0dXJuIG51bGxwdHI7CiAKLSAgICByZXR1cm4gYnVmZmVyOworICAgIHJldHVybiBT aGFyZWRCdWZmZXI6OmNyZWF0ZShXVEZNb3ZlKGRhdGEpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQo= 307207 2017-04-15 17:01:09 -0700 2017-04-15 17:01:29 -0700 Patch bug-170828-20170415170108.patch text/plain 4813 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTM5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA0LTE1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVu dXNlZCBTaGFyZWRCdWZmZXIgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDgyOAorCisgICAgICAgIFJldmlld2VkIGJ5IEJyYWR5 IEVpZHNvbi4KKworICAgICAgICAqIHBsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmFwcGVuZCk6CisgICAgICAgICogcGxhdGZvcm0vU2hh cmVkQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmNyZWF0ZSk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0YUZyZWVU eXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6Om9wZW5UeXBlVGFi bGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250UGxhdGZvcm1EYXRhV2lu LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6Om9wZW5UeXBlVGFibGUp OgorCiAyMDE3LTA0LTE1ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjE1MzkzLgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCShyZXZpc2lvbiAyMTUzOTUpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02NiwxMiArNjYsNiBAQCBTaGFyZWRCdWZmZXI6OlNoYXJlZEJ1ZmZlcigpCiB7CiB9CiAKLVNo YXJlZEJ1ZmZlcjo6U2hhcmVkQnVmZmVyKHVuc2lnbmVkIHNpemUpCi0gICAgOiBtX3NpemUoc2l6 ZSkKLSAgICAsIG1fYnVmZmVyKGFkb3B0UmVmKCpuZXcgRGF0YUJ1ZmZlcikpCi17Ci19Ci0KIFNo YXJlZEJ1ZmZlcjo6U2hhcmVkQnVmZmVyKGNvbnN0IGNoYXIqIGRhdGEsIHVuc2lnbmVkIHNpemUp CiAgICAgOiBtX2J1ZmZlcihhZG9wdFJlZigqbmV3IERhdGFCdWZmZXIpKQogewpAQCAtMjMzLDYg KzIyNyw4IEBAIHZvaWQgU2hhcmVkQnVmZmVyOjphcHBlbmQoY29uc3QgY2hhciogZGEKIAogdm9p ZCBTaGFyZWRCdWZmZXI6OmFwcGVuZChWZWN0b3I8Y2hhcj4mJiBkYXRhKQogeworICAgIC8vIFRo aXMgdGFrZXMgaXRzIGFyZ3VtZW50IGFzIGEgcnZhbHVlIHJlZmVyZW5jZSBiZWNhdXNlIHdlIGlu dGVuZCB0byBoYXZlIGEgZnV0dXJlCisgICAgLy8gdmVyc2lvbiB0YWtlIG93bmVyc2hpcCBvZiB0 aGUgdmVjdG9yIHJhdGhlciB0aGFuIGNvcHlpbmcuCiAgICAgYXBwZW5kKGRhdGEuZGF0YSgpLCBk YXRhLnNpemUoKSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1 ZmZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZl ci5oCShyZXZpc2lvbiAyMTUzOTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRC dWZmZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTIsNyArNTIsNiBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBjbGFzcyBTaGFyZWRCdWZmZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxTaGFyZWRCdWZmZXI+ IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPFNoYXJlZEJ1ZmZlcj4gY3JlYXRlKCkgeyByZXR1 cm4gYWRvcHRSZWYoKm5ldyBTaGFyZWRCdWZmZXIpOyB9Ci0gICAgc3RhdGljIFJlZjxTaGFyZWRC dWZmZXI+IGNyZWF0ZSh1bnNpZ25lZCBzaXplKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IFNoYXJl ZEJ1ZmZlcihzaXplKSk7IH0KICAgICBzdGF0aWMgUmVmPFNoYXJlZEJ1ZmZlcj4gY3JlYXRlKGNv bnN0IGNoYXIqIGMsIHVuc2lnbmVkIGkpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgU2hhcmVkQnVm ZmVyKGMsIGkpKTsgfQogICAgIHN0YXRpYyBSZWY8U2hhcmVkQnVmZmVyPiBjcmVhdGUoY29uc3Qg dW5zaWduZWQgY2hhciogZGF0YSwgdW5zaWduZWQgc2l6ZSkgeyByZXR1cm4gYWRvcHRSZWYoKm5l dyBTaGFyZWRCdWZmZXIoZGF0YSwgc2l6ZSkpOyB9CiAKQEAgLTEyMyw3ICsxMjIsNiBAQCBwdWJs aWM6CiAKIHByaXZhdGU6CiAgICAgV0VCQ09SRV9FWFBPUlQgU2hhcmVkQnVmZmVyKCk7Ci0gICAg ZXhwbGljaXQgU2hhcmVkQnVmZmVyKHVuc2lnbmVkKTsKICAgICBXRUJDT1JFX0VYUE9SVCBTaGFy ZWRCdWZmZXIoY29uc3QgY2hhciosIHVuc2lnbmVkKTsKICAgICBXRUJDT1JFX0VYUE9SVCBTaGFy ZWRCdWZmZXIoY29uc3QgdW5zaWduZWQgY2hhciosIHVuc2lnbmVkKTsKICAgICBleHBsaWNpdCBT aGFyZWRCdWZmZXIoTWFwcGVkRmlsZURhdGEmJik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQ bGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAJKHJldmlzaW9uIDIxNTM5NSkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM2MiwxNiArMzYyLDEzIEBAIFJlZlB0cjxTaGFyZWRCdWZm ZXI+IEZvbnRQbGF0Zm9ybURhdGE6Om8KICAgICBpZiAoRlRfTG9hZF9TZm50X1RhYmxlKGZyZWVU eXBlRmFjZSwgdGFnLCAwLCAwLCAmdGFibGVTaXplKSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7 CiAKLSAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBidWZmZXIgPSBTaGFyZWRCdWZmZXI6OmNyZWF0 ZSh0YWJsZVNpemUpOwotICAgIGlmIChidWZmZXItPnNpemUoKSAhPSB0YWJsZVNpemUpCi0gICAg ICAgIHJldHVybiBudWxscHRyOwotCisgICAgVmVjdG9yPGNoYXI+IGRhdGEodGFibGVTaXplKTsK ICAgICBGVF9VTG9uZyBleHBlY3RlZFRhYmxlU2l6ZSA9IHRhYmxlU2l6ZTsKLSAgICBGVF9FcnJv ciBlcnJvciA9IEZUX0xvYWRfU2ZudF9UYWJsZShmcmVlVHlwZUZhY2UsIHRhZywgMCwgcmVpbnRl cnByZXRfY2FzdDxGVF9CeXRlKj4oY29uc3RfY2FzdDxjaGFyKj4oYnVmZmVyLT5kYXRhKCkpKSwg JnRhYmxlU2l6ZSk7CisgICAgRlRfRXJyb3IgZXJyb3IgPSBGVF9Mb2FkX1NmbnRfVGFibGUoZnJl ZVR5cGVGYWNlLCB0YWcsIDAsIHJlaW50ZXJwcmV0X2Nhc3Q8RlRfQnl0ZSo+KGRhdGEuZGF0YSgp KSwgJnRhYmxlU2l6ZSk7CiAgICAgaWYgKGVycm9yIHx8IHRhYmxlU2l6ZSAhPSBleHBlY3RlZFRh YmxlU2l6ZSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKLSAgICByZXR1cm4gYnVmZmVyOwor ICAgIHJldHVybiBTaGFyZWRCdWZmZXI6OmNyZWF0ZShXVEZNb3ZlKGRhdGEpKTsKIH0KIAogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvd2luL0ZvbnRQbGF0Zm9ybURhdGFXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250UGxhdGZvcm1EYXRhV2luLmNwcAkocmV2aXNp b24gMjE1Mzk1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRQ bGF0Zm9ybURhdGFXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCwxMyArNzgsMTQgQEAgUmVm UHRyPFNoYXJlZEJ1ZmZlcj4gRm9udFBsYXRmb3JtRGF0YTo6bwogICAgIERXT1JEIHNpemUgPSBH ZXRGb250RGF0YShoZGMsIHRhYmxlLCAwLCAwLCAwKTsKICAgICBSZWZQdHI8U2hhcmVkQnVmZmVy PiBidWZmZXI7CiAgICAgaWYgKHNpemUgIT0gR0RJX0VSUk9SKSB7Ci0gICAgICAgIGJ1ZmZlciA9 IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKHNpemUpOwotICAgICAgICBEV09SRCByZXN1bHQgPSBHZXRG b250RGF0YShoZGMsIHRhYmxlLCAwLCAoUFZPSUQpYnVmZmVyLT5kYXRhKCksIHNpemUpOworICAg ICAgICBWZWN0b3I8Y2hhcj4gZGF0YShzaXplKTsKKyAgICAgICAgRFdPUkQgcmVzdWx0ID0gR2V0 Rm9udERhdGEoaGRjLCB0YWJsZSwgMCwgKFBWT0lEKWRhdGEtPmRhdGEoKSwgc2l6ZSk7CiAgICAg ICAgIEFTU0VSVChyZXN1bHQgPT0gc2l6ZSk7CisgICAgICAgIGJ1ZmZlciA9IFNoYXJlZEJ1ZmZl cjo6Y3JlYXRlKFdURk1vdmUoZGF0YSkpOwogICAgIH0KIAogICAgIFNlbGVjdE9iamVjdChoZGMs IG9sZEZvbnQpOwotICAgIHJldHVybiBidWZmZXIucmVsZWFzZSgpOworICAgIHJldHVybiBidWZm ZXI7CiB9CiAKICNpZm5kZWYgTkRFQlVHCg==