170765 2017-04-12 01:07:05 -0700 Assertion failed under WebCore::ApplyStyleCommand::applyBlockStyle. 2022-12-09 05:53:10 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan ahmad.saleem792 bfulgham ddkilzer mjs rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1296672 0 pvollan 2017-04-12 01:07:05 -0700 I have not been able to reproduce this myself, but in some cases an assertion fails under WebCore::ApplyStyleCommand::applyBlockStyle: 0 com.apple.JavaScriptCore 0x000000010bfdaf64 WTFCrash + 36 1 com.apple.WebCore 0x0000000111e9408f WebCore::ApplyStyleCommand::applyBlockStyle(WebCore::EditingStyle*) + 1535 2 com.apple.WebCore 0x0000000111e93a5d WebCore::ApplyStyleCommand::doApply() + 349 3 com.apple.WebCore 0x000000011210468a WebCore::CompositeEditCommand::apply() + 314 4 com.apple.WebCore 0x0000000112104521 WebCore::applyCommand(WTF::PassRefPtr<WebCore::CompositeEditCommand>) + 17 5 com.apple.WebCore 0x0000000112642639 WebCore::Editor::applyParagraphStyle(WebCore::StyleProperties*, WebCore::EditAction) + 521 6 com.apple.WebCore 0x0000000112660349 WebCore::executeApplyParagraphStyle(WebCore::Frame&, WebCore::EditorCommandSource, WebCore::EditAction, WebCore::CSSPropertyID, WTF::String const&) + 233 7 com.apple.WebCore 0x000000011265b5e2 WebCore::executeJustifyCenter(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) + 98 8 com.apple.WebCore 0x000000011265af33 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const + 211 9 com.apple.WebCore 0x00000001124f2d69 WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) + 89 10 com.apple.WebCore 0x000000011307a124 WebCore::jsDocumentPrototypeFunctionExecCommandCaller(JSC::ExecState*, WebCore::JSDocument*, JSC::ThrowScope&) + 660 11 com.apple.WebCore 0x00000001130646f2 long long WebCore::BindingCaller<WebCore::JSDocument>::callOperation<&(WebCore::jsDocumentPrototypeFunctionExecCommandCaller(JSC::ExecState*, WebCore::JSDocument*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState*, char const*) + 658 12 com.apple.WebCore 0x0000000113064448 WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::ExecState*) + 40 13 ??? 0x0000200287201028 0 + 35195229048872 14 com.apple.JavaScriptCore 0x000000010b91f41f llint_entry + 29979 1296674 1 pvollan 2017-04-12 01:17:26 -0700 rdar://problem/31441955 1296683 2 306896 pvollan 2017-04-12 01:36:58 -0700 Created attachment 306896 Patch 1296728 3 306896 wenson_hsieh 2017-04-12 07:54:41 -0700 Comment on attachment 306896 Patch Occasionally, we use ASSERTS to detect early on when we get into an inconsistent or unexpected state, even though in release, we are able to handle the inconsistency gracefully (in this case, with an is<> check). So even though some error cases are handled gracefully by release builds, there may still be value in keeping an ASSERT for debug builds. However, I'm not certain this is the case here. 1298247 4 pvollan 2017-04-18 04:16:48 -0700 rdar://problem/30297145 1657696 5 306896 mjs 2020-05-30 19:21:58 -0700 Comment on attachment 306896 Patch Not sure if this is a good change or not, but in any case the patch no longer applies as-is. 1916290 6 ahmad.saleem792 2022-12-02 12:06:52 -0800 Blink updated it here - https://src.chromium.org/viewvc/blink?view=revision&revision=177283 https://github.com/WebKit/WebKit/blob/85f4c97a6e063901a359c620aa1007c7c3ebd7ea/Source/WebCore/editing/ApplyStyleCommand.cpp#L269 1917895 7 ews-feeder 2022-12-09 02:02:18 -0800 Committed 257617@main (eb072c37fe4e): <https://commits.webkit.org/257617@main> Reviewed commits have been landed. Closing PR #7342 and removing active labels. 1917921 8 webkit-bug-importer 2022-12-09 05:53:10 -0800 <rdar://problem/103178512> 306896 2017-04-12 01:36:58 -0700 2020-05-30 19:21:58 -0700 Patch bug-170765-20170412013656.patch text/plain 1517 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTI2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA0LTEyICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnRpb24gZmFpbGVk IHVuZGVyIFdlYkNvcmU6OkFwcGx5U3R5bGVDb21tYW5kOjphcHBseUJsb2NrU3R5bGUuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA3NjUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGhhdmUgbm90IGJl ZW4gYWJsZSB0byByZXByb2R1Y2UgdGhpcywgYnV0IGluIHNvbWUgY2FzZXMgYW4gYXNzZXJ0aW9u IGZhaWxzIHVuZGVyIEFwcGx5U3R5bGVDb21tYW5kOjphcHBseUJsb2NrU3R5bGUuCisgICAgICAg IFNpbmNlIHRoaXMgaXMgaGFuZGxlZCBwcm9wZXJseSBpbiB0aGUgY29kZSBmb2xsb3dpbmcgdGhl IGFzc2VydCwgSSBiZWxpZXZlIGl0IGNhbiBiZSByZW1vdmVkLgorCisgICAgICAgIENvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBlZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5k LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGx5U3R5bGVDb21tYW5kOjphcHBseUJsb2NrU3R5 bGUpOgorCiAyMDE3LTA0LTEyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4K IAogICAgICAgICBJbXBsZW1lbnQgc3Ryb2tlLWNvbG9yIENTUyBwcm9wZXJ0eS4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCShyZXZpc2lvbiAy MTUyNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjY5LDcgKzI2OSw2IEBAIHZvaWQgQXBwbHlTdHlsZUNvbW1hbmQ6 OmFwcGx5QmxvY2tTdHlsZSgKICAgICAgICAgICAgICAgICBpZiAobmV3QmxvY2spCiAgICAgICAg ICAgICAgICAgICAgIGJsb2NrID0gbmV3QmxvY2s7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAg ICBBU1NFUlQoIWJsb2NrIHx8IGlzPEhUTUxFbGVtZW50PigqYmxvY2spKTsKICAgICAgICAgICAg IGlmIChpczxIVE1MRWxlbWVudD4oYmxvY2suZ2V0KCkpKSB7CiAgICAgICAgICAgICAgICAgcmVt b3ZlQ1NTU3R5bGUoc3R5bGUsIGRvd25jYXN0PEhUTUxFbGVtZW50PihibG9jay5nZXQoKSkpOwog ICAgICAgICAgICAgICAgIGlmICghbV9yZW1vdmVPbmx5KQo=