170744 2017-04-11 12:34:35 -0700 Consider the current document when allowing autoplay quirks 2017-04-12 11:29:36 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrajca mrajca eric.carlson oldest_to_newest 1296522 0 mrajca 2017-04-11 12:34:35 -0700 In addition to checking if the top-level document supports autoplay quirks, we should check if the current document supports quirks. This allows all embedded YouTube videos (which use iframes) to play correctly if the client allows autoplay quirks on youtube.com. 1296523 1 306841 mrajca 2017-04-11 12:37:25 -0700 Created attachment 306841 Patch 1296529 2 306841 eric.carlson 2017-04-11 13:14:44 -0700 Comment on attachment 306841 Patch As discussed in person, this should have a test. 1296536 3 mrajca 2017-04-11 13:38:15 -0700 (In reply to Eric Carlson from comment #2) > Comment on attachment 306841 [details] > Patch > > As discussed in person, this should have a test. I added an API test. 1296537 4 mrajca 2017-04-11 13:40:36 -0700 https://trac.webkit.org/changeset/215249/webkit 306841 2017-04-11 12:37:25 -0700 2017-04-12 11:29:36 -0700 Patch bug-170744-20170411123725.patch text/plain 1761 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVmMTRiZTM1YmE1MDdk ZWRlNTBmYTUzMmQxNDgwY2Y0YmQyYmJhMy4uZDUxYzNmY2MwMmUwOTJhZGIzZjk0YWYwZmQ2ZDI0 YTBiYzEzNzNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTExICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBDb25zaWRlciB0aGUgY3VycmVu dCBkb2N1bWVudCB3aGVuIGFsbG93aW5nIGF1dG9wbGF5IHF1aXJrcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDc0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGFkZGl0aW9uIHRvIGNoZWNraW5n IGlmIHRoZSB0b3AtbGV2ZWwgZG9jdW1lbnQgc3VwcG9ydHMgYXV0b3BsYXkgcXVpcmtzLCB3ZSBz aG91bGQgY2hlY2sKKyAgICAgICAgaWYgdGhlIGN1cnJlbnQgZG9jdW1lbnQgc3VwcG9ydHMgcXVp cmtzLiBUaGlzIGFsbG93cyBhbGwgZW1iZWRkZWQgWW91VHViZSB2aWRlb3MgKHdoaWNoIHVzZQor ICAgICAgICBpZnJhbWVzKSB0byBwbGF5IGNvcnJlY3RseSBpZiB0aGUgY2xpZW50IGFsbG93cyBh dXRvcGxheSBxdWlya3Mgb24geW91dHViZS5jb20uCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZGlzcGF0 Y2hQbGF5UGF1c2VFdmVudHNJZk5lZWRzUXVpcmtzKToKKwogMjAxNy0wMy0yMiAgTWF0dCBSYWpj YSAgPG1yYWpjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQ29uc2lkZXIgbXV0aW5nIGF1ZGlvIGhh cmR3YXJlIGEgZm9ybSBvZiBhdXRvcGxheSBpbnRlcmZlcmVuY2UuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCBhZDQ0YTk0M2VmMWEwYzY5N2NlMmYyYzRmMjQx YWEyZGIyM2JhMmU2Li4wODc3OTUyODM4ZDBkOGE3MGZmMDFkY2Y3MmVjZGEyZmU1ZjMzMjkzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTIzMjgsNyArMjMy OCw4IEBAIFN1Y2Nlc3NPcjxNZWRpYVBsYXliYWNrRGVuaWFsUmVhc29uPiBIVE1MTWVkaWFFbGVt ZW50OjpjYW5UcmFuc2l0aW9uRnJvbUF1dG9wbGF5CiAKIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6 ZGlzcGF0Y2hQbGF5UGF1c2VFdmVudHNJZk5lZWRzUXVpcmtzKCkKIHsKLSAgICBpZiAoIW5lZWRz QXV0b3BsYXlQbGF5UGF1c2VFdmVudHNRdWlyayhkb2N1bWVudCgpLnRvcERvY3VtZW50KCkpKQor ICAgIGF1dG8mIGRvY3VtZW50ID0gdGhpcy0+ZG9jdW1lbnQoKTsKKyAgICBpZiAoIW5lZWRzQXV0 b3BsYXlQbGF5UGF1c2VFdmVudHNRdWlyayhkb2N1bWVudCkgJiYgIW5lZWRzQXV0b3BsYXlQbGF5 UGF1c2VFdmVudHNRdWlyayhkb2N1bWVudC50b3BEb2N1bWVudCgpKSkKICAgICAgICAgcmV0dXJu OwogCiAgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVzKCkucGxheWluZ0V2ZW50KTsK