170731 2017-04-11 08:38:43 -0700 WebKitTestRunner/DumpRenderTree prevent device from sleeping 2017-04-28 13:51:01 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard achristensen cdumez commit-queue lforschler webkit-bug-importer oldest_to_newest 1296406 0 jbedard 2017-04-11 08:38:43 -0700 Prevent the device from sleeping while running tests. 1296407 1 webkit-bug-importer 2017-04-11 08:39:27 -0700 <rdar://problem/31556961> 1296408 2 306820 jbedard 2017-04-11 08:43:10 -0700 Created attachment 306820 Patch 1296409 3 306820 jbedard 2017-04-11 08:44:37 -0700 Comment on attachment 306820 Patch Removing review flag while I confirm that the toggle is actually needed. 1296461 4 306829 jbedard 2017-04-11 10:12:46 -0700 Created attachment 306829 Patch 1296462 5 jbedard 2017-04-11 10:13:55 -0700 We can set this when beginning the test suite. That seems to be the correct way of doing this. 1296680 6 306829 achristensen 2017-04-12 01:36:15 -0700 Comment on attachment 306829 Patch Do we need to unset this? 1296731 7 jbedard 2017-04-12 08:11:44 -0700 (In reply to Alex Christensen from comment #6) > Comment on attachment 306829 [details] > Patch > > Do we need to unset this? No, it only persists for the lifetime of the testing app, which we kill when testing is finished. 1302759 8 306829 achristensen 2017-04-28 13:40:21 -0700 Comment on attachment 306829 Patch r=me Maybe we could just put the setting of idleTimerDisabled into setUpIOSLayoutTestCommunication to reduce duplication, and maybe we could rename that function. Maybe not. 1302764 9 jbedard 2017-04-28 13:44:11 -0700 (In reply to Alex Christensen from comment #8) > Comment on attachment 306829 [details] > Patch > > r=me > Maybe we could just put the setting of idleTimerDisabled into > setUpIOSLayoutTestCommunication to reduce duplication, and maybe we could > rename that function. Maybe not. That function is specifically designed for setting up the communication, it's used for nothing else. I think duplication is better in this case, if we find we need to do more shared IOS setup between DumpRenderTree and WebKitTestRunnerApp in the future, I will investigate more code sharing. 1302769 10 306829 commit-queue 2017-04-28 13:51:00 -0700 Comment on attachment 306829 Patch Clearing flags on attachment: 306829 Committed r215942: <http://trac.webkit.org/changeset/215942> 1302770 11 commit-queue 2017-04-28 13:51:01 -0700 All reviewed patches have been landed. Closing bug. 306820 2017-04-11 08:43:10 -0700 2017-04-11 10:12:45 -0700 Patch bug-170731-20170411084309.patch text/plain 2253 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTIyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE3LTA0LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyL0R1bXBSZW5kZXJUcmVlIHByZXZlbnQgZGV2 aWNlIGZyb20gc2xlZXBpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MDczMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFR1cm5pbmcgdGhlIGlkbGUgdGltZXIgZmxhZyBvZmYgdGhlbiBvbiBndWFyYW50 ZWVzIHRoZSB0aW1lciB3aWxsIGJlIHJlc2V0LgorICAgICAgICBEbyB0aGlzIGJldHdlZW4gZXZl ciB0ZXN0LiBUZXN0cyBzaG91bGQgbm90IGxhc3QgbG9uZ2VyIHRoYW4gdGhlIGRldmljZSdzIGlk bGUKKyAgICAgICAgdGltZXIuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJl bmRlclRyZWUubW06CisgICAgICAgIChydW5UZXN0aW5nU2VydmVyTG9vcCk6IFRvZ2dsZSBpZGxl IHRpbWVyIG9uIGlPUy4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rlc3RDb250 cm9sbGVyQ29jb2EubW06CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybVdp bGxSdW5UZXN0KTogRGl0dG8uCisKIDIwMTctMDQtMTAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgcjIxNTIxNwpJbmRleDogVG9v bHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQkocmV2aXNpb24gMjE1MjI5 KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0xMTcyLDYgKzExNzIsMTEgQEAgc3RhdGljIHZvaWQgcnVuVGVzdGluZ1NlcnZl ckxvb3AoKQogICAgICAgICBpZiAoc3RybGVuKGZpbGVuYW1lQnVmZmVyKSA9PSAwKQogICAgICAg ICAgICAgY29udGludWU7CiAKKyNpZiBQTEFURk9STShJT1MpCisgICAgICAgIFtVSUFwcGxpY2F0 aW9uIHNoYXJlZEFwcGxpY2F0aW9uXS5pZGxlVGltZXJEaXNhYmxlZCA9IE5POworICAgICAgICBb VUlBcHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl0uaWRsZVRpbWVyRGlzYWJsZWQgPSBZRVM7 CisjZW5kaWYKKyAgICAgICAgCiAgICAgICAgIHJ1blRlc3QoZmlsZW5hbWVCdWZmZXIpOwogCiAg ICAgICAgIGlmIChwcmludFRlc3RDb3VudCkgewpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9jb2NvYS9UZXN0Q29udHJvbGxlckNvY29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktp dFRlc3RSdW5uZXIvY29jb2EvVGVzdENvbnRyb2xsZXJDb2NvYS5tbQkocmV2aXNpb24gMjE1MjI5 KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9UZXN0Q29udHJvbGxlckNvY29hLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0xNTksNiArMTU5LDExIEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6 OmNvY29hUmVzZXRTdGF0ZVRvQ28KIHZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtV2lsbFJ1 blRlc3QoY29uc3QgVGVzdEludm9jYXRpb24mIHRlc3RJbnZvY2F0aW9uKQogewogICAgIHNldENy YXNoUmVwb3J0QXBwbGljYXRpb25TcGVjaWZpY0luZm9ybWF0aW9uVG9VUkwodGVzdEludm9jYXRp b24udXJsKCkpOworCisjaWYgUExBVEZPUk0oSU9TKQorICAgIFtVSUFwcGxpY2F0aW9uIHNoYXJl ZEFwcGxpY2F0aW9uXS5pZGxlVGltZXJEaXNhYmxlZCA9IE5POworICAgIFtVSUFwcGxpY2F0aW9u IHNoYXJlZEFwcGxpY2F0aW9uXS5pZGxlVGltZXJEaXNhYmxlZCA9IFlFUzsKKyNlbmRpZgogfQog CiBzdGF0aWMgTlNTdHJpbmcgKiBjb25zdCBXZWJBcmNoaXZlUGJvYXJkVHlwZSA9IEAiQXBwbGUg V2ViIEFyY2hpdmUgcGFzdGVib2FyZCB0eXBlIjsK 306829 2017-04-11 10:12:46 -0700 2017-04-28 13:51:00 -0700 Patch bug-170731-20170411101245.patch text/plain 1788 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTIzNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTA0LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyL0R1bXBSZW5kZXJUcmVlIHByZXZlbnQgZGV2 aWNlIGZyb20gc2xlZXBpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MDczMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdoaWxlIHJ1bm5pbmcgbGF5b3V0IHRlc3RzIG9uIGEgZGV2aWNlLCB0aGUgZGV2 aWNlIHNob3VsZCBub3QgYmUgcHV0IGFzbGVlcC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L21hYy9EdW1wUmVuZGVyVHJlZS5tbToKKyAgICAgICAgKGR1bXBSZW5kZXJUcmVlKTogRGlzYWJs ZSBpZGxlIHRpbWVyLgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvaW9zL1Rlc3RDb250cm9s bGVySU9TLm1tOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFs aXplKTogRGl0dG8uCisKIDIwMTctMDQtMTAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgcjIxNTIxNwpJbmRleDogVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1 bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQkocmV2aXNpb24gMjE1MjI5KQorKysg VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xMjM4LDYgKzEyMzgsNyBAQCB2b2lkIGR1bXBSZW5kZXJUcmVlKGludCBhcmdjLCBjb25z dCBjaGFyCiB7CiAjaWYgUExBVEZPUk0oSU9TKQogICAgIHNldFVwSU9TTGF5b3V0VGVzdENvbW11 bmljYXRpb24oKTsKKyAgICBbVUlBcHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl0uaWRsZVRp bWVyRGlzYWJsZWQgPSBZRVM7CiAjZW5kaWYKIAogICAgIHNpZ25hbChTSUdJTEwsICZ3cml0ZUNy YXNoZWRNZXNzYWdlT25GYXRhbEVycm9yKTsKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv aW9zL1Rlc3RDb250cm9sbGVySU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tCShyZXZpc2lvbiAyMTUyMjkpCisrKyBUb29s cy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0Q29udHJvbGxlcklPUy5tbQkod29ya2luZyBjb3B5 KQpAQCAtNTEsNiArNTEsNyBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpub3RpZnlEb25lKCkKIHZv aWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCiB7CiAgICAgc2V0VXBJT1NM YXlvdXRUZXN0Q29tbXVuaWNhdGlvbigpOworICAgIFtVSUFwcGxpY2F0aW9uIHNoYXJlZEFwcGxp Y2F0aW9uXS5pZGxlVGltZXJEaXNhYmxlZCA9IFlFUzsKIH0KIAogdm9pZCBUZXN0Q29udHJvbGxl cjo6cGxhdGZvcm1EZXN0cm95KCkK