170727 2017-04-11 05:44:42 -0700 REGRESSION(r215211): [GTK] Lots of image related tests are timing out, causing the test bot to exit early 2017-04-11 08:24:39 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170530 https://bugs.webkit.org/show_bug.cgi?id=170721 https://bugs.webkit.org/show_bug.cgi?id=170730 P2 Normal --- 1 magomez magomez bugs-noreply cgarcia sabouhallawa thorton oldest_to_newest 1296363 0 magomez 2017-04-11 05:44:42 -0700 r215211 changed ImageDecoder::isSizeAvailable() to call encodedDataStatus() in the subclasses, which forces a partial decoding of the image to get the size from the file. But ImageDecoder::isSizeAvailable() is also being called inside the decoders in some places. One of this places is the setSize() method inside each decoder. So a call to isSizeAvailable() when the image size is not known causes the image to be partially decoded to get the size, but as a result setSize() gets called, which calls isSizeAvailable() again, which triggers a new decoder because the size has not been set, and we have another infinte loop. 1296370 1 306808 magomez 2017-04-11 06:12:50 -0700 Created attachment 306808 Patch 1296371 2 306808 cgarcia 2017-04-11 06:16:10 -0700 Comment on attachment 306808 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306808&action=review > Source/WebCore/ChangeLog:3 > + REGRESSION(r215211): [GTK] Lots of image related tests are timign out, causing the test bot to exit early Fix the typo. timign -> timing 1296372 3 magomez 2017-04-11 06:19:27 -0700 Committed r215227: <http://trac.webkit.org/changeset/215227> 306808 2017-04-11 06:12:50 -0700 2017-04-11 06:15:05 -0700 Patch bug-170727-20170411151248.patch text/plain 7295 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNkNThmOGM1OTdmZWQw ZTQzYmE0NmFkYjM3MTVkYTUwNmU5ODM5Ny4uZDcwNDE2NGJmZDY5ZDJlNmNiYmIyMDJiM2JjM2Vj MzIxZjE3ZmZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM2IEBACiAyMDE3LTA0LTExICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTihyMjE1 MjExKTogW0dUS10gTG90cyBvZiBpbWFnZSByZWxhdGVkIHRlc3RzIGFyZSB0aW1pZ24gb3V0LCBj YXVzaW5nIHRoZSB0ZXN0IGJvdCB0byBleGl0IGVhcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA3MjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSByMjE1MjExIEltYWdlRGVjb2Rlcjo6aXNT aXplQXZhaWxhYmxlKCkgY2FsbHMgZW5jb2RlZERhdGFTdGF0dXMoKSBpbiB0aGUgZGlmZmVyZW50 IGRlY29kZXIgaW1wbGVtZW50YXRpb25zLAorICAgICAgICBhbmQgdGhvc2UgaW1wbGVtZW50YXRp b25zIGZvcmNlIGEgcGFydGlhbCBkZWNvZGluZyBvZiB0aGUgaW1hZ2UgaWYgdGhlIHNpemUgaXMg bm90IGF2YWlsYWJsZSB5ZXQuIEJ1dAorICAgICAgICBJbWFnZURlY29kZXI6OmlzU2l6ZUF2YWls YWJsZSgpIHdhcyBhbHJlYWR5IGJlaW5nIHVzZWQgaW5zaWRlIHRoZSBkZWNvZGVycyBhc3N1bWlu ZyB0aGF0IGl0IHdhc24ndCBnb2luZyB0bworICAgICAgICBmb3JjZSB0aGlzIHBhcnRpYWwgZGVj b2RpbmcuIER1ZSB0byB0aGlzLCB0aGVyZSBhcmUgc29tZSBzaXR1YXRpb25zIHdoZXJlIHRoZSBw YXJ0aWFsIGRlY29kaW5nIGlzIG5vdAorICAgICAgICBkZXNpcmVkIGJ1dCBpdCdzIGhhcHBlbmlu ZyBhbnl3YXkuIEZvciBleGFtcGxlLCB0aGUgY2hlY2sgaW4gc2V0U2l6ZSgpLCB3aGljaCBjYXVz ZXMgdGhlIHBhcnRpYWwgZGVjb2RpbmcKKyAgICAgICAgdG8gaGFwcGVuIGFnYWluIGFuZCBhZ2Fp biBiZWNhdXNlIG5vIHZhbHVlIGlzIGFjdHVhbGx5IHNldCB0byB0aGUgYW5pbWF0aW9uIHNpemUg KHdoaWNoIGNhdXNlcyB0aGUgdGltb3V0cworICAgICAgICBpbiB0aGUgdGVzdCBib3QpLgorCisg ICAgICAgIFRvIGF2b2lkIHRoaXMsIHJlcGxhY2UgYWxsIHRoZSBjYWxscyB0byBJbWFnZURlY29k ZXI6OmlzU2l6ZUF2YWlsYWJsZSgpIGluc2lkZSB0aGUgZGVjb2RlcnMgd2l0aCBjYWxscyB0bwor ICAgICAgICBJbWFnZURlY29kZXI6OmVuY29kZWREYXRhU3RhdHVzKCksIHdoaWNoIGRvZXNuJ3Qg Zm9yY2UgdGhlIHBhcnRpYWwgZGVjb2RpbmcuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGVu dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFn ZURlY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R0lGSW1hZ2VEZWNvZGVyOjpzZXRTaXpl KToKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9pY28vSUNPSW1hZ2VEZWNvZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklDT0ltYWdlRGVjb2Rlcjo6ZGVjb2RlQXRJbmRleCk6 CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVy Lmg6CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcG5nL1BOR0ltYWdlRGVjb2Rl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQTkdJbWFnZVJlYWRlcjo6ZGVjb2RlKToKKyAgICAg ICAgKFdlYkNvcmU6OlBOR0ltYWdlRGVjb2Rlcjo6ZnJhbWVCdWZmZXJBdEluZGV4KToKKyAgICAg ICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJbWFnZURlY29kZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6V0VCUEltYWdlRGVjb2Rlcjo6ZGVjb2RlKToKKworMjAxNy0wNC0x MSAgTWlndWVsIEdvbWV6ICA8bWFnb21lekBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJFR1JFU1NJ T04ocjIxNTIxMSk6IFtHVEtdIExvdHMgb2YgaW1hZ2UgcmVsYXRlZCB0ZXN0cyBhcmUgY3Jhc2hp bmcsIGNhdXNpbmcgdGhlIHRlc3QgYm90IHRvIGV4aXQgZWFybHkKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDcyMQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VEZWNvZGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURl Y29kZXIuY3BwCmluZGV4IGE5MTVjYzE5N2FhZGM3MDJmNzFlZDI4OTc4ZGE1MzJmMjViMTc2OGUu LjQzYzI1ZTRlYzc4Yzg2YTY3NTQwZmY1NjM0N2I2ZjMyMTM1OGNiYWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJ bWFnZURlY29kZXIuY3BwCkBAIC02MCw3ICs2MCw3IEBAIEVuY29kZWREYXRhU3RhdHVzIEdJRklt YWdlRGVjb2Rlcjo6ZW5jb2RlZERhdGFTdGF0dXMoKQogCiBib29sIEdJRkltYWdlRGVjb2Rlcjo6 c2V0U2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQogewotICAgIGlmIChJbWFnZURlY29kZXI6Omlz U2l6ZUF2YWlsYWJsZSgpICYmIHRoaXMtPnNpemUoKSA9PSBzaXplKQorICAgIGlmIChJbWFnZURl Y29kZXI6OmVuY29kZWREYXRhU3RhdHVzKCkgPj0gRW5jb2RlZERhdGFTdGF0dXM6OlNpemVBdmFp bGFibGUgJiYgdGhpcy0+c2l6ZSgpID09IHNpemUpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAg ICAgaWYgKCFJbWFnZURlY29kZXI6OnNldFNpemUoc2l6ZSkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9pY28vSUNPSW1hZ2VEZWNvZGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2ljby9JQ09JbWFnZURlY29k ZXIuY3BwCmluZGV4IDk4MGU5MDU4OTE3OTI2OTI0MGMwZGQ4NGM0MDM2ZGNiZDcyZjYwMDkuLmNk OGRkNGI4MzUzYjJiN2ZiNDkxMTYzZjQyYWEyYmRlZTU1MzM1NjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2ljby9JQ09JbWFnZURlY29kZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2ljby9JQ09JbWFn ZURlY29kZXIuY3BwCkBAIC0yMjMsNyArMjIzLDcgQEAgYm9vbCBJQ09JbWFnZURlY29kZXI6OmRl Y29kZUF0SW5kZXgoc2l6ZV90IGluZGV4KQogICAgIH0KICAgICAvLyBGYWlsIGlmIHRoZSBzaXpl IHRoZSBQTkdJbWFnZURlY29kZXIgY2FsY3VsYXRlZCBkb2VzIG5vdCBtYXRjaCB0aGUgc2l6ZQog ICAgIC8vIGluIHRoZSBkaXJlY3RvcnkuCi0gICAgaWYgKG1fcG5nRGVjb2RlcnNbaW5kZXhdLT5p c1NpemVBdmFpbGFibGUoKSAmJiAobV9wbmdEZWNvZGVyc1tpbmRleF0tPnNpemUoKSAhPSBkaXJF bnRyeS5tX3NpemUpKQorICAgIGlmIChtX3BuZ0RlY29kZXJzW2luZGV4XS0+ZW5jb2RlZERhdGFT dGF0dXMoKSA+PSBFbmNvZGVkRGF0YVN0YXR1czo6U2l6ZUF2YWlsYWJsZSAmJiAobV9wbmdEZWNv ZGVyc1tpbmRleF0tPnNpemUoKSAhPSBkaXJFbnRyeS5tX3NpemUpKQogICAgICAgICByZXR1cm4g c2V0RmFpbGVkKCk7CiAgICAgbV9mcmFtZUJ1ZmZlckNhY2hlW2luZGV4XSA9ICptX3BuZ0RlY29k ZXJzW2luZGV4XS0+ZnJhbWVCdWZmZXJBdEluZGV4KDApOwogICAgIHJldHVybiAhbV9wbmdEZWNv ZGVyc1tpbmRleF0tPmZhaWxlZCgpIHx8IHNldEZhaWxlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURl Y29kZXIuaAppbmRleCA2NWQ1MGE0MDJjOWJkYmY2MmQ5ODY5N2ZiYjNlNTVjNzM1ZTZiZjM5Li4x YWViMzAwYjM4NTdjZTdmMjgxMDRiNTk0YTY3OTY5NjQ5NzhkZmI2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJ bWFnZURlY29kZXIuaApAQCAtNTgsNyArNTgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAg ICAgICAgYm9vbCB3aWxsRG93blNhbXBsZSgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIEFTU0VS VChJbWFnZURlY29kZXI6OmlzU2l6ZUF2YWlsYWJsZSgpKTsKKyAgICAgICAgICAgIEFTU0VSVChJ bWFnZURlY29kZXI6OmVuY29kZWREYXRhU3RhdHVzKCkgPj0gRW5jb2RlZERhdGFTdGF0dXM6OlNp emVBdmFpbGFibGUpOwogICAgICAgICAgICAgcmV0dXJuIG1fc2NhbGVkOwogICAgICAgICB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3BuZy9Q TkdJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2Rl cnMvcG5nL1BOR0ltYWdlRGVjb2Rlci5jcHAKaW5kZXggYjZlYTY1ZGVlZGRhNzA3MjAyYWU3Yzlk ZGRkMzE2NjAzNjJkZWI2Ni4uMzhmNGQ2Y2JjMDJmZTc1MzI3ZTFiMTYyNTI5MzQ5NjU3YTllZDM1 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcG5n L1BOR0ltYWdlRGVjb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvcG5nL1BOR0ltYWdlRGVjb2Rlci5jcHAKQEAgLTE2MiwxMCArMTYyLDEwIEBAIHB1 YmxpYzoKICAgICAgICAgICAgIG1fcmVhZE9mZnNldCArPSBzZWdtZW50TGVuZ3RoOwogICAgICAg ICAgICAgbV9jdXJyZW50QnVmZmVyU2l6ZSA9IG1fcmVhZE9mZnNldDsKICAgICAgICAgICAgIHBu Z19wcm9jZXNzX2RhdGEobV9wbmcsIG1faW5mbywgcmVpbnRlcnByZXRfY2FzdDxwbmdfYnl0ZXA+ KGNvbnN0X2Nhc3Q8Y2hhcio+KHNlZ21lbnQpKSwgc2VnbWVudExlbmd0aCk7Ci0gICAgICAgICAg ICAvLyBXZSBleHBsaWNpdGx5IHNwZWNpZnkgdGhlIHN1cGVyY2xhc3MgaXNTaXplQXZhaWxhYmxl KCkgYmVjYXVzZSB3ZQorICAgICAgICAgICAgLy8gV2UgZXhwbGljaXRseSBzcGVjaWZ5IHRoZSBz dXBlcmNsYXNzIGVuY29kZWREYXRhU3RhdHVzKCkgYmVjYXVzZSB3ZQogICAgICAgICAgICAgLy8g bWVyZWx5IHdhbnQgdG8gY2hlY2sgaWYgd2UndmUgbWFuYWdlZCB0byBzZXQgdGhlIHNpemUsIG5v dAogICAgICAgICAgICAgLy8gKHJlY3Vyc2l2ZWx5KSB0cmlnZ2VyIGFkZGl0aW9uYWwgZGVjb2Rp bmcgaWYgd2UgaGF2ZW4ndC4KLSAgICAgICAgICAgIGlmIChzaXplT25seSA/IGRlY29kZXItPklt YWdlRGVjb2Rlcjo6aXNTaXplQXZhaWxhYmxlKCkgOiBkZWNvZGVyLT5pc0NvbXBsZXRlQXRJbmRl eChoYWx0QXRGcmFtZSkpCisgICAgICAgICAgICBpZiAoc2l6ZU9ubHkgPyBkZWNvZGVyLT5JbWFn ZURlY29kZXI6OmVuY29kZWREYXRhU3RhdHVzKCkgPj0gRW5jb2RlZERhdGFTdGF0dXM6OlNpemVB dmFpbGFibGUgOiBkZWNvZGVyLT5pc0NvbXBsZXRlQXRJbmRleChoYWx0QXRGcmFtZSkpCiAgICAg ICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIGZhbHNl OwpAQCAtMjU5LDcgKzI1OSw3IEBAIGJvb2wgUE5HSW1hZ2VEZWNvZGVyOjpzZXRTaXplKGNvbnN0 IEludFNpemUmIHNpemUpCiBJbWFnZUZyYW1lKiBQTkdJbWFnZURlY29kZXI6OmZyYW1lQnVmZmVy QXRJbmRleChzaXplX3QgaW5kZXgpCiB7CiAjaWYgRU5BQkxFKEFQTkcpCi0gICAgaWYgKCFpc1Np emVBdmFpbGFibGUoKSkKKyAgICBpZiAoSW1hZ2VEZWNvZGVyOjplbmNvZGVkRGF0YVN0YXR1cygp IDwgRW5jb2RlZERhdGFTdGF0dXM6OlNpemVBdmFpbGFibGUpCiAgICAgICAgIHJldHVybiBudWxs cHRyOwogCiAgICAgaWYgKGluZGV4ID49IGZyYW1lQ291bnQoKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJbWFn ZURlY29kZXIuY3BwCmluZGV4IGQzNmQ5MzkyOTRjM2ZjOWY5YzdkN2JlODQzYTE4MjAzZjFiZDcx YTYuLmJmN2IwNzU5NTJhMzRlYTA4YmE3NWZhODgwZDk3Mjc4ZjE5YzcxMWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVj b2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2Vi cC9XRUJQSW1hZ2VEZWNvZGVyLmNwcApAQCAtOTQsNyArOTQsNyBAQCBib29sIFdFQlBJbWFnZURl Y29kZXI6OmRlY29kZShib29sIG9ubHlTaXplKQogICAgIGNvbnN0IHVpbnQ4X3QqIGRhdGFCeXRl cyA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KG1fZGF0YS0+ZGF0YSgpKTsKICAg ICBjb25zdCBzaXplX3QgZGF0YVNpemUgPSBtX2RhdGEtPnNpemUoKTsKIAotICAgIGlmICghSW1h Z2VEZWNvZGVyOjppc1NpemVBdmFpbGFibGUoKSkgeworICAgIGlmIChJbWFnZURlY29kZXI6OmVu Y29kZWREYXRhU3RhdHVzKCkgPCBFbmNvZGVkRGF0YVN0YXR1czo6U2l6ZUF2YWlsYWJsZSkgewog ICAgICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IGltYWdlSGVhZGVyU2l6ZSA9IDMwOwogICAgICAg ICBpZiAoZGF0YVNpemUgPCBpbWFnZUhlYWRlclNpemUpCiAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CkBAIC0xMTYsNyArMTE2LDcgQEAgYm9vbCBXRUJQSW1hZ2VEZWNvZGVyOjpkZWNvZGUoYm9v bCBvbmx5U2l6ZSkKICAgICAgICAgICAgIHJldHVybiBzZXRGYWlsZWQoKTsKICAgICB9CiAKLSAg ICBBU1NFUlQoSW1hZ2VEZWNvZGVyOjppc1NpemVBdmFpbGFibGUoKSk7CisgICAgQVNTRVJUKElt YWdlRGVjb2Rlcjo6ZW5jb2RlZERhdGFTdGF0dXMoKSA+PSBFbmNvZGVkRGF0YVN0YXR1czo6U2l6 ZUF2YWlsYWJsZSk7CiAgICAgaWYgKG9ubHlTaXplKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAo=