170721 2017-04-11 02:43:16 -0700 REGRESSION(r215211): [GTK] Lots of image related tests are crashing, causing the test bot to exit early 2017-04-11 09:21:54 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170530 https://bugs.webkit.org/show_bug.cgi?id=170727 https://bugs.webkit.org/show_bug.cgi?id=170730 P2 Normal --- 1 magomez magomez bugs-noreply cgarcia commit-queue sabouhallawa thorton oldest_to_newest 1296328 0 magomez 2017-04-11 02:43:16 -0700 There seems to be an infinite loop created by r215211. 1296332 1 306791 magomez 2017-04-11 02:49:16 -0700 Created attachment 306791 Patch 1296335 2 306791 commit-queue 2017-04-11 03:22:05 -0700 Comment on attachment 306791 Patch Clearing flags on attachment: 306791 Committed r215224: <http://trac.webkit.org/changeset/215224> 1296336 3 commit-queue 2017-04-11 03:22:07 -0700 All reviewed patches have been landed. Closing bug. 1296429 4 306791 sabouhallawa 2017-04-11 09:21:54 -0700 Comment on attachment 306791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306791&action=review > Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp:61 > + if (ImageDecoder::encodedDataStatus() < EncodedDataStatus::SizeAvailable) Alternately you could change the ImageDecoder::isSizeAvailable() in platform/image-decoders/ImageDecoder.h to force calling the base class function: << bool isSizeAvailable() { return encodedDataStatus() >= EncodedDataStatus::SizeAvailable; } >> bool isSizeAvailable() { return ImageDecoder::encodedDataStatus() >= EncodedDataStatus::SizeAvailable; } This should avoid making the same change in six different source files. And this is the correct behavior since isSizeAvailable() tells the status of the encoded data before doing any decoding. 306791 2017-04-11 02:49:16 -0700 2017-04-11 03:22:05 -0700 Patch bug-170721-20170411114915.patch text/plain 5913 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmExNDk0ZjBkYjU0ZTkx Y2ZjZTBkYjNmM2IwODhlZDkwNjY4M2QxOC4uMGMyMDAzZTYzYWMxZmQ0ZmNmN2U3NTUwYmU0ZGFk MGFhNGQ0MmQwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE3LTA0LTExICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjE1 MjExKTogW0dUS10gTG90cyBvZiBpbWFnZSByZWxhdGVkIHRlc3RzIGFyZSBjcmFzaGluZywgY2F1 c2luZyB0aGUgdGVzdCBib3QgdG8gZXhpdCBlYXJseQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgcjIxNTIxMSBjYXVzZWQgYW4gaW5maW5pdGUgbG9vcCBi ZWNhdXNlIG9mIGNhbGxzIGJldHdlZW4gSW1hZ2VEZWNvZGVyOjppc1NpemVBdmFpbGFibGUoKSBh bmQgdGhlIHNwZWNpYWxpemF0aW9ucyBvZgorICAgICAgICBJbWFnZURlY29kZXI6OmVuY29kZWRE YXRhU3RhdHVzKCkuIENoYW5nZSB0aGUgZGlmZmVyZW50IGRlY29kZXJzIHNvIEltYWdlRGVjb2Rl cjo6ZW5jb2RlZERhdGFTdGF0dXMgZG9lc24ndCBjYWxsCisgICAgICAgIEltYWdlRGVjb2Rlcjo6 aXNTaXplQXZhaWxhYmxlKCkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGVudCB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2JtcC9CTVBJbWFnZURlY29kZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Qk1QSW1hZ2VEZWNvZGVyOjplbmNvZGVkRGF0YVN0YXR1 cyk6CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVjb2Rl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHSUZJbWFnZURlY29kZXI6OmVuY29kZWREYXRhU3Rh dHVzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9pY28vSUNPSW1hZ2VEZWNv ZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklDT0ltYWdlRGVjb2Rlcjo6ZW5jb2RlZERhdGFT dGF0dXMpOgorICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdl RGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKUEVHSW1hZ2VEZWNvZGVyOjplbmNvZGVk RGF0YVN0YXR1cyk6CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcG5nL1BOR0lt YWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQTkdJbWFnZURlY29kZXI6OmVuY29k ZWREYXRhU3RhdHVzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dF QlBJbWFnZURlY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V0VCUEltYWdlRGVjb2Rlcjo6 ZW5jb2RlZERhdGFTdGF0dXMpOgorCiAyMDE3LTA0LTEwICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2ZXJ0IHIyMTUyMTcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2JtcC9CTVBJbWFnZURl Y29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvYm1wL0JN UEltYWdlRGVjb2Rlci5jcHAKaW5kZXggN2NkMjJmZDM4MDJjMjU1N2ViMzQ0ZDMyOTBmMTAwMjZi OTkxNmRiOC4uY2FiYmUzNzUwMWMyOTJkNTk5MTRjYjhhOTRkYTQ3MTEyN2JhMjA5NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvYm1wL0JNUEltYWdl RGVjb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv Ym1wL0JNUEltYWdlRGVjb2Rlci5jcHAKQEAgLTU4LDcgKzU4LDcgQEAgdm9pZCBCTVBJbWFnZURl Y29kZXI6OnNldERhdGEoU2hhcmVkQnVmZmVyJiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCkK IAogRW5jb2RlZERhdGFTdGF0dXMgQk1QSW1hZ2VEZWNvZGVyOjplbmNvZGVkRGF0YVN0YXR1cygp CiB7Ci0gICAgaWYgKCFJbWFnZURlY29kZXI6OmlzU2l6ZUF2YWlsYWJsZSgpKQorICAgIGlmIChJ bWFnZURlY29kZXI6OmVuY29kZWREYXRhU3RhdHVzKCkgPCBFbmNvZGVkRGF0YVN0YXR1czo6U2l6 ZUF2YWlsYWJsZSkKICAgICAgICAgZGVjb2RlKHRydWUpOwogCiAgICAgcmV0dXJuIEltYWdlRGVj b2Rlcjo6ZW5jb2RlZERhdGFTdGF0dXMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVjb2Rlci5jcHAKaW5k ZXggM2MzMGJlYTgzYTdjYThjNzdlYTQ4NzQyMTRlMmMxNTNmYTNhYTY3NC4uYTkxNWNjMTk3YWFk YzcwMmY3MWVkMjg5NzhkYTUzMmYyNWIxNzY4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVjb2Rlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVjb2Rlci5j cHAKQEAgLTUyLDcgKzUyLDcgQEAgdm9pZCBHSUZJbWFnZURlY29kZXI6OnNldERhdGEoU2hhcmVk QnVmZmVyJiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCkKIAogRW5jb2RlZERhdGFTdGF0dXMg R0lGSW1hZ2VEZWNvZGVyOjplbmNvZGVkRGF0YVN0YXR1cygpCiB7Ci0gICAgaWYgKCFJbWFnZURl Y29kZXI6OmlzU2l6ZUF2YWlsYWJsZSgpKQorICAgIGlmIChJbWFnZURlY29kZXI6OmVuY29kZWRE YXRhU3RhdHVzKCkgPCBFbmNvZGVkRGF0YVN0YXR1czo6U2l6ZUF2YWlsYWJsZSkKICAgICAgICAg ZGVjb2RlKDAsIEdJRlNpemVRdWVyeSk7CiAKICAgICByZXR1cm4gSW1hZ2VEZWNvZGVyOjplbmNv ZGVkRGF0YVN0YXR1cygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvaWNvL0lDT0ltYWdlRGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9pY28vSUNPSW1hZ2VEZWNvZGVyLmNwcAppbmRleCBmYjAxMTZi NzM2ZTFhMDNkZmU3MDcyZmE3NmU5N2JmZmVkNTI5MDAzLi45ODBlOTA1ODkxNzkyNjkyNDBjMGRk ODRjNDAzNmRjYmQ3MmY2MDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy9pY28vSUNPSW1hZ2VEZWNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9pY28vSUNPSW1hZ2VEZWNvZGVyLmNwcApAQCAtNzEs NyArNzEsNyBAQCB2b2lkIElDT0ltYWdlRGVjb2Rlcjo6c2V0RGF0YShTaGFyZWRCdWZmZXImIGRh dGEsIGJvb2wgYWxsRGF0YVJlY2VpdmVkKQogCiBFbmNvZGVkRGF0YVN0YXR1cyBJQ09JbWFnZURl Y29kZXI6OmVuY29kZWREYXRhU3RhdHVzKCkKIHsKLSAgICBpZiAoIUltYWdlRGVjb2Rlcjo6aXNT aXplQXZhaWxhYmxlKCkpCisgICAgaWYgKEltYWdlRGVjb2Rlcjo6ZW5jb2RlZERhdGFTdGF0dXMo KSA8IEVuY29kZWREYXRhU3RhdHVzOjpTaXplQXZhaWxhYmxlKQogICAgICAgICBkZWNvZGUoMCwg dHJ1ZSk7CiAKICAgICByZXR1cm4gSW1hZ2VEZWNvZGVyOjplbmNvZGVkRGF0YVN0YXR1cygpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9K UEVHSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHAKaW5kZXggN2NiZTU0Y2E3NTBhMzk0YzNjM2Jj NjgzYmM4NTc4NDI0ODQwMDAxZS4uNWI0YWQ2MTY4MjFmYzIwNTZkNTA0OTY0MTM2OWVlNDk5OTE3 YTkwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv anBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwCkBAIC01MTIsNyArNTEyLDcg QEAgSlBFR0ltYWdlRGVjb2Rlcjo6fkpQRUdJbWFnZURlY29kZXIoKQogCiBFbmNvZGVkRGF0YVN0 YXR1cyBKUEVHSW1hZ2VEZWNvZGVyOjplbmNvZGVkRGF0YVN0YXR1cygpCiB7Ci0gICAgaWYgKCFJ bWFnZURlY29kZXI6OmlzU2l6ZUF2YWlsYWJsZSgpKQorICAgIGlmIChJbWFnZURlY29kZXI6OmVu Y29kZWREYXRhU3RhdHVzKCkgPCBFbmNvZGVkRGF0YVN0YXR1czo6U2l6ZUF2YWlsYWJsZSkKICAg ICAgICAgZGVjb2RlKHRydWUpOwogCiAgICAgcmV0dXJuIEltYWdlRGVjb2Rlcjo6ZW5jb2RlZERh dGFTdGF0dXMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvcG5nL1BOR0ltYWdlRGVjb2Rlci5jcHAKaW5kZXggNmY1YTkyMDA5NDQx YTE1NzlkMTM4ZmY4ZTU2YmFkMWFlZjhmNmFmOS4uYjZlYTY1ZGVlZGRhNzA3MjAyYWU3YzlkZGRk MzE2NjAzNjJkZWI2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvcG5nL1BOR0ltYWdlRGVjb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZGVjb2RlcnMvcG5nL1BOR0ltYWdlRGVjb2Rlci5jcHAKQEAgLTI0MSw3ICsy NDEsNyBAQCBSZXBldGl0aW9uQ291bnQgUE5HSW1hZ2VEZWNvZGVyOjpyZXBldGl0aW9uQ291bnQo KSBjb25zdAogCiBFbmNvZGVkRGF0YVN0YXR1cyBQTkdJbWFnZURlY29kZXI6OmVuY29kZWREYXRh U3RhdHVzKCkKIHsKLSAgICBpZiAoIUltYWdlRGVjb2Rlcjo6aXNTaXplQXZhaWxhYmxlKCkpCisg ICAgaWYgKEltYWdlRGVjb2Rlcjo6ZW5jb2RlZERhdGFTdGF0dXMoKSA8IEVuY29kZWREYXRhU3Rh dHVzOjpTaXplQXZhaWxhYmxlKQogICAgICAgICBkZWNvZGUodHJ1ZSwgMCk7CiAKICAgICByZXR1 cm4gSW1hZ2VEZWNvZGVyOjplbmNvZGVkRGF0YVN0YXR1cygpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdl RGVjb2Rlci5jcHAKaW5kZXggM2VkY2FiN2JiMzJlNTU3MDFmNGZhZDNmZGUzNGE3N2ZjOWU4NWUy Zi4uZDM2ZDkzOTI5NGMzZmM5ZjljN2Q3YmU4NDNhMTgyMDNmMWJkNzFhNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNv ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJw L1dFQlBJbWFnZURlY29kZXIuY3BwCkBAIC02Niw3ICs2Niw3IEBAIHZvaWQgV0VCUEltYWdlRGVj b2Rlcjo6Y2xlYXIoKQogCiBFbmNvZGVkRGF0YVN0YXR1cyBXRUJQSW1hZ2VEZWNvZGVyOjplbmNv ZGVkRGF0YVN0YXR1cygpCiB7Ci0gICAgaWYgKCFJbWFnZURlY29kZXI6OmlzU2l6ZUF2YWlsYWJs ZSgpKQorICAgIGlmIChJbWFnZURlY29kZXI6OmVuY29kZWREYXRhU3RhdHVzKCkgPCBFbmNvZGVk RGF0YVN0YXR1czo6U2l6ZUF2YWlsYWJsZSkKICAgICAgICAgZGVjb2RlKHRydWUpOwogCiAgICAg cmV0dXJuIEltYWdlRGVjb2Rlcjo6ZW5jb2RlZERhdGFTdGF0dXMoKTsK