170719 2017-04-11 01:26:02 -0700 REGRESSION(r215153): Request Animation Frame broken when building without REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 2017-04-11 08:52:03 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170630 Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply buildbot cdumez commit-queue dbates esprehn+autocc kangil.han simon.fraser zan oldest_to_newest 1296314 0 cgarcia 2017-04-11 01:26:02 -0700 This is because when not using the display refresh monitor, the timer is always used, not only when throttling, but since r215153 the rAF timer is always aligned to 30ms. This made test fast/animation/request-animation-frame-too-rapid.html fail in the GTK+ port. 1296320 1 306787 cgarcia 2017-04-11 01:34:48 -0700 Created attachment 306787 Patch 1296367 2 306787 simon.fraser 2017-04-11 05:56:37 -0700 Comment on attachment 306787 Patch Thanks for fixing! I guess the gtk EWS bot doesn't run tests? 1296368 3 cgarcia 2017-04-11 06:03:26 -0700 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 306787 [details] > Patch > > Thanks for fixing! I guess the gtk EWS bot doesn't run tests? Yes :-( 1296415 4 306787 commit-queue 2017-04-11 08:52:01 -0700 Comment on attachment 306787 Patch Clearing flags on attachment: 306787 Committed r215231: <http://trac.webkit.org/changeset/215231> 1296416 5 commit-queue 2017-04-11 08:52:03 -0700 All reviewed patches have been landed. Closing bug. 306787 2017-04-11 01:34:48 -0700 2017-04-11 08:52:01 -0700 Patch wk-raf-broken.diff text/plain 2858 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZGUzZjZhMzkzMS4uN2I3YTliYzNlNDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wNC0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjE1MTUzKTogUmVxdWVzdCBBbmltYXRp b24gRnJhbWUgYnJva2VuIHdoZW4gYnVpbGRpbmcgd2l0aG91dCBSRVFVRVNUX0FOSU1BVElPTl9G UkFNRV9ESVNQTEFZX01PTklUT1IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3MDcxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSB3aGVuIG5vdCB1c2luZyB0aGUgZGlzcGxheSBy ZWZyZXNoIG1vbml0b3IsIHRoZSB0aW1lciBpcyBhbHdheXMgdXNlZCwgbm90IG9ubHkgd2hlbiB0 aHJvdHRsaW5nLAorICAgICAgICBidXQgc2luY2UgcjIxNTE1MyB0aGUgckFGIHRpbWVyIGlzIGFs d2F5cyBhbGlnbmVkIHRvIDMwbXMuCisKKyAgICAgICAgRml4ZXM6IGZhc3QvYW5pbWF0aW9uL3Jl cXVlc3QtYW5pbWF0aW9uLWZyYW1lLXRvby1yYXBpZC5odG1sCisKKyAgICAgICAgKiBkb20vU2Ny aXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdGVk QW5pbWF0aW9uQ29udHJvbGxlcjo6c2NoZWR1bGVBbmltYXRpb24pOiBPbmx5IGRvIHRoZSB0aW1l ciBhbGlnbm1lbnQgd2hlbiB0aHJvdHRsaW5nLgorCiAyMDE3LTA0LTEwICBaYW4gRG9iZXJzZWsg IDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVc2UgdGhlIERpc3BsYXlS ZWZyZXNoTW9uaXRvciBmYWNpbGl0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v U2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3Jp cHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCmluZGV4IDFiODU5MWY2YWMwLi5mYWI4Yjk5NDk2 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJv bGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJv bGxlci5jcHAKQEAgLTMwMywxNyArMzAzLDIxIEBAIHZvaWQgU2NyaXB0ZWRBbmltYXRpb25Db250 cm9sbGVyOjpzY2hlZHVsZUFuaW1hdGlvbigpCiAgICAgICAgIHJldHVybjsKIAogICAgIFNlY29u ZHMgYW5pbWF0aW9uSW50ZXJ2YWwgPSBpbnRlcnZhbCgpOworICAgIFNlY29uZHMgc2NoZWR1bGVE ZWxheSA9IHN0ZDo6bWF4KGFuaW1hdGlvbkludGVydmFsIC0gU2Vjb25kcyhtX2RvY3VtZW50LT5k b21XaW5kb3coKS0+bm93VGltZXN0YW1wKCkgLSBtX2xhc3RBbmltYXRpb25GcmFtZVRpbWVzdGFt cCksIDBfcyk7CisKKyAgICBpZiAoaXNUaHJvdHRsZWQoKSkgeworICAgICAgICAvLyBGSVhNRTog bm90IGlkZWFsIHRvIHNuYXBzaG90IHRpbWUgYm90aCBpbiBub3coKSBhbmQgbm93VGltZXN0YW1w KCksIHRoZSBsYXR0ZXIgb2Ygd2hpY2ggYWxzbyBoYXMgcmVkdWNlZCByZXNvbHV0aW9uLgorICAg ICAgICBNb25vdG9uaWNUaW1lIG5vdyA9IE1vbm90b25pY1RpbWU6Om5vdygpOworCisgICAgICAg IE1vbm90b25pY1RpbWUgZmlyZVRpbWUgPSBub3cgKyBzY2hlZHVsZURlbGF5OworICAgICAgICBT ZWNvbmRzIGFsaWdubWVudEludGVydmFsID0gMTBfbXM7CisgICAgICAgIC8vIFNuYXAgdG8gdGhl IG5lYXJlc3QgYWxpZ25tZW50SW50ZXJ2YWwuCisgICAgICAgIFNlY29uZHMgYWxpZ25tZW50ID0g KGZpcmVUaW1lICsgYWxpZ25tZW50SW50ZXJ2YWwgLyAyKSAlIGFsaWdubWVudEludGVydmFsOwor ICAgICAgICBNb25vdG9uaWNUaW1lIGFsaWduZWRGaXJlVGltZSA9IGZpcmVUaW1lIC0gYWxpZ25t ZW50OworICAgICAgICBzY2hlZHVsZURlbGF5ID0gYWxpZ25lZEZpcmVUaW1lIC0gbm93OworICAg IH0KIAotICAgIC8vIEZJWE1FOiBub3QgaWRlYWwgdG8gc25hcHNob3QgdGltZSBib3RoIGluIG5v dygpIGFuZCBub3dUaW1lc3RhbXAoKSwgdGhlIGxhdHRlciBvZiB3aGljaCBhbHNvIGhhcyByZWR1 Y2VkIHJlc29sdXRpb24uCi0gICAgTW9ub3RvbmljVGltZSBub3cgPSBNb25vdG9uaWNUaW1lOjpu b3coKTsKLQotICAgIE1vbm90b25pY1RpbWUgZmlyZVRpbWUgPSBub3cgKyBzdGQ6Om1heChhbmlt YXRpb25JbnRlcnZhbCAtIFNlY29uZHMobV9kb2N1bWVudC0+ZG9tV2luZG93KCktPm5vd1RpbWVz dGFtcCgpIC0gbV9sYXN0QW5pbWF0aW9uRnJhbWVUaW1lc3RhbXApLCAwX3MpOwotICAgIFNlY29u ZHMgYWxpZ25tZW50SW50ZXJ2YWwgPSAzMF9tczsKLSAgICAvLyBTbmFwIHRvIHRoZSBuZWFyZXN0 IGFsaWdubWVudEludGVydmFsLgotICAgIFNlY29uZHMgYWxpZ25tZW50ID0gKGZpcmVUaW1lICsg YWxpZ25tZW50SW50ZXJ2YWwgLyAyKSAlIGFsaWdubWVudEludGVydmFsOwotICAgIE1vbm90b25p Y1RpbWUgYWxpZ25lZEZpcmVUaW1lID0gZmlyZVRpbWUgLSBhbGlnbm1lbnQ7Ci0KLSAgICBtX2Fu aW1hdGlvblRpbWVyLnN0YXJ0T25lU2hvdChhbGlnbmVkRmlyZVRpbWUgLSBub3cpOworICAgIG1f YW5pbWF0aW9uVGltZXIuc3RhcnRPbmVTaG90KHNjaGVkdWxlRGVsYXkpOwogCiAgICAgZGlzcGF0 Y2hMb2dnaW5nRXZlbnRJZlJlcXVpcmVkKCJyYWYtc2NoZWR1bGUtYW5pbWF0aW9uLXRpbWVyIik7 CiAjZWxzZQo=