170702 2017-04-10 15:27:44 -0700 [macOS Sierra] LayoutTest http/tests/inspector/network/resource-request-headers.html is a flaky failure 2017-05-05 13:32:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=171545 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned bburg inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1296194 0 ryanhaddad 2017-04-10 15:27:44 -0700 LayoutTest http/tests/inspector/network/resource-request-headers.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r215180%20(401)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fresource-request-headers.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/inspector/network/resource-request-headers-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/inspector/network/resource-request-headers-actual.txt @@ -34,5 +34,7 @@ PASS: Resource should be created. PASS: Resource should receive a Response. PASS: Resource should have a 200 status code. -PASS: 'Authorization' header value should be for goodUsername:goodPassword. +FAIL: 'Authorization' header value should be for goodUsername:goodPassword. + Expected: "Basic Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA==" + Actual: undefined 1296195 1 ryanhaddad 2017-04-10 15:28:08 -0700 This test was added with https://trac.webkit.org/changeset/215062/webkit 1296198 2 joepeck 2017-04-10 15:39:28 -0700 Arg this will need to be marked flakey until I have time to investigate. 1297140 3 ryanhaddad 2017-04-13 14:41:44 -0700 (In reply to Joseph Pecoraro from comment #2) > Arg this will need to be marked flakey until I have time to investigate. Done in https://trac.webkit.org/changeset/215338/webkit 1297173 4 webkit-bug-importer 2017-04-13 15:40:21 -0700 <rdar://problem/31616643> 1304897 5 joepeck 2017-05-04 17:02:16 -0700 Adding InspectorTest.debug() I see: > event: {"method":"Network.requestWillBeSent","params":{"requestId":"0.330","frameId":"0.1","loaderId":"0.91","documentURL":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","request":{"url":"http://goodUsername:goodPassword@127.0.0.1:8000/inspector/network/resources/basic-auth.php?0.33697814343205157","method":"GET","headers":{"Referer":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","Accept":"*/*","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/604.1.22+ (KHTML, like Gecko)"}},"timestamp":0.9208538240000053,"initiator":{"type":"script","stackTrace":[{"functionName":"send","url":"[native code]","scriptId":"0","lineNumber":0,"columnNumber":0},{"functionName":"triggerNetworkLoadWithBasicAuthentication","url":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","scriptId":"1934","lineNumber":18,"columnNumber":13},{"functionName":"triggerNetworkLoadWithBasicAuthenticationSuccess","url":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","scriptId":"1934","lineNumber":40,"columnNumber":46},{"functionName":"global code","url":"","scriptId":"1967","lineNumber":1,"columnNumber":49},{"functionName":"evaluateWithScopeExtension","url":"[native code]","scriptId":"0","lineNumber":0,"columnNumber":0},{"functionName":"_evaluateOn","url":"","scriptId":"1935","lineNumber":100,"columnNumber":29},{"functionName":"_evaluateAndWrap","url":"","scriptId":"1935","lineNumber":93,"columnNumber":105},{"functionName":"evaluate","url":"","scriptId":"1935","lineNumber":83,"columnNumber":30}]},"type":"XHR"}} > response: {"result":{"result":{"type":"undefined"},"wasThrown":false},"id":57} > event: {"method":"Network.responseReceived","params":{"requestId":"0.330","frameId":"0.1","loaderId":"0.91","timestamp":0.9282765010000276,"type":"XHR","response":{"url":"http://127.0.0.1:8000/inspector/network/resources/basic-auth.php?0.33697814343205157","status":200,"statusText":"OK","headers":{"Content-Type":"text/html","Date":"Thu, 04 May 2017 23:58:00 GMT","Connection":"Keep-Alive","Server":"Apache/2.4.25 (Unix) PHP/5.6.30 LibreSSL/2.2.7","Content-Length":"8","Keep-Alive":"timeout=15, max=100","X-Powered-By":"PHP/5.6.30"},"mimeType":"text/html","source":"network","timing":{"startTime":0.9201104710000436,"domainLookupStart":0.565946102142334,"domainLookupEnd":0.565946102142334,"connectStart":0.565946102142334,"connectEnd":0.565946102142334,"secureConnectionStart":-1000,"requestStart":0.7959604263305664,"responseStart":1.3339519500732422}}}} > event: {"method":"Network.dataReceived","params":{"requestId":"0.330","timestamp":0.9285717630000363,"dataLength":8,"encodedDataLength":8}} > FAIL: 'Authorization' header value should be for goodUsername:goodPassword. > Expected: "Basic Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA==" > Actual: undefined > request: {"id":61,"method":"Runtime.evaluate","params":{"expression":"TestPage.addResult(unescape(\"FAIL%3A%20%27Authorization%27%20header%20value%20should%20be%20for%20goodUsername%3AgoodPassword.%0A%20%20%20%20Expected%3A%20%22Basic%20Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA%3D%3D%22%0A%20%20%20%20Actual%3A%20undefined\"))","objectGroup":"test","includeCommandLineAPI":false}} > completeTest() > event: {"method":"Network.loadingFinished","params":{"requestId":"0.330","timestamp":0.9215144584077279,"metrics":{"protocol":"http/1.1","priority":"medium","requestHeaders":{"Referer":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","Host":"127.0.0.1:8000","Accept":"*/*","Connection":"keep-alive","Accept-Language":"en-us","Accept-Encoding":"gzip, deflate","Authorization":"Basic Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA==","Cookie":"InspectorTestCookie=1234","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/604.1.22+ (KHTML, like Gecko)"}}}} So the test is checking the values before the Network load has finished (Network.loadingFinished). I'll wait for the loading finished event. 1304900 6 309115 joepeck 2017-05-04 17:09:24 -0700 Created attachment 309115 [PATCH] Proposed Fix 1305285 7 309115 bburg 2017-05-05 13:28:36 -0700 Comment on attachment 309115 [PATCH] Proposed Fix rs=me 1305286 8 joepeck 2017-05-05 13:32:24 -0700 <https://trac.webkit.org/changeset/216266/webkit> 309115 2017-05-04 17:09:24 -0700 2017-05-05 13:28:36 -0700 [PATCH] Proposed Fix wait-for-finish-1.patch text/plain 2889 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwZjUyOWUxODI3NC4uY2Q3OTZiZTg1OTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxNy0wNS0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIFttYWNPUyBTaWVycmFdIExheW91dFRlc3QgaHR0cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29y ay9yZXNvdXJjZS1yZXF1ZXN0LWhlYWRlcnMuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDcwMgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzE2MTY2NDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6 CisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29yay9yZXNvdXJjZS1yZXF1ZXN0 LWhlYWRlcnMuaHRtbDoKKyAgICAgICAgTWFrZSB0aGlzIHRlc3QgdW5mbGFrZXkgYnkgZW5zdXJp bmcgd2Ugd2FpdCBmb3IgdGhlIGxvYWQgdG8gY29tcGxldGUuCisKIDIwMTctMDUtMDQgIFNhaWQg QWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUg dGVzdFJ1bm5lci5kaXNwbGF5QW5kVHJhY2tSZXBhaW50cygpIHRvIHRlc3RSdW5uZXIuZGlzcGxh eUFuZFRyYWNrUmVwYWludHMoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9p bnNwZWN0b3IvbmV0d29yay9yZXNvdXJjZS1yZXF1ZXN0LWhlYWRlcnMuaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvcmVzb3VyY2UtcmVxdWVzdC1oZWFkZXJz Lmh0bWwKaW5kZXggN2VlMTkxNjI0ZTUuLjYxMGMyMGE2ZTAxIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrL3Jlc291cmNlLXJlcXVlc3QtaGVhZGVy cy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvcmVz b3VyY2UtcmVxdWVzdC1oZWFkZXJzLmh0bWwKQEAgLTUyLDggKzUyLDkgQEAgZnVuY3Rpb24gdGVz dCgpCiAgICAgICAgICAgICAgICAgUHJvbWlzZS5hbGwoWwogICAgICAgICAgICAgICAgICAgICBX ZWJJbnNwZWN0b3IuRnJhbWUuYXdhaXRFdmVudChXZWJJbnNwZWN0b3IuRnJhbWUuRXZlbnQuUmVz b3VyY2VXYXNBZGRlZCksCiAgICAgICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5SZXNvdXJj ZS5hd2FpdEV2ZW50KFdlYkluc3BlY3Rvci5SZXNvdXJjZS5FdmVudC5SZXNwb25zZVJlY2VpdmVk KSwKKyAgICAgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLlJlc291cmNlLmF3YWl0RXZlbnQo V2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50LkxvYWRpbmdEaWRGaW5pc2gpLAogICAgICAgICAg ICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmF3YWl0RXZlbnQoIkxvYWRDb21wbGV0ZSIpLAotICAg ICAgICAgICAgICAgIF0pLnRoZW4oKFtyZXNvdXJjZVdhc0FkZGVkRXZlbnQsIHJlc3BvbnNlUmVj ZWl2ZWRFdmVudCwgbG9hZENvbXBsZXRlRXZlbnRdKSA9PiB7CisgICAgICAgICAgICAgICAgXSku dGhlbigoW3Jlc291cmNlV2FzQWRkZWRFdmVudCwgcmVzcG9uc2VSZWNlaXZlZEV2ZW50LCBsb2Fk aW5nRGlkRmluaXNoLCBsb2FkQ29tcGxldGVFdmVudF0pID0+IHsKICAgICAgICAgICAgICAgICAg ICAgbGV0IHJlc291cmNlID0gcmVzb3VyY2VXYXNBZGRlZEV2ZW50LmRhdGEucmVzb3VyY2U7CiAg ICAgICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdChyZXNvdXJjZSBpbnN0 YW5jZW9mIFdlYkluc3BlY3Rvci5SZXNvdXJjZSwgIlJlc291cmNlIHNob3VsZCBiZSBjcmVhdGVk LiIpOwogICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEVxdWFsKHJlc291 cmNlLCByZXNwb25zZVJlY2VpdmVkRXZlbnQudGFyZ2V0LCAiUmVzb3VyY2Ugc2hvdWxkIHJlY2Vp dmUgYSBSZXNwb25zZS4iKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13 azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4 cGVjdGF0aW9ucwppbmRleCAyMzk3MmU0MjkzMy4uOTY3Y2Q1MTNhNjMgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTY0OCw4ICs2NDgsNiBA QCB3ZWJraXQub3JnL2IvMTcwNDEwIGZhc3QvaW1hZ2VzL2FuaW1hdGVkLWdpZi13ZWJraXQtdHJh bnNmb3JtLmh0bWwgWyBQYXNzIEZhaWx1cgogCiBjb21wb3NpdGluZy90aWxpbmcvbm9uLXZpc2li bGUtd2luZG93LXRpbGUtY292ZXJhZ2UuaHRtbCBbIFBhc3MgXQogCi13ZWJraXQub3JnL2IvMTcw NzAyIFsgU2llcnJhIF0gaHR0cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29yay9yZXNvdXJjZS1yZXF1 ZXN0LWhlYWRlcnMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNzA5MDcg WyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViQ3J5cHRvQVBJL2Rl cml2ZV9iaXRzX2tleXMvaGtkZi53b3JrZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBUaW1lb3V0IF0K IAogd2Via2l0Lm9yZy9iLzE3MDYyOSBbIFNpZXJyYSBEZWJ1ZyBdIG1lbW9yeS9tZW1vcnktcHJl c3N1cmUtc2ltdWxhdGlvbi5odG1sIFsgUGFzcyBGYWlsdXJlIF0K