170696 2017-04-10 15:08:38 -0700 Have parseRevisionProperty use default repo name as the buildbot key. 2017-04-10 20:44:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kocsen_chung webkit-unassigned ap commit-queue dbates kocsen_chung lforschler thorton youennf oldest_to_newest 1296181 0 kocsen_chung 2017-04-10 15:08:38 -0700 Have parseRevisionProperty use default repo name as the buildbot key. 1296183 1 306749 kocsen_chung 2017-04-10 15:13:05 -0700 Created attachment 306749 Patch 1296208 2 306749 dbates 2017-04-10 16:23:23 -0700 Comment on attachment 306749 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306749&action=review > Tools/ChangeLog:9 > + buildobt data. That is no longer necessary as we can make a safe assumption buildobt => Buildbot > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:208 > + var key = repositoryName; Instead of default initializing these variables and then overwriting them for OpenSiurce I suggest that we leave them hninitialized here and remove the "else if" For Internal. 1296221 3 306759 kocsen_chung 2017-04-10 17:01:23 -0700 Created attachment 306759 Patch 1296225 4 306759 kocsen_chung 2017-04-10 17:12:04 -0700 Comment on attachment 306759 Patch Thanks Dan, for the review. commit-queue ? 1296261 5 306759 commit-queue 2017-04-10 20:34:00 -0700 Comment on attachment 306759 Patch Clearing flags on attachment: 306759 Committed r215215: <http://trac.webkit.org/changeset/215215> 1296262 6 commit-queue 2017-04-10 20:34:02 -0700 All reviewed patches have been landed. Closing bug. 1296265 7 lforschler 2017-04-10 20:44:40 -0700 I've updated the buildbot repo as of 8:45 pacific time. 306749 2017-04-10 15:13:05 -0700 2017-04-10 17:01:21 -0700 Patch bug-170696-20170410151304.patch text/plain 2572 kocsen_chung U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0OTcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWM2MDkxY2ViNWQ5ZjdjYzc0YzE1M2IxMjUwZmVkNDM5 YTYxOWY4Yy4uMmZlZTJhZGFlN2ExYTY5MDdjYTM2YTYyMjBmNDNlOTE4Y2QxMWMxMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE3LTA0LTEwICBLb2NzZW4gQ2h1bmcgIDxrb2NzZW5fY2h1bmdAYXBwbGUuY29tPgor CisgICAgICAgIEhhdmUgcGFyc2VSZXZpc2lvblByb3BlcnR5IHVzZSBkZWZhdWx0IHJlcG8gbmFt ZSBhcyB0aGUgYnVpbGRib3Qga2V5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTcwNjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUHJldmlvdXNseSwgd2UgbmVlZGVkIHRvIHNldCBhIGtleSBhbmQgYSBm YWxsYmFja0tleSB3aGVuIGFkZHJlc3NpbmcKKyAgICAgICAgYnVpbGRvYnQgZGF0YS4gVGhhdCBp cyBubyBsb25nZXIgbmVjZXNzYXJ5IGFzIHdlIGNhbiBtYWtlIGEgc2FmZSBhc3N1bXB0aW9uCisg ICAgICAgIHRoYXQgdGhlIHJlcG8gbmFtZSBtYXBzIGV4YWN0bHkgdG8gdGhhdCBrZXkgZm9yIGV2 ZXJ5IHJlcG9zaXRvcnkgb3RoZXIKKyAgICAgICAgdGhhbiBXZWJLaXQuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qczoKKyAgICAgICAgU2V0IGBrZXkgPSBy ZXBvc2l0b3J5TmFtZWAgYW5kIG9ubHkgdXNlIGZhbGxiYWNrIGtleXMgd2hlbiBkZWFsaW5nIHdp dGggV2ViS2l0LgorCiAyMDE3LTA0LTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxl LmNvbT4KIAogICAgICAgICB3ZWJraXRweTogQWRkIHBpZCBsb2dnaW5nIGZvciBzaW11bGF0b3Ig cHJvY2Vzc2VzCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJh dGlvbi5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90SXRlcmF0aW9uLmpzCmluZGV4 IDYzZTQ5MzU4MWQ4YTg1OTkzMjA1ODBmZjMyMmI5ZDZhZjExZjkyZDQuLjAwY2E2ZGZhNDE3YzI4 Y2I5MDE1ZTYxYWQ4YzMzZmM4ZTZhNjNmZGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3Jp cHRzL0J1aWxkYm90SXRlcmF0aW9uLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxk Ym90SXRlcmF0aW9uLmpzCkBAIC0yMDEsMjEgKzIwMSwxOCBAQCBCdWlsZGJvdEl0ZXJhdGlvbi5w cm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm4gcHJvcGVydHlbMF0gPT09ICJnb3RfcmV2 aXNpb24iOwogICAgICAgICB9KTsKICAgICAgICAgdmFyIGJyYW5jaGVzID0gdGhpcy5xdWV1ZS5i cmFuY2hlczsKKwogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGJyYW5jaGVzLmxlbmd0aDsg KytpKSB7CiAgICAgICAgICAgICB2YXIgcmVwb3NpdG9yeSA9IGJyYW5jaGVzW2ldLnJlcG9zaXRv cnk7CiAgICAgICAgICAgICB2YXIgcmVwb3NpdG9yeU5hbWUgPSByZXBvc2l0b3J5Lm5hbWU7Ci0g ICAgICAgICAgICB2YXIga2V5OwotICAgICAgICAgICAgdmFyIGZhbGxiYWNrS2V5OworICAgICAg ICAgICAgdmFyIGtleSA9IHJlcG9zaXRvcnlOYW1lOworICAgICAgICAgICAgdmFyIGZhbGxiYWNr S2V5ID0gbnVsbDsKKwogICAgICAgICAgICAgaWYgKHJlcG9zaXRvcnkgPT09IERhc2hib2FyZC5S ZXBvc2l0b3J5Lk9wZW5Tb3VyY2UpIHsKICAgICAgICAgICAgICAgICBrZXkgPSAiV2ViS2l0IjsK ICAgICAgICAgICAgICAgICBmYWxsYmFja0tleSA9ICJvcGVuc291cmNlIjsKLSAgICAgICAgICAg IH0gZWxzZSBpZiAocmVwb3NpdG9yeSA9PT0gRGFzaGJvYXJkLlJlcG9zaXRvcnkuSW50ZXJuYWwp IHsKLSAgICAgICAgICAgICAgICBrZXkgPSAiSW50ZXJuYWwiOwotICAgICAgICAgICAgICAgIGZh bGxiYWNrS2V5ID0gImludGVybmFsIjsKLSAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAg ICAgICAga2V5ID0gcmVwb3NpdG9yeU5hbWU7Ci0gICAgICAgICAgICAgICAgZmFsbGJhY2tLZXkg PSBudWxsOwogICAgICAgICAgICAgfQorCiAgICAgICAgICAgICB2YXIgcmV2aXNpb24gPSBwYXJz ZVJldmlzaW9uUHJvcGVydHkocmV2aXNpb25Qcm9wZXJ0eSwga2V5LCBmYWxsYmFja0tleSk7CiAg ICAgICAgICAgICB0aGlzLnJldmlzaW9uW3JlcG9zaXRvcnlOYW1lXSA9IHJldmlzaW9uOwogICAg ICAgICB9Cg== 306759 2017-04-10 17:01:23 -0700 2017-04-10 20:34:00 -0700 Patch bug-170696-20170410170121.patch text/plain 2564 kocsen_chung U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MjA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjc1MWMyYjUwZmRkYmNhZWQyODM1NDQzZDY5YWIxZjZj ODRlOWYyNC4uYmNlYjc0YjM2ODcyNDQzM2QzNzcyZWM4ZDg2Y2RlM2RhODY0MDI5YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE3LTA0LTEwICBLb2NzZW4gQ2h1bmcgIDxrb2NzZW5fY2h1bmdAYXBwbGUuY29tPgor CisgICAgICAgIEhhdmUgcGFyc2VSZXZpc2lvblByb3BlcnR5IHVzZSBkZWZhdWx0IHJlcG8gbmFt ZSBhcyB0aGUgQnVpbGRib3Qga2V5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTcwNjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUHJldmlvdXNseSwgd2UgbmVlZGVkIHRvIHNldCBhIGtleSBhbmQgYSBm YWxsYmFja0tleSB3aGVuIGFkZHJlc3NpbmcKKyAgICAgICAgQnVpbGRib3QgZGF0YSBmb3IgSW50 ZXJuYWwuIFRoYXQgaXMgbm8gbG9uZ2VyIG5lY2Vzc2FyeSBhcyB3ZSBjYW4gbWFrZSBhIHNhZmUg YXNzdW1wdGlvbgorICAgICAgICB0aGF0IHRoZSByZXBvIG5hbWUgbWFwcyBleGFjdGx5IHRvIHRo YXQga2V5IGZvciBldmVyeSByZXBvc2l0b3J5IG90aGVyCisgICAgICAgIHRoYW4gV2ViS2l0Lgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RJdGVyYXRpb24uanM6CisgICAgICAg IFNldCBga2V5ID0gcmVwb3NpdG9yeU5hbWVgIGFuZCBvbmx5IHVzZSBmYWxsYmFjayBrZXlzIHdo ZW4gZGVhbGluZyB3aXRoIFdlYktpdC4KKwogMjAxNy0wNC0xMCAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWZhY3RvciBEYXRhSW50ZXJhY3Rpb25U ZXN0cy5VbnJlc3BvbnNpdmVQYWdlRG9lc05vdEhhbmdVSSB0byBub3QgY2hlY2sgYWdhaW5zdCBh IGZpeGVkIHRpbWUgaW50ZXJ2YWwKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1 aWxkYm90SXRlcmF0aW9uLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RJdGVyYXRp b24uanMKaW5kZXggNjNlNDkzNTgxZDhhODU5OTMyMDU4MGZmMzIyYjlkNmFmMTFmOTJkNC4uODNh YzIxMTg5NDRjNWZjMjJkODAyNjVhNjcxOWMwM2M0YzM5Zjk3NCAxMDA2NDQKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFz aGJvYXJkL1NjcmlwdHMvQnVpbGRib3RJdGVyYXRpb24uanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Nj cmlwdHMvQnVpbGRib3RJdGVyYXRpb24uanMKQEAgLTIwMSwyMSArMjAxLDIxIEBAIEJ1aWxkYm90 SXRlcmF0aW9uLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybiBwcm9wZXJ0eVswXSA9 PT0gImdvdF9yZXZpc2lvbiI7CiAgICAgICAgIH0pOwogICAgICAgICB2YXIgYnJhbmNoZXMgPSB0 aGlzLnF1ZXVlLmJyYW5jaGVzOworCiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgYnJhbmNo ZXMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIHZhciByZXBvc2l0b3J5ID0gYnJhbmNoZXNb aV0ucmVwb3NpdG9yeTsKICAgICAgICAgICAgIHZhciByZXBvc2l0b3J5TmFtZSA9IHJlcG9zaXRv cnkubmFtZTsKICAgICAgICAgICAgIHZhciBrZXk7CiAgICAgICAgICAgICB2YXIgZmFsbGJhY2tL ZXk7CisKICAgICAgICAgICAgIGlmIChyZXBvc2l0b3J5ID09PSBEYXNoYm9hcmQuUmVwb3NpdG9y eS5PcGVuU291cmNlKSB7CiAgICAgICAgICAgICAgICAga2V5ID0gIldlYktpdCI7CiAgICAgICAg ICAgICAgICAgZmFsbGJhY2tLZXkgPSAib3BlbnNvdXJjZSI7Ci0gICAgICAgICAgICB9IGVsc2Ug aWYgKHJlcG9zaXRvcnkgPT09IERhc2hib2FyZC5SZXBvc2l0b3J5LkludGVybmFsKSB7Ci0gICAg ICAgICAgICAgICAga2V5ID0gIkludGVybmFsIjsKLSAgICAgICAgICAgICAgICBmYWxsYmFja0tl eSA9ICJpbnRlcm5hbCI7CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgIGtl eSA9IHJlcG9zaXRvcnlOYW1lOwogICAgICAgICAgICAgICAgIGZhbGxiYWNrS2V5ID0gbnVsbDsK ICAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgdmFyIHJldmlzaW9uID0gcGFyc2VSZXZpc2lv blByb3BlcnR5KHJldmlzaW9uUHJvcGVydHksIGtleSwgZmFsbGJhY2tLZXkpOwogICAgICAgICAg ICAgdGhpcy5yZXZpc2lvbltyZXBvc2l0b3J5TmFtZV0gPSByZXZpc2lvbjsKICAgICAgICAgfQo=