170695 2017-04-10 14:51:52 -0700 Retrying an A/B testing does not set the repetition count in some cases 2017-04-11 21:37:40 -0700 1 1 1 Unclassified WebKit Perf Dashboard Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez joepeck rniwa oldest_to_newest 1296174 0 rniwa 2017-04-10 14:51:52 -0700 When retrying or creating a new new A/B testing, changing the repetition change from the default 4 has no effect. 1296179 1 306748 rniwa 2017-04-10 15:01:14 -0700 Created attachment 306748 Fixes the bug 1296180 2 306748 joepeck 2017-04-10 15:04:17 -0700 Comment on attachment 306748 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=306748&action=review r=me > Websites/perf.webkit.org/browser-tests/test-group-form-tests.js:1 > + Normal to have an empty line? 1296222 3 306748 rniwa 2017-04-10 17:02:08 -0700 Comment on attachment 306748 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=306748&action=review Thanks for the review! >> Websites/perf.webkit.org/browser-tests/test-group-form-tests.js:1 >> + > > Normal to have an empty line? Yeah, almost every test starts with a blank line. 1296646 4 rniwa 2017-04-11 21:37:40 -0700 Committed r215257: <http://trac.webkit.org/changeset/215257> 306748 2017-04-10 15:01:14 -0700 2017-04-10 15:04:17 -0700 Fixes the bug bug-170695-20170410150114.patch text/plain 6669 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MTk5CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAyYjljYzZiYTVmNzEzZjdhOGQ0ZDQxYTg2YzIwY2Q3ODdiMzMyNGNhLi5kMjA0YmEyODMy NzA4MjM1ZjZjYjJiYTA1MTRlM2YyYzY2MmQ1MmQ4IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyNyBAQAogMjAxNy0wNC0xMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAorICAgICAgICBSZXRyeWluZyBhbiBBL0IgdGVzdGluZyBkb2VzIG5vdCBz ZXQgdGhlIHJlcGV0aXRpb24gY291bnQgaW4gc29tZSBjYXNlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNjk1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBzZWxlY3RpbmcgYW4gZXhpc3Rpbmcg QS9CIHRlc3QgZ3JvdXAsIHRoZSBhbmFseXNpcyB0YXNrIHBhZ2UgYXV0b21hdGljYWxseSBzZXRz IHRoZSByZXBldGl0aW9uIGNvdW50CisgICAgICAgIG9mIGl0cyByZXRyeSB0byBiZSB0aGF0IG9m IHRoZSBvcmlnaW5hbCB0ZXN0IGdyb3VwLiBIb3dldmVyLCB0aGlzIGluZm9ybWF0aW9uIHdhc24n dCBiZWluZyBwYXNzZWQgY29ycmVjdGx5CisgICAgICAgIHRvIHRoZSBjb2RlIHRoYXQgYWN0dWFs bHkgY3JlYXRlZCBhIHRlc3QgZ3JvdXAuIEFzIGEgcmVzdWx0LCB0aGUgcmV0cmllZCB0ZXN0IGdy b3VwJ3MgcmVwZXRpdGlvbiBjb3VudCBkb2VzCisgICAgICAgIG5vdCBtYXRjaCB0aGF0IG9mIHRo ZSBvcmlnaW5hbCBncm91cCBvciB0aGUgbnVtYmVyIHNob3duIHRvIHRoZSB1c2VyIG9uIFVJLgor CisgICAgICAgIEZpeGVkIHRoZSBidWcgYnkgdXBkYXRpbmcgdGhpcy5fcmVwZXRpdGlvbkNvdW50 IGluIHNldFJlcGV0aXRpb25Db3VudC4KKworICAgICAgICAqIGJyb3dzZXItdGVzdHMvaW5kZXgu aHRtbDoKKyAgICAgICAgKiBicm93c2VyLXRlc3RzL3Rlc3QtZ3JvdXAtZm9ybS10ZXN0cy5qczog QWRkZWQuIEFkZGVkIHRlc3RzLgorICAgICAgICAoLmNyZWF0ZVRlc3RHcm91cEZvcm1XaXRoQ29u dGV4dCk6IEFkZGVkLgorICAgICAgICAqIHB1YmxpYy92My9jb21wb25lbnRzL3Rlc3QtZ3JvdXAt Zm9ybS5qczoKKyAgICAgICAgKFRlc3RHcm91cEZvcm0ucHJvdG90eXBlLnNldFJlcGV0aXRpb25D b3VudCk6CisgICAgICAgIChUZXN0R3JvdXBGb3JtLmZvcm1Db250ZW50KToKKyAgICAgICAgKFRl c3RHcm91cEZvcm0pOgorCisyMDE3LTA0LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgorCiAgICAgICAgIEFkZCB0aGUgVUkgZm9yIHNjaGVkdWxpbmcgYSBBL0IgdGVzdGluZyB3 aXRoIGEgY3VzdG9tIHJvb3QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MDYyMgogCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv YnJvd3Nlci10ZXN0cy9pbmRleC5odG1sIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL2Jyb3dz ZXItdGVzdHMvaW5kZXguaHRtbAppbmRleCBmMTdiNzBlM2U2ODNmZGNiZjI2NzFlZmE4M2JiM2Y2 ZGUwZWM5YTJlLi5hMzI2MGFkMjJiNjk2ODQ0ZWE5MDA1YmM2Njk4YjAwZTkyZDdmYmRjIDEwMDY0 NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvYnJvd3Nlci10ZXN0cy9pbmRleC5odG1s CisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9icm93c2VyLXRlc3RzL2luZGV4Lmh0bWwK QEAgLTIzLDYgKzIzLDcgQEAgbW9jaGEuc2V0dXAoJ2JkZCcpOwogPHNjcmlwdCBzcmM9ImNoYXJ0 LXN0YXR1cy1ldmFsdWF0b3ItdGVzdHMuanMiPjwvc2NyaXB0PgogPHNjcmlwdCBzcmM9ImNoYXJ0 LXJldmlzaW9uLXJhbmdlLXRlc3RzLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSJjb21taXQt bG9nLXZpZXdlci10ZXN0cy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0idGVzdC1ncm91cC1m b3JtLXRlc3RzLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+CiAKIGFmdGVyRWFjaCgoKSA9PiB7CmRp ZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvYnJvd3Nlci10ZXN0cy90ZXN0LWdy b3VwLWZvcm0tdGVzdHMuanMgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvYnJvd3Nlci10ZXN0 cy90ZXN0LWdyb3VwLWZvcm0tdGVzdHMuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjY1MzU2NzI4NDlhMTlkZGZk ZmY5MmI0NTk4Nzk1M2IwZGU4MGQ3MgotLS0gL2Rldi9udWxsCisrKyBiL1dlYnNpdGVzL3BlcmYu d2Via2l0Lm9yZy9icm93c2VyLXRlc3RzL3Rlc3QtZ3JvdXAtZm9ybS10ZXN0cy5qcwpAQCAtMCww ICsxLDY3IEBACisKK2Rlc2NyaWJlKCdUZXN0R3JvdXBGb3JtVGVzdHMnLCAoKSA9PiB7CisgICAg Y29uc3Qgc2NyaXB0cyA9IFsnaW5zdHJ1bWVudGF0aW9uLmpzJywgJ2NvbXBvbmVudHMvYmFzZS5q cycsICdjb21wb25lbnRzL3Rlc3QtZ3JvdXAtZm9ybS5qcyddOworCisgICAgZnVuY3Rpb24gY3Jl YXRlVGVzdEdyb3VwRm9ybVdpdGhDb250ZXh0KGNvbnRleHQpCisgICAgeworICAgICAgICByZXR1 cm4gY29udGV4dC5pbXBvcnRTY3JpcHRzKHNjcmlwdHMsICdDb21wb25lbnRCYXNlJywgJ1Rlc3RH cm91cEZvcm0nKS50aGVuKChzeW1ib2xzKSA9PiB7CisgICAgICAgICAgICBjb25zdCB0ZXN0R3Jv dXBGb3JtID0gbmV3IGNvbnRleHQuc3ltYm9scy5UZXN0R3JvdXBGb3JtOworICAgICAgICAgICAg Y29udGV4dC5kb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHRlc3RHcm91cEZvcm0uZWxlbWVudCgp KTsKKyAgICAgICAgICAgIHJldHVybiB0ZXN0R3JvdXBGb3JtOworICAgICAgICB9KTsKKyAgICB9 CisKKyAgICBpdCgnbXVzdCBkaXNwYXRjaCAic3RhcnRUZXN0aW5nIiBhY3Rpb24gd2l0aCB0aGUg bnVtYmVyIG9mIHJlcGV0aXRpb25zIHRoZSB1c2VyIGNsaWNrcyBvbiAiU3RhcnQgQS9CIHRlc3Rp bmciJywgKCkgPT4geworICAgICAgICBjb25zdCBjb250ZXh0ID0gbmV3IEJyb3dzaW5nQ29udGV4 dCgpOworICAgICAgICByZXR1cm4gY3JlYXRlVGVzdEdyb3VwRm9ybVdpdGhDb250ZXh0KGNvbnRl eHQpLnRoZW4oKHRlc3RHcm91cEZvcm0pID0+IHsKKyAgICAgICAgICAgIGNvbnN0IGNhbGxzID0g W107CisgICAgICAgICAgICB0ZXN0R3JvdXBGb3JtLmxpc3RlblRvQWN0aW9uKCdzdGFydFRlc3Rp bmcnLCAoLi4uYXJncykgPT4gY2FsbHMucHVzaChhcmdzKSk7CisgICAgICAgICAgICBleHBlY3Qo Y2FsbHMpLnRvLmVxbCh7fSk7CisgICAgICAgICAgICB0ZXN0R3JvdXBGb3JtLmNvbnRlbnQoJ3N0 YXJ0LWJ1dHRvbicpLmNsaWNrKCk7CisgICAgICAgICAgICBleHBlY3QoY2FsbHMpLnRvLmVxbChb WzRdXSk7CisgICAgICAgIH0pOworICAgIH0pOworCisgICAgaXQoJ211c3QgdXBkYXRlIHRoZSBy ZXBldGl0aW9uIGNvdW50IHdoZW4gdGhlIHVzZXIgc2VsZWN0ZWQgYSBkaWZmZXJlbnQgY291bnQn LCAoKSA9PiB7CisgICAgICAgIGNvbnN0IGNvbnRleHQgPSBuZXcgQnJvd3NpbmdDb250ZXh0KCk7 CisgICAgICAgIHJldHVybiBjcmVhdGVUZXN0R3JvdXBGb3JtV2l0aENvbnRleHQoY29udGV4dCku dGhlbigodGVzdEdyb3VwRm9ybSkgPT4geworICAgICAgICAgICAgY29uc3QgY2FsbHMgPSBbXTsK KyAgICAgICAgICAgIHRlc3RHcm91cEZvcm0ubGlzdGVuVG9BY3Rpb24oJ3N0YXJ0VGVzdGluZycs ICguLi5hcmdzKSA9PiBjYWxscy5wdXNoKGFyZ3MpKTsKKyAgICAgICAgICAgIGV4cGVjdChjYWxs cykudG8uZXFsKHt9KTsKKyAgICAgICAgICAgIHRlc3RHcm91cEZvcm0uY29udGVudCgnc3RhcnQt YnV0dG9uJykuY2xpY2soKTsKKyAgICAgICAgICAgIGV4cGVjdChjYWxscykudG8uZXFsKFtbNF1d KTsKKyAgICAgICAgICAgIGNvbnN0IGNvdW50Rm9ybSA9IHRlc3RHcm91cEZvcm0uY29udGVudCgn cmVwZXRpdGlvbi1jb3VudCcpOworICAgICAgICAgICAgY291bnRGb3JtLnZhbHVlID0gJzYnOwor ICAgICAgICAgICAgY291bnRGb3JtLmRpc3BhdGNoRXZlbnQobmV3IEV2ZW50KCdjaGFuZ2UnKSk7 IAorICAgICAgICAgICAgdGVzdEdyb3VwRm9ybS5jb250ZW50KCdzdGFydC1idXR0b24nKS5jbGlj aygpOworICAgICAgICAgICAgZXhwZWN0KGNhbGxzKS50by5lcWwoW1s0XSwgWzZdXSk7CisgICAg ICAgIH0pOworICAgIH0pOworCisgICAgZGVzY3JpYmUoJ3NldFJlcGV0aXRpb25Db3VudCcsICgp ID0+IHsKKyAgICAgICAgaXQoJ211c3QgdXBkYXRlIHRoZSB2aXNpYmxlIHJlcGV0aXRpb24gY291 bnQnLCAoKSA9PiB7CisgICAgICAgICAgICBjb25zdCBjb250ZXh0ID0gbmV3IEJyb3dzaW5nQ29u dGV4dCgpOworICAgICAgICAgICAgcmV0dXJuIGNyZWF0ZVRlc3RHcm91cEZvcm1XaXRoQ29udGV4 dChjb250ZXh0KS50aGVuKCh0ZXN0R3JvdXBGb3JtKSA9PiB7CisgICAgICAgICAgICAgICAgZXhw ZWN0KHRlc3RHcm91cEZvcm0uY29udGVudCgncmVwZXRpdGlvbi1jb3VudCcpLnZhbHVlKS50by5i ZSgnNCcpOworICAgICAgICAgICAgICAgIHRlc3RHcm91cEZvcm0uc2V0UmVwZXRpdGlvbkNvdW50 KDIpOworICAgICAgICAgICAgICAgIHJldHVybiB3YWl0Rm9yQ29tcG9uZW50c1RvUmVuZGVyKGNv bnRleHQpLnRoZW4oKCkgPT4geworICAgICAgICAgICAgICAgICAgICBleHBlY3QodGVzdEdyb3Vw Rm9ybS5jb250ZW50KCdyZXBldGl0aW9uLWNvdW50JykudmFsdWUpLnRvLmJlKCcyJyk7CisgICAg ICAgICAgICAgICAgfSk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfSk7CisKKyAgICAgICAg aXQoJ211c3QgdXBkYXRlIHRoZSByZXBldGl0aW9uIGNvdW50IHBhc3NlZCB0byAic3RhcnRUZXN0 aW5nIiBhY3Rpb24nLCAoKSA9PiB7CisgICAgICAgICAgICBjb25zdCBjb250ZXh0ID0gbmV3IEJy b3dzaW5nQ29udGV4dCgpOworICAgICAgICAgICAgcmV0dXJuIGNyZWF0ZVRlc3RHcm91cEZvcm1X aXRoQ29udGV4dChjb250ZXh0KS50aGVuKCh0ZXN0R3JvdXBGb3JtKSA9PiB7CisgICAgICAgICAg ICAgICAgY29uc3QgY2FsbHMgPSBbXTsKKyAgICAgICAgICAgICAgICB0ZXN0R3JvdXBGb3JtLmxp c3RlblRvQWN0aW9uKCdzdGFydFRlc3RpbmcnLCAoLi4uYXJncykgPT4gY2FsbHMucHVzaChhcmdz KSk7CisgICAgICAgICAgICAgICAgZXhwZWN0KGNhbGxzKS50by5lcWwoe30pOworICAgICAgICAg ICAgICAgIHRlc3RHcm91cEZvcm0uY29udGVudCgpLnF1ZXJ5U2VsZWN0b3IoJ2J1dHRvbicpLmNs aWNrKCk7CisgICAgICAgICAgICAgICAgZXhwZWN0KGNhbGxzKS50by5lcWwoW1s0XV0pOworICAg ICAgICAgICAgICAgIHRlc3RHcm91cEZvcm0uc2V0UmVwZXRpdGlvbkNvdW50KDgpOworICAgICAg ICAgICAgICAgIHRlc3RHcm91cEZvcm0uY29udGVudCgpLnF1ZXJ5U2VsZWN0b3IoJ2J1dHRvbicp LmNsaWNrKCk7CisgICAgICAgICAgICAgICAgZXhwZWN0KGNhbGxzKS50by5lcWwoW1s0XSwgWzhd XSk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfSk7CisgICAgfSk7Cit9KTsKZGlmZiAtLWdp dCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy90ZXN0LWdy b3VwLWZvcm0uanMgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVu dHMvdGVzdC1ncm91cC1mb3JtLmpzCmluZGV4IGFjODE4ZjcyZTdkNmZlNWJiM2NhYmNlYjYzZGYx OThhYmU2MDIyNzIuLjdlMGFjMGFmZjJkZmEyNWQyYzJkMGYxYzhhMDA3Y2I4Y2QwYzA4NzEgMTAw NjQ0Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy90 ZXN0LWdyb3VwLWZvcm0uanMKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92 My9jb21wb25lbnRzL3Rlc3QtZ3JvdXAtZm9ybS5qcwpAQCAtMTAsNiArMTAsNyBAQCBjbGFzcyBU ZXN0R3JvdXBGb3JtIGV4dGVuZHMgQ29tcG9uZW50QmFzZSB7CiAgICAgc2V0UmVwZXRpdGlvbkNv dW50KGNvdW50KQogICAgIHsKICAgICAgICAgdGhpcy5jb250ZW50KCdyZXBldGl0aW9uLWNvdW50 JykudmFsdWUgPSBjb3VudDsKKyAgICAgICAgdGhpcy5fcmVwZXRpdGlvbkNvdW50ID0gY291bnQ7 CiAgICAgfQogCiAgICAgZGlkQ29uc3RydWN0U2hhZG93VHJlZSgpCkBAIC0zOSw3ICs0MCw3IEBA IGNsYXNzIFRlc3RHcm91cEZvcm0gZXh0ZW5kcyBDb21wb25lbnRCYXNlIHsKICAgICAgICAgICAg ICAgICA8b3B0aW9uPjE8L29wdGlvbj4KICAgICAgICAgICAgICAgICA8b3B0aW9uPjI8L29wdGlv bj4KICAgICAgICAgICAgICAgICA8b3B0aW9uPjM8L29wdGlvbj4KLSAgICAgICAgICAgICAgICA8 b3B0aW9uPjQ8L29wdGlvbj4KKyAgICAgICAgICAgICAgICA8b3B0aW9uIHNlbGVjdGVkPjQ8L29w dGlvbj4KICAgICAgICAgICAgICAgICA8b3B0aW9uPjU8L29wdGlvbj4KICAgICAgICAgICAgICAg ICA8b3B0aW9uPjY8L29wdGlvbj4KICAgICAgICAgICAgICAgICA8b3B0aW9uPjc8L29wdGlvbj4K